gloomberb 0.9.6 → 0.9.8

package/src/plugins/builtin/portfolio-list/pane/index.test.tsx

@@ -279,6 +279,7 @@ function PortfolioHarness({
   stateMutator,
   runtime = createTestPluginRuntime(),
   paneHeight = 24,
+  paneFocused = true,
 }: {
   config: AppConfig;
   collectionId: string;
@@ -290,6 +291,7 @@ function PortfolioHarness({
   stateMutator?: (state: ReturnType<typeof createInitialState>) => void;
   runtime?: PluginRuntimeAccess;
   paneHeight?: number;
+  paneFocused?: boolean;
 }) {
   const initialState = createPortfolioState(config, collectionId, expanded, {
     ticker,
@@ -309,7 +311,7 @@ function PortfolioHarness({
           <PortfolioPane
             paneId={TEST_PANE_ID}
             paneType="portfolio-list"
-            focused
+            focused={paneFocused}
             width={100}
             height={paneHeight}
           />
@@ -323,11 +325,162 @@ async function flushFrame() {
   await act(async () => {
     await Promise.resolve();
     await testSetup!.renderOnce();
+    await new Promise((resolve) => setTimeout(resolve, 0));
     await Promise.resolve();
     await testSetup!.renderOnce();
   });
 }
 
+function makeSortWarmupQuote(symbol: string): Quote {
+  return makeQuote({
+    symbol,
+    price: symbol === "SIVE" ? 46.7 : 100,
+    change: symbol === "SIVE" ? -9.6 : 0,
+    changePercent: symbol === "SIVE" ? -17.05 : 0,
+    previousClose: symbol === "SIVE" ? 56.3 : 100,
+    listingExchangeName: "NASDAQ",
+  });
+}
+
+function makeSortWarmupBrokerTicker(portfolioId: string, symbol: string, index: number): TickerRecord {
+  return makeTicker({
+    ticker: symbol,
+    name: symbol,
+    portfolios: [portfolioId],
+    positions: [{
+      portfolio: portfolioId,
+      shares: 10,
+      avgCost: 100,
+      currency: "USD",
+      broker: "ibkr",
+      brokerInstanceId: "ibkr-live",
+      brokerAccountId: "DU12345",
+      brokerContractId: 10_000 + index,
+      markPrice: 100,
+    }],
+    broker_contracts: [{
+      brokerId: "ibkr",
+      brokerInstanceId: "ibkr-live",
+      symbol,
+      localSymbol: symbol,
+      exchange: "SMART",
+      primaryExchange: "NASDAQ",
+      conId: 10_000 + index,
+    }],
+  });
+}
+
+async function renderHiddenChangePctSortWarmup(options: { staleCachedSiveSnapshot?: boolean } = {}) {
+  const portfolioId = "broker:ibkr-live:DU12345";
+  const config = createPortfolioConfigWithColumns(
+    portfolioId,
+    ["ticker", "price", "change_pct", "latency"],
+    [createBrokerInstance("gateway", "ibkr-live")],
+  );
+  const requestedSnapshots: string[] = [];
+  const provider: DataProvider = {
+    id: "test-provider",
+    name: "Test Provider",
+    async getTickerFinancials(symbol) {
+      requestedSnapshots.push(symbol);
+      return {
+        annualStatements: [],
+        quarterlyStatements: [],
+        priceHistory: [],
+        quote: makeSortWarmupQuote(symbol),
+      };
+    },
+    async getQuote(symbol) {
+      return makeSortWarmupQuote(symbol);
+    },
+    async getExchangeRate() {
+      return 1;
+    },
+    async search() {
+      return [];
+    },
+    async getArticleSummary() {
+      return null;
+    },
+    async getPriceHistory() {
+      return [];
+    },
+    subscribeQuotes() {
+      return () => {};
+    },
+  };
+  sharedCoordinator = new MarketDataCoordinator(provider);
+  setSharedMarketDataCoordinator(sharedCoordinator);
+
+  const tickers = Array.from({ length: 29 }, (_, index) => makeSortWarmupBrokerTicker(portfolioId, `T${String(index).padStart(2, "0")}`, index));
+  const sive = makeSortWarmupBrokerTicker(portfolioId, "SIVE", 29);
+  if (options.staleCachedSiveSnapshot) {
+    const siveInstrument = instrumentFromTicker(sive, "SIVE", { portfolioId });
+    if (!siveInstrument) throw new Error("expected SIVE instrument");
+    sharedCoordinator.primeCachedFinancials([{
+      instrument: siveInstrument,
+      financials: {
+        annualStatements: [],
+        quarterlyStatements: [],
+        priceHistory: [],
+        quote: makeQuote({
+          symbol: "SIVE",
+          price: 56.3,
+          change: 56.3,
+          changePercent: 100,
+          previousClose: 0,
+          listingExchangeName: "NASDAQ",
+          lastUpdated: Date.now() - 24 * 60 * 60_000,
+        }),
+      },
+    }]);
+  }
+
+  testSetup = await testRender(
+    <PortfolioHarness
+      config={config}
+      collectionId={portfolioId}
+      stateMutator={(state) => {
+        state.tickers = new Map([...tickers, sive].map((entry) => [entry.metadata.ticker, entry]));
+        state.financials = new Map(tickers.map((entry, index) => [
+          entry.metadata.ticker,
+          {
+            annualStatements: [],
+            quarterlyStatements: [],
+            priceHistory: [],
+            quote: makeQuote({
+              symbol: entry.metadata.ticker,
+              price: 100 + index,
+              change: index,
+              changePercent: index,
+              listingExchangeName: "NASDAQ",
+            }),
+          },
+        ]));
+        state.paneState[TEST_PANE_ID] = {
+          collectionId: portfolioId,
+          cursorSymbol: "T00",
+          cashDrawerExpanded: false,
+          collectionSorts: {
+            [portfolioId]: { columnId: "change_pct", direction: "asc" },
+          },
+        };
+      }}
+      paneHeight={12}
+    />,
+    { width: 100, height: 12 },
+  );
+
+  await flushFrame();
+  const beforeFrame = testSetup.captureCharFrame();
+  await act(async () => {
+    await new Promise((resolve) => setTimeout(resolve, 400));
+  });
+  await flushFrame();
+
+  return { beforeFrame, frame: testSetup.captureCharFrame(), requestedSnapshots };
+}
+
 afterEach(async () => {
   if (testSetup) {
     testSetup.renderer.destroy();
@@ -690,6 +843,13 @@ describe("PortfolioListPane cash and margin UI", () => {
   test("renders portfolio grid from portfolio table values and opens the selected ticker", async () => {
     const portfolioId = "broker:ibkr-flex:DU12345";
     const config = createPortfolioConfig(portfolioId, [createBrokerInstance("flex")]);
+    const instance = config.layout.instances.find((entry) => entry.instanceId === TEST_PANE_ID);
+    if (instance) {
+      instance.settings = {
+        ...(instance.settings ?? {}),
+        viewMode: "grid",
+      };
+    }
     const pinned: Array<{ symbol: string; options: { floating?: boolean; paneType?: string } | undefined }> = [];
     const runtime = createTestPluginRuntime({
       pinTicker: (symbol, options) => {
@@ -702,12 +862,6 @@ describe("PortfolioListPane cash and margin UI", () => {
         config={config}
         collectionId={portfolioId}
         runtime={runtime}
-        stateMutator={(state) => {
-          state.paneState[TEST_PANE_ID] = {
-            ...state.paneState[TEST_PANE_ID],
-            viewMode: "grid",
-          };
-        }}
       />,
       { width: 100, height: 12 },
     );
@@ -715,7 +869,6 @@ describe("PortfolioListPane cash and margin UI", () => {
     await flushFrame();
 
     const frame = testSetup.captureCharFrame();
-    expect(frame).toContain("Grid");
     expect(frame).toContain("AAPL");
     expect(frame).toContain("1.3k");
     expect(frame).toContain("+4.17%");
@@ -728,6 +881,32 @@ describe("PortfolioListPane cash and margin UI", () => {
     expect(pinned).toEqual([{ symbol: "AAPL", options: { floating: true, paneType: TICKER_RESEARCH_PANE_ID } }]);
   });
 
+  test("keeps watchlists in table view when grid is saved on the pane", async () => {
+    const config = createManualCollectionConfig("watchlist");
+    const instance = config.layout.instances.find((entry) => entry.instanceId === TEST_PANE_ID);
+    if (instance) {
+      instance.settings = {
+        ...(instance.settings ?? {}),
+        viewMode: "grid",
+      };
+    }
+
+    testSetup = await testRender(
+      <PortfolioHarness
+        config={config}
+        collectionId="watchlist"
+        ticker={makeTicker({ portfolios: [], watchlists: ["watchlist"], positions: [] })}
+      />,
+      { width: 100, height: 12 },
+    );
+
+    await flushFrame();
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame).toContain("TICKER");
+    expect(frame).toContain("AAPL");
+  });
+
   test("keeps option avg cost on premium scale and multiplies quoted value by contract size", async () => {
     const portfolioId = "broker:ibkr-flex:DU12345";
     const optionTicker = "SPY  260619C00500000";
@@ -965,6 +1144,100 @@ describe("PortfolioListPane cash and margin UI", () => {
     expect(frame).toContain("22.0");
   });
 
+  test("force-refreshes old visible quote data even when the pane is not focused", async () => {
+    const config = createPortfolioConfigWithColumns(
+      "broker:ibkr-flex:DU12345",
+      ["ticker", "price", "day_pnl"],
+      [createBrokerInstance("flex")],
+    );
+    const oldQuote = makeQuote({
+      price: 120,
+      change: -5,
+      changePercent: -4,
+      currency: "EUR",
+      listingExchangeName: "FWB2",
+      marketState: "REGULAR",
+      lastUpdated: Date.now() - 5 * 60 * 1000,
+    });
+    const batchOptions: Array<{ forceRefresh?: boolean } | undefined> = [];
+    const provider: DataProvider = {
+      id: "test-provider",
+      name: "Test Provider",
+      async getTickerFinancials() {
+        return {
+          annualStatements: [],
+          quarterlyStatements: [],
+          priceHistory: [],
+          quote: oldQuote,
+        };
+      },
+      async getQuotesBatch(targets, options) {
+        batchOptions.push(options);
+        return targets.map((target) => ({
+          target,
+          quote: makeQuote({
+            symbol: target.symbol,
+            price: 126,
+            change: 1,
+            changePercent: 0.8,
+            currency: "EUR",
+            listingExchangeName: "FWB2",
+            marketState: "REGULAR",
+          }),
+        }));
+      },
+      async getQuote(symbol) {
+        return makeQuote({ symbol, price: 126 });
+      },
+      async getExchangeRate() {
+        return 1;
+      },
+      async search() {
+        return [];
+      },
+      async getArticleSummary() {
+        return null;
+      },
+      async getPriceHistory() {
+        return [];
+      },
+      subscribeQuotes() {
+        return () => {};
+      },
+    };
+    sharedCoordinator = new MarketDataCoordinator(provider);
+    setSharedMarketDataCoordinator(sharedCoordinator);
+
+    testSetup = await testRender(
+      <PortfolioHarness
+        config={config}
+        collectionId="broker:ibkr-flex:DU12345"
+        ticker={makeTicker({ exchange: "FWB2", currency: "EUR" })}
+        quote={oldQuote}
+        paneFocused={false}
+        stateMutator={(state) => {
+          state.focusedPaneId = "portfolio-list:other";
+          state.paneState[TEST_PANE_ID] = {
+            ...(state.paneState[TEST_PANE_ID] ?? {}),
+            collectionSorts: {
+              "broker:ibkr-flex:DU12345": { columnId: "ticker", direction: "asc" },
+            },
+          };
+        }}
+      />,
+      { width: 100, height: 12 },
+    );
+
+    await flushFrame();
+    await act(async () => {
+      await Promise.resolve();
+    });
+    await flushFrame();
+
+    expect(batchOptions.some((options) => options?.forceRefresh === true)).toBe(true);
+    expect(testSetup.captureCharFrame()).toContain("126");
+  });
+
   test("shows cached market cap on reopen for broker-linked rows", async () => {
     const dbPath = createTempDbPath("cached-reopen-market-cap");
     const persistence = new AppPersistence(dbPath);
@@ -1305,4 +1578,137 @@ describe("PortfolioListPane cash and margin UI", () => {
     expect(frame).toContain("+5.41%");
   });
 
+  test("streams portfolio rows with the active collection broker contract", async () => {
+    const config = createPortfolioConfigWithColumns(
+      "broker:ibkr-live:DU12345",
+      ["ticker", "price", "change_pct", "latency"],
+      [createBrokerInstance("gateway", "ibkr-flex"), createBrokerInstance("gateway", "ibkr-live")],
+    );
+    let subscribedTargets: Array<{ symbol: string; context?: { brokerInstanceId?: string; instrument?: unknown } }> = [];
+    const provider: DataProvider = {
+      id: "test-provider",
+      name: "Test Provider",
+      async getTickerFinancials(symbol) {
+        return {
+          annualStatements: [],
+          quarterlyStatements: [],
+          priceHistory: [],
+          quote: makeQuote({ symbol }),
+        };
+      },
+      async getQuote(symbol) {
+        return makeQuote({ symbol });
+      },
+      async getExchangeRate() {
+        return 1;
+      },
+      async search() {
+        return [];
+      },
+      async getArticleSummary() {
+        return null;
+      },
+      async getPriceHistory() {
+        return [];
+      },
+      subscribeQuotes(targets) {
+        subscribedTargets = targets;
+        return () => {};
+      },
+    };
+    sharedCoordinator = new MarketDataCoordinator(provider);
+    setSharedMarketDataCoordinator(sharedCoordinator);
+
+    const flexContract = {
+      brokerId: "ibkr",
+      brokerInstanceId: "ibkr-flex",
+      symbol: "VICR",
+      localSymbol: "VICR",
+      exchange: "NASDAQ",
+      conId: 275759,
+    };
+    const liveContract = {
+      brokerId: "ibkr",
+      brokerInstanceId: "ibkr-live",
+      symbol: "VICR",
+      localSymbol: "VICR",
+      exchange: "NASDAQ",
+      primaryExchange: "NASDAQ",
+      conId: 275759,
+    };
+
+    testSetup = await testRender(
+      <PortfolioHarness
+        config={config}
+        collectionId="broker:ibkr-live:DU12345"
+        stateMutator={(state) => {
+          state.tickers = new Map([["VICR", makeTicker({
+            ticker: "VICR",
+            name: "Vicor",
+            portfolios: ["broker:ibkr-flex:DU12345", "broker:ibkr-live:DU12345"],
+            positions: [
+              {
+                portfolio: "broker:ibkr-flex:DU12345",
+                shares: 170,
+                avgCost: 198,
+                currency: "USD",
+                broker: "ibkr",
+                brokerInstanceId: "ibkr-flex",
+                brokerAccountId: "DU12345",
+                brokerContractId: 275759,
+              },
+              {
+                portfolio: "broker:ibkr-live:DU12345",
+                shares: 350,
+                avgCost: 290,
+                currency: "USD",
+                broker: "ibkr",
+                brokerInstanceId: "ibkr-live",
+                brokerAccountId: "DU12345",
+                brokerContractId: 275759,
+              },
+            ],
+            broker_contracts: [flexContract, liveContract],
+          })]]);
+          state.financials = new Map();
+          state.paneState[TEST_PANE_ID] = {
+            collectionId: "broker:ibkr-live:DU12345",
+            cursorSymbol: "VICR",
+            cashDrawerExpanded: false,
+          };
+        }}
+      />,
+      { width: 100, height: 12 },
+    );
+
+    await flushFrame();
+    await act(async () => {
+      await Promise.resolve();
+    });
+
+    const vicrTarget = subscribedTargets.find((target) => target.symbol === "VICR");
+    expect(vicrTarget?.context?.brokerInstanceId).toBe("ibkr-live");
+    expect(vicrTarget?.context?.instrument).toEqual(liveContract);
+  });
+
+  test("warms hidden quote-missing rows when sorting by change percent", async () => {
+    const { beforeFrame, frame, requestedSnapshots } = await renderHiddenChangePctSortWarmup();
+    expect(beforeFrame).not.toContain("SIVE");
+    expect(requestedSnapshots).toContain("SIVE");
+    expect(frame).toContain("SIVE");
+    expect(frame).toContain("-17.05%");
+    expect(frame).toContain("46.7");
+  });
+
+  test("force-refreshes hidden stale cached snapshots when sorting by change percent", async () => {
+    const { beforeFrame, frame, requestedSnapshots } = await renderHiddenChangePctSortWarmup({
+      staleCachedSiveSnapshot: true,
+    });
+    expect(beforeFrame).not.toContain("SIVE");
+    expect(requestedSnapshots).toContain("SIVE");
+    expect(frame).toContain("SIVE");
+    expect(frame).toContain("-17.05%");
+    expect(frame).toContain("46.7");
+  });
+
 });

package/src/plugins/builtin/portfolio-list/pane/index.tsx

@@ -13,6 +13,7 @@ import {
   useAppSelector,
   usePaneCollection,
   usePaneInstance,
+  usePaneSettingValue,
   usePaneStateValue,
   type CollectionSortPreference,
 } from "../../../../state/app/context";
@@ -33,6 +34,7 @@ import {
   resolveActiveCollectionId,
   resolveScopedCollectionEntries,
   resolveVisibleColumns,
+  type PortfolioViewMode,
 } from "../settings";
 import { useQuoteFlashMap } from "../../../../components/quote-flash";
 import { PortfolioTickerTable } from "../table";
@@ -50,8 +52,6 @@ import {
 import { usePortfolioPaneStreaming } from "./streaming";
 import { usePortfolioSupplementalData } from "./supplemental";
 
-type PortfolioViewMode = "table" | "grid";
-
 export function PortfolioListPane({ focused, width, height }: PaneProps) {
   const { pinTicker } = usePluginTickerActions();
   const paneInstance = usePaneInstance();
@@ -68,7 +68,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
   const [committedCursorSymbol, setCommittedCursorSymbol] = usePaneStateValue<string | null>("cursorSymbol", null);
   const [collectionSorts, setCollectionSorts] = usePaneStateValue<Record<string, CollectionSortPreference>>("collectionSorts", {});
   const [cashDrawerExpanded, setCashDrawerExpanded] = usePaneStateValue<boolean>("cashDrawerExpanded", false);
-  const [viewMode, setViewMode] = usePaneStateValue<PortfolioViewMode>("viewMode", "table");
+  const [, setViewMode] = usePaneSettingValue<PortfolioViewMode>("viewMode", "table");
 
   const [now, setNow] = useState(Date.now());
   const [streamWindow, setStreamWindow] = useState({ start: 0, end: 24 });
@@ -101,12 +101,16 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
       ? config.portfolios.find((portfolio) => portfolio.id === activeCollectionId) ?? null
       : null
   ), [activeCollectionId, config.portfolios, isPortfolioTab]);
+  const viewMode: PortfolioViewMode = isPortfolioTab ? paneSettings.viewMode : "table";
 
   const tickers = useMemo(
     () => getCollectionTickersFromConfig(config, tickersBySymbol, activeCollectionId),
     [activeCollectionId, config, tickersBySymbol],
   );
-  const marketFinancialsMap = useTickerFinancialsMap(tickers);
+  const financialsInstrumentOptions = useMemo(() => ({
+    portfolioId: isPortfolioTab ? activeCollectionId : undefined,
+  }), [activeCollectionId, isPortfolioTab]);
+  const marketFinancialsMap = useTickerFinancialsMap(tickers, financialsInstrumentOptions);
   const financialsMap = useMemo(() => {
     const merged = new Map(cachedFinancials);
     for (const [symbol, financials] of marketFinancialsMap) {
@@ -178,8 +182,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
     ? (cashDrawerExpanded ? Math.min(6, Math.max(3, 2 + accountState.visibleCashBalances.length)) : 1)
     : 0;
   const showCollectionTabs = visibleCollections.length > 1;
-  const viewTabsHeight = 1;
-  const headerHeight = viewTabsHeight + (showCollectionTabs ? 1 : 0);
+  const headerHeight = showCollectionTabs ? 1 : 0;
   const drawerHeight = showCashDrawer
     ? Math.min(requestedDrawerHeight, Math.max(1, height - (headerHeight + 2)))
     : 0;
@@ -220,8 +223,9 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
   }, [pinTicker]);
 
   const toggleViewMode = useCallback(() => {
+    if (!isPortfolioTab) return;
     setViewMode((current) => current === "table" ? "grid" : "table");
-  }, [setViewMode]);
+  }, [isPortfolioTab, setViewMode]);
 
   const handleRowActivate = useCallback((ticker: TickerRecord) => {
     flushCursorSymbol(ticker.metadata.ticker);
@@ -254,7 +258,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
       return true;
     }
 
-    if (key === "s") {
+    if (key === "s" && isPortfolioTab) {
       event.preventDefault?.();
       event.stopPropagation?.();
       toggleViewMode();
@@ -265,6 +269,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
   }, [
     cashDrawerExpanded,
     focused,
+    isPortfolioTab,
     openTickerFloating,
     safeSelectedIdx,
     setCashDrawerExpanded,
@@ -301,16 +306,20 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
   const effectiveStreamWindow = useMemo(() => (
     viewMode === "grid"
       ? { start: 0, end: Math.min(sortedTickers.length, 96) }
-      : streamWindow
-  ), [sortedTickers.length, streamWindow, viewMode]);
+      : {
+        start: streamWindow.start,
+        end: Math.min(sortedTickers.length, Math.max(streamWindow.end, height + 4)),
+      }
+  ), [height, sortedTickers.length, streamWindow, viewMode]);
 
   usePortfolioPaneStreaming({
     appActive,
-    focused,
+    activeCollectionId: isPortfolioTab ? activeCollectionId : undefined,
     sortedTickers,
     cursorSymbol,
     streamWindow: effectiveStreamWindow,
     isPortfolioTab,
+    activeSort,
     financialsMap,
     visibleWarmupRequirements,
   });
@@ -379,25 +388,8 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
 
   return (
     <Box flexDirection="column" width={width} height={height}>
-      <Box flexDirection="column" height={headerHeight}>
-        <Box flexDirection="row" height={1}>
-          <Box flexShrink={1} overflow="hidden">
-            <Tabs
-              tabs={[
-                { label: "Table", value: "table" },
-                { label: "Grid", value: "grid" },
-              ]}
-              activeValue={viewMode}
-              onSelect={(value) => setViewMode(value as PortfolioViewMode)}
-              compact
-              variant="bare"
-              focused={focused && !quickAddFocused}
-              keyboardNavigation={false}
-            />
-          </Box>
-        </Box>
-
-        {showCollectionTabs && (
+      {showCollectionTabs && (
+        <Box flexDirection="column" height={headerHeight}>
           <Box flexDirection="row" height={1}>
             <Box flexShrink={1} overflow="hidden">
               <Tabs
@@ -409,8 +401,8 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
               />
             </Box>
           </Box>
-        )}
-      </Box>
+        </Box>
+      )}
 
       {viewMode === "table" ? (
         <PortfolioTickerTable