gloomberb 0.9.4 → 0.9.6

package/src/core/state/app/layout.ts

@@ -351,6 +351,9 @@ export function focusPaneState(state: AppState, paneId: string): AppState {
     ...state,
     config: syncConfigActiveLayoutState(config, state.paneState, paneId, state.activePanel),
     focusedPaneId: paneId,
+    previousFocusedPaneId: state.focusedPaneId && state.focusedPaneId !== paneId
+      ? state.focusedPaneId
+      : state.previousFocusedPaneId,
     recentTickers,
   };
 }
@@ -386,6 +389,9 @@ export function withFocusedPane(
     paneState: nextPaneState,
     brokerAccounts: reconcileBrokerAccounts(syncedConfig, state.brokerAccounts),
     focusedPaneId,
+    previousFocusedPaneId: state.focusedPaneId && state.focusedPaneId !== focusedPaneId
+      ? state.focusedPaneId
+      : state.previousFocusedPaneId,
     activePanel,
   };
 }

package/src/core/state/app/state.ts

@@ -108,7 +108,9 @@ export function appReducer(state: AppState, action: AppAction): AppState {
       return { ...state, recentTickers: nextRecentTickers(state.recentTickers, action.symbol) };
 
     case "SET_ACTIVE_PANEL": {
-      const firstPane = getPanelFocusTarget(state.config.layout, action.panel);
+      const firstPane = action.preserveFocus
+        ? state.focusedPaneId
+        : getPanelFocusTarget(state.config.layout, action.panel);
       return withFocusedPane(state, state.config, {
         activePanel: action.panel,
         focusedPaneId: firstPane ?? state.focusedPaneId,
@@ -260,6 +262,25 @@ export function appReducer(state: AppState, action: AppAction): AppState {
       };
     }
 
+    case "REPLACE_PANE_STATE": {
+      const current = state.paneState[action.paneId] ?? {};
+      const nextState = action.state;
+      if (Object.is(current, nextState)) return state;
+      const paneState = {
+        ...state.paneState,
+        [action.paneId]: nextState,
+      };
+      const recentTickers = current.cursorSymbol !== nextState.cursorSymbol
+        ? nextRecentTickers(state.recentTickers, typeof nextState.cursorSymbol === "string" ? nextState.cursorSymbol : null)
+        : state.recentTickers;
+      return {
+        ...state,
+        config: syncConfigActiveLayoutState(state.config, paneState, state.focusedPaneId, state.activePanel),
+        paneState,
+        recentTickers,
+      };
+    }
+
     case "UPDATE_PLUGIN_PANE_STATE": {
       const current = state.paneState[action.paneId] ?? {};
       const currentPluginState = current.pluginState ?? {};
@@ -319,6 +340,7 @@ export function createInitialState(config: AppConfig, sessionSnapshot: AppSessio
     brokerAccounts: {},
     activePanel,
     focusedPaneId,
+    previousFocusedPaneId: null,
     paneState,
     recentTickers: config.recentTickers,
     commandBarOpen: false,

package/src/core/state/app/types.ts

@@ -48,6 +48,7 @@ export interface AppState {
   brokerAccounts: Record<string, BrokerAccount[]>;
   activePanel: "left" | "right";
   focusedPaneId: string | null;
+  previousFocusedPaneId: string | null;
   paneState: Record<string, PaneRuntimeState>;
   recentTickers: string[];
   commandBarOpen: boolean;
@@ -76,7 +77,7 @@ export type AppAction =
   | { type: "MERGE_QUOTE"; symbol: string; quote: Quote }
   | { type: "HYDRATE_FINANCIALS"; financials: Map<string, TickerFinancials> }
   | { type: "TRACK_TICKER"; symbol: string | null }
-  | { type: "SET_ACTIVE_PANEL"; panel: "left" | "right" }
+  | { type: "SET_ACTIVE_PANEL"; panel: "left" | "right"; preserveFocus?: boolean }
   | { type: "TOGGLE_COMMAND_BAR" }
   | {
       type: "SET_COMMAND_BAR";
@@ -104,7 +105,7 @@ export type AppAction =
   | { type: "PUSH_LAYOUT_HISTORY" }
   | { type: "UNDO_LAYOUT" }
   | { type: "REDO_LAYOUT" }
-  | { type: "UPDATE_LAYOUT"; layout: LayoutConfig }
+  | { type: "UPDATE_LAYOUT"; layout: LayoutConfig; focusedPaneId?: string | null }
   | { type: "SWITCH_LAYOUT"; index: number }
   | { type: "NEW_LAYOUT"; name: string }
   | { type: "DELETE_LAYOUT"; index: number }
@@ -121,4 +122,5 @@ export type AppAction =
       key: string;
       value: unknown;
     }
+  | { type: "REPLACE_PANE_STATE"; paneId: string; state: PaneRuntimeState }
   | { type: "UPDATE_PANE_STATE"; paneId: string; patch: Partial<PaneRuntimeState> };

package/src/plugins/builtin/account-management/form-components.tsx

@@ -85,7 +85,7 @@ export function PickerRow({
   return (
     <Box
       flexDirection="column"
-      onMouseMove={onFocus}
+      onMouseOver={onFocus}
       onMouseDown={(event?: { stopPropagation?: () => void; preventDefault?: () => void }) => {
         event?.stopPropagation?.();
         event?.preventDefault?.();
@@ -135,7 +135,7 @@ export function CheckboxRow({
     <Box
       flexDirection="column"
       backgroundColor={hovered ? hoverBg() : undefined}
-      onMouseMove={() => {
+      onMouseOver={() => {
         setHovered(true);
         onFocus();
       }}

package/src/plugins/builtin/alerts/pane.tsx

@@ -214,7 +214,7 @@ export function AlertsPane({ focused, width, height, close }: PaneProps) {
     alert: AlertRule,
     column: AlertColumn,
     _index: number,
-    rowState: { selected: boolean; hovered: boolean },
+    rowState: { selected: boolean },
   ): DataTableCell => {
     const selectedColor = rowState.selected ? colors.selectedText : undefined;
     const actionMouseDown = (handler: () => void) => (

package/src/plugins/builtin/buildout/cells.tsx

@@ -26,7 +26,7 @@ interface BuildoutCellContext {
 export function renderBuildoutCell(
   row: BuildoutRow,
   column: BuildoutColumn,
-  rowState: { selected: boolean; hovered: boolean },
+  rowState: { selected: boolean },
   context: BuildoutCellContext,
 ): DataTableCell {
   const selectedColor = rowState.selected ? colors.selectedText : undefined;

package/src/plugins/builtin/buildout/pane/index.tsx

@@ -314,7 +314,7 @@ export function BuildoutPane({ focused, width, height }: PaneProps) {
     row: BuildoutRow,
     column: BuildoutColumn,
     _index: number,
-    rowState: { selected: boolean; hovered: boolean },
+    rowState: { selected: boolean },
   ) => renderBuildoutCell(row, column, rowState, {
     favoriteBusyKey,
     toggleFavorite,

package/src/plugins/builtin/chat/channels.ts

@@ -1,6 +1,6 @@
 import type { CommandResultDef, GloomPluginContext } from "../../../types/plugin";
 import type { ChatChannel, ChatChannelState } from "../../../api-client";
-import type { AppConfig, PaneInstanceConfig } from "../../../types/config";
+import type { AppConfig } from "../../../types/config";
 import { chatController } from "./controller";
 import { formatChannelLabel } from "./channel-labels";
 
@@ -25,14 +25,6 @@ export function getLastVisitedChatChannelId(config: { pluginConfig: Record<strin
   return normalizeChannelId(config.pluginConfig["gloomberb-cloud"]?.[LAST_VISITED_CHAT_CHANNEL_KEY] as string | undefined);
 }
 
-export function findChatPaneInstanceForChannel(config: AppConfig, channelId: string): PaneInstanceConfig | undefined {
-  const normalizedChannelId = normalizeChannelId(channelId);
-  return config.layout.instances.find((instance) => (
-    instance.paneId === "chat"
-    && normalizeChannelId(typeof instance.settings?.channelId === "string" ? instance.settings.channelId : null) === normalizedChannelId
-  ));
-}
-
 export function getPreferredChatOpenChannelId(
   config: AppConfig,
   snapshot?: { channels: ChatChannel[]; channelStates: ChatChannelState[] },
@@ -80,17 +72,12 @@ export function hasOnlyDmUsernameArgs(value: string): boolean {
   return parts.length > 0 && parts.every((part) => CHAT_USERNAME_ARG.test(part));
 }
 
-function openChatChannelFromCommand(ctx: Pick<GloomPluginContext, "createPaneFromTemplate" | "focusPane" | "getConfig">, channelId: string): void {
-  const existingInstance = findChatPaneInstanceForChannel(ctx.getConfig(), channelId);
-  if (existingInstance) {
-    ctx.focusPane(existingInstance.instanceId);
-    return;
-  }
+function openChatChannelFromCommand(ctx: Pick<GloomPluginContext, "createPaneFromTemplate">, channelId: string): void {
   ctx.createPaneFromTemplate("new-chat-pane", { arg: channelId });
 }
 
-export function openDefaultChatFromCommand(
-  ctx: Pick<GloomPluginContext, "createPaneFromTemplate" | "focusPane" | "getConfig">,
+function openDefaultChatPane(
+  ctx: Pick<GloomPluginContext, "createPaneFromTemplate" | "getConfig">,
 ): void {
   const config = ctx.getConfig();
   openChatChannelFromCommand(ctx, getPreferredChatOpenChannelId(config, chatController.getSnapshot()));
@@ -98,7 +85,7 @@ export function openDefaultChatFromCommand(
 
 export async function openDmTargetFromCommand(ctx: GloomPluginContext, usernames: string[]): Promise<void> {
   if (usernames.length === 0) {
-    openDefaultChatFromCommand(ctx);
+    openDefaultChatPane(ctx);
     return;
   }
   const channel = usernames.length === 1

package/src/plugins/builtin/chat/chat.test.tsx

@@ -1178,7 +1178,6 @@ describe("ChatContent", () => {
       user: { id: "u1", username: "vince", emailVerified: true },
     });
     const openedTemplates: Array<{ templateId: string; options?: { arg?: string } }> = [];
-    const focusedPanes: string[] = [];
     const state = createInitialState(createDefaultConfig("/tmp/gloomberb-chat"));
     state.config.disabledPlugins = [];
 
@@ -1186,9 +1185,6 @@ describe("ChatContent", () => {
       createPaneFromTemplate(templateId: string, options?: { arg?: string }) {
         openedTemplates.push({ templateId, options });
       },
-      focusPane(paneId: string) {
-        focusedPanes.push(paneId);
-      },
     });
 
     await act(async () => {
@@ -1230,9 +1226,7 @@ describe("ChatContent", () => {
       await setup().renderOnce();
     });
 
-    expect(openedTemplates).toEqual([]);
-    expect(focusedPanes).toHaveLength(1);
-    expect(focusedPanes[0]?.startsWith("chat:")).toBe(true);
+    expect(openedTemplates).toEqual([{ templateId: "new-chat-pane", options: { arg: "everyone" } }]);
   });
 
   test("opens an unread direct-message channel from the status widget", async () => {

package/src/plugins/builtin/chat/message/desktop.tsx

@@ -97,7 +97,7 @@ export const DesktopChatMessage = memo(function DesktopChatMessage({
           <Text
             fg={state.authorColor}
             attributes={state.authorAttributes}
-            onMouseMove={() => onUserHover(msg.user)}
+            onMouseOver={() => onUserHover(msg.user)}
             onMouseOut={onUserHoverEnd}
             style={{ cursor: "default" }}
           >

package/src/plugins/builtin/chat/message/inline-tokens.tsx

@@ -58,7 +58,7 @@ export function ResponsiveTickerBadgeText({
         height={1}
         flexDirection="row"
         backgroundColor={blendHex(colors.panel, colors.positive, 0.24)}
-        onMouseMove={() => {
+        onMouseOver={() => {
           if (user) onUserHover?.(user);
         }}
         onMouseOut={() => {

package/src/plugins/builtin/chat/message/terminal.tsx

@@ -44,7 +44,7 @@ export function TerminalChatMessage({
   const messageRowProps = {
     width: contentWidth,
     backgroundColor: state.bgColor,
-    onMouseMove: setHovered,
+    onMouseOver: setHovered,
     onMouseOut: clearHovered,
   };
 
@@ -80,7 +80,7 @@ export function TerminalChatMessage({
           <Text
             fg={state.authorColor}
             attributes={state.authorAttributes}
-            onMouseMove={() => onUserHover(msg.user)}
+            onMouseOver={() => onUserHover(msg.user)}
             onMouseOut={onUserHoverEnd}
           >
             {msg.user.username ?? "anon"}

package/src/plugins/builtin/chat/sidebar.tsx

@@ -239,7 +239,7 @@ export function ChannelSidebar({
               flexDirection="row"
               backgroundColor={bg}
               onMouseDown={selectChannel}
-              onMouseMove={() => setHoveredChannelId((current) => (current === channel.id ? current : channel.id))}
+              onMouseOver={() => setHoveredChannelId((current) => (current === channel.id ? current : channel.id))}
               onMouseOut={() => setHoveredChannelId((current) => (current === channel.id ? null : current))}
               style={{ cursor: "pointer" }}
             >

package/src/plugins/builtin/chat/status-widget.tsx

@@ -5,7 +5,6 @@ import { Box, Span, Text, TextAttributes, useUiCapabilities } from "../../../ui"
 import { usePluginAppActions } from "../../runtime";
 import { InlineAuthActions } from "../cloud/auth-actions";
 import {
-  findChatPaneInstanceForChannel,
   getPreferredChatOpenChannelId,
 } from "./channels";
 import { chatController, type ChatController } from "./controller";
@@ -53,7 +52,7 @@ function CloudStatusIcon() {
 }
 
 export function ChatStatusWidget({ controller = chatController }: ChatStatusWidgetProps) {
-  const { createPaneFromTemplate, focusPane } = usePluginAppActions();
+  const { createPaneFromTemplate } = usePluginAppActions();
   const config = useAppSelector((state) => state.config);
   const cloudPluginDisabled = config.disabledPlugins.includes("gloomberb-cloud");
   const initialSnapshot = controller.getSnapshot();
@@ -67,11 +66,6 @@ export function ChatStatusWidget({ controller = chatController }: ChatStatusWidg
     event?.preventDefault?.();
     event?.stopPropagation?.();
     const channelId = getPreferredChatOpenChannelId(config, snapshot);
-    const existingInstance = findChatPaneInstanceForChannel(config, channelId);
-    if (existingInstance) {
-      focusPane(existingInstance.instanceId);
-      return;
-    }
     createPaneFromTemplate("new-chat-pane", { arg: channelId });
   };
 
@@ -98,7 +92,7 @@ export function ChatStatusWidget({ controller = chatController }: ChatStatusWidg
         <Box
           flexDirection="row"
           backgroundColor={hovered ? hoverBg() : undefined}
-          onMouseMove={() => setHovered((current) => (current ? current : true))}
+          onMouseOver={() => setHovered((current) => (current ? current : true))}
           onMouseOut={() => setHovered((current) => (current ? false : current))}
           onMouseDown={openChat}
         >

package/src/plugins/builtin/cloud/auth-actions.tsx

@@ -22,7 +22,7 @@ export function InlineAuthActions({ showSignup = true }: { showSignup?: boolean
     <Box flexDirection="row">
       <Box
         backgroundColor={hoveredAction === "login" ? hoverBg() : undefined}
-        onMouseMove={() => setHoveredAction((current) => (current === "login" ? current : "login"))}
+        onMouseOver={() => setHoveredAction((current) => (current === "login" ? current : "login"))}
         onMouseOut={() => setHoveredAction((current) => (current === "login" ? null : current))}
         onMouseDown={(event: any) => openAuthCommand(openCommandBar, "Log In", event)}
       >
@@ -33,7 +33,7 @@ export function InlineAuthActions({ showSignup = true }: { showSignup?: boolean
           <Text fg={colors.textDim}>/</Text>
           <Box
             backgroundColor={hoveredAction === "signup" ? hoverBg() : undefined}
-            onMouseMove={() => setHoveredAction((current) => (current === "signup" ? current : "signup"))}
+            onMouseOver={() => setHoveredAction((current) => (current === "signup" ? current : "signup"))}
             onMouseOut={() => setHoveredAction((current) => (current === "signup" ? null : current))}
             onMouseDown={(event: any) => openAuthCommand(openCommandBar, "Sign Up", event)}
           >

package/src/plugins/builtin/cloud/plugin.tsx

@@ -14,10 +14,9 @@ import { registerTwitterFeedFeature } from "../cloud-tweets";
 import {
   buildDmCommandResults,
   formatChatPaneTitle,
-  getLastVisitedChatChannelId,
+  getPreferredChatOpenChannelId,
   hasOnlyDmUsernameArgs,
   normalizeShortcutChannelId,
-  openDefaultChatFromCommand,
   openDmTargetFromCommand,
   parseDmUsernames,
 } from "../chat/channels";
@@ -50,7 +49,9 @@ export function createGloomberbCloudPlugin({
         createInstance: async (context, options) => {
           const channelId = options?.arg
             ? await chatController.resolveRequiredChannelId(normalizeShortcutChannelId(options.arg))
-            : await chatController.resolvePreferredChannelId(getLastVisitedChatChannelId(context.config));
+            : await chatController.resolvePreferredChannelId(
+              getPreferredChatOpenChannelId(context.config, chatController.getSnapshot()),
+            );
           const channel = chatController.getChannels().find((entry) => entry.id === channelId);
           return {
             placement: "floating",
@@ -144,16 +145,6 @@ export function createGloomberbCloudPlugin({
 
       registerTwitterFeedFeature(ctx);
 
-      ctx.registerCommand({
-        id: "open-chat",
-        label: "Chat",
-        description: "Open chat",
-        keywords: ["chat", "message", "messages"],
-        category: "navigation",
-        shortcut: "CHAT",
-        execute: () => openDefaultChatFromCommand(ctx),
-      });
-
       ctx.registerCommand({
         id: "direct-message",
         label: "DM",

package/src/plugins/builtin/correlation/matrix/symbol-cell.tsx

@@ -41,7 +41,7 @@ export function SymbolLabelCell({
       overflow="hidden"
       backgroundColor={hovered ? hoverBg() : undefined}
       style={{ cursor: "pointer" }}
-      onMouseMove={() => onHover(symbol)}
+      onMouseOver={() => onHover(symbol)}
       onMouseOut={() => onLeave(symbol)}
       onMouseDown={(event: any) => handleSymbolMouseDown(event, openSymbol)}
     >

package/src/plugins/builtin/debug/index.tsx

@@ -64,7 +64,6 @@ function DebugPane({ focused, width, height }: PaneProps) {
   const [filterSource, setFilterSource] = useState<string | null>(null);
   const [autoScroll, setAutoScroll] = useState(true);
   const [selectedIdx, setSelectedIdx] = useState(-1);
-  const [hoveredIdx, setHoveredIdx] = useState<number | null>(null);
   const [showDetail, setShowDetail] = useState(false);
   const sourcesRef = useRef<string[]>(debugLog.getSources());
 
@@ -261,8 +260,8 @@ function DebugPane({ focused, width, height }: PaneProps) {
         {visibleEntries.map((entry, i) => {
           const globalIdx = viewStart + i;
           const isSelected = globalIdx === selectedIdx;
-          const isHovered = globalIdx === hoveredIdx && !isSelected;
-          const bgColor = isSelected ? colors.selected : isHovered ? hoverBg() : undefined;
+          const bgColor = isSelected ? colors.selected : undefined;
+          const rowHoverBg = isSelected ? undefined : hoverBg();
           const ts = formatTimestamp(entry.timestamp);
           const lvl = LEVEL_LABELS[entry.level];
           const sourceTag = entry.source;
@@ -278,7 +277,7 @@ function DebugPane({ focused, width, height }: PaneProps) {
               width={contentWidth}
               flexDirection="row"
               backgroundColor={bgColor}
-              onMouseMove={() => setHoveredIdx((current) => (current === globalIdx ? current : globalIdx))}
+              hoverBackgroundColor={rowHoverBg}
               onMouseDown={() => { setSelectedIdx(globalIdx); setAutoScroll(false); }}
             >
               <Text fg={colors.textMuted}> {ts} </Text>

package/src/plugins/builtin/help/components.tsx

@@ -63,7 +63,7 @@ export function ActionButton({
   return (
     <Box
       backgroundColor={hovered ? hoverBg() : colors.panel}
-      onMouseMove={() => onHover(id)}
+      onMouseOver={() => onHover(id)}
       onMouseOut={() => onHover(null)}
       onMouseDown={(event: any) => {
         event.stopPropagation?.();