gloomberb 0.9.3 → 0.9.4

package/src/plugins/builtin/options/view.tsx

@@ -6,6 +6,7 @@ import { isPlainKey } from "../../../utils/keyboard";
 import { formatExpDate, resolveOptionsTarget } from "../../../utils/options";
 import { useOptionsQuery, useResolvedEntryValue } from "../../../market-data/hooks";
 import { DataTableView, Spinner, Tabs, usePaneFooter, type DataTableKeyEvent } from "../../../components";
+import { useShortcut } from "../../../react/input";
 import {
   OPTION_COLUMNS,
   buildStrikeList,
@@ -26,6 +27,7 @@ export function OptionsView({ width, focused, onCapture = () => {} }: OptionsVie
   const [scrollToIndexAlign, setScrollToIndexAlign] = useState<"nearest" | "center">("nearest");
   const [interactive, setInteractive] = useState(false);
   const userSelectedStrikeRef = useRef(false);
+  const onCaptureRef = useRef(onCapture);
   const target = resolveOptionsTarget(ticker);
   const isOpt = target?.isOptionTicker ?? false;
   const parsed = target?.parsedOption ?? null;
@@ -53,6 +55,7 @@ export function OptionsView({ width, focused, onCapture = () => {} }: OptionsVie
   );
   const expirationChain = useResolvedEntryValue(expirationChainEntry);
   const chain = expirationChain ?? initialChain;
+  const expirationCount = chain?.expirationDates.length ?? 0;
   const loading = (initialChainEntry?.phase === "loading" || initialChainEntry?.phase === "refreshing") && !chain
     || (expirationChainEntry?.phase === "loading" || expirationChainEntry?.phase === "refreshing");
   const error = initialChainEntry?.phase === "error"
@@ -61,24 +64,34 @@ export function OptionsView({ width, focused, onCapture = () => {} }: OptionsVie
       ? expirationChainEntry.error?.message ?? "Failed to load options"
       : null;
 
-  const enterInteractive = () => {
+  useEffect(() => {
+    onCaptureRef.current = onCapture;
+  }, [onCapture]);
+
+  const enterInteractive = useCallback(() => {
     if (!interactive) {
       setInteractive(true);
-      onCapture(true);
+      onCaptureRef.current(true);
     }
-  };
+  }, [interactive]);
 
-  const exitInteractive = () => {
+  const exitInteractive = useCallback(() => {
     if (interactive) {
       setInteractive(false);
-      onCapture(false);
+      onCaptureRef.current(false);
     }
-  };
+  }, [interactive]);
+
+  const selectAdjacentExpiration = useCallback((offset: -1 | 1) => {
+    if (expirationCount === 0) return;
+    setExpIdx((index) => Math.max(0, Math.min(index + offset, expirationCount - 1)));
+  }, [expirationCount]);
 
   useEffect(() => {
     userSelectedStrikeRef.current = false;
     setScrollToIndexAlign("nearest");
-    exitInteractive();
+    setInteractive(false);
+    onCaptureRef.current(false);
     setExpIdx(0);
     setStrikeIdx(0);
   }, [effectiveTicker]);
@@ -154,6 +167,37 @@ export function OptionsView({ width, focused, onCapture = () => {} }: OptionsVie
     setAutoScrollVersion((version) => version + 1);
   }, [expIdx, financials?.quote?.price, parsed?.strike, strikes]);
 
+  useShortcut((event) => {
+    if (event.defaultPrevented || event.propagationStopped || event.targetEditable) return;
+    if (event.ctrl || event.meta || event.alt || event.shift) return;
+
+    const isEnter = event.name === "enter" || event.name === "return";
+    const isEscape = event.name === "escape" || event.name === "esc";
+    if (isEnter && !interactive) {
+      event.preventDefault();
+      event.stopPropagation();
+      enterInteractive();
+      return;
+    }
+    if (isEscape && interactive) {
+      event.preventDefault();
+      event.stopPropagation();
+      exitInteractive();
+      return;
+    }
+    if (interactive && isPlainKey(event, "h", "left")) {
+      event.preventDefault();
+      event.stopPropagation();
+      selectAdjacentExpiration(-1);
+      return;
+    }
+    if (interactive && isPlainKey(event, "l", "right")) {
+      event.preventDefault();
+      event.stopPropagation();
+      selectAdjacentExpiration(1);
+    }
+  }, { enabled: focused, phase: "before" });
+
   const handleTableKeyDown = useCallback((event: DataTableKeyEvent) => {
     const isEnter = event.name === "enter" || event.name === "return";
 
@@ -169,6 +213,18 @@ export function OptionsView({ width, focused, onCapture = () => {} }: OptionsVie
       exitInteractive();
       return true;
     }
+    if (interactive && isPlainKey(event, "h", "left")) {
+      event.preventDefault?.();
+      event.stopPropagation?.();
+      selectAdjacentExpiration(-1);
+      return true;
+    }
+    if (interactive && isPlainKey(event, "l", "right")) {
+      event.preventDefault?.();
+      event.stopPropagation?.();
+      selectAdjacentExpiration(1);
+      return true;
+    }
 
     if (isPlainKey(event, "j", "down")) {
       if (strikes.length === 0) return true;
@@ -190,30 +246,27 @@ export function OptionsView({ width, focused, onCapture = () => {} }: OptionsVie
     }
 
     return false;
-  }, [enterInteractive, exitInteractive, interactive, strikes.length]);
+  }, [enterInteractive, exitInteractive, interactive, selectAdjacentExpiration, strikes.length]);
 
   if (!ticker) return <Text fg={colors.textDim}>Select a ticker to view options.</Text>;
   if (loading && !chain) return <Spinner label="Loading options chain..." />;
   if (error) return <Text fg={colors.textDim}>{error}</Text>;
   if (!chain || chain.expirationDates.length === 0) return <Text fg={colors.textDim}>No options available for {effectiveTicker}.</Text>;
 
-  const innerWidth = Math.max(width - 4, 60);
   const posShares = isOpt && parsed
     ? ticker.metadata.positions.reduce((sum, p) => sum + p.shares, 0)
     : 0;
-  const maxExpVisible = Math.max(Math.floor((innerWidth - 14) / 13), 3);
-  const expStart = Math.max(0, Math.min(expIdx - Math.floor(maxExpVisible / 2), chain.expirationDates.length - maxExpVisible));
-  const visibleExps = chain.expirationDates.slice(expStart, expStart + maxExpVisible);
+  const expirationTabsWidth = Math.max(width - 7 - (loading ? 2 : 0), 8);
 
   return (
     <Box flexDirection="column" flexGrow={1} paddingX={1} onMouseDown={() => { if (!interactive) enterInteractive(); }}>
       <Box flexDirection="row" height={1} gap={1}>
         <Text fg={colors.textDim}>Exp:</Text>
-        <Box flexGrow={1} height={1}>
+        <Box width={expirationTabsWidth} height={1} overflow="hidden">
           <Tabs
-            tabs={visibleExps.map((ts, i) => ({
+            tabs={chain.expirationDates.map((ts, i) => ({
               label: formatExpDate(ts),
-              value: String(expStart + i),
+              value: String(i),
             }))}
             activeValue={String(expIdx)}
             onSelect={(value) => {
@@ -223,6 +276,8 @@ export function OptionsView({ width, focused, onCapture = () => {} }: OptionsVie
             compact
             variant="bare"
             focused={focused && interactive}
+            keyboardNavigation={false}
+            scrollId="options-expiration-tabs-scroll"
           />
         </Box>
         {loading && <Spinner />}
@@ -255,14 +310,20 @@ export function OptionsView({ width, focused, onCapture = () => {} }: OptionsVie
           setStrikeIdx(index);
         }}
         onRootKeyDown={handleTableKeyDown}
+        headerScrollId="options-table-header-scroll"
+        bodyScrollId="options-table-body-scroll"
         columns={optionColumns}
         items={rows}
         sortColumnId={null}
         sortDirection="asc"
         onHeaderClick={() => {}}
+        onTableMouseDown={enterInteractive}
         getItemKey={(row) => String(row.strike)}
         renderCell={renderOptionCell}
         emptyStateTitle="No strikes available."
+        columnGap={0}
+        horizontalPadding={0}
+        fillAvailableWidth={false}
         scrollToIndex={strikeIdx}
         scrollToIndexAlign={scrollToIndexAlign}
         scrollToIndexVersion={autoScrollVersion}

package/src/plugins/builtin/portfolio-list/account-metrics.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, test } from "bun:test";
 import type { BrokerAccount } from "../../../types/trading";
 import type { PortfolioSummaryTotals } from "./metrics";
-import { resolvePortfolioAccountMetrics } from "./account-metrics";
+import { resolvePortfolioAccountMetrics, resolvePortfolioMarketValue } from "./account-metrics";
 
 function createTotals(overrides: Partial<PortfolioSummaryTotals> = {}): PortfolioSummaryTotals {
   return {
@@ -48,3 +48,28 @@ describe("resolvePortfolioAccountMetrics", () => {
     });
   });
 });
+
+describe("resolvePortfolioMarketValue", () => {
+  test("uses explicit broker gross position value when available", () => {
+    const account: BrokerAccount = {
+      accountId: "DU12345",
+      name: "DU12345",
+      grossPositionValue: 12_345,
+      netLiquidation: 20_000,
+      totalCashValue: 7_000,
+    };
+
+    expect(resolvePortfolioMarketValue(createTotals({ totalMktValue: 10_000 }), account)).toBe(12_345);
+  });
+
+  test("does not derive market value from account cash and net liquidation", () => {
+    const account: BrokerAccount = {
+      accountId: "DU12345",
+      name: "DU12345",
+      netLiquidation: 20_000,
+      totalCashValue: 7_000,
+    };
+
+    expect(resolvePortfolioMarketValue(createTotals({ totalMktValue: 10_000 }), account)).toBe(10_000);
+  });
+});

package/src/plugins/builtin/portfolio-list/account-metrics.ts

@@ -17,6 +17,20 @@ function percentChange(value: number, previousValue: number): number {
   return previousValue !== 0 ? (value / previousValue) * 100 : 0;
 }
 
+export function resolveBrokerPortfolioMarketValue(account?: BrokerAccount | null): number | null {
+  if (finiteNumber(account?.grossPositionValue)) {
+    return account.grossPositionValue;
+  }
+  return null;
+}
+
+export function resolvePortfolioMarketValue(
+  totals: PortfolioSummaryTotals,
+  account?: BrokerAccount | null,
+): number {
+  return resolveBrokerPortfolioMarketValue(account) ?? totals.totalMktValue;
+}
+
 export function resolvePortfolioAccountMetrics(
   totals: PortfolioSummaryTotals,
   account?: BrokerAccount | null,

package/src/plugins/builtin/portfolio-list/index.test.ts

@@ -40,6 +40,7 @@ describe("buildPortfolioSummarySegments", () => {
     accountId: "DU12345",
     name: "DU12345",
     netLiquidation: 125000,
+    grossPositionValue: 175000,
     totalCashValue: -50000,
     settledCash: -45000,
     availableFunds: 12000,
@@ -57,6 +58,16 @@ describe("buildPortfolioSummarySegments", () => {
     expect(segments.map((segment) => segment.id)).toEqual(["netliq", "val"]);
   });
 
+  test("uses broker gross position value for broker portfolio value", () => {
+    const segments = buildPortfolioSummarySegments({
+      totals,
+      accountState: { account, sourceLabel: "Live" },
+      widthBudget: 80,
+    });
+
+    expect(segments.find((segment) => segment.id === "val")?.parts[1]?.text).toBe("175k");
+  });
+
   test("drops low-priority broker segments before required ones", () => {
     const segments = buildPortfolioSummarySegments({
       totals,
@@ -85,6 +96,18 @@ describe("buildPortfolioSummarySegments", () => {
     expect(segments.map((segment) => segment.id)).toContain("source");
   });
 
+  test("shows account status when a broker portfolio has positions but no account snapshot", () => {
+    const segments = buildPortfolioSummarySegments({
+      totals,
+      accountState: null,
+      accountStatusText: "Acct missing",
+      widthBudget: 80,
+    });
+
+    expect(segments.map((segment) => segment.id)).toContain("account-status");
+    expect(segments.find((segment) => segment.id === "account-status")?.parts[0]?.text).toBe("Acct missing");
+  });
+
   test("treats c as the cash drawer shortcut only when the drawer is available", () => {
     expect(shouldToggleCashMarginDrawer("c", true)).toBe(true);
     expect(shouldToggleCashMarginDrawer("c", false)).toBe(false);

package/src/plugins/builtin/portfolio-list/pane/index.tsx

@@ -294,6 +294,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
 
   const summaryFooterInfo = useMemo(() => buildPortfolioFooterSegments({
     accountState: accountState ? { account: accountState.account, sourceLabel: accountState.sourceLabel } : null,
+    accountStatusText: isPortfolioTab && currentPortfolio?.brokerInstanceId && !accountState ? "Acct missing" : undefined,
     activeCollectionId,
     baseCurrency: config.baseCurrency,
     exchangeRates: effectiveExchangeRates,
@@ -306,6 +307,7 @@ export function PortfolioListPane({ focused, width, height }: PaneProps) {
   }), [
     accountState,
     activeCollectionId,
+    currentPortfolio?.brokerInstanceId,
     effectiveExchangeRates,
     financialsMap,
     isPortfolioTab,

package/src/plugins/builtin/portfolio-list/summary/index.test.ts

@@ -112,6 +112,7 @@ describe("resolvePortfolioAccountState", () => {
           currency: "USD",
           source: "flex",
           updatedAt: new Date("2026-05-15T05:02:17.000Z").getTime(),
+          asOfDate: "2026-05-14",
           netLiquidation: 123456,
         }],
       },
@@ -121,6 +122,63 @@ describe("resolvePortfolioAccountState", () => {
     });
 
     expect(accountState?.account.netLiquidation).toBe(123456);
-    expect(accountState?.sourceLabel).toBe("Flex May 15");
+    expect(accountState?.sourceLabel).toBe("Flex May 14");
   });
+
+  test("uses the account as-of date when choosing the freshest cached Flex account", () => {
+    const accountState = resolvePortfolioAccountState({
+      id: "broker:ibkr-old:U12345",
+      name: "U12345",
+      currency: "USD",
+      brokerId: "ibkr",
+      brokerInstanceId: "ibkr-old",
+      brokerAccountId: "U12345",
+    }, {
+      config: {
+        brokerInstances: [
+          {
+            id: "ibkr-old",
+            label: "IBKR Old",
+            brokerType: "ibkr",
+            enabled: true,
+            config: {},
+          },
+          {
+            id: "ibkr-new",
+            label: "IBKR New",
+            brokerType: "ibkr",
+            enabled: true,
+            config: {},
+          },
+        ],
+      } as any,
+      brokerAccounts: {
+        "ibkr-old": [{
+          accountId: "U12345",
+          name: "U12345",
+          currency: "USD",
+          source: "flex",
+          updatedAt: new Date("2026-06-16T10:00:00.000Z").getTime(),
+          asOfDate: "2026-06-15",
+          netLiquidation: 100000,
+        }],
+        "ibkr-new": [{
+          accountId: "U12345",
+          name: "U12345",
+          currency: "USD",
+          source: "flex",
+          updatedAt: new Date("2026-06-15T10:00:00.000Z").getTime(),
+          asOfDate: "2026-06-16",
+          netLiquidation: 200000,
+        }],
+      },
+    }, {
+      status: null,
+      accounts: [],
+    });
+
+    expect(accountState?.account.netLiquidation).toBe(200000);
+    expect(accountState?.sourceLabel).toBe("Flex Jun 16");
+  });
+
 });

package/src/plugins/builtin/portfolio-list/summary/index.tsx

@@ -9,7 +9,7 @@ import type { Portfolio, TickerRecord } from "../../../../types/ticker";
 import type { BrokerAccount, BrokerCashBalance } from "../../../../types/trading";
 import { formatCompact, formatPercentRaw } from "../../../../utils/format";
 import { getBrokerInstance } from "../../../../utils/broker-instances";
-import { resolvePortfolioAccountMetrics } from "../account-metrics";
+import { resolvePortfolioAccountMetrics, resolvePortfolioMarketValue } from "../account-metrics";
 import { calculatePortfolioSummaryTotals, type PortfolioSummaryTotals } from "./totals";
 import { getMostRecentQuoteUpdate } from "../../../../market-data/quotes/time";
 
@@ -54,6 +54,22 @@ function formatSignedCompact(value: number): string {
   return `${value >= 0 ? "+" : ""}${formatCompact(value)}`;
 }
 
+function formatMonthDay(date: Date): string {
+  return date.toLocaleDateString("en-US", { month: "short", day: "numeric" });
+}
+
+function parseIsoDateAsLocalDate(value: string): Date | null {
+  const match = value.match(/^(\d{4})-(\d{2})-(\d{2})$/);
+  if (!match) return null;
+  const [, year, month, day] = match;
+  return new Date(Number(year), Number(month) - 1, Number(day));
+}
+
+function getAccountFreshnessTime(account: BrokerAccount): number {
+  const asOfDate = account.asOfDate ? parseIsoDateAsLocalDate(account.asOfDate) : null;
+  return asOfDate?.getTime() ?? account.updatedAt ?? 0;
+}
+
 function fitSummarySegments(candidates: PortfolioSummarySegment[], widthBudget: number): PortfolioSummarySegment[] {
   const fitted: PortfolioSummarySegment[] = [];
   let used = 0;
@@ -71,9 +87,12 @@ function formatSourceBadge(account: BrokerAccount, liveGateway: boolean): { labe
     return { label: "Live", kind: "live" };
   }
   if (account.source === "flex") {
+    const asOfDate = account.asOfDate ? parseIsoDateAsLocalDate(account.asOfDate) : null;
     return {
-      label: account.updatedAt
-        ? `Flex ${new Date(account.updatedAt).toLocaleDateString("en-US", { month: "short", day: "numeric" })}`
+      label: asOfDate
+        ? `Flex ${formatMonthDay(asOfDate)}`
+        : account.updatedAt
+          ? `Flex ${formatMonthDay(new Date(account.updatedAt))}`
         : "Flex",
       kind: "flex",
     };
@@ -120,7 +139,7 @@ function findPortfolioAccount(
 }
 
 function sortAccountsByFreshness(accounts: BrokerAccount[]): BrokerAccount[] {
-  return [...accounts].sort((left, right) => (right.updatedAt ?? 0) - (left.updatedAt ?? 0));
+  return [...accounts].sort((left, right) => getAccountFreshnessTime(right) - getAccountFreshnessTime(left));
 }
 
 export function resolvePortfolioAccountState(
@@ -165,16 +184,19 @@ export function resolvePortfolioAccountState(
 export function buildPortfolioSummarySegments({
   totals,
   accountState,
+  accountStatusText,
   widthBudget,
   refreshText,
 }: {
   totals: PortfolioSummaryTotals;
   accountState: PortfolioSummaryAccountState | null;
+  accountStatusText?: string;
   widthBudget: number;
   refreshText?: string;
 }): PortfolioSummarySegment[] {
   const candidates: PortfolioSummarySegment[] = [];
   const accountMetrics = resolvePortfolioAccountMetrics(totals, accountState?.account);
+  const totalMarketValue = resolvePortfolioMarketValue(totals, accountState?.account);
 
   if (accountState?.account.netLiquidation != null) {
     candidates.push(createSummarySegment("netliq", [
@@ -185,7 +207,7 @@ export function buildPortfolioSummarySegments({
 
   candidates.push(createSummarySegment("val", [
     { text: "Val", tone: "label" },
-    { text: formatCompact(totals.totalMktValue), tone: "value", bold: true },
+    { text: formatCompact(totalMarketValue), tone: "value", bold: true },
   ]));
 
   if (accountState?.account.totalCashValue != null) {
@@ -247,6 +269,12 @@ export function buildPortfolioSummarySegments({
     return fitSummarySegments([...candidates, ...brokerSegments], widthBudget);
   }
 
+  if (accountStatusText) {
+    candidates.push(createSummarySegment("account-status", [
+      { text: accountStatusText, tone: "muted" },
+    ]));
+  }
+
   if (refreshText) {
     candidates.push(createSummarySegment("refresh", [
       { text: refreshText, tone: "muted" },
@@ -258,6 +286,7 @@ export function buildPortfolioSummarySegments({
 
 export function buildPortfolioFooterSegments({
   accountState,
+  accountStatusText,
   activeCollectionId,
   baseCurrency,
   exchangeRates,
@@ -269,6 +298,7 @@ export function buildPortfolioFooterSegments({
   width,
 }: {
   accountState: PortfolioSummaryAccountState | null;
+  accountStatusText?: string;
   activeCollectionId: string | null;
   baseCurrency: string;
   exchangeRates: Map<string, number>;
@@ -319,6 +349,7 @@ export function buildPortfolioFooterSegments({
   return buildPortfolioSummarySegments({
     totals,
     accountState,
+    accountStatusText,
     widthBudget: Math.max(16, width - 14),
     refreshText,
   }).map((segment) => ({