gloomberb 0.8.2 → 0.9.1

package/src/plugins/builtin/chat/content/channel-navigation.ts

@@ -1,12 +1,15 @@
 import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import type { Dispatch, MutableRefObject, SetStateAction } from "react";
 import type { ChatChannel, ChatUserSummary } from "../../../../api-client";
+import { useThrottledCommitValue } from "../../../../react/use-throttled-commit-value";
 import {
   DEFAULT_CHAT_CHANNEL_ID,
   normalizeChannelId,
 } from "../channels";
 import type { ChatContentController } from "./types";
 
+const CHANNEL_NAVIGATION_COMMIT_DELAY_MS = 150;
+
 function isConversationChannelId(channelId: string): boolean {
   return channelId.startsWith("dm:") || channelId.startsWith("grp:") || channelId.startsWith("group:");
 }
@@ -38,15 +41,16 @@ export function useChatChannelNavigation({
   resetTranscriptSelection: () => void;
   showChannelSidebar: boolean;
 }): {
-  changeChannel: (nextChannelId: string) => void;
   cycleChannel: (direction: 1 | -1) => boolean;
   directExpanded: boolean;
   focusChannelSidebar: () => boolean;
   focusChatContent: () => boolean;
   moveSidebarChannelSelection: (direction: "up" | "down") => boolean;
   openDirectMessage: (target: ChatUserSummary) => Promise<void>;
+  selectSidebarChannel: (channelId: string) => void;
   setDirectExpanded: Dispatch<SetStateAction<boolean>>;
   setSidebarFocused: (nextFocused: boolean) => void;
+  sidebarCursorChannelId: string;
   sidebarFocused: boolean;
   sidebarFocusedRef: MutableRefObject<boolean>;
 } {
@@ -70,6 +74,13 @@ export function useChatChannelNavigation({
     resetTranscriptSelection();
     onChannelChange?.(normalized);
   }, [channelIdRef, onChannelChange, resetTranscriptSelection]);
+  const {
+    value: sidebarCursorChannelId,
+    valueRef: sidebarCursorChannelIdRef,
+    setValue: setSidebarCursorChannelId,
+    flushValue: flushSidebarCursorChannelId,
+    replaceValue: replaceSidebarCursorChannelId,
+  } = useThrottledCommitValue(channelId, changeChannel, CHANNEL_NAVIGATION_COMMIT_DELAY_MS);
 
   const openDirectMessage = useCallback(async (target: ChatUserSummary) => {
     if (!target.id && !target.username) return;
@@ -79,10 +90,10 @@ export function useChatChannelNavigation({
         username: target.username ?? undefined,
       });
       setDirectExpanded(true);
-      changeChannel(channel.id);
+      setSidebarCursorChannelId(channel.id, { immediate: true });
       closeProfilePopover();
     } catch {}
-  }, [changeChannel, closeProfilePopover, controller]);
+  }, [closeProfilePopover, controller, setSidebarCursorChannelId]);
 
   useEffect(() => {
     if (!onChannelChange || channelsLoading || channels.length === 0) return;
@@ -109,9 +120,9 @@ export function useChatChannelNavigation({
     const nextIndex = (currentIndex + direction + channels.length) % channels.length;
     const nextChannel = channels[nextIndex];
     if (!nextChannel) return false;
-    changeChannel(nextChannel.id);
+    setSidebarCursorChannelId(nextChannel.id, { immediate: true });
     return true;
-  }, [changeChannel, channelIdRef, channels, onChannelChange]);
+  }, [channelIdRef, channels, onChannelChange, setSidebarCursorChannelId]);
 
   const focusChannelSidebar = useCallback(() => {
     if (!showChannelSidebar || !onChannelChange) return false;
@@ -119,28 +130,49 @@ export function useChatChannelNavigation({
       blurInput();
     }
     resetTranscriptSelection();
+    replaceSidebarCursorChannelId(channelId);
     setSidebarFocused(true);
     return true;
-  }, [blurInput, inputFocused, onChannelChange, resetTranscriptSelection, setSidebarFocused, showChannelSidebar]);
+  }, [
+    blurInput,
+    channelId,
+    inputFocused,
+    onChannelChange,
+    replaceSidebarCursorChannelId,
+    resetTranscriptSelection,
+    setSidebarFocused,
+    showChannelSidebar,
+  ]);
 
   const focusChatContent = useCallback(() => {
     if (!showChannelSidebar) return false;
+    flushSidebarCursorChannelId(sidebarCursorChannelIdRef.current);
     setSidebarFocused(false);
     return true;
-  }, [setSidebarFocused, showChannelSidebar]);
+  }, [flushSidebarCursorChannelId, setSidebarFocused, showChannelSidebar, sidebarCursorChannelIdRef]);
 
   const moveSidebarChannelSelection = useCallback((direction: "up" | "down") => {
     if (!showChannelSidebar || sidebarNavigationChannels.length <= 1 || !onChannelChange) return false;
-    const currentIndex = sidebarNavigationChannels.findIndex((channel) => channel.id === channelIdRef.current);
+    const currentIndex = sidebarNavigationChannels.findIndex((channel) => channel.id === sidebarCursorChannelIdRef.current);
     const baseIndex = currentIndex >= 0 ? currentIndex : 0;
     const nextIndex = direction === "down"
       ? Math.min(baseIndex + 1, sidebarNavigationChannels.length - 1)
       : Math.max(baseIndex - 1, 0);
     const nextChannel = sidebarNavigationChannels[nextIndex];
     if (!nextChannel || nextIndex === baseIndex) return true;
-    changeChannel(nextChannel.id);
+    setSidebarCursorChannelId(nextChannel.id);
     return true;
-  }, [changeChannel, channelIdRef, onChannelChange, showChannelSidebar, sidebarNavigationChannels]);
+  }, [
+    onChannelChange,
+    setSidebarCursorChannelId,
+    showChannelSidebar,
+    sidebarCursorChannelIdRef,
+    sidebarNavigationChannels,
+  ]);
+
+  const selectSidebarChannel = useCallback((nextChannelId: string) => {
+    setSidebarCursorChannelId(nextChannelId, { immediate: true });
+  }, [setSidebarCursorChannelId]);
 
   useEffect(() => {
     if (focused && showChannelSidebar) return;
@@ -148,15 +180,16 @@ export function useChatChannelNavigation({
   }, [focused, setSidebarFocused, showChannelSidebar]);
 
   return {
-    changeChannel,
     cycleChannel,
     directExpanded,
     focusChannelSidebar,
     focusChatContent,
     moveSidebarChannelSelection,
     openDirectMessage,
+    selectSidebarChannel,
     setDirectExpanded,
     setSidebarFocused,
+    sidebarCursorChannelId,
     sidebarFocused,
     sidebarFocusedRef,
   };

package/src/plugins/builtin/chat/content/index.tsx

@@ -212,15 +212,16 @@ export function ChatContent({
   });
 
   const {
-    changeChannel,
     cycleChannel,
     directExpanded,
     focusChannelSidebar,
     focusChatContent,
     moveSidebarChannelSelection,
     openDirectMessage,
+    selectSidebarChannel,
     setDirectExpanded,
     setSidebarFocused,
+    sidebarCursorChannelId,
     sidebarFocused,
     sidebarFocusedRef,
   } = useChatChannelNavigation({
@@ -367,7 +368,7 @@ export function ChatContent({
         <ChannelSidebar
           channels={channels}
           channelStates={channelStates}
-          activeChannelId={channelId}
+          activeChannelId={sidebarFocused ? sidebarCursorChannelId : channelId}
           onlineCount={onlineCount}
           width={channelSidebarWidth}
           height={height}
@@ -376,7 +377,7 @@ export function ChatContent({
           loading={channelsLoading}
           canManageNotifications={!!user?.emailVerified}
           directExpanded={directExpanded}
-          onSelect={changeChannel}
+          onSelect={selectSidebarChannel}
           onFocusRequest={() => setSidebarFocused(true)}
           onToggleNotifications={(nextChannelId, enabled) => {
             controller.setChannelNotificationsEnabled(nextChannelId, enabled);
@@ -392,7 +393,7 @@ export function ChatContent({
         flexGrow={nativePaneChrome ? 1 : undefined}
         backgroundColor={chatContentBg}
         position="relative"
-        onMouseDown={() => setSidebarFocused(false)}
+        onMouseDown={() => focusChatContent()}
         style={nativeFillStyle}
       >
       {!nativePaneChrome && (

package/src/plugins/builtin/chat/content/shortcuts.ts

@@ -75,6 +75,13 @@ export function useChatContentShortcuts({
     const isEnterKey = event.name === "return" || event.name === "enter";
 
     if (sidebarFocusedRef.current && showChannelSidebar) {
+      if (isEnterKey) {
+        event.preventDefault?.();
+        event.stopPropagation?.();
+        focusChatContent();
+        return;
+      }
+
       if (isPlainKey(event, "left")) {
         event.preventDefault?.();
         event.stopPropagation?.();

package/src/plugins/builtin/chat/sidebar.test.tsx

@@ -9,6 +9,7 @@ import { PluginRenderProvider } from "../../runtime";
 import { gloomberbCloudPlugin } from "../cloud";
 import { ChatContent } from "../chat";
 import { chatController } from "./controller";
+import { useChatChannelNavigation } from "./content/channel-navigation";
 import {
   cleanupChatTest,
   createChatTestControls,
@@ -285,6 +286,76 @@ describe("ChatContent channel sidebar", () => {
     expect(setup().captureCharFrame()).toContain("#equities");
   });
 
+  test("coalesces rapid sidebar navigation to the final channel", async () => {
+    const controller = createController({ sessionToken: "token-123" });
+    const channels = [
+      { id: "everyone", name: "everyone", created_at: "2026-03-26T12:10:05.684Z" },
+      { id: "equities", name: "equities", created_at: "2026-05-09T00:00:00.000Z" },
+      { id: "options", name: "options", created_at: "2026-05-09T00:00:00.000Z" },
+      { id: "macro", name: "macro", created_at: "2026-05-09T00:00:00.000Z" },
+      { id: "crypto", name: "crypto", created_at: "2026-05-09T00:00:00.000Z" },
+    ];
+    const channelChanges: string[] = [];
+    let navigation: ReturnType<typeof useChatChannelNavigation> | null = null;
+    let latestCursorChannelId = "";
+    let latestCommittedChannelId = "";
+
+    function NavigationHarness() {
+      const [channelId, setChannelId] = useState("equities");
+      const channelIdRef = useRef(channelId);
+      channelIdRef.current = channelId;
+      const handleChannelChange = useCallback((nextChannelId: string) => {
+        channelChanges.push(nextChannelId);
+        setChannelId(nextChannelId);
+      }, []);
+      navigation = useChatChannelNavigation({
+        blurInput: () => {},
+        channelId,
+        channelIdRef,
+        channels,
+        channelsLoading: false,
+        closeProfilePopover: () => {},
+        controller,
+        focused: true,
+        inputFocused: false,
+        onChannelChange: handleChannelChange,
+        resetTranscriptSelection: () => {},
+        showChannelSidebar: true,
+      });
+      latestCursorChannelId = navigation.sidebarCursorChannelId;
+      latestCommittedChannelId = channelId;
+
+      return null;
+    }
+
+    await act(async () => {
+      testSetup = await testRender(<NavigationHarness />, {
+        width: 90,
+        height: 12,
+      });
+    });
+
+    await act(async () => {
+      navigation?.focusChannelSidebar();
+      navigation?.moveSidebarChannelSelection("down");
+      navigation?.moveSidebarChannelSelection("down");
+      navigation?.moveSidebarChannelSelection("down");
+      await setup().renderOnce();
+    });
+
+    expect(latestCursorChannelId).toBe("crypto");
+    expect(latestCommittedChannelId).toBe("equities");
+    expect(channelChanges).toEqual([]);
+
+    await act(async () => {
+      await new Promise((resolve) => setTimeout(resolve, 180));
+      await setup().renderOnce();
+    });
+
+    expect(channelChanges).toEqual(["crypto"]);
+    expect(latestCommittedChannelId).toBe("crypto");
+  });
+
   test("keeps the channel sidebar visible while a channel loads", async () => {
     const controller = createController({ sessionToken: "token-123" });
     installServerChannels(controller);

package/src/plugins/builtin/help/components.tsx

@@ -29,7 +29,7 @@ export function ShortcutRow({
   return (
     <Box flexDirection="row" gap={1}>
       <Box flexDirection="row" gap={1} flexShrink={0}>
-        {badges.map((badge) => <ShortcutBadge key={badge} label={badge} />)}
+        {badges.map((badge, index) => <ShortcutBadge key={`${badge}:${index}`} label={badge} />)}
       </Box>
       <Box flexGrow={1}>
         <Text fg={colors.text} wrapText>{description}</Text>

package/src/plugins/builtin/help/index.test.tsx

@@ -34,32 +34,69 @@ async function renderHelpPane(
     size,
   );
 
+  await testSetup.renderOnce();
   await testSetup.renderOnce();
   return testSetup;
 }
 
+async function moveHelpTabRight(count = 1) {
+  await act(async () => {
+    for (let index = 0; index < count; index += 1) {
+      testSetup!.mockInput.pressArrow("right");
+    }
+    await testSetup!.renderOnce();
+    await testSetup!.renderOnce();
+  });
+}
+
+async function resetRenderedHelpPane(
+  runtime = createTestPluginRuntime(),
+  size = { width: 88, height: 36 },
+) {
+  if (testSetup) {
+    act(() => {
+      testSetup!.renderer.destroy();
+    });
+    testSetup = undefined;
+  }
+  return renderHelpPane(runtime, size);
+}
+
 function withoutScrollbar(line: string) {
   const scrollThumb = String.fromCharCode(0x2588);
   return (line.endsWith(scrollThumb) ? line.slice(0, -1) : line).trimEnd();
 }
 
 describe("HelpPane", () => {
-  test("puts section spacing before headings instead of after them", async () => {
+  test("starts on basics and puts section spacing before headings instead of after them", async () => {
     await renderHelpPane(createTestPluginRuntime(), { width: 88, height: 80 });
 
     const lines = testSetup!.captureCharFrame().split("\n").map(withoutScrollbar);
     const commandBarRow = lines.findIndex((line) => line.includes("Command Bar"));
-    const templatesRow = lines.findIndex((line) => line.includes("Window Templates"));
-
+    const layoutRow = lines.findIndex((line) => line.includes("Layout Basics"));
+
+    expect(lines[0]).toContain("Basics");
+    expect(testSetup!.captureCharFrame()).toContain("Basics");
+    expect(testSetup!.captureCharFrame()).toContain("Functions");
+    expect(testSetup!.captureCharFrame()).toContain("Issues");
+    expect(testSetup!.captureCharFrame()).not.toContain("Issues/Debug");
+    expect(testSetup!.captureCharFrame()).not.toContain("Window Templates");
+    expect(testSetup!.captureCharFrame()).not.toContain("Search for a ticker or open the best matching security.");
     expect(commandBarRow).toBeGreaterThan(0);
-    expect(templatesRow).toBeGreaterThan(commandBarRow);
+    expect(layoutRow).toBeGreaterThan(commandBarRow);
     expect(lines[commandBarRow - 1]?.trim()).toBe("");
-    expect(lines[commandBarRow + 1]).toContain("Open or toggle the command bar");
-    expect(lines[templatesRow - 1]?.trim()).toBe("");
-    expect(lines[templatesRow + 1]?.trim()).not.toBe("");
+    expect(lines[commandBarRow + 1]).toContain("Open command mode");
+    expect(testSetup!.captureCharFrame()).toContain("Open ticker search directly.");
+    expect(testSetup!.captureCharFrame()).toContain("DES");
+    expect(testSetup!.captureCharFrame()).toContain("Clear command text.");
+    expect(testSetup!.captureCharFrame()).toContain("Delete the previous word");
+    expect(testSetup!.captureCharFrame()).toContain("Submit multiline command forms.");
+    expect(testSetup!.captureCharFrame()).toContain("close all floating panes");
+    expect(lines[layoutRow - 1]?.trim()).toBe("");
+    expect(lines[layoutRow + 1]?.trim()).not.toBe("");
   });
 
-  test("lists core, plugin command, template, and keyboard shortcuts", async () => {
+  test("separates functions from keyboard shortcuts", async () => {
     setSharedRegistryForTests({
       commands: new Map([[
         "set-alert",
@@ -106,24 +143,52 @@ describe("HelpPane", () => {
     } as any);
 
     await renderHelpPane(createTestPluginRuntime(), { width: 88, height: 80 });
-
-    const frame = testSetup!.captureCharFrame();
-    expect(frame).toMatch(/AW\s+<ticker>/);
-    expect(frame).toMatch(/SA\s+<symbol condition price>/);
-    expect(frame).toMatch(/QQ\s+<tickers>/);
-    expect(frame).toContain("Add Alert (Alerts)");
-    expect(frame).toContain("Shift+X");
-    expect(frame).toContain("Sync data (Gloom Cloud)");
-    expect(frame).toContain("Ctrl+W");
-    expect(frame).toContain("Ctrl+,");
-    expect(frame).not.toContain("Ctrl+Shift+O");
-    expect(frame).not.toContain("Pop the focused pane");
-    expect(frame).not.toContain("Cmd+W");
-    expect(frame).not.toContain("Cmd+,");
-    expect(frame).not.toContain("Cmd+K");
-    expect(frame).not.toContain("Cmd/Ctrl");
-    expect(frame).not.toContain("CmdOrCtrl");
-    expect(frame).not.toContain("Open ticker actions for the focused ticker.");
+    await moveHelpTabRight();
+
+    const functionsFrame = testSetup!.captureCharFrame();
+    expect(functionsFrame).toContain("Manage Plugins");
+    expect(functionsFrame).toMatch(/AW\s+<ticker>/);
+    expect(functionsFrame).toMatch(/SA\s+<symbol condition price>/);
+    expect(functionsFrame).toMatch(/QQ\s+<tickers>/);
+    expect(functionsFrame).toContain("Alerts");
+    expect(functionsFrame).toContain("Add Alert");
+    expect(functionsFrame).toContain("Shift+X");
+    expect(functionsFrame).toContain("Gloom Cloud");
+    expect(functionsFrame).toContain("Sync data");
+    expect(functionsFrame).toContain("Ticker Research");
+    expect(functionsFrame).toContain("Quote Monitor");
+    expect(functionsFrame).not.toContain("Add Alert (Alerts)");
+    expect(functionsFrame).not.toContain("Sync data (Gloom Cloud)");
+    expect(functionsFrame).not.toContain("Quote Monitor (Ticker Research)");
+    expect(functionsFrame).not.toContain("Ctrl+W");
+
+    await resetRenderedHelpPane(createTestPluginRuntime(), { width: 88, height: 80 });
+    await moveHelpTabRight(2);
+
+    const shortcutsFrame = testSetup!.captureCharFrame();
+    expect(shortcutsFrame).toContain("Ctrl+W");
+    expect(shortcutsFrame).toContain("Ctrl+Alt+W");
+    expect(shortcutsFrame).toContain("Ctrl+Shift+M");
+    expect(shortcutsFrame).toContain("Ctrl+Shift+R");
+    expect(shortcutsFrame).toContain("Ctrl+,");
+    expect(shortcutsFrame).toContain("Navigation");
+    expect(shortcutsFrame).toContain("Up/Down");
+    expect(shortcutsFrame).toContain("j/k");
+    expect(shortcutsFrame).toContain("Left/Right");
+    expect(shortcutsFrame).toContain("h/l");
+    expect(shortcutsFrame).toContain("PageUp/PageDown");
+    expect(shortcutsFrame).toContain("Window Mode");
+    expect(shortcutsFrame).toContain("h/j/k/l");
+    expect(shortcutsFrame).toContain("Close all floating panes.");
+    expect(shortcutsFrame).not.toContain("AW");
+    expect(shortcutsFrame).not.toContain("Ctrl+Shift+O");
+    expect(shortcutsFrame).not.toContain("Pop the focused pane");
+    expect(shortcutsFrame).not.toContain("Cmd+W");
+    expect(shortcutsFrame).not.toContain("Cmd+,");
+    expect(shortcutsFrame).not.toContain("Cmd+K");
+    expect(shortcutsFrame).not.toContain("Cmd/Ctrl");
+    expect(shortcutsFrame).not.toContain("CmdOrCtrl");
+    expect(shortcutsFrame).not.toContain("Open ticker actions for the focused ticker.");
   });
 
   test("keeps shortcuts and descriptions on the same row when narrow", async () => {
@@ -131,14 +196,18 @@ describe("HelpPane", () => {
 
     const lines = testSetup!.captureCharFrame().split("\n").map(withoutScrollbar);
     const closeCommandRow = lines.findIndex((line) => line.includes("Close the command bar."));
-    const securityDetailsRow = lines.findIndex((line) => line.includes("Open security details"));
 
     expect(closeCommandRow).toBeGreaterThanOrEqual(0);
     expect(lines[closeCommandRow]).toContain("Esc");
     expect(lines[closeCommandRow]).toContain("`");
+
+    await moveHelpTabRight();
+
+    const functionLines = testSetup!.captureCharFrame().split("\n").map(withoutScrollbar);
+    const securityDetailsRow = functionLines.findIndex((line) => line.includes("Open security details"));
     expect(securityDetailsRow).toBeGreaterThanOrEqual(0);
-    expect(lines[securityDetailsRow]).toContain("DES");
-    expect(lines[securityDetailsRow]).toContain("<ticker>");
+    expect(functionLines[securityDetailsRow]).toContain("DES");
+    expect(functionLines[securityDetailsRow]).toContain("<ticker>");
   });
 
   test("opens the debug log from the mouse action", async () => {
@@ -149,8 +218,14 @@ describe("HelpPane", () => {
     });
 
     await renderHelpPane(runtime);
+    await moveHelpTabRight(3);
+
+    const frame = testSetup!.captureCharFrame();
+    expect(frame).toContain("GitHub Issues");
+    expect(frame).not.toContain("Issues/Debug");
+    expect(frame).not.toContain("plugin,\n");
 
-    const lines = testSetup!.captureCharFrame().split("\n");
+    const lines = frame.split("\n");
     const row = lines.findIndex((line) => line.includes("Open Debug Log"));
     const col = lines[row]?.indexOf("Open Debug Log") ?? -1;