gloomberb 0.7.5 → 0.8.0

package/src/components/command-bar/commands/plugin/items.ts

@@ -0,0 +1,166 @@
+import type { PluginRegistry } from "../../../../plugins/registry";
+import type { CommandDef, CommandResultDef } from "../../../../types/plugin";
+import type { OpenInlineConfirm } from "../../routing/confirm";
+import type { ResultItem } from "../../list/model";
+
+type NotifyFn = (body: string, options?: { type?: "info" | "success" | "error" }) => void;
+
+interface PluginCommandConfirm {
+  title: string;
+  body: string[];
+  confirmLabel?: string;
+  cancelLabel?: string;
+  tone?: "default" | "danger";
+}
+
+export function getAvailablePluginCommandsForState(
+  pluginRegistry: PluginRegistry,
+  disabledPlugins: readonly string[],
+): CommandDef[] {
+  const disabledPluginIds = new Set(disabledPlugins);
+  return [...pluginRegistry.commands.values()]
+    .filter((command) => {
+      if (command.hidden?.()) return false;
+      const pluginId = pluginRegistry.getCommandPluginId(command.id);
+      if (pluginId && disabledPluginIds.has(pluginId)) return false;
+      return true;
+    });
+}
+
+export async function runPluginCommandDirect(options: {
+  command: CommandDef;
+  values?: Record<string, string>;
+  closeAll: (options?: { revertThemePreview?: boolean }) => void;
+  notify: NotifyFn;
+}): Promise<void> {
+  try {
+    await options.command.execute(options.values);
+    options.closeAll({ revertThemePreview: false });
+  } catch (error) {
+    options.notify(
+      error instanceof Error ? error.message : `Could not run ${options.command.label.toLowerCase()}.`,
+      { type: "error" },
+    );
+  }
+}
+
+function parsePluginCommandShortcutArg(
+  command: CommandDef,
+  shortcutArg: string,
+  activeTicker: string | null,
+): Record<string, string> {
+  return command.shortcutArg?.parse?.(shortcutArg, {
+    activeTicker,
+  }) ?? (shortcutArg.trim() ? { shortcut: shortcutArg } : {});
+}
+
+export function buildPluginCommandItem(options: {
+  command: CommandDef;
+  shortcutArg?: string;
+  activeTicker: string | null;
+  pluginRegistry: PluginRegistry;
+  openPluginCommandWorkflow: (command: CommandDef, options?: { values?: Record<string, string> }) => void;
+  resolvePluginCommandConfirm: (command: CommandDef) => PluginCommandConfirm | null;
+  openInlineConfirm: OpenInlineConfirm;
+  runPluginCommandDirect: (command: CommandDef, values?: Record<string, string>) => void;
+  notify: NotifyFn;
+}): ResultItem {
+  const pluginId = options.pluginRegistry.getCommandPluginId(options.command.id);
+  const pluginName = pluginId ? options.pluginRegistry.allPlugins.get(pluginId)?.name : null;
+  const shortcut = options.command.shortcut?.trim() || undefined;
+  const shortcutArg = options.shortcutArg?.trim() || "";
+  return {
+    id: options.command.id,
+    label: options.command.label,
+    detail: shortcutArg || options.command.description || "",
+    category: pluginName || "Plugin Commands",
+    kind: "command",
+    right: shortcut,
+    shortcutQuery: shortcut,
+    searchText: `${options.command.label} ${options.command.description || ""} ${(options.command.keywords ?? []).join(" ")} ${shortcut || ""}`,
+    action: () => {
+      if (shortcutArg && options.command.wizard && options.command.wizard.length > 0) {
+        try {
+          options.openPluginCommandWorkflow(options.command, {
+            values: parsePluginCommandShortcutArg(options.command, shortcutArg, options.activeTicker),
+          });
+        } catch (error) {
+          options.notify(
+            error instanceof Error ? error.message : `Could not parse ${options.command.label.toLowerCase()}.`,
+            { type: "error" },
+          );
+        }
+        return;
+      }
+      if (shortcutArg) {
+        try {
+          options.runPluginCommandDirect(
+            options.command,
+            parsePluginCommandShortcutArg(options.command, shortcutArg, options.activeTicker),
+          );
+        } catch (error) {
+          options.notify(
+            error instanceof Error ? error.message : `Could not parse ${options.command.label.toLowerCase()}.`,
+            { type: "error" },
+          );
+        }
+        return;
+      }
+      if (options.command.wizard && options.command.wizard.length > 0) {
+        const values = parsePluginCommandShortcutArg(options.command, "", options.activeTicker);
+        options.openPluginCommandWorkflow(options.command, { values });
+        return;
+      }
+      const confirm = options.resolvePluginCommandConfirm(options.command);
+      if (confirm) {
+        options.openInlineConfirm({
+          confirmId: `plugin-command:${options.command.id}`,
+          title: confirm.title,
+          body: confirm.body,
+          confirmLabel: confirm.confirmLabel || options.command.label,
+          cancelLabel: confirm.cancelLabel || "Back",
+          tone: confirm.tone || "danger",
+          onConfirm: async () => {
+            await options.command.execute();
+          },
+        });
+        return;
+      }
+      options.runPluginCommandDirect(options.command);
+    },
+  };
+}
+
+export function buildPluginCommandResultItem(options: {
+  command: CommandDef;
+  result: CommandResultDef;
+  pluginRegistry: PluginRegistry;
+  closeAll: (options?: { revertThemePreview?: boolean }) => void;
+  notify: NotifyFn;
+}): ResultItem {
+  const pluginId = options.pluginRegistry.getCommandPluginId(options.command.id);
+  const pluginName = pluginId ? options.pluginRegistry.allPlugins.get(pluginId)?.name : null;
+  const category = options.result.category ?? pluginName ?? options.command.label;
+  return {
+    id: `plugin-command-result:${options.command.id}:${options.result.id}`,
+    label: options.result.label,
+    detail: options.result.detail ?? options.command.description ?? "",
+    category,
+    kind: "command",
+    right: (options.result.right ?? options.command.shortcut?.trim()) || undefined,
+    searchText: `${options.result.label} ${options.result.detail || ""} ${(options.result.keywords ?? []).join(" ")} ${options.command.label} ${options.command.description || ""} ${(options.command.keywords ?? []).join(" ")}`,
+    disabled: options.result.disabled,
+    current: options.result.current,
+    action: async () => {
+      try {
+        await options.result.execute();
+        options.closeAll({ revertThemePreview: false });
+      } catch (error) {
+        options.notify(
+          error instanceof Error ? error.message : `Could not run ${options.command.label.toLowerCase()}.`,
+          { type: "error" },
+        );
+      }
+    },
+  };
+}

package/src/components/command-bar/commands/registry.ts

@@ -0,0 +1,263 @@
+import type { AppAction } from "../../../state/app/context";
+import type { Dispatch } from "react";
+
+type CommandExecutor = (dispatch: Dispatch<AppAction>, context: CommandContext) => void | Promise<void>;
+
+interface CommandContext {
+  activeTicker: string | null;
+  activeCollectionId: string | null;
+}
+
+export interface Command {
+  id: string;
+  prefix: string;        // e.g., "DES", "AW", "RP"
+  aliases?: string[];
+  label: string;
+  description: string;
+  hasArg?: boolean;       // true if prefix takes an argument (e.g., "DES AMD")
+  argPlaceholder?: string;
+  shortcut?: string;
+  category: string;
+  execute?: CommandExecutor;
+}
+
+export const commands: Command[] = [
+  // Security description
+  {
+    id: "security-description",
+    prefix: "DES",
+    aliases: ["T"],
+    label: "Description",
+    description: "Open security details for a ticker",
+    hasArg: true,
+    argPlaceholder: "ticker",
+    category: "Search",
+  },
+  {
+    id: "help",
+    prefix: "HELP",
+    label: "Help",
+    description: "Open the help window",
+    category: "Navigation",
+  },
+
+  // Watchlist/Portfolio management
+  {
+    id: "add-watchlist",
+    prefix: "AW",
+    label: "Add to Watchlist",
+    description: "Add current ticker to active watchlist",
+    hasArg: true,
+    argPlaceholder: "ticker",
+    category: "Portfolio",
+  },
+  {
+    id: "add-portfolio",
+    prefix: "AP",
+    label: "Add to Portfolio",
+    description: "Add current ticker to active portfolio",
+    hasArg: true,
+    argPlaceholder: "ticker",
+    category: "Portfolio",
+  },
+  {
+    id: "remove-watchlist",
+    prefix: "RW",
+    label: "Remove from Watchlist",
+    description: "Remove current ticker from active watchlist",
+    hasArg: true,
+    argPlaceholder: "ticker",
+    category: "Portfolio",
+  },
+  {
+    id: "remove-portfolio",
+    prefix: "RP",
+    label: "Remove from Portfolio",
+    description: "Remove current ticker from active portfolio",
+    hasArg: true,
+    argPlaceholder: "ticker",
+    category: "Portfolio",
+  },
+  {
+    id: "set-portfolio-position",
+    prefix: "",
+    label: "Set Portfolio Position",
+    description: "Create or update a manual position in a portfolio",
+    category: "Portfolio",
+  },
+
+  // Create / Delete
+  {
+    id: "new-portfolio",
+    prefix: "",
+    label: "New Portfolio",
+    description: "Create a new portfolio",
+    category: "Create",
+  },
+  {
+    id: "new-watchlist",
+    prefix: "",
+    label: "New Watchlist",
+    description: "Create a new watchlist",
+    category: "Create",
+  },
+  {
+    id: "delete-portfolio",
+    prefix: "",
+    label: "Delete Portfolio",
+    description: "Remove a portfolio and its data",
+    category: "Danger",
+  },
+  {
+    id: "delete-watchlist",
+    prefix: "",
+    label: "Delete Watchlist",
+    description: "Remove a watchlist",
+    category: "Danger",
+  },
+  {
+    id: "add-broker-account",
+    prefix: "",
+    label: "Add Broker Account",
+    description: "Connect a new broker profile",
+    category: "Config",
+  },
+  {
+    id: "disconnect-broker-account",
+    prefix: "",
+    label: "Disconnect Broker Account",
+    description: "Remove one connected broker profile and its imported data",
+    category: "Danger",
+  },
+
+  {
+    id: "pane-settings",
+    prefix: "PS",
+    label: "Pane Settings",
+    description: "Edit settings for the focused pane",
+    category: "Config",
+  },
+  {
+    id: "layout",
+    prefix: "LAY",
+    label: "Layout Actions",
+    description: "Organize panes and saved layouts",
+    hasArg: true,
+    argPlaceholder: "action",
+    category: "Config",
+  },
+  {
+    id: "window-mode",
+    prefix: "WIN",
+    aliases: ["WM"],
+    label: "Window Mode",
+    description: "Move or resize the focused window",
+    hasArg: true,
+    argPlaceholder: "move|resize",
+    category: "Config",
+  },
+  {
+    id: "toggle-status-bar",
+    prefix: "SB",
+    label: "Toggle Status Bar",
+    description: "Show or hide the keyboard shortcuts bar",
+    category: "Config",
+    execute: (dispatch) => {
+      dispatch({ type: "TOGGLE_STATUS_BAR" });
+    },
+  },
+  {
+    id: "toggle-value-flashing",
+    prefix: "VF",
+    label: "Toggle Value Flashing",
+    description: "Turn quote update flashing on or off",
+    category: "Config",
+  },
+  {
+    id: "check-for-updates",
+    prefix: "",
+    label: "Check for Updates",
+    description: "Check GitHub releases for a newer version",
+    category: "Config",
+  },
+
+  // Theme
+  {
+    id: "theme",
+    prefix: "TH",
+    label: "Change Theme",
+    description: "Switch color theme",
+    hasArg: true,
+    argPlaceholder: "theme name",
+    category: "Config",
+  },
+  {
+    id: "cycle-chart-renderer",
+    prefix: "CR",
+    label: "Cycle Chart Renderer",
+    description: "Cycle chart rendering between Auto, Kitty, and Braille",
+    category: "Config",
+  },
+
+  // Plugins
+  {
+    id: "plugins",
+    prefix: "PL",
+    label: "Manage Plugins",
+    description: "Toggle plugins on/off",
+    hasArg: true,
+    argPlaceholder: "plugin name",
+    category: "Config",
+  },
+
+  // Import/Export
+  {
+    id: "export-config",
+    prefix: "",
+    label: "Export Config",
+    description: "Save config to ~/gloomberb-config-backup.json",
+    category: "Config",
+  },
+  {
+    id: "import-config",
+    prefix: "",
+    label: "Import Config",
+    description: "Load config from ~/gloomberb-config-backup.json",
+    category: "Config",
+  },
+
+  // Danger zone
+  {
+    id: "reset-all-data",
+    prefix: "",
+    label: "Reset All Data",
+    description: "Delete all data and reset to first-run state",
+    category: "Danger",
+  },
+];
+
+/** Find a command whose prefix matches the start of the input */
+export function matchPrefix(input: string, commandList: Command[] = commands): { command: Command; arg: string; prefix: string } | null {
+  const upper = input.toUpperCase().trim();
+  if (!upper) return null;
+
+  // Sort by prefix length descending so longer prefixes match first (e.g., "AW" before "A")
+  const sorted = commandList
+    .flatMap((command) => getCommandPrefixes(command).map((prefix) => ({ command, prefix })))
+    .sort((a, b) => b.prefix.length - a.prefix.length);
+
+  for (const { command, prefix } of sorted) {
+    if (upper.startsWith(`${prefix} `) || upper === prefix) {
+      const arg = input.slice(prefix.length).trim();
+      return { command, arg, prefix };
+    }
+  }
+
+  return null;
+}
+
+export function getCommandPrefixes(command: Command): string[] {
+  return [command.prefix, ...(command.aliases ?? [])]
+    .map((prefix) => prefix.trim().toUpperCase())
+    .filter(Boolean);
+}

package/src/components/command-bar/helpers.test.ts

@@ -3,7 +3,7 @@ import type { PaneTemplateDef, WizardStep } from "../../types/plugin";
 import type {
   CommandBarRoute,
   CommandBarWorkflowField,
-} from "./workflow-types";
+} from "./workflow/types";
 import {
   buildGeneratedTemplateField,
   getCollectionCommandAction,
@@ -18,14 +18,12 @@ import {
   isRouteCommandId,
   isWorkflowTextField,
   looksDestructiveCommand,
-  moveSelectedValue,
   normalizeWizardFields,
   routeCommandIdToScreen,
   slugifyName,
   summarizeError,
   summarizePaneSettingValue,
   summarizeWorkflowFieldValue,
-  toggleSelectedValue,
 } from "./helpers";
 
 const workflowFields: CommandBarWorkflowField[] = [
@@ -101,24 +99,6 @@ describe("command-bar helpers", () => {
     }, ["symbol", "price", "pnl", "volume"])).toBe("Symbol, Price, P&L +1");
   });
 
-  test("toggles and reorders selected values while preserving unknown entries", () => {
-    expect(toggleSelectedValue(["symbol", "price"], "price")).toEqual(["symbol"]);
-    expect(toggleSelectedValue(["symbol"], "price")).toEqual(["symbol", "price"]);
-
-    expect(moveSelectedValue(
-      {
-        options: [
-          { label: "Symbol", value: "symbol" },
-          { label: "Price", value: "price" },
-          { label: "P&L", value: "pnl" },
-        ],
-      },
-      ["symbol", "price", "custom"],
-      "price",
-      "up",
-    )).toEqual(["price", "symbol", "custom"]);
-  });
-
   test("normalizes wizard fields and derives defaults from steps", () => {
     const steps: WizardStep[] = [
       { key: "intro", label: "Intro", type: "info", body: ["Line one", "Line two"] },
@@ -194,18 +174,30 @@ describe("command-bar helpers", () => {
     };
     const workflowRoute: CommandBarRoute = {
       kind: "workflow",
+      workflowId: "create-pane",
       title: "Create Pane",
       fields: [],
       values: {},
       activeFieldId: null,
+      submitLabel: "Create",
+      pending: false,
+      error: null,
+      payload: {
+        kind: "builtin",
+        actionId: "create-pane",
+      },
     };
     const confirmRoute: CommandBarRoute = {
       kind: "confirm",
+      confirmId: "delete",
       title: "Delete",
       body: ["Delete item?"],
       confirmLabel: "Delete",
       cancelLabel: "Back",
       tone: "danger",
+      onConfirm: () => {},
+      pending: false,
+      error: null,
     };
 
     expect(getScreenFooterLeft(null)).toBe("up/down move  enter select");