gloomberb 0.6.1 → 0.7.0

package/src/plugins/builtin/chat-controller.test.ts

@@ -83,6 +83,15 @@ class MemoryPersistence implements PluginPersistence {
   }
 }
 
+class TrackingPersistence extends MemoryPersistence {
+  stateWrites = 0;
+
+  setState(key: string, value: unknown, options?: { schemaVersion?: number }): void {
+    this.stateWrites += 1;
+    super.setState(key, value, options);
+  }
+}
+
 afterEach(() => {
   apiClient.dispose();
   apiClient.setSessionToken(null);
@@ -209,6 +218,34 @@ describe("ChatController", () => {
     })).toBeNull();
   });
 
+  test("defers draft persistence and subscriber sync until the user pauses or leaves", () => {
+    const persistence = new TrackingPersistence();
+    const controller = new ChatController();
+    const draftSnapshots: string[] = [];
+
+    controller.attachPersistence(persistence);
+    const unsubscribe = controller.subscribe((snapshot) => {
+      draftSnapshots.push(snapshot.draft);
+    });
+    draftSnapshots.length = 0;
+    persistence.stateWrites = 0;
+
+    controller.setDraft("h");
+    controller.setDraft("he");
+
+    expect(controller.getSnapshot().draft).toBe("he");
+    expect(draftSnapshots).toEqual([]);
+    expect(persistence.stateWrites).toBe(0);
+    expect(persistence.getState("channel:everyone", { schemaVersion: 1 })).toBeNull();
+
+    unsubscribe();
+    controller.dispose();
+
+    expect(persistence.getState<{ draft: string }>("channel:everyone", { schemaVersion: 1 })).toMatchObject({
+      draft: "he",
+    });
+  });
+
   test("pauses verification polling while the app is backgrounded", () => {
     const controller = new ChatController();
 
@@ -254,6 +291,74 @@ describe("ChatController", () => {
     expect((controller as any).wsConnection).toBeNull();
   });
 
+  test("runs a quiet safety refresh while the live connection is active", async () => {
+    const persistence = new MemoryPersistence();
+    const controller = new ChatController();
+    const originalSetInterval = globalThis.setInterval;
+    const originalClearInterval = globalThis.clearInterval;
+    const intervalCallbacks: Array<() => void> = [];
+    const intervalHandle = { unref: () => {} };
+    let cleared = false;
+    let getMessagesCalls = 0;
+    const loadingSnapshots: boolean[] = [];
+
+    persistence.setState("session", {
+      sessionToken: "token-123",
+      user: { id: "u1", username: "vince", emailVerified: true },
+    }, { schemaVersion: 1 });
+
+    (globalThis as any).setInterval = (callback: () => void, timeout: number) => {
+      expect(timeout).toBe(30_000);
+      intervalCallbacks.push(callback);
+      return intervalHandle;
+    };
+    (globalThis as any).clearInterval = (handle: unknown) => {
+      if (handle === intervalHandle) {
+        cleared = true;
+      }
+    };
+
+    try {
+      apiClient.getMessages = async () => {
+        getMessagesCalls += 1;
+        return [];
+      };
+      apiClient.connectChannel = () => ({
+        send: async () => {
+          throw new Error("not implemented");
+        },
+        close: () => {},
+      });
+
+      controller.attachPersistence(persistence);
+      controller.ensureConnection();
+      await flushMicrotasks();
+
+      expect(intervalCallbacks).toHaveLength(1);
+      expect(getMessagesCalls).toBe(1);
+      expect(controller.getSnapshot().loading).toBe(false);
+
+      controller.subscribe((snapshot) => {
+        loadingSnapshots.push(snapshot.loading);
+      });
+      loadingSnapshots.length = 0;
+
+      intervalCallbacks[0]!();
+      await flushMicrotasks();
+
+      expect(getMessagesCalls).toBe(2);
+      expect(loadingSnapshots).toEqual([false]);
+
+      controller.clearSession();
+      expect((controller as any).safetyRefreshTimer).toBeNull();
+      expect(cleared).toBe(true);
+    } finally {
+      controller.dispose();
+      (globalThis as any).setInterval = originalSetInterval;
+      (globalThis as any).clearInterval = originalClearInterval;
+    }
+  });
+
   test("keeps the cached session when session refresh fails transiently", async () => {
     const persistence = new MemoryPersistence();
     const controller = new ChatController();

package/src/plugins/builtin/chat-controller.ts

@@ -16,7 +16,9 @@ const TRANSCRIPT_CACHE_POLICY = {
   staleMs: 30 * 24 * 60 * 60_000,
   expireMs: 90 * 24 * 60 * 60_000,
 };
+const DRAFT_SYNC_DEBOUNCE_MS = 250;
 const VERIFICATION_POLL_MS = 5_000;
+const SAFETY_REFRESH_MS = 30_000;
 const ISO_TIMESTAMP_CURSOR = /^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(?:\.\d+)?Z$/;
 const USERNAME_MENTION = /(^|[^A-Za-z0-9_])@([A-Za-z][A-Za-z0-9_]{2,29})(?![A-Za-z0-9_])/g;
 const PENDING_RECONCILE_WINDOW_MS = 2 * 60_000;
@@ -125,6 +127,8 @@ export class ChatController {
   private wsConnection: ChatConnection | null = null;
   private wsConnected = false;
   private verificationPollTimer: ReturnType<typeof setInterval> | null = null;
+  private safetyRefreshTimer: ReturnType<typeof setInterval> | null = null;
+  private draftSyncTimer: ReturnType<typeof setTimeout> | null = null;
   private openViewCount = 0;
   private pendingMessageSeq = 0;
   private notifyFn: (notification: AppNotificationRequest) => void = () => {};
@@ -212,6 +216,7 @@ export class ChatController {
     const token = apiClient.getSessionToken();
     if (!token) {
       this.stopVerificationPolling();
+      this.stopSafetyRefresh();
       this.wsConnection?.close();
       this.wsConnection = null;
       this.wsConnected = false;
@@ -227,6 +232,7 @@ export class ChatController {
     const session = await apiClient.getSession();
     if (!session) {
       this.stopVerificationPolling();
+      this.stopSafetyRefresh();
       this.wsConnection?.close();
       this.wsConnection = null;
       this.wsConnected = false;
@@ -259,23 +265,32 @@ export class ChatController {
     }
 
     this.syncVerificationPolling();
+    this.stopSafetyRefresh();
     this.wsConnection?.close();
     this.wsConnection = null;
     this.wsConnected = false;
   }
 
   async refreshMessages(): Promise<void> {
+    return this.runMessagesRefresh({ showLoading: true });
+  }
+
+  private async runMessagesRefresh(options: { showLoading: boolean }): Promise<void> {
     if (this.refreshMessagesPromise) return this.refreshMessagesPromise;
 
-    this.messagesLoading = true;
-    this.emit();
+    if (options.showLoading) {
+      this.messagesLoading = true;
+      this.emit();
+    }
 
     const request = this.fetchMessages()
       .catch(() => {
         this.persistChannelState();
       })
       .finally(() => {
-        this.messagesLoading = false;
+        if (options.showLoading) {
+          this.messagesLoading = false;
+        }
         this.refreshMessagesPromise = null;
         this.emit();
       });
@@ -309,8 +324,7 @@ export class ChatController {
   setDraft(draft: string): void {
     if (draft === this.draft) return;
     this.draft = draft;
-    this.persistChannelState();
-    this.emit();
+    this.scheduleDraftSync();
   }
 
   setReplyToId(replyToId: string | null): void {
@@ -326,11 +340,13 @@ export class ChatController {
     }
     return () => {
       this.openViewCount = Math.max(0, this.openViewCount - 1);
+      this.flushDraftSync();
     };
   }
 
   clearSession(): void {
     this.stopVerificationPolling();
+    this.stopSafetyRefresh();
     this.wsConnection?.close();
     this.wsConnection = null;
     this.wsConnected = false;
@@ -353,6 +369,7 @@ export class ChatController {
 
   reset(clearSession = false): void {
     this.stopVerificationPolling();
+    this.stopSafetyRefresh();
     this.wsConnection?.close();
     this.wsConnection = null;
     this.wsConnected = false;
@@ -381,7 +398,9 @@ export class ChatController {
       listeners: this.listeners.size,
       hasConnection: !!this.wsConnection,
     });
+    this.flushDraftSync();
     this.stopVerificationPolling();
+    this.stopSafetyRefresh();
     this.wsConnection?.close();
     this.wsConnection = null;
     this.wsConnected = false;
@@ -428,7 +447,12 @@ export class ChatController {
   }
 
   ensureConnection(): void {
-    if (this.wsConnected || !this.user?.emailVerified || !apiClient.getSessionToken()) return;
+    if (!this.user?.emailVerified || !apiClient.getSessionToken()) {
+      this.stopSafetyRefresh();
+      return;
+    }
+    this.startSafetyRefresh();
+    if (this.wsConnected) return;
     this.wsConnected = true;
 
     void this.refreshMessages().catch(() => {});
@@ -473,6 +497,24 @@ export class ChatController {
     this.verificationPollTimer = null;
   }
 
+  private startSafetyRefresh(): void {
+    if (this.safetyRefreshTimer) return;
+    this.safetyRefreshTimer = setInterval(() => {
+      if (!this.user?.emailVerified || !apiClient.getSessionToken()) {
+        this.stopSafetyRefresh();
+        return;
+      }
+      void this.runMessagesRefresh({ showLoading: false }).catch(() => {});
+    }, SAFETY_REFRESH_MS);
+    this.safetyRefreshTimer.unref?.();
+  }
+
+  private stopSafetyRefresh(): void {
+    if (!this.safetyRefreshTimer) return;
+    clearInterval(this.safetyRefreshTimer);
+    this.safetyRefreshTimer = null;
+  }
+
   private async fetchMessages(): Promise<void> {
     const legacyTimestampCursor = isLegacyTimestampCursor(this.lastCursor);
     const hasIncrementalCursor = !!this.lastCursor;
@@ -568,6 +610,11 @@ export class ChatController {
   }
 
   private persistChannelState(): void {
+    this.clearDraftSyncTimer();
+    this.writeChannelState();
+  }
+
+  private writeChannelState(): void {
     const value = {
       draft: this.draft,
       replyToId: this.replyToId,
@@ -582,6 +629,28 @@ export class ChatController {
     });
   }
 
+  private scheduleDraftSync(): void {
+    this.clearDraftSyncTimer();
+    this.draftSyncTimer = setTimeout(() => {
+      this.draftSyncTimer = null;
+      this.writeChannelState();
+      this.emit();
+    }, DRAFT_SYNC_DEBOUNCE_MS);
+    this.draftSyncTimer.unref?.();
+  }
+
+  private clearDraftSyncTimer(): void {
+    if (!this.draftSyncTimer) return;
+    clearTimeout(this.draftSyncTimer);
+    this.draftSyncTimer = null;
+  }
+
+  private flushDraftSync(): void {
+    if (!this.draftSyncTimer) return;
+    this.clearDraftSyncTimer();
+    this.writeChannelState();
+  }
+
   private persistTranscript(): void {
     if (this.messages.length === 0) {
       this.persistence?.deleteResource(TRANSCRIPT_KIND, "everyone", { sourceKey: TRANSCRIPT_SOURCE });

package/src/plugins/builtin/chat.test.tsx

@@ -1431,13 +1431,13 @@ describe("ChatContent", () => {
       sessionToken: "token-123",
       user: { id: "u1", username: "vince", emailVerified: true },
     });
-    const openedWidgets: string[] = [];
+    const openedPanes: string[] = [];
     const state = createInitialState(createDefaultConfig("/tmp/gloomberb-chat"));
     state.config.disabledPlugins = [];
 
     const runtime = createTestPluginRuntime({
-      showWidget(paneId: string) {
-        openedWidgets.push(paneId);
+      showPane(paneId: string) {
+        openedPanes.push(paneId);
       },
     });
 
@@ -1480,7 +1480,7 @@ describe("ChatContent", () => {
       await testSetup!.renderOnce();
     });
 
-    expect(openedWidgets).toEqual(["chat"]);
+    expect(openedPanes).toEqual(["chat"]);
   });
 
   test("auth commands use a single-form layout and signup no longer prompts for display name", () => {
@@ -1500,8 +1500,8 @@ describe("ChatContent", () => {
       registerCommand: (command: { id: string; wizardLayout?: string; wizard?: Array<{ key: string }> }) => {
         registeredCommands.push(command);
       },
-      showWidget: () => {},
-      hideWidget: () => {},
+      showPane: () => {},
+      hidePane: () => {},
       notify: () => {},
     } as any);
 

package/src/plugins/builtin/chat.tsx

@@ -222,6 +222,11 @@ export function ChatContent({
 }: ChatContentProps) {
   const dispatch = useAppDispatch();
   const initialSnapshot = controller.getSnapshot();
+  const { nativePaneChrome } = useUiCapabilities();
+  const contentWidth = Math.max(width - 2, 1);
+  const composerPrefixWidth = nativePaneChrome ? 0 : 3;
+  const composerTextWidth = Math.max(contentWidth - composerPrefixWidth, 1);
+  const inputValueRef = useRef(initialSnapshot.draft);
   const [messages, setMessages] = useState<ChatMessage[]>(initialSnapshot.messages);
   const [hasSavedSession, setHasSavedSession] = useState(initialSnapshot.hasSavedSession);
   const [user, setUser] = useState<{ id: string; username: string; emailVerified: boolean } | null>(initialSnapshot.user);
@@ -229,15 +234,13 @@ export function ChatContent({
   const [loadingOlderMessages, setLoadingOlderMessages] = useState(initialSnapshot.loadingOlderMessages);
   const [hasOlderMessages, setHasOlderMessages] = useState(initialSnapshot.hasOlderMessages);
   const [inputFocused, setInputFocused] = useState(false);
-  const [inputValue, setInputValue] = useState(initialSnapshot.draft);
+  const [composerRows, setComposerRows] = useState(() => estimateComposerHeight(initialSnapshot.draft, composerTextWidth));
   const [selectedIdx, setSelectedIdx] = useState(-1);
   const [hoveredIdx, setHoveredIdx] = useState<number | null>(null);
   const [followMessages, setFollowMessages] = useState(true);
-  const contentWidth = Math.max(width - 2, 1);
   const [replyTo, setReplyTo] = useState<ChatMessage | null>(() => (
     initialSnapshot.replyToId ? initialSnapshot.messages.find((message) => message.id === initialSnapshot.replyToId) ?? null : null
   ));
-  const { nativePaneChrome } = useUiCapabilities();
   const inputRef = useRef<TextareaRenderable>(null);
   const scrollRef = useRef<ScrollBoxRenderable>(null);
   const applyingExternalDraftRef = useRef(false);
@@ -250,9 +253,6 @@ export function ChatContent({
   const canSend = !!user?.emailVerified;
   const nativeComposerTopGap = nativePaneChrome && canSend ? NATIVE_CHAT_COMPOSER_TOP_GAP_PX : 0;
   const messageBodyWidth = Math.max(contentWidth - 4, 1);
-  const composerPrefixWidth = nativePaneChrome ? 0 : 3;
-  const composerTextWidth = Math.max(contentWidth - composerPrefixWidth, 1);
-  const composerRows = estimateComposerHeight(inputValue, composerTextWidth);
   const composerHeight = canSend
     ? nativePaneChrome
       ? Math.min(CHAT_COMPOSER_MAX_ROWS + 1, Math.max(2, composerRows + 1))
@@ -260,11 +260,19 @@ export function ChatContent({
     : 0;
   const selectionActive = selectedIdx >= 0 && selectedIdx < messages.length;
   const stickyTranscript = followMessages && !selectionActive;
+  const updateComposerRows = useCallback((draft: string) => {
+    const nextRows = estimateComposerHeight(draft, composerTextWidth);
+    setComposerRows((current) => (current === nextRows ? current : nextRows));
+  }, [composerTextWidth]);
 
   useEffect(() => {
     return controller.attachView();
   }, [controller]);
 
+  useEffect(() => {
+    updateComposerRows(inputValueRef.current);
+  }, [updateComposerRows]);
+
   useEffect(() => {
     const unsubscribe = controller.subscribe((snapshot) => {
       setMessages(snapshot.messages);
@@ -273,7 +281,10 @@ export function ChatContent({
       setLoading(snapshot.loading);
       setLoadingOlderMessages(snapshot.loadingOlderMessages);
       setHasOlderMessages(snapshot.hasOlderMessages);
-      setInputValue((current) => (current === snapshot.draft ? current : snapshot.draft));
+      if (inputValueRef.current !== snapshot.draft) {
+        inputValueRef.current = snapshot.draft;
+        updateComposerRows(snapshot.draft);
+      }
       const textarea = inputRef.current;
       if (textarea && textarea.editBuffer.getText() !== snapshot.draft) {
         applyingExternalDraftRef.current = true;
@@ -288,12 +299,10 @@ export function ChatContent({
     void controller.refreshSession().catch(() => {});
     void controller.refreshMessages().catch(() => {});
     return unsubscribe;
-  }, [controller]);
+  }, [controller, updateComposerRows]);
 
   const { catalog, openTicker } = useInlineTickers(messages.map((message) => message.content));
 
-  const inputValueRef = useRef(inputValue);
-  inputValueRef.current = inputValue;
   const replyToRef = useRef(replyTo);
   replyToRef.current = replyTo;
 
@@ -423,9 +432,9 @@ export function ChatContent({
   const commitLocalDraft = useCallback((draft: string) => {
     if (applyingExternalDraftRef.current) return;
     inputValueRef.current = draft;
-    setInputValue((current) => (current === draft ? current : draft));
+    updateComposerRows(draft);
     controller.setDraft(draft);
-  }, [controller]);
+  }, [controller, updateComposerRows]);
 
   useEffect(() => {
     const textarea = inputRef.current;
@@ -834,7 +843,7 @@ export function ChatContent({
 
           <MessageComposer
             inputRef={inputRef}
-            initialValue={inputValue}
+            initialValue={inputValueRef.current}
             focused={inputFocused && focused}
             placeholder={inputPlaceholder}
             terminalPrefix=" > "
@@ -882,7 +891,7 @@ export function ChatContent({
   );
 }
 
-export function ChatPane({ focused, width, height, close }: PaneProps) {
+function ChatPane({ focused, width, height, close }: PaneProps) {
   return (
     <ChatContent
       width={width}
@@ -894,7 +903,7 @@ export function ChatPane({ focused, width, height, close }: PaneProps) {
 }
 
 export function ChatStatusWidget({ controller = chatController }: ChatStatusWidgetProps) {
-  const { showWidget } = usePluginAppActions();
+  const { showPane } = usePluginAppActions();
   const cloudPluginDisabled = useAppSelector((state) => state.config.disabledPlugins.includes("gloomberb-cloud"));
   const initialSnapshot = controller.getSnapshot();
   const [username, setUsername] = useState<string | null>(initialSnapshot.user?.username ?? null);
@@ -905,7 +914,7 @@ export function ChatStatusWidget({ controller = chatController }: ChatStatusWidg
   const openChat = (event?: { preventDefault?: () => void; stopPropagation?: () => void }) => {
     event?.preventDefault?.();
     event?.stopPropagation?.();
-    showWidget("chat");
+    showPane("chat");
   };
 
   useEffect(() => {
@@ -1056,9 +1065,9 @@ export const gloomberbCloudPlugin: GloomPlugin = {
       execute: () => {
         const registry = getSharedRegistry();
         if (registry?.isPaneFloating("chat")) {
-          ctx.hideWidget("chat");
+          ctx.hidePane("chat");
         } else {
-          ctx.showWidget("chat");
+          ctx.showPane("chat");
         }
       },
     });
@@ -1086,7 +1095,7 @@ export const gloomberbCloudPlugin: GloomPlugin = {
         }
         chatController.clearSession();
         await chatController.refreshSession();
-        ctx.showWidget("chat");
+        ctx.showPane("chat");
       },
     });
 
@@ -1122,7 +1131,7 @@ export const gloomberbCloudPlugin: GloomPlugin = {
         await apiClient.sendVerification();
         chatController.clearSession();
         await chatController.refreshSession();
-        ctx.showWidget("chat");
+        ctx.showPane("chat");
       },
     });
 

package/src/plugins/builtin/cloud-tweets.tsx

@@ -546,7 +546,6 @@ function TweetSearchTable({
       emptyContent={emptyContent}
       emptyStateTitle={loading ? "Loading tweets..." : error ?? "No tweets"}
       emptyStateHint={data?.query}
-      showHorizontalScrollbar={false}
     />
   );
 }

package/src/plugins/builtin/comparison-chart.test.tsx

@@ -109,7 +109,7 @@ function createRegistrySpy(spy: { selected: string[]; focused: string[] }): Plug
   } as unknown as PluginRegistry;
 }
 
-function createRuntimeSpy(spy: { selected: string[]; focused: string[] }): PluginRuntimeAccess {
+function createRuntimeSpy(spy: { selected: string[]; focused: string[]; settings?: string[] }): PluginRuntimeAccess {
   return createTestPluginRuntime({
     pinTicker: (symbol: string) => {
       spy.selected.push(symbol);
@@ -119,6 +119,9 @@ function createRuntimeSpy(spy: { selected: string[]; focused: string[] }): Plugi
       spy.selected.push(symbol);
       spy.focused.push("ticker-detail");
     },
+    openPaneSettings: (paneId) => {
+      spy.settings?.push(paneId ?? "");
+    },
   });
 }
 
@@ -196,7 +199,7 @@ async function mountComparisonHarness(
   settings: Record<string, unknown>,
   tickers: TickerRecord[],
   financials: Array<[string, TickerFinancials]>,
-  spy: { selected: string[]; focused: string[] } = { selected: [], focused: [] },
+  spy: { selected: string[]; focused: string[]; settings?: string[] } = { selected: [], focused: [] },
 ) {
   actEnvironment.IS_REACT_ACT_ENVIRONMENT = true;
   testSetup = await createTestRenderer({ width: 120, height: 20 });
@@ -251,6 +254,21 @@ describe("comparisonChartPlugin", () => {
     });
   });
 
+  test("requires at least two symbols when creating a comparison pane", async () => {
+    const template = comparisonChartPlugin.paneTemplates?.[0]!;
+    const context = {
+      config: createDefaultConfig("/tmp/gloomberb-compare"),
+      layout: { dockRoot: null, instances: [], floating: [], detached: [] },
+      focusedPaneId: null,
+      activeTicker: null,
+      activeCollectionId: null,
+    };
+
+    expect(template.canCreate?.(context, { arg: "AMD" })).toBe(true);
+    expect(template.canCreate?.(context, { arg: "AMD", symbols: ["AMD"] })).toBe(false);
+    expect(await template.createInstance?.(context, { symbols: ["AMD"] })).toBeNull();
+  });
+
   test("renders one shared overlay chart with the mixed-currency warning", async () => {
     const provider = createProvider({
       AAPL: [100, 102, 104, 106],
@@ -284,6 +302,7 @@ describe("comparisonChartPlugin", () => {
     expect(frame).toContain("2:1W");
     expect(frame).toContain("1D");
     expect(frame).toContain("view:");
+    expect(frame).toContain("[t]ickers");
     expect(frame).toContain("[m]ode");
     expect(frame).toContain("[r]es");
     expect(frame).not.toContain("[up/down]legend");
@@ -364,4 +383,36 @@ describe("comparisonChartPlugin", () => {
     expect(spy.selected).toEqual(["MSFT"]);
     expect(spy.focused).toEqual(["ticker-detail"]);
   });
+
+  test("opens comparison ticker settings from the t shortcut", async () => {
+    const spy = { selected: [] as string[], focused: [] as string[], settings: [] as string[] };
+    const provider = createProvider({
+      AAPL: [100, 102, 104],
+      MSFT: [200, 202, 204],
+    }, {
+      AAPL: "USD",
+      MSFT: "USD",
+    });
+    setSharedMarketDataForTests(provider);
+    sharedCoordinator = new MarketDataCoordinator(provider);
+    setSharedMarketDataCoordinator(sharedCoordinator);
+    setSharedRegistryForTests(createRegistrySpy(spy));
+
+    await mountComparisonHarness({
+      axisMode: "percent",
+      symbols: ["AAPL", "MSFT"],
+      symbolsText: "AAPL, MSFT",
+    }, [
+      makeTicker("AAPL", "USD"),
+      makeTicker("MSFT", "USD"),
+    ], [
+      ["AAPL", makeFinancials("AAPL", "USD", [100, 102, 104])],
+      ["MSFT", makeFinancials("MSFT", "USD", [200, 202, 204])],
+    ], spy);
+
+    await flushFrames();
+    await pressComparisonInput(() => testSetup!.mockInput.pressKey("t"));
+
+    expect(spy.settings).toEqual([TEST_PANE_ID]);
+  });
 });

package/src/plugins/builtin/comparison-chart.tsx

@@ -8,7 +8,7 @@ import {
   DEFAULT_COMPARISON_CHART_RESOLUTION,
   normalizeChartResolution,
 } from "../../components/chart/chart-resolution";
-import { usePluginTickerActions } from "../../plugins/plugin-runtime";
+import { usePluginAppActions, usePluginTickerActions } from "../../plugins/plugin-runtime";
 import { usePaneInstance } from "../../state/app-context";
 import { colors } from "../../theme/colors";
 import type { GloomPlugin, PaneProps, PaneSettingsDef } from "../../types/plugin";
@@ -16,6 +16,7 @@ import { formatTickerListInput, MAX_TICKER_LIST_SIZE, parseTickerListInput } fro
 
 export const COMPARISON_CHART_PANE_ID = "comparison-chart";
 export const COMPARISON_CHART_TEMPLATE_ID = "comparison-chart-pane";
+export const MIN_COMPARISON_CHART_SYMBOLS = 2;
 
 interface ComparisonChartPaneSettings {
   axisMode: ChartAxisMode;
@@ -77,7 +78,7 @@ function buildComparisonChartSettingsDef(): PaneSettingsDef {
       {
         key: "symbolsText",
         label: "Tickers",
-        description: `Enter 1-${MAX_TICKER_LIST_SIZE} tickers separated by commas.`,
+        description: `Enter ${MIN_COMPARISON_CHART_SYMBOLS}-${MAX_TICKER_LIST_SIZE} tickers separated by commas.`,
         type: "text",
         placeholder: "AAPL, MSFT, NVDA",
       },
@@ -102,12 +103,16 @@ export function buildComparisonChartPaneTitle(symbols: string[]): string {
 }
 function ComparisonChartPane({ paneId, focused, width, height }: PaneProps) {
   const { navigateTicker } = usePluginTickerActions();
+  const { openPaneSettings } = usePluginAppActions();
   const pane = usePaneInstance();
   const settings = useMemo(() => getComparisonChartPaneSettings(pane?.settings), [pane?.settings]);
 
   const openTicker = useCallback((symbol: string) => {
     navigateTicker(symbol);
   }, [navigateTicker]);
+  const editTickers = useCallback(() => {
+    openPaneSettings(paneId);
+  }, [openPaneSettings, paneId]);
 
   if (settings.symbols.length === 0) {
     return (
@@ -127,6 +132,7 @@ function ComparisonChartPane({ paneId, focused, width, height }: PaneProps) {
         symbols={settings.symbols}
         axisMode={settings.axisMode}
         onOpenSymbol={openTicker}
+        onEditTickers={editTickers}
       />
     </Box>
   );
@@ -162,15 +168,15 @@ export const comparisonChartPlugin: GloomPlugin = {
           label: "Comparison Tickers",
           placeholder: "AAPL, MSFT, NVDA",
           body: [
-            `Enter 1-${MAX_TICKER_LIST_SIZE} ticker symbols separated by commas.`,
+            `Enter ${MIN_COMPARISON_CHART_SYMBOLS}-${MAX_TICKER_LIST_SIZE} ticker symbols separated by commas.`,
           ],
           type: "text",
         },
       ],
-      canCreate: (_context, options) => !options?.symbols || options.symbols.length > 0,
+      canCreate: (_context, options) => !options?.symbols || options.symbols.length >= MIN_COMPARISON_CHART_SYMBOLS,
       createInstance: (_context, options) => {
         const symbols = options?.symbols ?? [];
-        if (symbols.length === 0) return null;
+        if (symbols.length < MIN_COMPARISON_CHART_SYMBOLS) return null;
         return {
           title: buildComparisonChartPaneTitle(symbols),
           placement: "floating",