gloomberb 0.4.1 → 0.5.0

package/src/components/command-bar/command-bar.test.tsx

@@ -218,7 +218,7 @@ function makePluginRegistry(hasPaneSettings: (paneId: string) => boolean = () =>
     showWidget: () => {},
     updateLayoutFn: () => {},
     getTermSizeFn: () => ({ width: 80, height: 24 }),
-    showToastFn: () => {},
+    notify: () => {},
     createPaneFromTemplateFn: () => {},
     createPaneFromTemplateAsyncFn: async () => {},
     openPaneSettingsFn: () => {},
@@ -352,6 +352,308 @@ describe("CommandBar", () => {
     expect(testSetup.captureCharFrame()).not.toContain("Commands");
   });
 
+  test("runs plugin command shortcuts from the root query", async () => {
+    const calls: string[] = [];
+
+    testSetup = await testRender(<CommandBarHarness
+      query="GL"
+      configurePluginRegistry={(pluginRegistry) => {
+        (pluginRegistry.commands as Map<string, any>).set("gridlock-all", {
+          id: "gridlock-all",
+          label: "Gridlock All Windows",
+          description: "Arrange all visible panes into a tiled grid",
+          keywords: ["grid", "gridlock", "tile", "arrange", "windows", "layout"],
+          shortcut: "GL",
+          category: "config",
+          execute: async () => {
+            calls.push("gridlock-all");
+          },
+        });
+        (pluginRegistry.allPlugins as Map<string, any>).set("layout-manager", {
+          id: "layout-manager",
+          name: "Layout Manager",
+          version: "1.0.0",
+          description: "Pane layout management commands",
+        });
+        const getCommandPluginId = pluginRegistry.getCommandPluginId;
+        pluginRegistry.getCommandPluginId = (commandId: string) => (
+          commandId === "gridlock-all" ? "layout-manager" : getCommandPluginId(commandId)
+        );
+      }}
+    />, {
+      width: 80,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame).toContain("Gridlock All Windows");
+    expect(frame).toContain("GL");
+
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await Bun.sleep(0);
+      await testSetup!.renderOnce();
+    });
+
+    expect(calls).toEqual(["gridlock-all"]);
+  });
+
+  test("surfaces plugin commands by add-style search terms", async () => {
+    testSetup = await testRender(<CommandBarHarness
+      query="add alert"
+      configurePluginRegistry={(pluginRegistry) => {
+        (pluginRegistry.commands as Map<string, any>).set("set-alert", {
+          id: "set-alert",
+          label: "Add Alert",
+          description: "Create a price alert from a symbol, condition, and target price",
+          keywords: ["add", "set", "alert", "price", "trigger"],
+          shortcut: "SA",
+          category: "data",
+          execute: async () => {},
+        });
+      }}
+    />, {
+      width: 80,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame).toContain("Add Alert");
+    expect(frame).toContain("SA");
+  });
+
+  test("opens plugin command shortcut arguments in the wizard for confirmation", async () => {
+    const calls: Array<Record<string, string> | undefined> = [];
+
+    testSetup = await testRender(<CommandBarHarness
+      query="SA AAPL above 200"
+      configurePluginRegistry={(pluginRegistry) => {
+        (pluginRegistry.commands as Map<string, any>).set("set-alert", {
+          id: "set-alert",
+          label: "Add Alert",
+          description: "Create a price alert from a symbol, condition, and target price",
+          keywords: ["add", "set", "alert", "price", "trigger"],
+          shortcut: "SA",
+          shortcutArg: {
+            placeholder: "symbol condition price",
+            kind: "text",
+            parse: (arg: string) => {
+              const [symbol, condition, price] = arg.split(/\s+/);
+              return { symbol, condition, price };
+            },
+          },
+          category: "data",
+          wizardLayout: "form",
+          wizard: [
+            { key: "symbol", label: "Symbol", type: "text" },
+            {
+              key: "condition",
+              label: "Condition",
+              type: "select",
+              options: [
+                { label: "Above", value: "above" },
+                { label: "Below", value: "below" },
+              ],
+            },
+            { key: "price", label: "Target Price", type: "number" },
+          ],
+          execute: async (values?: Record<string, string>) => {
+            calls.push(values);
+          },
+        });
+      }}
+    />, {
+      width: 80,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame).toContain("Add Alert");
+    expect(frame).toContain("AAPL above 200");
+
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await Bun.sleep(0);
+      await testSetup!.renderOnce();
+    });
+
+    const workflowFrame = await waitForFrameToContain("Target Price");
+    expect(workflowFrame).toContain("AAPL");
+    expect(workflowFrame).toContain("Above");
+    expect(workflowFrame).toContain("200");
+    expect(calls).toEqual([]);
+  });
+
+  test("opens partial plugin command shortcut arguments in the wizard", async () => {
+    testSetup = await testRender(<CommandBarHarness
+      query="SA AMD"
+      configurePluginRegistry={(pluginRegistry) => {
+        (pluginRegistry.commands as Map<string, any>).set("set-alert", {
+          id: "set-alert",
+          label: "Add Alert",
+          description: "Create a price alert from a symbol, condition, and target price",
+          keywords: ["add", "set", "alert", "price", "trigger"],
+          shortcut: "SA",
+          shortcutArg: {
+            placeholder: "symbol condition price",
+            kind: "text",
+            parse: (arg: string) => ({ symbol: arg.trim().toUpperCase() }),
+          },
+          category: "data",
+          wizardLayout: "form",
+          wizard: [
+            { key: "symbol", label: "Symbol", type: "text" },
+            {
+              key: "condition",
+              label: "Condition",
+              type: "select",
+              options: [{ label: "Above", value: "above" }],
+            },
+            { key: "price", label: "Target Price", type: "number" },
+          ],
+          execute: async () => {},
+        });
+      }}
+    />, {
+      width: 80,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await Bun.sleep(0);
+      await testSetup!.renderOnce();
+    });
+
+    const workflowFrame = await waitForFrameToContain("Target Price");
+    expect(workflowFrame).toContain("AMD");
+  });
+
+  test("updates workflow select fields from the option picker", async () => {
+    testSetup = await testRender(<CommandBarHarness
+      query="SA AMD"
+      configurePluginRegistry={(pluginRegistry) => {
+        (pluginRegistry.commands as Map<string, any>).set("set-alert", {
+          id: "set-alert",
+          label: "Add Alert",
+          description: "Create a price alert from a symbol, condition, and target price",
+          keywords: ["add", "set", "alert", "price", "trigger"],
+          shortcut: "SA",
+          shortcutArg: {
+            placeholder: "symbol condition price",
+            kind: "text",
+            parse: (arg: string) => ({ symbol: arg.trim().toUpperCase() }),
+          },
+          category: "data",
+          wizardLayout: "form",
+          wizard: [
+            { key: "symbol", label: "Symbol", type: "text" },
+            {
+              key: "condition",
+              label: "Condition",
+              type: "select",
+              options: [
+                { label: "Above", value: "above" },
+                { label: "Below", value: "below" },
+                { label: "Crosses", value: "crosses" },
+              ],
+            },
+            { key: "price", label: "Target Price", type: "number" },
+          ],
+          execute: async () => {},
+        });
+      }}
+    />, {
+      width: 80,
+      height: 24,
+    });
+
+    await testSetup.renderOnce();
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await Bun.sleep(0);
+      await testSetup!.renderOnce();
+    });
+    await waitForFrameToContain("Target Price");
+
+    await act(async () => {
+      testSetup!.mockInput.pressTab();
+      await testSetup!.renderOnce();
+    });
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await testSetup!.renderOnce();
+    });
+    let frame = await waitForFrameToContain("Below");
+    expect(frame).toContain("Crosses");
+
+    await act(async () => {
+      testSetup!.mockInput.pressArrow("down");
+      await testSetup!.renderOnce();
+    });
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await testSetup!.renderOnce();
+    });
+
+    frame = await waitForFrameToContain("Target Price");
+    expect(frame).toContain("Below");
+  });
+
+  test("opens plugin command workflows from a launch request", async () => {
+    testSetup = await testRender(<CommandBarHarness
+      query=""
+      configureState={(state) => ({
+        ...state,
+        commandBarLaunchRequest: {
+          kind: "plugin-command",
+          commandId: "set-alert",
+          sequence: 1,
+        },
+      })}
+      configurePluginRegistry={(pluginRegistry) => {
+        (pluginRegistry.commands as Map<string, any>).set("set-alert", {
+          id: "set-alert",
+          label: "Set Alert",
+          keywords: ["alert", "price", "trigger"],
+          shortcut: "SA",
+          category: "data",
+          wizardLayout: "form",
+          wizard: [
+            { key: "symbol", label: "Symbol", type: "text" },
+            {
+              key: "condition",
+              label: "Condition",
+              type: "select",
+              options: [
+                { label: "Above", value: "above" },
+                { label: "Below", value: "below" },
+              ],
+            },
+            { key: "price", label: "Target Price", type: "number" },
+          ],
+          execute: async () => {},
+        });
+      }}
+    />, {
+      width: 80,
+      height: 24,
+    });
+
+    const frame = await waitForFrameToContain("Target Price");
+    expect(frame).toContain("Set Alert");
+    expect(frame).toContain("Symbol");
+    expect(frame).toContain("Condition");
+  });
+
   test("renders theme prefix results in the root query", async () => {
     testSetup = await testRender(<CommandBarHarness query="TH " />, {
       width: 80,
@@ -659,11 +961,42 @@ describe("CommandBar", () => {
     expect(saved.at(-1)?.metadata.watchlists).toEqual(["watchlist"]);
   });
 
-  test("bare AW without a compatible active target opens inline target selection", async () => {
+  test("bare AW without a compatible active target adds to the sole watchlist directly", async () => {
+    const saved: TickerRecord[] = [];
+
     testSetup = await testRender(
       <CommandBarHarness
         query="AW"
         selectedTicker="AAPL"
+        onSaveTicker={(ticker) => {
+          saved.push(ticker);
+        }}
+      />,
+      { width: 100, height: 20 },
+    );
+
+    await testSetup.renderOnce();
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await Bun.sleep(0);
+      await testSetup!.renderOnce();
+    });
+
+    expect(saved.at(-1)?.metadata.watchlists).toEqual(["watchlist"]);
+  });
+
+  test("bare AW without a compatible active target opens inline target selection when multiple watchlists exist", async () => {
+    testSetup = await testRender(
+      <CommandBarHarness
+        query="AW"
+        selectedTicker="AAPL"
+        configureConfig={(config) => ({
+          ...config,
+          watchlists: [
+            { id: "watchlist", name: "Watchlist" },
+            { id: "growth", name: "Growth Radar" },
+          ],
+        })}
       />,
       { width: 100, height: 20 },
     );
@@ -710,7 +1043,6 @@ describe("CommandBar", () => {
 
     const frame = testSetup.captureCharFrame();
     expect(frame).toContain("Add AAPL to Portfolio");
-    expect(frame).toContain('in "Research"');
   });
 
   test("AP opens the add-to-portfolio workflow and prefills avg cost from the current price", async () => {
@@ -720,7 +1052,7 @@ describe("CommandBar", () => {
         selectedTicker="AAPL"
         configureConfig={(config) => ({
           ...config,
-          portfolios: [{ id: "research", name: "Research", currency: "USD" }],
+          portfolios: [{ id: "research", name: "Only Manual Portfolio", currency: "USD" }],
         })}
         configureState={(state) => ({
           ...state,
@@ -762,6 +1094,7 @@ describe("CommandBar", () => {
     expect(frame).toContain("Shares");
     expect(frame).toContain("Avg Cost");
     expect(frame).toContain("205.5");
+    expect(frame).not.toContain("Only Manual Portfolio");
     expectSingleBackControl(frame);
   });
 
@@ -873,7 +1206,6 @@ describe("CommandBar", () => {
 
     const frame = testSetup.captureCharFrame();
     expect(frame).toContain("Set Position for AAPL");
-    expect(frame).toContain('in "Research"');
   });
 
   test("prefills the portfolio position workflow from the active manual portfolio and ticker", async () => {