gloomberb 0.3.7 → 0.4.0

package/src/components/command-bar/command-registry.ts

@@ -82,6 +82,14 @@ export const commands: Command[] = [
     category: "Portfolio",
     execute: () => {},
   },
+  {
+    id: "set-portfolio-position",
+    prefix: "",
+    label: "Set Portfolio Position",
+    description: "Create or update a manual position in a portfolio",
+    category: "Portfolio",
+    execute: () => {},
+  },
 
   // Create / Delete
   {

package/src/components/command-bar/helpers.test.ts

@@ -188,10 +188,32 @@ describe("command-bar helpers", () => {
       options: [],
       payload: { fieldType: "ordered-multi-select" },
     };
+    const filteredPickerRoute: CommandBarRoute = {
+      ...orderedPickerRoute,
+      query: "vol",
+    };
+    const workflowRoute: CommandBarRoute = {
+      kind: "workflow",
+      title: "Create Pane",
+      fields: [],
+      values: {},
+      activeFieldId: null,
+    };
+    const confirmRoute: CommandBarRoute = {
+      kind: "confirm",
+      title: "Delete",
+      body: ["Delete item?"],
+      confirmLabel: "Delete",
+      cancelLabel: "Back",
+      tone: "danger",
+    };
 
     expect(getScreenFooterLeft(null)).toBe("up/down move  enter select");
     expect(getScreenFooterLeft(orderedPickerRoute)).toBe("up/down move  space toggle  [ ] reorder  enter done");
-    expect(getScreenFooterRight(orderedPickerRoute)).toBe("esc back");
+    expect(getScreenFooterRight(orderedPickerRoute)).toBe("backspace/esc back");
+    expect(getScreenFooterRight(filteredPickerRoute)).toBe("backspace delete  esc back");
+    expect(getScreenFooterRight(workflowRoute)).toBe("esc back");
+    expect(getScreenFooterRight(confirmRoute)).toBe("backspace/esc back");
   });
 
   test("maps route and collection command ids", () => {

package/src/components/command-bar/helpers.ts

@@ -4,6 +4,7 @@ import type {
   PaneTemplateDef,
   WizardStep,
 } from "../../types/plugin";
+export { slugifyName } from "../../utils/slugify";
 import type {
   CommandBarFieldOption,
   CommandBarFieldValue,
@@ -251,10 +252,6 @@ export function routeCommandIdToScreen(commandId: RouteCommandId): "ticker-searc
   }
 }
 
-export function slugifyName(name: string, fallbackPrefix: string): string {
-  return name.toLowerCase().replace(/[^a-z0-9]+/g, "-").replace(/^-|-$/g, "") || `${fallbackPrefix}-${Date.now()}`;
-}
-
 export function getFirstVisibleFieldId(
   fields: CommandBarWorkflowField[],
   values: Record<string, CommandBarFieldValue>,
@@ -328,7 +325,19 @@ export function getScreenFooterLeft(route: CommandBarRoute | null): string {
 }
 
 export function getScreenFooterRight(route: CommandBarRoute | null): string {
-  return route ? "esc back" : "esc close";
+  if (!route) return "esc close";
+
+  if (route.kind === "workflow") return "esc back";
+  if (route.kind === "confirm") return "backspace/esc back";
+
+  if (
+    (route.kind === "mode" || route.kind === "picker" || route.kind === "pane-settings")
+    && route.query.trim().length > 0
+  ) {
+    return "backspace delete  esc back";
+  }
+
+  return "backspace/esc back";
 }
 
 export function isRootParsedCommand(commandId: string): boolean {

package/src/components/command-bar/pane-template-display.ts

@@ -0,0 +1,12 @@
+import type { PaneTemplateDef } from "../../types/plugin";
+
+export function formatPaneTemplateLabel(label: string): string {
+  let normalized = label.trim();
+  if (normalized.startsWith("New ")) normalized = normalized.slice(4);
+  if (normalized.endsWith(" Pane")) normalized = normalized.slice(0, -5);
+  return normalized;
+}
+
+export function getPaneTemplateDisplayLabel(template: Pick<PaneTemplateDef, "label">): string {
+  return formatPaneTemplateLabel(template.label);
+}

package/src/components/command-bar/root-shortcuts.ts

@@ -1,5 +1,6 @@
 import type { PaneTemplateDef } from "../../types/plugin";
 import type { Command } from "./command-registry";
+import { getPaneTemplateDisplayLabel } from "./pane-template-display";
 
 export type RootShortcutArgKind = "text" | "ticker" | "ticker-list";
 export type ShortcutIntentKind = "none" | "complete" | "inferred-complete" | "partial" | "ambiguous";
@@ -88,7 +89,7 @@ function buildShortcutCandidates(
       .filter((template) => template.shortcut?.prefix)
       .map((template) => ({
         prefix: normalizeShortcutPrefix(template.shortcut!.prefix),
-        label: template.label,
+        label: getPaneTemplateDisplayLabel(template),
         description: template.description,
         argKind: getPaneShortcutArgKind(template),
         argPlaceholder: template.shortcut?.argPlaceholder,

package/src/components/command-bar/workflow-ops.ts

@@ -9,10 +9,12 @@ import type { TickerRepository } from "../../data/ticker-repository";
 import { resolveTickerSearch, upsertTickerFromSearchResult } from "../../utils/ticker-search";
 import { formatTickerListInput, parseTickerListInput } from "../../utils/ticker-list";
 import { updatePaneInstance, setPaneSettings } from "../../pane-settings";
+import { isManualPortfolio } from "../../plugins/builtin/portfolio-list/mutations";
 import {
   buildComparisonChartPaneTitle,
   COMPARISON_CHART_PANE_ID,
 } from "../../plugins/builtin/comparison-chart";
+import { getPaneTemplateDisplayLabel } from "./pane-template-display";
 
 export interface SharedWorkflowDeps {
   dataProvider: DataProvider;
@@ -109,7 +111,7 @@ function getCollectionOptions(
   if (kind === "watchlist") {
     return state.config.watchlists;
   }
-  return state.config.portfolios.filter((portfolio) => !portfolio.brokerId && !portfolio.brokerInstanceId);
+  return state.config.portfolios.filter(isManualPortfolio);
 }
 
 export function getCollectionTargetOptions(
@@ -302,7 +304,7 @@ export async function createPaneTemplateOrThrow(
   const { context, resolvedOptions } = await resolvePaneTemplateOptions(template, options, deps);
 
   if (template.canCreate && !template.canCreate(context, resolvedOptions)) {
-    throw new Error(`Can't create ${template.label.toLowerCase()} right now.`);
+    throw new Error(`Can't create ${getPaneTemplateDisplayLabel(template).toLowerCase()} right now.`);
   }
 
   const createInstanceResult = await template.createInstance?.(context, resolvedOptions);

package/src/components/detail-feed-view.test.tsx

@@ -1,26 +1,55 @@
 import { afterEach, describe, expect, test } from "bun:test";
+import { act, useState } from "react";
 import { testRender } from "@opentui/react/test-utils";
-import { DetailFeedView } from "./detail-feed-view";
+import {
+  DetailFeedView,
+  type DetailFeedItem,
+} from "./detail-feed-view";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
+let setHarnessItems:
+  | ((items: DetailFeedItem[]) => void)
+  | undefined;
+let harnessSelectedIdx = 0;
 
-afterEach(() => {
+afterEach(async () => {
   if (testSetup) {
-    testSetup.renderer.destroy();
+    await act(async () => {
+      testSetup!.renderer.destroy();
+    });
     testSetup = undefined;
   }
+  setHarnessItems = undefined;
+  harnessSelectedIdx = 0;
 });
 
-const items = [
+async function renderSettled() {
+  await act(async () => {
+    await testSetup!.renderOnce();
+    await testSetup!.renderOnce();
+  });
+}
+
+async function clickAt(x: number, y: number) {
+  await act(async () => {
+    await testSetup!.mockMouse.click(x, y);
+    await testSetup!.renderOnce();
+    await testSetup!.renderOnce();
+  });
+}
+
+const items: DetailFeedItem[] = [
   {
     id: "1",
     eyebrow: "Reuters",
-    title: "Long headline with enough words to prove the list wraps instead of collapsing into fixed columns",
+    title:
+      "Long headline with enough words to prove the list wraps instead of collapsing into fixed columns",
     timestamp: new Date("2024-08-01T12:00:00Z"),
     preview: "Preview text with a little more color.",
     detailTitle: "Long headline with enough words to prove the list wraps",
     detailMeta: ["Reuters", "Published Aug 1, 2024"],
-    detailBody: "This body should stay readable when the pane is narrow and also when the pane is wide enough for a split layout.",
+    detailBody:
+      "This body should stay readable when the pane is narrow and also when the pane is wide enough for a split layout.",
     detailNote: "https://example.com/story",
   },
   {
@@ -35,68 +64,114 @@ const items = [
   },
 ];
 
+function Harness({
+  width,
+  height,
+  listVariant = "comfortable",
+}: {
+  width: number;
+  height: number;
+  listVariant?: "comfortable" | "compact" | "single-line";
+}) {
+  const [activeItems, setActiveItems] = useState(items);
+  const [selectedIdx, setSelectedIdx] = useState(0);
+  const [hoveredIdx, setHoveredIdx] = useState<number | null>(null);
+
+  setHarnessItems = setActiveItems;
+  harnessSelectedIdx = selectedIdx;
+
+  return (
+    <DetailFeedView
+      width={width}
+      height={height}
+      focused
+      items={activeItems}
+      selectedIdx={selectedIdx}
+      hoveredIdx={hoveredIdx}
+      onSelect={setSelectedIdx}
+      onHover={setHoveredIdx}
+      listVariant={listVariant}
+    />
+  );
+}
+
 describe("DetailFeedView", () => {
-  test("renders readable stacked content in narrow panes", async () => {
-    testSetup = await testRender(
-      <DetailFeedView
-        width={60}
-        height={16}
-        items={items}
-        selectedIdx={0}
-        hoveredIdx={null}
-        onSelect={() => {}}
-        onHover={() => {}}
-      />,
-      { width: 60, height: 16 },
-    );
+  test("renders the browse list by default", async () => {
+    testSetup = await testRender(<Harness width={60} height={16} />, {
+      width: 60,
+      height: 16,
+    });
 
-    await testSetup.renderOnce();
+    await renderSettled();
     const frame = testSetup.captureCharFrame();
 
     expect(frame).toContain("Long headline with enough words");
-    expect(frame).toContain("This body should stay readable");
-    expect(frame).toContain("Published Aug 1, 2024");
+    expect(frame).toContain("j/k move  enter or click selected row");
+    expect(frame).not.toContain("This body should stay readable");
   });
 
-  test("renders split list and detail content in wide panes", async () => {
+  test("selects an item on single click without opening detail", async () => {
     testSetup = await testRender(
-      <DetailFeedView
-        width={110}
-        height={16}
-        items={items}
-        selectedIdx={0}
-        hoveredIdx={1}
-        onSelect={() => {}}
-        onHover={() => {}}
-      />,
-      { width: 110, height: 16 },
+      <Harness width={90} height={12} listVariant="single-line" />,
+      {
+        width: 90,
+        height: 12,
+      },
     );
 
-    await testSetup.renderOnce();
+    await renderSettled();
+
     const frame = testSetup.captureCharFrame();
+    const lines = frame.split("\n");
+    const filingRow = lines.findIndex((line) => line.includes("10-Q filing"));
+    const filingCol = lines[filingRow]?.indexOf("10-Q filing") ?? -1;
+
+    await clickAt(filingCol + 1, filingRow);
+
+    const nextFrame = testSetup.captureCharFrame();
+    expect(harnessSelectedIdx).toBe(1);
+    expect(nextFrame).not.toContain("<- Back");
+    expect(nextFrame).not.toContain("Quarterly report details.");
+  });
+
+  test("closes the open detail page when the feed items change", async () => {
+    testSetup = await testRender(<Harness width={90} height={16} />, {
+      width: 90,
+      height: 16,
+    });
 
-    expect(frame).toContain("Reuters");
-    expect(frame).toContain("10-Q filing");
-    expect(frame).toContain("j/k navigate");
+    await renderSettled();
+
+    await act(async () => {
+      testSetup!.mockInput.pressEnter();
+      await testSetup!.renderOnce();
+      await testSetup!.renderOnce();
+    });
+
+    await act(async () => {
+      setHarnessItems?.([
+        {
+          id: "9",
+          title: "Fresh item after source change",
+          detailBody: "Replacement detail",
+        },
+      ]);
+    });
+    await renderSettled();
+
+    const frame = testSetup.captureCharFrame();
+    expect(frame).toContain("Fresh item after source change");
+    expect(frame).not.toContain("<- Back");
+    expect(frame).not.toContain("Replacement detail");
   });
 
   test("renders a single-line list variant", async () => {
     testSetup = await testRender(
-      <DetailFeedView
-        width={110}
-        height={12}
-        items={items}
-        selectedIdx={0}
-        hoveredIdx={null}
-        onSelect={() => {}}
-        onHover={() => {}}
-        listVariant="single-line"
-        splitListWidthRatio={0.33}
-      />,
+      <Harness width={110} height={12} listVariant="single-line" />,
       { width: 110, height: 12 },
     );
 
-    await testSetup.renderOnce();
+    await renderSettled();
     const frame = testSetup.captureCharFrame();
 
     expect(frame).toContain("Long headline with enough words");