gloomberb 0.3.1 → 0.3.3

package/src/pane-settings.test.ts

@@ -1,5 +1,5 @@
 import { describe, expect, test } from "bun:test";
-import { cloneLayout, createDefaultConfig, createPaneInstance, type LayoutConfig } from "./types/config";
+import { cloneLayout, createDefaultConfig, createPaneInstance, DEFAULT_PORTFOLIO_COLUMN_IDS, type LayoutConfig } from "./types/config";
 import { deletePaneSetting, getPaneSettingValue, setPaneSetting } from "./pane-settings";
 
 describe("pane settings helpers", () => {
@@ -13,15 +13,7 @@ describe("pane settings helpers", () => {
       hideTabs: false,
       lockedCollectionId: "main",
     });
-    expect(portfolioPane?.settings?.columnIds).toEqual([
-      "ticker",
-      "price",
-      "change_pct",
-      "market_cap",
-      "pe",
-      "forward_pe",
-      "latency",
-    ]);
+    expect(portfolioPane?.settings?.columnIds).toEqual(DEFAULT_PORTFOLIO_COLUMN_IDS);
     expect(detailPane?.settings).toEqual({
       hideTabs: false,
       lockedTabId: "overview",
@@ -38,15 +30,7 @@ describe("pane settings helpers", () => {
     expect(clonedPortfolioSettings).not.toBe(originalPortfolioSettings);
 
     (clonedPortfolioSettings?.columnIds as string[]).push("change");
-    expect(originalPortfolioSettings?.columnIds).toEqual([
-      "ticker",
-      "price",
-      "change_pct",
-      "market_cap",
-      "pe",
-      "forward_pe",
-      "latency",
-    ]);
+    expect(originalPortfolioSettings?.columnIds).toEqual(DEFAULT_PORTFOLIO_COLUMN_IDS);
   });
 
   test("setPaneSetting and deletePaneSetting update pane-scoped settings immutably", () => {

package/src/plugins/builtin/ai/ask-ai-detail-tab.tsx

@@ -1,13 +1,13 @@
 import { useRef, useEffect, useState, useCallback } from "react";
 import { useKeyboard } from "@opentui/react";
 import { TextAttributes } from "@opentui/core";
-import type { InputRenderable } from "@opentui/core";
+import type { InputRenderable, ScrollBoxRenderable } from "@opentui/core";
 import type { DetailTabProps } from "../../../types/plugin";
 import { useAppState, usePaneTicker } from "../../../state/app-context";
 import { useFxRatesMap } from "../../../market-data/hooks";
 import { usePluginState } from "../../../plugins/plugin-runtime";
 import { useInlineTickers } from "../../../state/use-inline-tickers";
-import { TickerBadgeText } from "../../../components/ticker-badge-text";
+import { MarkdownText } from "../../../components/markdown-text";
 import { colors } from "../../../theme/colors";
 import { Spinner } from "../../../components/spinner";
 import { buildTickerAiContext } from "./ticker-context";
@@ -80,6 +80,7 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
   const [inputFocused, setInputFocused] = useState(false);
   const [inputValue, setInputValue] = useState("");
   const inputRef = useRef<InputRenderable>(null);
+  const scrollRef = useRef<ScrollBoxRenderable>(null);
   const runRef = useRef<ReturnType<typeof runAiPrompt> | null>(null);
   const availableProviders = getAvailableProviders(providers);
   const currentProvider = providers.find((provider) => provider.id === providerId && provider.available)
@@ -116,7 +117,12 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
 
   useEffect(() => {
     if (!tickerSymbol || !currentProvider || messages.length === 0) return;
-    const trimmed = messages.filter((message) => !message.loading).slice(-ASK_AI_HISTORY_LIMIT);
+    const hasLoading = messages.some((message) => message.loading);
+    if (hasLoading) {
+      chatHistories.set(tickerSymbol, messages);
+      return;
+    }
+    const trimmed = messages.slice(-ASK_AI_HISTORY_LIMIT);
     chatHistories.set(tickerSymbol, trimmed);
     setPersistedConversation({
       updatedAt: Date.now(),
@@ -124,6 +130,12 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
     });
   }, [currentProvider, messages, setPersistedConversation, tickerSymbol]);
 
+  useEffect(() => {
+    const sb = scrollRef.current;
+    if (!sb || messages.length === 0) return;
+    sb.scrollTo({ x: 0, y: Math.max(0, sb.scrollHeight - sb.viewport.height) });
+  }, [messages, focused]);
+
   const cycleProvider = useCallback(() => {
     if (availableProviders.length <= 1) return;
     setProviderId((current) => {
@@ -267,7 +279,7 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
         </box>
       </box>
 
-      <scrollbox height={chatHeight} scrollY>
+      <scrollbox ref={scrollRef} height={chatHeight} scrollY>
         <box flexDirection="column">
           {messages.length === 0 ? (
             <box paddingTop={1}>
@@ -289,7 +301,7 @@ export function AskAiDetailTab({ width, height, focused, onCapture }: DetailTabP
                 </box>
                 <box>
                   {message.content ? (
-                    <TickerBadgeText
+                    <MarkdownText
                       text={message.content}
                       lineWidth={contentWidth}
                       catalog={catalog}

package/src/plugins/builtin/portfolio-list/metrics.ts

@@ -57,6 +57,31 @@ function getPositionCurrency(
   return positions.find((position) => position.currency)?.currency || fallbackCurrency;
 }
 
+function normalizePositionMultiplier(multiplier: number | undefined): number {
+  return typeof multiplier === "number" && Number.isFinite(multiplier) && multiplier > 0
+    ? multiplier
+    : 1;
+}
+
+function resolvePositionCostMultiplier(
+  position: TickerRecord["metadata"]["positions"][number],
+): number {
+  const priceMultiplier = normalizePositionMultiplier(position.multiplier);
+  if (priceMultiplier === 1) return 1;
+
+  if (position.marketValue == null || position.unrealizedPnl == null) {
+    return priceMultiplier;
+  }
+
+  const costWithoutMultiplier = position.shares * position.avgCost;
+  const costWithMultiplier = costWithoutMultiplier * priceMultiplier;
+  const withoutMultiplierError = Math.abs((position.marketValue - costWithoutMultiplier) - position.unrealizedPnl);
+  const withMultiplierError = Math.abs((position.marketValue - costWithMultiplier) - position.unrealizedPnl);
+
+  // IBKR gateway derivatives can report avgCost already scaled to the contract.
+  return withoutMultiplierError < withMultiplierError ? 1 : priceMultiplier;
+}
+
 function getPortfolioPositionMetrics(
   ticker: TickerRecord,
   activeTab: string | undefined,
@@ -66,25 +91,24 @@ function getPortfolioPositionMetrics(
     ? ticker.metadata.positions.filter((position) => position.portfolio === activeTab)
     : ticker.metadata.positions;
   const positionCurrency = getPositionCurrency(tabPositions, fallbackCurrency);
-  const totalShares = tabPositions.reduce((sum, position) => sum + position.shares * (position.side === "short" ? -1 : 1), 0);
-  const totalCost = tabPositions.reduce(
-    (sum, position) => sum + position.shares * position.avgCost * (position.multiplier || 1),
-    0,
-  );
-  const totalCostUnits = tabPositions.reduce(
-    (sum, position) => sum + position.shares * (position.multiplier || 1),
-    0,
-  );
-  const totalPriceUnits = tabPositions.reduce(
-    (sum, position) => sum + position.shares * (position.multiplier || 1) * (position.side === "short" ? -1 : 1),
-    0,
-  );
-
+  let totalShares = 0;
+  let totalCost = 0;
+  let totalCostUnits = 0;
+  let totalPriceUnits = 0;
   let brokerMktValue = 0;
   let hasBrokerMktValue = false;
   let brokerPnl = 0;
   let hasBrokerPnl = false;
   for (const position of tabPositions) {
+    const direction = position.side === "short" ? -1 : 1;
+    const priceMultiplier = normalizePositionMultiplier(position.multiplier);
+    const costMultiplier = resolvePositionCostMultiplier(position);
+
+    totalShares += position.shares * direction;
+    totalCost += position.shares * position.avgCost * costMultiplier;
+    totalCostUnits += position.shares * costMultiplier;
+    totalPriceUnits += position.shares * priceMultiplier * direction;
+
     if (position.marketValue != null) {
       brokerMktValue += position.marketValue;
       hasBrokerMktValue = true;

package/src/plugins/builtin/portfolio-list/settings.ts

@@ -1,5 +1,5 @@
 import type { PaneSettingOption, PaneSettingsDef, PaneTemplateContext } from "../../../types/plugin";
-import { DEFAULT_COLUMNS, type AppConfig, type ColumnConfig } from "../../../types/config";
+import { DEFAULT_COLUMNS, DEFAULT_PORTFOLIO_COLUMN_IDS, type AppConfig, type ColumnConfig } from "../../../types/config";
 
 export type CollectionScope = "all" | "portfolios" | "watchlists" | "custom";
 
@@ -35,16 +35,6 @@ export const PORTFOLIO_COLUMN_DEFS: ColumnConfig[] = [
   { id: "pnl_pct", label: "P&L%", width: 8, align: "right", format: "percent" },
 ];
 
-export const DEFAULT_PORTFOLIO_COLUMN_IDS = [
-  ...DEFAULT_COLUMNS.map((column) => column.id),
-  "shares",
-  "avg_cost",
-  "cost_basis",
-  "mkt_value",
-  "pnl",
-  "pnl_pct",
-];
-
 const PORTFOLIO_COLUMNS_BY_ID = new Map(PORTFOLIO_COLUMN_DEFS.map((column) => [column.id, column]));
 const PORTFOLIO_ONLY_COLUMN_IDS = new Set([
   "shares",

package/src/plugins/builtin/portfolio-metrics.test.ts

@@ -133,6 +133,77 @@ describe("portfolio-metrics", () => {
     });
   });
 
+  test("does not double-apply IBKR option multipliers when avgCost is already contract-scaled", () => {
+    const ticker = createTicker({
+      ticker: "AMD   270917C00230000",
+      assetCategory: "OPT",
+      positions: [{
+        portfolio: "main",
+        shares: 10,
+        avgCost: 5095.07295,
+        broker: "ibkr",
+        currency: "USD",
+        marketValue: 58803.06,
+        unrealizedPnl: 7852.33,
+        multiplier: 100,
+        markPrice: 58.8030586,
+      }],
+    });
+    const financialsMap = new Map<string, TickerFinancials>();
+
+    const totals = calculatePortfolioSummaryTotals(
+      [ticker],
+      financialsMap,
+      "USD",
+      new Map([["USD", 1]]),
+      true,
+      "main",
+    );
+
+    expect(totals.totalMktValue).toBeCloseTo(58803.06, 2);
+    expect(totals.totalCostBasis).toBeCloseTo(50950.7295, 4);
+    expect(totals.unrealizedPnl).toBeCloseTo(7852.3305, 4);
+    expect(totals.hasPositions).toBe(true);
+  });
+
+  test("keeps option avg cost display contract-scaled while using the correct cost basis", () => {
+    const ticker = createTicker({
+      ticker: "AMD   270917C00230000",
+      assetCategory: "OPT",
+      positions: [{
+        portfolio: "main",
+        shares: 10,
+        avgCost: 5095.07295,
+        broker: "ibkr",
+        currency: "USD",
+        marketValue: 58803.06,
+        unrealizedPnl: 7852.33,
+        multiplier: 100,
+        markPrice: 58.8030586,
+      }],
+    });
+    const financials = createFinancials({
+      quote: {
+        symbol: "AMD   270917C00230000",
+        price: 58.8030586,
+        currency: "USD",
+        change: 0,
+        changePercent: 0,
+        previousClose: 58.8030586,
+      },
+    });
+    const avgCostColumn: ColumnConfig = { id: "avg_cost", label: "AVG COST", width: 10, align: "right", format: "currency" };
+    const pnlColumn: ColumnConfig = { id: "pnl", label: "P&L", width: 10, align: "right", format: "compact" };
+
+    expect(getColumnValue(avgCostColumn, ticker, financials, defaultColumnContext)).toEqual({
+      text: "5,095.07",
+    });
+    expect(getColumnValue(pnlColumn, ticker, financials, defaultColumnContext)).toEqual({
+      text: "+7.9k",
+      color: expect.any(String),
+    });
+  });
+
   test("formats portfolio-only column values and sort keys consistently", () => {
     const ticker = createTicker({
       positions: [{ portfolio: "main", shares: 10, avgCost: 100, broker: "manual" }],

package/src/state/app-context.test.tsx

@@ -129,4 +129,34 @@ describe("appReducer command bar state", () => {
       ? secondUndone.config.layout.dockRoot.ratio
       : null).toBe(0.4);
   });
+
+  test("tracks manual update-check feedback", () => {
+    const initial = createInitialState(createDefaultConfig("/tmp/gloomberb-test"));
+    const checking = appReducer(initial, { type: "SET_UPDATE_CHECK_IN_PROGRESS", checking: true });
+    const noticed = appReducer(checking, { type: "SET_UPDATE_NOTICE", notice: "Already on v0.3.1" });
+
+    expect(checking.updateCheckInProgress).toBe(true);
+    expect(noticed.updateNotice).toBe("Already on v0.3.1");
+  });
+
+  test("clears stale update notices when an update becomes available", () => {
+    const initial = {
+      ...createInitialState(createDefaultConfig("/tmp/gloomberb-test")),
+      updateNotice: "Already on v0.3.1",
+    };
+    const next = appReducer(initial, {
+      type: "SET_UPDATE_AVAILABLE",
+      release: {
+        version: "0.3.2",
+        tagName: "v0.3.2",
+        downloadUrl: "https://example.com/gloomberb.gz",
+        publishedAt: "2026-04-03T00:00:00Z",
+        updateAction: { kind: "self" },
+        compressed: true,
+      },
+    });
+
+    expect(next.updateAvailable?.version).toBe("0.3.2");
+    expect(next.updateNotice).toBeNull();
+  });
 });

package/src/state/app-context.tsx

@@ -78,6 +78,8 @@ export interface AppState {
   inputCaptured: boolean;
   updateAvailable: ReleaseInfo | null;
   updateProgress: UpdateProgress | null;
+  updateCheckInProgress: boolean;
+  updateNotice: string | null;
   layoutHistory: Record<number, LayoutHistoryEntry>;
 }
 
@@ -101,8 +103,10 @@ export type AppAction =
   | { type: "SHOW_GRIDLOCK_TIP" }
   | { type: "DISMISS_GRIDLOCK_TIP" }
   | { type: "SET_THEME"; theme: string }
-  | { type: "SET_UPDATE_AVAILABLE"; release: ReleaseInfo }
+  | { type: "SET_UPDATE_AVAILABLE"; release: ReleaseInfo | null }
   | { type: "SET_UPDATE_PROGRESS"; progress: UpdateProgress | null }
+  | { type: "SET_UPDATE_CHECK_IN_PROGRESS"; checking: boolean }
+  | { type: "SET_UPDATE_NOTICE"; notice: string | null }
   | { type: "TOGGLE_PLUGIN"; pluginId: string }
   | { type: "SET_INPUT_CAPTURED"; captured: boolean }
   | { type: "SET_EXCHANGE_RATE"; currency: string; rate: number }
@@ -548,10 +552,16 @@ export function appReducer(state: AppState, action: AppAction): AppState {
       return { ...state, config: { ...state.config, theme: action.theme } };
 
     case "SET_UPDATE_AVAILABLE":
-      return { ...state, updateAvailable: action.release };
+      return { ...state, updateAvailable: action.release, updateNotice: action.release ? null : state.updateNotice };
 
     case "SET_UPDATE_PROGRESS":
-      return { ...state, updateProgress: action.progress };
+      return { ...state, updateProgress: action.progress, updateNotice: action.progress ? null : state.updateNotice };
+
+    case "SET_UPDATE_CHECK_IN_PROGRESS":
+      return { ...state, updateCheckInProgress: action.checking };
+
+    case "SET_UPDATE_NOTICE":
+      return { ...state, updateNotice: action.notice };
 
     case "TOGGLE_PLUGIN": {
       const disabledPlugins = state.config.disabledPlugins.includes(action.pluginId)
@@ -936,6 +946,8 @@ export function createInitialState(config: AppConfig, sessionSnapshot: AppSessio
     inputCaptured: false,
     updateAvailable: null,
     updateProgress: null,
+    updateCheckInProgress: false,
+    updateNotice: null,
     layoutHistory: {},
   };
 }

package/src/types/config.ts

@@ -1,6 +1,6 @@
 import type { Portfolio, Watchlist } from "./ticker";
 
-export const CURRENT_CONFIG_VERSION = 10;
+export const CURRENT_CONFIG_VERSION = 11;
 
 export type DefaultChartRenderMode = "area" | "line" | "candles" | "ohlc";
 export type ChartRendererPreference = "auto" | "kitty" | "braille";
@@ -134,6 +134,16 @@ export const DEFAULT_COLUMNS: ColumnConfig[] = [
   { id: "latency", label: "AGE", width: 6, align: "right" },
 ];
 
+export const DEFAULT_PORTFOLIO_COLUMN_IDS = [
+  ...DEFAULT_COLUMNS.map((column) => column.id),
+  "shares",
+  "avg_cost",
+  "cost_basis",
+  "mkt_value",
+  "pnl",
+  "pnl_pct",
+];
+
 export const DEFAULT_LAYOUT: LayoutConfig = {
   dockRoot: {
     kind: "split",
@@ -148,7 +158,7 @@ export const DEFAULT_LAYOUT: LayoutConfig = {
       paneId: "portfolio-list",
       params: { collectionId: "main" },
       settings: {
-        columnIds: DEFAULT_COLUMNS.map((column) => column.id),
+        columnIds: [...DEFAULT_PORTFOLIO_COLUMN_IDS],
         collectionScope: "all",
         visibleCollectionIds: [],
         hideTabs: false,

package/src/updater.test.ts

@@ -1,7 +1,12 @@
-import { describe, expect, it, test } from "bun:test";
+import { afterEach, describe, expect, it, test } from "bun:test";
+import { chmodSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from "fs";
+import { tmpdir } from "os";
+import { join } from "path";
+import { gzipSync } from "zlib";
 import {
   canSelfUpdate,
   checkForUpdate,
+  checkForUpdateDetailed,
   detectUpdateAction,
   performUpdate,
   resolveSelfUpdateTargetPath,
@@ -9,6 +14,18 @@ import {
   type UpdateProgress,
 } from "./updater";
 
+const originalFetch = globalThis.fetch;
+
+afterEach(() => {
+  globalThis.fetch = originalFetch;
+});
+
+function expectedAssetName(compressed = false): string {
+  const os = process.platform === "darwin" ? "darwin" : "linux";
+  const arch = os === "darwin" || process.arch === "arm64" ? "arm64" : "x64";
+  return compressed ? `gloomberb-${os}-${arch}.gz` : `gloomberb-${os}-${arch}`;
+}
+
 describe("detectUpdateAction", () => {
   test("uses self-update for standalone binaries", () => {
     expect(detectUpdateAction(
@@ -100,6 +117,66 @@ describe("checkForUpdate", () => {
       Object.defineProperty(process, "argv", { value: originalArgv, configurable: true });
     }
   });
+
+  it("finds gzipped release assets published on GitHub", async () => {
+    const originalExecPath = process.execPath;
+    const originalArgv = process.argv;
+    globalThis.fetch = (async () => new Response(JSON.stringify({
+      tag_name: "v0.3.2",
+      published_at: "2026-04-03T00:00:00Z",
+      assets: [{
+        name: expectedAssetName(true),
+        browser_download_url: "https://example.com/gloomberb.gz",
+      }],
+    }), {
+      status: 200,
+      headers: { "content-type": "application/json" },
+    })) as typeof fetch;
+
+    try {
+      Object.defineProperty(process, "execPath", { value: "/Applications/gloomberb", configurable: true });
+      Object.defineProperty(process, "argv", {
+        value: ["/Applications/gloomberb"],
+        configurable: true,
+      });
+
+      await expect(checkForUpdate("0.3.1")).resolves.toEqual({
+        version: "0.3.2",
+        tagName: "v0.3.2",
+        downloadUrl: "https://example.com/gloomberb.gz",
+        publishedAt: "2026-04-03T00:00:00Z",
+        updateAction: { kind: "self" },
+        compressed: true,
+      });
+    } finally {
+      Object.defineProperty(process, "execPath", { value: originalExecPath, configurable: true });
+      Object.defineProperty(process, "argv", { value: originalArgv, configurable: true });
+    }
+  });
+});
+
+describe("checkForUpdateDetailed", () => {
+  it("returns a useful error when GitHub rejects the request", async () => {
+    const originalExecPath = process.execPath;
+    const originalArgv = process.argv;
+    globalThis.fetch = (async () => new Response("busy", { status: 503 })) as typeof fetch;
+
+    try {
+      Object.defineProperty(process, "execPath", { value: "/Applications/gloomberb", configurable: true });
+      Object.defineProperty(process, "argv", {
+        value: ["/Applications/gloomberb"],
+        configurable: true,
+      });
+
+      await expect(checkForUpdateDetailed("0.3.1")).resolves.toEqual({
+        kind: "error",
+        error: "GitHub returned 503",
+      });
+    } finally {
+      Object.defineProperty(process, "execPath", { value: originalExecPath, configurable: true });
+      Object.defineProperty(process, "argv", { value: originalArgv, configurable: true });
+    }
+  });
 });
 
 describe("performUpdate", () => {
@@ -159,4 +236,47 @@ describe("performUpdate", () => {
       Object.defineProperty(process, "argv", { value: originalArgv, configurable: true });
     }
   });
+
+  it("decompresses gzipped release assets before replacing the binary", async () => {
+    const originalExecPath = process.execPath;
+    const originalArgv = process.argv;
+    const tempDir = mkdtempSync(join(tmpdir(), "gloomberb-update-"));
+    const execPath = join(tempDir, "gloomberb");
+    const nextBinary = Buffer.from("new-binary");
+    const payload = gzipSync(nextBinary);
+    const progress: UpdateProgress[] = [];
+
+    writeFileSync(execPath, Buffer.from("old-binary"));
+    chmodSync(execPath, 0o755);
+    globalThis.fetch = (async () => new Response(payload, {
+      status: 200,
+      headers: { "content-length": String(payload.length) },
+    })) as typeof fetch;
+
+    try {
+      Object.defineProperty(process, "execPath", { value: execPath, configurable: true });
+      Object.defineProperty(process, "argv", {
+        value: [execPath],
+        configurable: true,
+      });
+
+      await performUpdate({
+        version: "9.9.9",
+        tagName: "v9.9.9",
+        downloadUrl: "https://example.com/gloomberb.gz",
+        publishedAt: "2026-04-03T00:00:00Z",
+        updateAction: { kind: "self" },
+        compressed: true,
+      }, (entry) => {
+        progress.push(entry);
+      });
+
+      expect(readFileSync(execPath)).toEqual(nextBinary);
+      expect(progress.at(-1)).toEqual({ phase: "done" });
+    } finally {
+      Object.defineProperty(process, "execPath", { value: originalExecPath, configurable: true });
+      Object.defineProperty(process, "argv", { value: originalArgv, configurable: true });
+      rmSync(tempDir, { recursive: true, force: true });
+    }
+  });
 });