gloomberb 0.2.0 → 0.3.1

package/src/components/command-bar/command-registry.ts

@@ -0,0 +1,261 @@
+import type { AppAction } from "../../state/app-context";
+import { themes, getThemeIds } from "../../theme/themes";
+
+export type CommandExecutor = (dispatch: React.Dispatch<AppAction>, context: CommandContext) => void | Promise<void>;
+
+export interface CommandContext {
+  activeTicker: string | null;
+  activeCollectionId: string | null;
+}
+
+export interface Command {
+  id: string;
+  prefix: string;        // e.g., "T", "AW", "RP"
+  label: string;
+  description: string;
+  hasArg?: boolean;       // true if prefix takes an argument (e.g., "T AMD")
+  argPlaceholder?: string;
+  shortcut?: string;
+  category: string;
+  execute: CommandExecutor;
+}
+
+export const commands: Command[] = [
+  // Ticker search
+  {
+    id: "search-ticker",
+    prefix: "T",
+    label: "Search Ticker",
+    description: "Search Yahoo Finance for a ticker",
+    hasArg: true,
+    argPlaceholder: "symbol or name",
+    category: "Search",
+    execute: () => {}, // handled specially by command bar
+  },
+  {
+    id: "help",
+    prefix: "HELP",
+    label: "Help",
+    description: "Open the help window",
+    category: "Navigation",
+    execute: () => {}, // handled specially by command bar
+  },
+
+  // Watchlist/Portfolio management
+  {
+    id: "add-watchlist",
+    prefix: "AW",
+    label: "Add to Watchlist",
+    description: "Add current ticker to active watchlist",
+    hasArg: true,
+    argPlaceholder: "ticker",
+    category: "Portfolio",
+    execute: () => {}, // handled by command bar
+  },
+  {
+    id: "add-portfolio",
+    prefix: "AP",
+    label: "Add to Portfolio",
+    description: "Add current ticker to active portfolio",
+    hasArg: true,
+    argPlaceholder: "ticker",
+    category: "Portfolio",
+    execute: () => {},
+  },
+  {
+    id: "remove-watchlist",
+    prefix: "RW",
+    label: "Remove from Watchlist",
+    description: "Remove current ticker from active watchlist",
+    hasArg: true,
+    argPlaceholder: "ticker",
+    category: "Portfolio",
+    execute: () => {},
+  },
+  {
+    id: "remove-portfolio",
+    prefix: "RP",
+    label: "Remove from Portfolio",
+    description: "Remove current ticker from active portfolio",
+    hasArg: true,
+    argPlaceholder: "ticker",
+    category: "Portfolio",
+    execute: () => {},
+  },
+
+  // Create / Delete
+  {
+    id: "new-portfolio",
+    prefix: "",
+    label: "New Portfolio",
+    description: "Create a new portfolio",
+    category: "Create",
+    execute: () => {},
+  },
+  {
+    id: "new-watchlist",
+    prefix: "",
+    label: "New Watchlist",
+    description: "Create a new watchlist",
+    category: "Create",
+    execute: () => {},
+  },
+  {
+    id: "delete-portfolio",
+    prefix: "",
+    label: "Delete Portfolio",
+    description: "Remove a portfolio and its data",
+    category: "Danger",
+    execute: () => {},
+  },
+  {
+    id: "delete-watchlist",
+    prefix: "",
+    label: "Delete Watchlist",
+    description: "Remove a watchlist",
+    category: "Danger",
+    execute: () => {},
+  },
+  {
+    id: "add-broker-account",
+    prefix: "",
+    label: "Add Broker Account",
+    description: "Connect a new broker profile",
+    category: "Config",
+    execute: () => {},
+  },
+  {
+    id: "disconnect-broker-account",
+    prefix: "",
+    label: "Disconnect Broker Account",
+    description: "Remove one connected broker profile and its imported data",
+    category: "Danger",
+    execute: () => {},
+  },
+
+  {
+    id: "pane-settings",
+    prefix: "PS",
+    label: "Pane Settings",
+    description: "Edit settings for the focused pane",
+    category: "Config",
+    execute: () => {}, // handled by command bar
+  },
+  {
+    id: "layout",
+    prefix: "LAY",
+    label: "Layout Actions",
+    description: "Organize panes and saved layouts",
+    hasArg: true,
+    argPlaceholder: "action",
+    category: "Config",
+    execute: () => {}, // handled by command bar
+  },
+  {
+    id: "new-pane",
+    prefix: "NP",
+    label: "New Pane",
+    description: "Add or create a new pane from plugin templates",
+    hasArg: true,
+    argPlaceholder: "pane",
+    category: "Config",
+    execute: () => {}, // handled by command bar
+  },
+  {
+    id: "toggle-status-bar",
+    prefix: "SB",
+    label: "Toggle Status Bar",
+    description: "Show or hide the keyboard shortcuts bar",
+    category: "Config",
+    execute: (dispatch) => {
+      dispatch({ type: "TOGGLE_STATUS_BAR" });
+    },
+  },
+
+  // Theme
+  {
+    id: "theme",
+    prefix: "TH",
+    label: "Change Theme",
+    description: "Switch color theme",
+    hasArg: true,
+    argPlaceholder: "theme name",
+    category: "Config",
+    execute: () => {}, // handled by command bar
+  },
+  {
+    id: "cycle-chart-renderer",
+    prefix: "CR",
+    label: "Cycle Chart Renderer",
+    description: "Cycle chart rendering between Auto, Kitty, and Braille",
+    category: "Config",
+    execute: () => {}, // handled specially by command bar
+  },
+
+  // Plugins
+  {
+    id: "plugins",
+    prefix: "PL",
+    label: "Manage Plugins",
+    description: "Toggle plugins on/off",
+    hasArg: true,
+    argPlaceholder: "plugin name",
+    category: "Config",
+    execute: () => {}, // handled by command bar
+  },
+
+  // Import/Export
+  {
+    id: "export-config",
+    prefix: "",
+    label: "Export Config",
+    description: "Save config to ~/gloomberb-config-backup.json",
+    category: "Config",
+    execute: () => {}, // handled by command bar
+  },
+  {
+    id: "import-config",
+    prefix: "",
+    label: "Import Config",
+    description: "Load config from ~/gloomberb-config-backup.json",
+    category: "Config",
+    execute: () => {}, // handled by command bar
+  },
+
+  // Danger zone
+  {
+    id: "reset-all-data",
+    prefix: "",
+    label: "Reset All Data",
+    description: "Delete all data and reset to first-run state",
+    category: "Danger",
+    execute: () => {}, // handled by command bar (needs confirm dialog)
+  },
+];
+
+/** Get theme options for the command bar */
+export function getThemeOptions(): Array<{ id: string; name: string; description: string }> {
+  return getThemeIds().map((id) => ({
+    id,
+    name: themes[id]!.name,
+    description: themes[id]!.description,
+  }));
+}
+
+/** Find a command whose prefix matches the start of the input */
+export function matchPrefix(input: string): { command: Command; arg: string } | null {
+  const upper = input.toUpperCase().trim();
+  if (!upper) return null;
+
+  // Sort by prefix length descending so longer prefixes match first (e.g., "AW" before "A")
+  const sorted = [...commands].sort((a, b) => b.prefix.length - a.prefix.length);
+
+  for (const cmd of sorted) {
+    if (upper.startsWith(cmd.prefix + " ") || upper === cmd.prefix) {
+      const arg = input.slice(cmd.prefix.length).trim();
+      return { command: cmd, arg };
+    }
+  }
+
+  return null;
+}

package/src/components/command-bar/helpers.test.ts

@@ -0,0 +1,224 @@
+import { describe, expect, test } from "bun:test";
+import type { PaneTemplateDef, WizardStep } from "../../types/plugin";
+import type {
+  CommandBarRoute,
+  CommandBarWorkflowField,
+} from "./workflow-types";
+import {
+  buildGeneratedTemplateField,
+  getCollectionCommandAction,
+  getCollectionCommandKind,
+  getCollectionCommandVerb,
+  getFirstVisibleFieldId,
+  getScreenFooterLeft,
+  getScreenFooterRight,
+  getVisibleWorkflowFields,
+  isCollectionCommand,
+  isRootParsedCommand,
+  isRouteCommandId,
+  isWorkflowTextField,
+  looksDestructiveCommand,
+  moveSelectedValue,
+  normalizeWizardFields,
+  routeCommandIdToScreen,
+  slugifyName,
+  summarizeError,
+  summarizePaneSettingValue,
+  summarizeWorkflowFieldValue,
+  toggleSelectedValue,
+} from "./helpers";
+
+const workflowFields: CommandBarWorkflowField[] = [
+  {
+    id: "source",
+    label: "Source",
+    type: "select",
+    options: [
+      { label: "Manual", value: "manual" },
+      { label: "Broker", value: "broker" },
+    ],
+  },
+  {
+    id: "account",
+    label: "Account",
+    type: "text",
+    dependsOn: [{ key: "source", value: "broker" }],
+  },
+  {
+    id: "enabled",
+    label: "Enabled",
+    type: "toggle",
+  },
+];
+
+describe("command-bar helpers", () => {
+  test("filters visible workflow fields by dependencies", () => {
+    expect(getVisibleWorkflowFields(workflowFields, { source: "manual" }).map((field) => field.id)).toEqual([
+      "source",
+      "enabled",
+    ]);
+    expect(getFirstVisibleFieldId(workflowFields, { source: "broker" })).toBe("source");
+  });
+
+  test("summarizes workflow field values using labels and truncation", () => {
+    expect(summarizeWorkflowFieldValue(workflowFields[2]!, true)).toBe("On");
+    expect(summarizeWorkflowFieldValue(workflowFields[0]!, "broker")).toBe("Broker");
+    expect(summarizeWorkflowFieldValue({
+      id: "prompt",
+      label: "Prompt",
+      type: "textarea",
+    }, "quality\ncompounders")).toBe("quality compounders");
+    expect(summarizeWorkflowFieldValue({
+      id: "columns",
+      label: "Columns",
+      type: "ordered-multi-select",
+      options: [
+        { label: "Symbol", value: "symbol" },
+        { label: "Price", value: "price" },
+        { label: "P&L", value: "pnl" },
+        { label: "Volume", value: "volume" },
+      ],
+    }, ["symbol", "price", "pnl", "volume"])).toBe("Symbol, Price, P&L +1");
+  });
+
+  test("summarizes pane setting values consistently", () => {
+    expect(summarizePaneSettingValue({
+      key: "theme",
+      label: "Theme",
+      type: "select",
+      options: [{ label: "Nord", value: "nord" }],
+    }, "nord")).toBe("Nord");
+    expect(summarizePaneSettingValue({
+      key: "columns",
+      label: "Columns",
+      type: "ordered-multi-select",
+      options: [
+        { label: "Symbol", value: "symbol" },
+        { label: "Price", value: "price" },
+        { label: "P&L", value: "pnl" },
+        { label: "Volume", value: "volume" },
+      ],
+    }, ["symbol", "price", "pnl", "volume"])).toBe("Symbol, Price, P&L +1");
+  });
+
+  test("toggles and reorders selected values while preserving unknown entries", () => {
+    expect(toggleSelectedValue(["symbol", "price"], "price")).toEqual(["symbol"]);
+    expect(toggleSelectedValue(["symbol"], "price")).toEqual(["symbol", "price"]);
+
+    expect(moveSelectedValue(
+      {
+        options: [
+          { label: "Symbol", value: "symbol" },
+          { label: "Price", value: "price" },
+          { label: "P&L", value: "pnl" },
+        ],
+      },
+      ["symbol", "price", "custom"],
+      "price",
+      "up",
+    )).toEqual(["price", "symbol", "custom"]);
+  });
+
+  test("normalizes wizard fields and derives defaults from steps", () => {
+    const steps: WizardStep[] = [
+      { key: "intro", label: "Intro", type: "info", body: ["Line one", "Line two"] },
+      { key: "_validate-broker", label: "Validate", type: "info", body: ["Connecting…", "Connected"] },
+      { key: "mode", label: "Mode", type: "select", options: [{ label: "Paper", value: "paper" }, { label: "Live", value: "live" }] },
+      { key: "account", label: "Account", type: "text", defaultValue: "DU12345", dependsOn: { key: "mode", value: "live" } },
+      { key: "prompt", label: "Prompt", type: "textarea", defaultValue: "Find quality compounders" },
+    ];
+
+    const normalized = normalizeWizardFields(steps);
+
+    expect(normalized.description).toEqual(["Line one", "Line two"]);
+    expect(normalized.pendingLabel).toBe("Connecting…");
+    expect(normalized.successLabel).toBe("Connected");
+    expect(normalized.initialValues).toEqual({
+      mode: "paper",
+      account: "DU12345",
+      prompt: "Find quality compounders",
+    });
+    expect(normalized.fields[1]?.dependsOn).toEqual([{ key: "mode", value: "live" }]);
+    expect(normalized.fields[2]?.type).toBe("textarea");
+  });
+
+  test("builds generated template fields from shortcut placeholders", () => {
+    const tickerTemplate: PaneTemplateDef = {
+      id: "detail",
+      paneId: "detail",
+      label: "Detail",
+      description: "Open detail",
+      shortcut: { prefix: "detail", argPlaceholder: "ticker" },
+    };
+
+    expect(buildGeneratedTemplateField(tickerTemplate, "AAPL")).toEqual({
+      field: {
+        id: "ticker",
+        label: "Ticker",
+        type: "text",
+        required: true,
+        placeholder: "AAPL",
+      },
+      initialValue: "AAPL",
+    });
+
+    expect(buildGeneratedTemplateField({
+      ...tickerTemplate,
+      shortcut: { prefix: "compare", argPlaceholder: "tickers" },
+    }, null)).toEqual({
+      field: {
+        id: "tickers",
+        label: "Tickers",
+        type: "text",
+        required: true,
+        placeholder: "AAPL, MSFT, NVDA",
+      },
+      initialValue: "",
+    });
+  });
+
+  test("formats screen footers based on route context", () => {
+    const orderedPickerRoute: CommandBarRoute = {
+      kind: "picker",
+      pickerId: "field-multi-select",
+      title: "Columns",
+      query: "",
+      selectedIdx: 0,
+      hoveredIdx: null,
+      options: [],
+      payload: { fieldType: "ordered-multi-select" },
+    };
+
+    expect(getScreenFooterLeft(null)).toBe("up/down move  enter select");
+    expect(getScreenFooterLeft(orderedPickerRoute)).toBe("up/down move  space toggle  [ ] reorder  enter done");
+    expect(getScreenFooterRight(orderedPickerRoute)).toBe("esc back");
+  });
+
+  test("maps route and collection command ids", () => {
+    expect(isRouteCommandId("plugins")).toBe(true);
+    expect(routeCommandIdToScreen("plugins")).toBe("plugins");
+    expect(isRootParsedCommand("remove-portfolio")).toBe(true);
+    expect(isCollectionCommand("remove-portfolio")).toBe(true);
+    expect(getCollectionCommandKind("remove-portfolio")).toBe("portfolio");
+    expect(getCollectionCommandAction("remove-portfolio")).toBe("remove");
+    expect(getCollectionCommandVerb("add")).toBe("Add");
+  });
+
+  test("identifies workflow text fields and destructive commands", () => {
+    expect(isWorkflowTextField({ id: "name", label: "Name", type: "text" })).toBe(true);
+    expect(isWorkflowTextField({ id: "prompt", label: "Prompt", type: "textarea" })).toBe(true);
+    expect(isWorkflowTextField({ id: "enabled", label: "Enabled", type: "toggle" })).toBe(false);
+    expect(looksDestructiveCommand({
+      id: "reset-layout",
+      label: "Reset Layout",
+      description: "Reset all panes",
+      keywords: ["danger"],
+    })).toBe(true);
+  });
+
+  test("slugifies names and summarizes errors", () => {
+    expect(slugifyName("Broker Account 01", "portfolio")).toBe("broker-account-01");
+    expect(summarizeError(new Error("boom"))).toMatchObject({ name: "Error", message: "boom" });
+    expect(summarizeError("broken")).toEqual({ message: "broken" });
+  });
+});