gloomberb 0.18.1 → 0.18.3

package/src/cli/commands/news-search.ts

@@ -2,6 +2,9 @@ import { apiClient } from "../../api-client";
 import type { NewsArticle } from "../../news/types";
 import { mapCloudNewsArticle } from "../../sources/gloomberb-cloud/news";
 import { cliStyles } from "../../utils/cli-output";
+import { logFailure } from "../../utils/log-failure";
+import { commodityNamedIn, commoditySearchName, isCommodityName } from "../../market-data/commodity-names";
+import type { FuturesContract } from "../../market-data/futures-board";
 
 /** What the service accepts of a search: two characters to two hundred, with a letter or a number in them. */
 const MIN_TEXT_LENGTH = 2;
@@ -60,8 +63,8 @@ export function newsSearchTextProblem(text: string): string | null {
 
 /**
  * The word a symbol lookup found no stories for, as text to search stories for.
- * Null under three characters, where the fuzzy match finds names that merely
- * contain it (ZN, Telomir-Zn) and the lookup's own answer is the better one.
+ * Null under three characters, where the word is mostly a piece of other
+ * names (ZN in Telomir-Zn) and the lookup's own answer is the better one.
  */
 export function newsFallbackText(symbol: string): string | null {
   const text = symbol.trim().replace(/^\$/, "");
@@ -69,15 +72,39 @@ export function newsFallbackText(symbol: string): string | null {
 }
 
 /**
- * The stories matching the text, newest first. The service answers best match
- * first and holds stories back from an account without real-time access, as
- * every other news request.
+ * The stories matching the text, in the service's order: stories with every
+ * word in the headline first, then the ones with some only in the summary,
+ * newest first within each. The service holds stories back from an account
+ * without real-time access, as every other news request.
  */
 export async function searchNewsStories(text: string, limit: number): Promise<NewsArticle[]> {
   const response = await apiClient.searchCloudNews(text, limit);
-  return response.items
-    .map((item) => mapCloudNewsArticle(item))
-    .sort((a, b) => b.publishedAt.getTime() - a.publishedAt.getTime());
+  return response.items.map((item) => mapCloudNewsArticle(item));
+}
+
+/** The futures news route a search offers when no story matches it: `gloomberb news KC=F` for "arabica". */
+export interface CommodityNewsRoute {
+  contract: FuturesContract;
+  command: string;
+}
+
+/**
+ * The future of the commodity a search names, offered when no story matched:
+ * `news KC=F` searches the stories of coffee, so it is offered only when
+ * those are not what just found nothing and they have a story to show.
+ */
+export async function commodityNewsRoute(text: string): Promise<CommodityNewsRoute | null> {
+  const contract = commodityNamedIn(text);
+  const name = contract ? commoditySearchName(contract) : null;
+  if (!contract || !name || isCommodityName(text, name)) return null;
+  const stories = await searchNewsStories(name, 1).catch(logFailure("cli.news-search", "Search a commodity's stories failed", []));
+  return stories.length > 0 ? { contract, command: `gloomberb news ${contract.symbol}` } : null;
+}
+
+/** What a search that matched no story says: never a near miss, and the commodity's futures news where it has some. */
+export function noStoriesMessage(text: string, route: CommodityNewsRoute | null): string {
+  const none = `No stories match "${text}".`;
+  return route ? `${none} For the ${route.contract.name} future, try: ${route.command}` : none;
 }
 
 /** The line above the stories: "Stories matching "european gas"", with why a word typed as a symbol is searched. */

package/src/cli/commands/system.ts

@@ -5,6 +5,7 @@ import { saveConfig } from "../../data/config/store";
 import { builtinPluginGroupMembers } from "../../plugins/ownership";
 import type { AppConfig, TelemetryConfig } from "../../types/config";
 import { canonicalTimeZone } from "../../utils/utc-time";
+import { readBaseCurrency } from "../../utils/base-currency";
 import { NIGHTLY_CHANNEL_SUMMARY, parseUpdateChannel, withUpdateChannel } from "../../updater/channel";
 import type { CliCommandDef } from "../../types/plugin";
 import { resolveCliDataDir, withCliServices, withConfigData } from "../context";
@@ -65,6 +66,32 @@ function parseTimezoneSetting(value: string): string | null {
   );
 }
 
+/**
+ * The code `config set baseCurrency` stores (`cad` is CAD); fails on a name
+ * or sign, naming the code it stands for, and on anything that is no code.
+ */
+function parseBaseCurrencySetting(value: string): string {
+  const reading = readBaseCurrency(value);
+  if ("code" in reading) return reading.code;
+  const [first] = reading.suggestions;
+  return fail(reading.error, first
+    ? `baseCurrency takes an ISO 4217 code: gloomberb config set baseCurrency ${first}`
+    : "baseCurrency takes an ISO 4217 code such as USD, EUR or CAD.");
+}
+
+/** A saved base currency that is no code (an older version stored names), with what to set instead; null for a code. */
+function baseCurrencyProblem(value: unknown): string | null {
+  const reading = readBaseCurrency(typeof value === "string" ? value : "");
+  if ("code" in reading) return null;
+  const [first] = reading.suggestions;
+  return `${reading.error} Set one: gloomberb config set baseCurrency ${first ?? "<code>"}`;
+}
+
+function describeBaseCurrency(value: unknown): string {
+  const problem = baseCurrencyProblem(value);
+  return problem ? `${String(value)} ${cliStyles.warning(`(${problem})`)}` : String(value);
+}
+
 function describeTimezone(value: unknown): string {
   return typeof value === "string" && value ? value : "not set, times print in UTC alone";
 }
@@ -189,6 +216,9 @@ export function createSystemCliCommands(): CliCommandDef[] {
           checks.push({ check: "database", status: "ok", detail: join(services.dataDir, ".gloomberb-cache.db") });
           checks.push({ check: "plugins", status: "ok", detail: String(services.services.pluginRegistry.allPlugins.size) });
           checks.push({ check: "capabilities", status: "ok", detail: String(services.services.pluginRegistry.capabilities.manifests().length) });
+          // Only a saved value no conversion can price is worth a line.
+          const baseCurrencyIssue = baseCurrencyProblem(services.config.baseCurrency);
+          if (baseCurrencyIssue) checks.push({ check: "baseCurrency", status: "warn", detail: baseCurrencyIssue });
           const theme = services.config.theme;
           checks.push({
             check: "theme",
@@ -311,6 +341,7 @@ export function createSystemCliCommands(): CliCommandDef[] {
               ...(key === KEYBINDINGS_CONFIG_KEY ? { format: summarizeKeybindings } : {}),
               ...(key === "theme" ? { format: (value: unknown) => describeThemeId(String(value)) } : {}),
               ...(key === TIMEZONE_CONFIG_KEY ? { format: describeTimezone } : {}),
+              ...(key === "baseCurrency" ? { format: describeBaseCurrency } : {}),
             })),
           });
           return;
@@ -329,7 +360,8 @@ export function createSystemCliCommands(): CliCommandDef[] {
           }
           ctx.printResult({ data: { key, value: safeConfig[key] } }, {
             text: (data) => key === KEYBINDINGS_CONFIG_KEY ? renderKeybindings(data.value)
-              : key === TIMEZONE_CONFIG_KEY ? describeTimezone(data.value) : describeConfigValue(data.value),
+              : key === TIMEZONE_CONFIG_KEY ? describeTimezone(data.value)
+                : key === "baseCurrency" ? describeBaseCurrency(data.value) : describeConfigValue(data.value),
           });
           return;
         }
@@ -367,6 +399,8 @@ export function createSystemCliCommands(): CliCommandDef[] {
           // A display name may come unquoted: config set theme White Phosphor.
           const parsedValue = key === "theme"
             ? requireThemeId(args.slice(2).join(" "))
+            : key === "baseCurrency"
+              ? parseBaseCurrencySetting(args.slice(2).join(" "))
             : key === TIMEZONE_CONFIG_KEY
               ? parseTimezoneSetting(value)
               : key === UPDATE_CHANNEL_CONFIG_KEY