gloomberb 0.17.5 → 0.18.0

package/src/api-client/supply-chain-graph.ts

@@ -7,7 +7,7 @@ export interface GraphOptions {
   minPct: number; minConfidence: number; limit: number; ranking: "score" | "shortest"; asOf?: string;
 }
 export const DEFAULT_GRAPH_OPTIONS: GraphOptions = { depth: 2, direction: "both", roles: [], sources: [], tiers: [], minPct: 0, minConfidence: 0, limit: 50, ranking: "score" };
-export interface GraphEvidence extends Pick<SupplyRow, "claimType" | "corroboration" | "leadStatus" | "firstSeenAt" | "lastSeenAt" | "lastConfirmedAt" | "whyUnconfirmed" | "evidence" | "nativeAmount" | "nativeCurrency" | "nativeScale" | "entityScope" | "quoteGloss" | "sectionRef" | "sourceAttribution"> {
+export interface GraphEvidence extends Pick<SupplyRow, "claimType" | "corroboration" | "leadStatus" | "firstSeenAt" | "lastSeenAt" | "lastConfirmedAt" | "whyUnconfirmed" | "evidence" | "nativeAmount" | "nativeCurrency" | "nativeScale" | "entityScope" | "quoteGloss" | "sectionRef" | "sourceAttribution" | "periodMonths"> {
   /** Source trust tier, distinct from the graph evidence class in tier. */
   trustTier?: SupplyTier;
   id: string; fromEntity: string; toEntity: string; reportingEntity: string;
@@ -25,7 +25,7 @@ interface GraphLink {
 }
 export interface GraphPath {
   id: string; nodeIds: string[]; linkIds: string[]; hops: number; score: number; confidence: number;
-  exposure: { pct: number; basis: NonNullable<SupplyRow["pctBasis"]>; period: string; denominatorEntityId: string; estimated: true } | null;
+  exposure: { pct: number; basis: NonNullable<SupplyRow["pctBasis"]>; period: string; periodMonths?: number | null; denominatorEntityId: string; estimated: true } | null;
 }
 interface GraphReach { entityId: string; direction: "upstream" | "downstream"; hops: number; bestPath: GraphPath; shortestPath: GraphPath; }
 export interface GraphPayload {

package/src/api-client/supply-chain.ts

@@ -55,6 +55,8 @@ export interface SupplyRow {
   jurisdiction?: string | null;
   entityScope?: "entity" | "group" | "anonymous" | "aggregate" | null;
   period: string;
+  /** Months every figure on the row covers: 0 a balance at the period end, 3 a quarter, 12 a year. Null or absent when the source does not say or the figures differ in length. */
+  periodMonths?: number | null;
   fiscalYear: string | null;
   sourceKind: "xbrl" | "filing_text" | "call" | "news" | "web" | "import" | "press_release";
   form: string | null;
@@ -88,6 +90,12 @@ export interface SupplyChainPayload {
   says: SupplyRow[];
   names: SupplyRow[];
   counts: { says: Record<SupplyRole, number>; names: Record<SupplyRole, number> };
+  /**
+   * Shares from a period before the latest one their reporter disclosed on the
+   * same basis: dated, never current rows. Absent from older servers.
+   */
+  earlier?: { says: SupplyRow[]; names: SupplyRow[] };
+  earlierCounts?: { says: Record<SupplyRole, number>; names: Record<SupplyRole, number> };
   access: "full" | "preview";
   lockedRows: number;
   totalRows: number;

package/src/api-client/tape.ts

@@ -39,6 +39,18 @@ export interface TapeSnapshot {
   corrections: number;
   cancels: number;
   connected: boolean;
+  /**
+   * Present when a window was asked for (`from`/`to`): the span served, its
+   * end clipped to the feed cutoff, and whether a channel held more than its
+   * capacity there, so only the first of its prints are listed. Absent from a
+   * server that predates windows, which answers with the latest tape.
+   */
+  window?: TapeRange & { truncated: { trades: boolean; quotes: boolean } };
+}
+/** A span of the tape as ISO instants; `to` is exclusive. */
+export interface TapeRange {
+  from: string;
+  to: string;
 }
 export type TapeFeedEvent = { type: "data"; payload: TapeSnapshot }
   | { type: "reset" | "disconnected"; reason: string };

package/src/api-client/types.ts

@@ -120,6 +120,12 @@ export interface ChatMessage {
   attachmentReview?: "pending" | "failed";
   /** What the message opens in the terminal (a Gloom Wire story or calendar). Only the server sets it. */
   paneLink?: ChatPaneLink;
+  /**
+   * An announcement Gloom posted, drawn as one. Only the server sets it, and
+   * only on one that still stands: a retracted announcement is the removal
+   * placeholder without it.
+   */
+  announcement?: true;
   clientStatus?: "sending" | "failed";
   clientError?: string | null;
   /** The idempotency key a local send went out with, so a retry repeats it. */
@@ -143,6 +149,21 @@ export interface ChatChannel {
   teamId?: string;
   dmUser?: ChatUserSummary | null;
   members?: ChatUserSummary[];
+  /**
+   * When the newest message you can see in a direct or group conversation was
+   * sent; null when it has none. Absent from channels of other kinds and from
+   * servers that do not report it.
+   */
+  lastMessageAt?: string | null;
+}
+
+/** Minimal identities scoped by the server to this channel and existing DMs. */
+export interface ChatMentionCandidate {
+  id: string;
+  username: string;
+  displayName: string | null;
+  channelActivityAt: string | null;
+  conversationActivityAt: string | null;
 }
 
 export interface ChatChannelState {
@@ -596,9 +617,25 @@ export interface CloudCdsHistoryPointPayload {
   reported: number;
   /** The contract on the run that day, e.g. "2031-12-20". */
   maturity: string;
+  /** For a line quoted upfront: that day's level in points on the line's coupon. */
+  upfrontPts?: number;
 }
 
-export interface CloudCdsHistoryResponse {
+/**
+ * Past 2,000bp a name is quoted in points upfront on its running coupon, the
+ * level and its moves alike; `spreadBp` and the bp moves stay beside them.
+ * Absent from servers before it, which read as `spread`.
+ */
+interface CloudCdsUpfrontQuote {
+  quote?: "spread" | "upfront";
+  /** The line's running coupon, bp. */
+  couponBp?: number | null;
+  upfrontPts?: number | null;
+  change1WPts?: number | null;
+  change1MPts?: number | null;
+}
+
+export interface CloudCdsHistoryResponse extends CloudCdsUpfrontQuote {
   source: string;
   /** The matched reference entity, or null when nothing on the tape matched. */
   issuer: string | null;
@@ -606,14 +643,31 @@ export interface CloudCdsHistoryResponse {
   currency: string | null;
   asOf: string | null;
   points: CloudCdsHistoryPointPayload[];
+  /**
+   * The last point's move over a week and a month in bp, on one contract and
+   * chained through the contract before across a roll, as the index board's.
+   * Null without a comparable level, or once the level is more than 5 trading
+   * days behind the tape; absent from servers before them.
+   */
+  change1W?: number | null;
+  change1M?: number | null;
+  /**
+   * Why the line has no level in the month to its newest print, when one
+   * cause explains it: `upfront-side-unknown` when the prints carry an
+   * upfront without the side that paid it and nothing else places the level.
+   */
+  noLevelReason?: string | null;
 }
 
 /** An issuer's latest 5Y level: the last point of its history over the last month. */
-export interface CloudCdsLevelPayload {
+export interface CloudCdsLevelPayload extends CloudCdsUpfrontQuote {
   /** The reference entity as the history response names it. */
   issuer: string;
   spreadBp: number;
   date: string;
+  /** As the history response's moves for the same name. */
+  change1W?: number | null;
+  change1M?: number | null;
 }
 
 export interface CloudCdsLevelsResponse {
@@ -1084,6 +1138,8 @@ export interface CloudTranscriptTurnPayload {
   isQa: boolean;
   /** Offset into the recording; null when the company published the transcript as a document. */
   startSeconds: number | null;
+  /** Where each of `paragraphs` starts in the recording, in seconds; absent without timings or on older servers. */
+  paragraphStarts?: number[];
 }
 
 interface CloudTranscriptKeyFigurePayload {
@@ -1130,6 +1186,20 @@ export interface CloudEarningsTranscriptPayload {
   updatedAt: string | null;
 }
 
+/**
+ * A call's audio to play beside its transcript. `kind` names what it is; a
+ * stored recording is the only kind so far.
+ */
+export interface CloudEarningsCallAudioPayload {
+  kind: "recording";
+  /** A signed address that plays until `expiresAt`, seeking included. */
+  url: string;
+  expiresAt: string;
+  durationSeconds: number | null;
+  bytes?: number;
+  contentType?: string;
+}
+
 export type CloudSearchDocType = "transcript" | "news" | "filing";
 
 export type CloudSearchSort = "relevance" | "newest" | "oldest";
@@ -1248,10 +1318,14 @@ interface CloudSecFilingPayload {
   primaryDocument?: string;
   primaryDocDescription?: string;
   items?: string;
+  /** SEC's period of report, YYYY-MM-DD: a 10-Q's or 10-K's balance-sheet date. Absent from older servers. */
+  reportDate?: string;
   cik: string;
   companyName?: string;
   filingUrl: string;
   primaryDocumentUrl?: string;
+  /** The filing's SEC file number for this company, empty when it has none. Absent from older servers. */
+  fileNumber?: string;
 }
 
 interface CloudSecDocumentPayload {
@@ -1473,6 +1547,11 @@ export interface CloudMarketResponse<T> {
   session?: unknown;
   /** "1day" when daily bars answer an intraday range: the listing has no intraday bars. */
   servedResolution?: unknown;
+  /**
+   * Untrusted: daily sessions the bars leave out and why, as
+   * `[{ date: "2020-04-20", reason: "non-positive-close" }]`. Validated by the history adapter.
+   */
+  omittedSessions?: unknown;
   /** Untrusted until the history adapter validates its boundary dates. */
   coverage?: CloudHistoryCoverage;
   providerMeta?: {
@@ -1517,6 +1596,15 @@ export interface CloudMarketBatchPayload<T> {
 
 export type CloudMarketScreenerCategory = "gainers" | "losers" | "most-active";
 
+/**
+ * What Gloom Cloud selects and ranks Gainers and Losers by: `regular` the last
+ * completed regular session's move, the Chg% a row shows; `extended` the
+ * latest print, after-hours or pre-market included. While the regular session
+ * trades the two are one list. A server that predates the choice ignores it
+ * and ranks by the latest print.
+ */
+export type CloudMoverSession = "regular" | "extended";
+
 /**
  * A movers row's quote sessions, under the quote's field names and meaning:
  * the session it was read in, the day its change is dated to, the last
@@ -1529,7 +1617,7 @@ export type CloudMoverSessionFields = Partial<Pick<Quote,
   | "preMarketPrice" | "preMarketChange" | "preMarketChangePercent"
   | "postMarketPrice" | "postMarketChange" | "postMarketChangePercent">>;
 
-/** price, change and changePercent are the live print the list is ranked by; the session fields say how it reads. */
+/** price, change and changePercent are the live print the server ranks the list by; the session fields say how it reads. */
 export interface CloudMarketScreenerItem extends CloudMoverSessionFields {
   rank: number;
   symbol: string;

package/src/api-client/upgrade-experiment.ts

@@ -1,3 +1,4 @@
+import { logFailure } from "../utils/log-failure";
 import type { ExperimentAnswer, StorageLike } from "./web-experiments";
 
 /**
@@ -36,11 +37,11 @@ function isVariant(value: unknown): value is UpgradePersonalizedVariant {
 }
 
 function read(storage: StorageLike | undefined, key: string): string | null {
-  try { return storage?.getItem(key) ?? null; } catch { return null; }
+  try { return storage?.getItem(key) ?? null; } catch { /* Intentional ignore: Private browsing may deny optional experiment storage. */ return null; }
 }
 
 function write(storage: StorageLike | undefined, key: string, value: string): void {
-  try { storage?.setItem(key, value); } catch { /* Storage is optional in private browsing. */ }
+  try { storage?.setItem(key, value); } catch { /* Intentional ignore: Private browsing may deny optional experiment storage. */ }
 }
 
 /**
@@ -77,7 +78,7 @@ export function createUpgradeExperimentSession() {
       if (inFlight) return inFlight;
       const request = (async () => {
         let answer: ExperimentAnswer;
-        try { answer = await ask(); } catch { return null; }
+        try { answer = await ask(); } catch (error) { logFailure("cloud-experiments", "Experiment exposure request failed")(error); return null; }
         const variant = answer.accepted && isVariant(answer.variant) ? answer.variant : null;
         answers.set(identity, variant);
         write(context.session, `${SESSION_PREFIX}${identity}`, variant ?? "excluded");

package/src/api-client/wall-experiments.ts

@@ -1,3 +1,4 @@
+import { logFailure } from "../utils/log-failure";
 import { EXPERIMENTS_STORAGE_KEY, storedExperimentAssignments, type ExperimentAnswer, type StorageLike } from "./web-experiments";
 
 export type WallExperiment = "wall_teaser" | "wall_teaser_signin";
@@ -25,11 +26,11 @@ function unit(context: WallExperimentContext, experiment: WallExperiment): strin
 }
 
 function read(storage: StorageLike | undefined, key: string): string | null {
-  try { return storage?.getItem(key) ?? null; } catch { return null; }
+  try { return storage?.getItem(key) ?? null; } catch { /* Intentional ignore: Private browsing may deny optional experiment storage. */ return null; }
 }
 
 function write(storage: StorageLike | undefined, key: string, value: string): void {
-  try { storage?.setItem(key, value); } catch { /* Storage is optional in private browsing. */ }
+  try { storage?.setItem(key, value); } catch { /* Intentional ignore: Private browsing may deny optional experiment storage. */ }
 }
 
 function isVariant(value: unknown): value is WallTeaserVariant {
@@ -77,7 +78,8 @@ export function createWallExperimentSession(experiment: WallExperiment = "wall_t
 
       const request = (async () => {
         let answer: ExperimentAnswer;
-        try { answer = await ask(storedVariant(context.local, experiment)); } catch {
+        try { answer = await ask(storedVariant(context.local, experiment)); } catch (error) {
+          logFailure("cloud-experiments", "Experiment exposure request failed")(error);
           // An older API (422), offline connection or timeout is not an exposure.
           return null;
         }

package/src/api-client/wall-summary.ts

@@ -1,3 +1,4 @@
+import { logFailure } from "../utils/log-failure";
 import { withDeadline } from "../utils/async-deadline";
 import { canonicalExchange } from "../utils/exchanges";
 import { CloudApiRequestTransport } from "./request";
@@ -43,7 +44,8 @@ export async function getWallSummary(wall: string, symbol: string, exchange?: st
       signal: controller.signal,
     }), 3_000, "Wall summary request timed out", (error) => controller.abort(error));
     return parseWallSummary(result);
-  } catch {
+  } catch (error) {
+    logFailure("cloud-wall-summary", "Wall summary request failed")(error);
     return null;
   }
 }

package/src/api-client/web-experiments.ts

@@ -13,6 +13,7 @@
  * later milestone as `experiments`, which the API turns into `exp_<key>` and
  * saves to the account once they sign in.
  */
+import { logFailure } from "../utils/log-failure";
 
 export interface StorageLike {
   getItem(key: string): string | null;
@@ -75,6 +76,7 @@ function read(storage: StorageLike, key: string): string | null {
   try {
     return storage.getItem(key);
   } catch {
+    // Intentional ignore: Private browsing may deny optional experiment storage.
     return null;
   }
 }
@@ -83,7 +85,7 @@ function write(storage: StorageLike, key: string, value: string): void {
   try {
     storage.setItem(key, value);
   } catch {
-    /* Private browsing still runs the terminal; the arm is just not remembered. */
+    // Intentional ignore: Private browsing may deny optional experiment storage.
   }
 }
 
@@ -112,7 +114,8 @@ export function exposeExperiment(experiment: string, env: WebExperimentEnvironme
     let answer: ExperimentAnswer;
     try {
       answer = await env.ask({ experiment, variant: assignments.get(experiment) });
-    } catch {
+    } catch (error) {
+      logFailure("cloud-experiments", "Experiment exposure request failed")(error);
       // Not counted, so the next page load in this session may ask again.
       return null;
     }

package/src/api-client/yield-curves.ts

@@ -33,9 +33,26 @@ export interface CloudCurveView {
     percentile1y: number | null;
     observations1y: number;
   }>;
+  /** Each tenor's 1D and 1W move ranked against its whole stored history; absent on servers older than it. */
+  moves?: CloudCurveMove[];
   checkedAt: string | null;
 }
 
+/** How big a tenor's move into the session was, against every move of the same horizon through it. */
+export interface CloudCurveMove {
+  tenor: string;
+  horizon: "1D" | "1W";
+  /** The session the move is measured from (the day before, or seven days before, within ten days). */
+  from: string | null;
+  /** Percentage points. */
+  change: number | null;
+  /** Midrank percentile of the move's size, 0 to 100; null below a year of moves. */
+  percentile: number | null;
+  observations: number;
+  /** The session the oldest ranked move ends on. */
+  since: string | null;
+}
+
 /** One tenor of a stored curve over time, oldest first (`GET /cloud/econ/curves/:curve/history`). */
 export interface CloudCurveHistory {
   curve: CloudCurveHeader;

package/src/app/command-bar-intro.ts

@@ -0,0 +1,38 @@
+import type { AppConfig } from "../types/config";
+
+/**
+ * The empty command bar's introduction: the Start Here rows in plain words and
+ * a placeholder with plain words to type. It shows for the first opens of the
+ * empty bar on this machine and then never again, so the bar settles into the
+ * list someone who knows the codes expects.
+ */
+const COMMAND_BAR_INTRO_OPENS = 10;
+
+/**
+ * Where the count stops: one past the last open with the introduction. It
+ * changes no more after that, so it is never saved again.
+ */
+const COMMAND_BAR_OPENS_DONE = COMMAND_BAR_INTRO_OPENS + 1;
+
+/**
+ * The saved count, or done when there is none. A new config starts at 0, so a
+ * config without one was made by a build from before the count, by someone who
+ * has been opening the bar all along.
+ */
+export function sanitizeCommandBarOpens(value: unknown): number {
+  if (typeof value !== "number" || !Number.isFinite(value)) return COMMAND_BAR_OPENS_DONE;
+  return Math.min(COMMAND_BAR_OPENS_DONE, Math.max(0, Math.floor(value)));
+}
+
+/** The count after the empty bar opens once more. */
+export function recordCommandBarOpen(opens: number | undefined): number {
+  return Math.min(COMMAND_BAR_OPENS_DONE, sanitizeCommandBarOpens(opens) + 1);
+}
+
+/**
+ * Whether the open bar is one of the first opens. The count already includes
+ * this open, so it reads the same for as long as the bar stays open.
+ */
+export function showsCommandBarIntro(config: Pick<AppConfig, "commandBarOpens">): boolean {
+  return sanitizeCommandBarOpens(config.commandBarOpens) <= COMMAND_BAR_INTRO_OPENS;
+}

package/src/app/keybindings/actions.ts

@@ -231,7 +231,7 @@ export const KEYBINDING_ACTIONS: readonly KeybindingActionDef[] = [
   {
     id: "pane-share",
     category: "Pane Management",
-    description: "Share the focused pane: post a picture to chat or copy its link.",
+    description: "Share the focused pane: copy a link to it.",
     defaults: ["CmdOrCtrl+Shift+S"],
   },
   {

package/src/app/pane-runtime/pane-template-runtime.ts

@@ -11,6 +11,7 @@ import type { DataProvider } from "../../types/data-provider";
 import type {
   PaneDef,
   PaneTemplateCreateOptions,
+  PaneTemplateDef,
   PaneTemplateInstanceConfig,
 } from "../../types/plugin";
 
@@ -35,6 +36,39 @@ interface UseAppPaneTemplateRuntimeOptions {
   tickerRepository: AppTickerRepositoryPort;
 }
 
+/**
+ * Whether shared data opens the pane by itself: the template takes it whole
+ * (a chart a plugin built), so its settings form would ask for what the data
+ * already says. A template that restores shares decides; any other takes data
+ * that holds something.
+ */
+function shareDataOpens(template: Pick<PaneTemplateDef, "publicShare">, shareData: unknown): boolean {
+  if (!shareData || typeof shareData !== "object" || Array.isArray(shareData)) return false;
+  const restore = template.publicShare?.restore;
+  if (!restore) return Object.keys(shareData).length > 0;
+  try {
+    return restore(shareData as Record<string, unknown>) !== null;
+  } catch {
+    // Intentional ignore: data the template cannot restore asks for its settings form instead.
+    return false;
+  }
+}
+
+/**
+ * Whether opening a template asks for its settings first, in the same form the
+ * command bar opens, which creates the pane when it is sent.
+ */
+export function templateAsksForSettings(
+  template: Pick<PaneTemplateDef, "wizard" | "publicShare">,
+  options: PaneTemplateCreateOptions | undefined,
+): boolean {
+  return !!template.wizard
+    && template.wizard.length > 0
+    && !options?.values
+    && !shareDataOpens(template, options?.shareData)
+    && (!options?.arg || template.wizard.some((step) => step.type === "textarea"));
+}
+
 export function useAppPaneTemplateRuntime({
   buildPaneInstance,
   dataProvider,
@@ -49,13 +83,7 @@ export function useAppPaneTemplateRuntime({
     const template = pluginRegistry.paneTemplates.get(templateId);
     if (!template) return;
 
-    // A template that asks for settings asks in the same form the command bar
-    // opens, which creates the pane when it is sent.
-    const asksForSettings = !!template.wizard
-      && template.wizard.length > 0
-      && !options?.values
-      && (!options?.arg || template.wizard.some((step) => step.type === "textarea"));
-    if (asksForSettings) {
+    if (templateAsksForSettings(template, options)) {
       openFormModal({ kind: "pane-template", templateId, arg: options?.arg, options });
       return;
     }

package/src/app/pane-runtime/plugin-bindings.ts

@@ -177,6 +177,10 @@ export function bindAppPanePluginRegistry({
       if (isDetachedWindow || isDialogOpen()) return;
       dispatch({ type: "SET_COMMAND_BAR", open: true, query });
     },
+    runCommandBarQuery: (query) => {
+      if (isDetachedWindow || isDialogOpen()) return;
+      dispatch({ type: "SET_COMMAND_BAR", open: true, query, launch: { kind: "run-query", query } });
+    },
     // Forms submit through the main window's state, so a detached window says where to go.
     openPluginCommandWorkflow: (commandId) => {
       if (isDetachedWindow) {

package/src/app/pane-runtime/ticker-open-runtime.ts

@@ -24,8 +24,8 @@ import {
   tickerOpenFailureMessage,
   type TickerOpenTarget,
 } from "../../tickers/open-target";
-import { AmbiguousTickerError, findExactTickerSearchMatch } from "../../tickers/search";
-import { isDialogOpen } from "../../ui/dialog-stack";
+import { findExactTickerSearchMatch } from "../../tickers/search";
+import { offerTickerListings, publishTickerOpenTarget as publishOpenTarget } from "./ticker-open-target";
 import { parsePublicTickerKey, publicTickerKey } from "../../utils/exchanges";
 import { attentionActionForPane, captureAttentionAction } from "../../telemetry/attention-counts";
 import { tickerHasListingSuffix } from "../../sources/listing-symbols";
@@ -79,11 +79,7 @@ export function useAppTickerOpenRuntime({
       return target;
     } catch (err) {
       if (!canPresentFeedback()) return null;
-      // Ticker search offers the listings, unless a dialog would sit over the bar.
-      if (err instanceof AmbiguousTickerError && !isDialogOpen()) {
-        dispatch({ type: "SET_COMMAND_BAR", open: true, query: rawSymbol,
-          launch: { kind: "ticker-search", query: rawSymbol } });
-      }
+      offerTickerListings(err, rawSymbol, dispatch);
       const message = err instanceof Error ? err.message : String(err);
       pluginRegistry.notify({ body: `Failed to open ${rawSymbol}: ${message}`, type: "error" });
       return null;
@@ -91,13 +87,7 @@ export function useAppTickerOpenRuntime({
   }, [dataProvider, dispatch, pluginRegistry, stateRef, tickerRepository]);
 
   const publishTickerOpenTarget = useCallback((target: TickerOpenTarget) => {
-    const currentTicker = stateRef.current.tickers.get(target.symbol);
-    if (currentTicker !== target.ticker) {
-      dispatch({ type: "UPDATE_TICKER", ticker: target.ticker });
-    }
-    if (target.created) {
-      pluginRegistry.events.emit("ticker:added", { symbol: target.symbol, ticker: target.ticker });
-    }
+    publishOpenTarget(target, { tickers: stateRef.current.tickers, dispatch, events: pluginRegistry.events });
   }, [dispatch, pluginRegistry.events, stateRef]);
 
   /**

package/src/app/pane-runtime/ticker-open-target.ts

@@ -0,0 +1,31 @@
+import type { Dispatch } from "react";
+import type { PluginRegistry } from "../../plugins/registry";
+import type { AppAction } from "../../state/app/context";
+import type { TickerRecord } from "../../types/ticker";
+import type { TickerOpenTarget } from "../../tickers/open-target";
+import { AmbiguousTickerError } from "../../tickers/search";
+import { isDialogOpen } from "../../ui/dialog-stack";
+
+/**
+ * A resolved open joins the app's tickers: the store takes the record when it
+ * is not the one it holds, and a ticker new to the app is announced once.
+ * Every open, from the command bar, a link or a pane, publishes it this way.
+ */
+export function publishTickerOpenTarget(target: TickerOpenTarget, { tickers, dispatch, events }: {
+  tickers: ReadonlyMap<string, TickerRecord>;
+  dispatch: Dispatch<AppAction>;
+  events: Pick<PluginRegistry["events"], "emit">;
+}): void {
+  if (tickers.get(target.symbol) !== target.ticker) {
+    dispatch({ type: "UPDATE_TICKER", ticker: target.ticker });
+  }
+  if (target.created) {
+    events.emit("ticker:added", { symbol: target.symbol, ticker: target.ticker });
+  }
+}
+
+/** An open whose symbol names several listings offers them in ticker search, unless a dialog would sit over the bar. */
+export function offerTickerListings(error: unknown, rawSymbol: string, dispatch: Dispatch<AppAction>): void {
+  if (!(error instanceof AmbiguousTickerError) || isDialogOpen()) return;
+  dispatch({ type: "SET_COMMAND_BAR", open: true, query: rawSymbol, launch: { kind: "ticker-search", query: rawSymbol } });
+}

package/src/app/runtime/broker-import.ts

@@ -8,7 +8,7 @@ import {
 import type { SyncBrokerInstanceResult } from "../../brokers/sync-broker-instance";
 import type { AppTickerRepositoryPort } from "../../core/app-service-ports";
 import type { PluginRegistry } from "../../plugins/registry";
-import { adoptHeldPortfolioCurrencies } from "../../plugins/builtin/portfolio-list/mutations";
+import { adoptHeldPortfolioCurrencies } from "../../portfolio/mutations";
 import { saveConfigImmediately } from "../../state/config-save-scheduler";
 import type { AppAction, AppState } from "../../state/app/context";
 import type { AppConfig } from "../../types/config";
@@ -18,6 +18,7 @@ import { getBrokerInstance } from "../../utils/broker-instances";
 export interface AppBrokerImportRuntime {
   importBrokerPositions: (
     instanceId: string,
+    /** What the sync reads. It lands on the app's tickers as they are when it commits, whatever was passed. */
     tickerMap?: Map<string, TickerRecord>,
     options?: BrokerImportOptions,
   ) => Promise<SyncBrokerInstanceResult>;
@@ -52,6 +53,13 @@ export function useBrokerImportRuntime({
   stateRef: { current: AppState };
   tickerRepository: AppTickerRepositoryPort;
 }): AppBrokerImportRuntime {
+  /**
+   * Commits a sync: carried onto the app as it is now (a pull or an edit while
+   * the broker answered stays) and handed to the app before anything is
+   * written. With a wait in between, a pull landing in it would be overwritten
+   * by this older copy and pushed from here as an edit. The writes start in
+   * the same tick, so the copy of anyone writing after lands on disk after it.
+   */
   const applyBrokerImportResult = useCallback(async (
     instanceId: string,
     result: SyncBrokerInstanceResult,
@@ -62,31 +70,27 @@ export function useBrokerImportRuntime({
     },
   ) => {
     throwIfBrokerImportCancelled(options?.signal);
-    dispatch({ type: "SET_BROKER_ACCOUNTS", instanceId, accounts: result.brokerAccounts });
-
-    const liveConfig = stateRef.current.config;
+    const live = stateRef.current;
+    result.rebase(live);
     const nextConfig = options?.callerOwnsConfig
-      ? (result.config !== baseConfig ? result.config : liveConfig)
-      : rebaseBrokerSyncConfig(liveConfig, baseConfig, result.config, instanceId);
-    if (nextConfig !== liveConfig) {
-      throwIfBrokerImportCancelled(options?.signal);
-      dispatch({ type: "SET_CONFIG", config: nextConfig });
-      await saveConfigImmediately(nextConfig);
-      throwIfBrokerImportCancelled(options?.signal);
-      pluginRegistry.events.emit("config:changed", { config: nextConfig });
+      ? (result.config !== baseConfig ? result.config : live.config)
+      : rebaseBrokerSyncConfig(live.config, baseConfig, result.config, instanceId);
+    const configChanged = nextConfig !== live.config;
+
+    dispatch({ type: "SET_BROKER_ACCOUNTS", instanceId, accounts: result.brokerAccounts });
+    if (configChanged) dispatch({ type: "SET_CONFIG", config: nextConfig });
+    for (const ticker of [...result.addedTickers, ...result.updatedTickers]) {
+      dispatch({ type: "UPDATE_TICKER", ticker });
     }
+    await Promise.all([result.commit(), configChanged ? saveConfigImmediately(nextConfig) : undefined]);
 
+    if (configChanged) pluginRegistry.events.emit("config:changed", { config: nextConfig });
     for (const ticker of result.addedTickers) {
-      throwIfBrokerImportCancelled(options?.signal);
       pluginRegistry.events.emit("ticker:added", { symbol: ticker.metadata.ticker, ticker });
     }
-    for (const ticker of [...result.addedTickers, ...result.updatedTickers]) {
-      throwIfBrokerImportCancelled(options?.signal);
-      dispatch({ type: "UPDATE_TICKER", ticker: { ...ticker } });
-    }
 
     for (const position of result.positions) {
-      throwIfBrokerImportCancelled(options?.signal);
+      if (options?.signal?.aborted) break;
       // Skip market data for broker option symbols; position marks are already available.
       // Position data (markPrice, marketValue, unrealizedPnl) is used directly.
       if (options?.refreshImportedTickers !== false && position.assetCategory !== "OPT") {
@@ -120,8 +124,6 @@ export function useBrokerImportRuntime({
       throwIfBrokerImportCancelled(options?.signal);
       options?.onCommitStart?.();
       commitStarted = true;
-      await result.commit();
-      throwIfBrokerImportCancelled(options?.signal);
       await applyBrokerImportResult(instanceId, result, baseConfig, {
         ...options,
         callerOwnsConfig: options?.config !== undefined,
@@ -155,7 +157,7 @@ export function useBrokerImportRuntime({
       deferPersistence: true,
       onResult: async (result, instance, previousConfig) => {
         if (!getBrokerInstance(stateRef.current.config.brokerInstances, instance.id)) return;
-        await result.commit();
+        // Startup syncs run beside the first pull: each lands on what it left.
         await applyBrokerImportResult(instance.id, result, previousConfig, {
           refreshImportedTickers: false,
         });