gloomberb 0.16.6 → 0.17.1

package/src/app/runtime/desktop-deeplink.ts

@@ -13,7 +13,8 @@ import type { DesktopWindowBridge } from "../../types/desktop-window";
 import { requestAccountManagementTab } from "../../plugins/builtin/account-management/navigation";
 import { openTeamPane } from "../../plugins/builtin/cloud/team/pane-request";
 import { chatController } from "../../plugins/builtin/chat/controller";
-import { getShare } from "../../shares/api";
+import { getShare, type ShareRecord } from "../../shares/api";
+import { openShareLink, registerShareOpener } from "../../shares/open";
 import { openPaneShare } from "../../shares/pane";
 import { PluginOffError, notifyPluginOff } from "../../plugins/plugin-off";
 import { materializeMarketplaceLayout } from "../../shares/portable-layout";
@@ -514,15 +515,44 @@ async function handleOpenLayout(
   notifySuccess(options.pluginRegistry, `Layout "${entry.name}" added.`);
 }
 
-async function handleOpenShare(
-  action: Extract<DesktopDeepLinkAction, { type: "open-share" }>,
+/**
+ * Opens a pane share in this app: the web app's `?share=` hand-off, a
+ * gloomberb://share link and a share link in chat all come through here.
+ * With `fallback`, a share this app cannot read or that holds a snapshot
+ * goes there (its web page) instead of to an error.
+ */
+async function openShareInApp(
+  id: string,
   pluginRegistry: PluginRegistry,
+  options: { retry: () => void; fallback?: () => void },
 ): Promise<void> {
-  const share = await getShare(action.id, fetch, { trackView: false });
-  if (!share) throw new Error("This share is unavailable or has expired.");
-  if (share.kind !== "pane") throw new Error("This link contains a snapshot, not a live pane.");
-  await openPaneShare(pluginRegistry, share.data);
-  notifySuccess(pluginRegistry, action.message);
+  let share: ShareRecord | null;
+  try {
+    share = await getShare(id, fetch, { trackView: false });
+  } catch (error) {
+    if (options.fallback) options.fallback();
+    else notifyError(pluginRegistry, error instanceof Error ? error.message : "Could not open shared pane.");
+    return;
+  }
+  if (!share) {
+    notifyError(pluginRegistry, "This share is unavailable or has expired.");
+    return;
+  }
+  if (share.kind !== "pane") {
+    if (options.fallback) options.fallback();
+    else notifyError(pluginRegistry, "This link contains a snapshot, not a live pane.");
+    return;
+  }
+  try {
+    await openPaneShare(pluginRegistry, share.data);
+    notifySuccess(pluginRegistry, "Opened shared pane.");
+  } catch (error) {
+    if (error instanceof PluginOffError) {
+      notifyPluginOff(pluginRegistry, error, options.retry);
+      return;
+    }
+    notifyError(pluginRegistry, error instanceof Error ? error.message : "Could not open shared pane.");
+  }
 }
 
 export function handleDesktopDeepLink(rawUrl: string, options: DesktopDeepLinkHandlerOptions): void {
@@ -569,13 +599,7 @@ export function handleDesktopDeepLink(rawUrl: string, options: DesktopDeepLinkHa
       handleOpenNews(action, options.pluginRegistry);
       return;
     case "open-share":
-      void handleOpenShare(action, options.pluginRegistry).catch((error) => {
-        if (error instanceof PluginOffError) {
-          notifyPluginOff(options.pluginRegistry, error, () => handleDesktopDeepLink(rawUrl, options));
-          return;
-        }
-        notifyError(options.pluginRegistry, error instanceof Error ? error.message : "Could not open shared pane.");
-      });
+      void openShareInApp(action.id, options.pluginRegistry, { retry: () => handleDesktopDeepLink(rawUrl, options) });
       return;
     case "open-layout":
       void handleOpenLayout(action, options).catch((error) => {
@@ -600,6 +624,15 @@ export function useDesktopDeepLinkRuntime({
   pluginRegistry: PluginRegistry;
   stateRef: { current: AppState };
 }) {
+  // Share links opened inside the app (chat's share chips) take the same path, in every renderer.
+  useEffect(() => {
+    if (!initialized) return;
+    return registerShareOpener((id, { fallback }) => openShareInApp(id, pluginRegistry, {
+      fallback,
+      retry: () => openShareLink(id, fallback),
+    }));
+  }, [initialized, pluginRegistry]);
+
   useEffect(() => {
     if (!initialized || desktopWindowKind === "detached" || !desktopDeepLinkBridge) return;
     return desktopDeepLinkBridge.subscribe((deeplink) => {

package/src/app/runtime/update.ts

@@ -10,13 +10,25 @@ import {
   performUpdate,
   type ReleaseInfo,
   type UpdateCheckResult,
+  type UpdateProgress,
 } from "../../updater";
 import { VERSION } from "../../version";
+import { debugLog } from "../../utils/debug-log";
 import { reportCrash } from "../../telemetry/crash-reports";
 import { runAutomated } from "../../telemetry/usage-counts";
 
 const UPDATE_CHECK_INTERVAL_MS = 60 * 60_000; // hourly
 
+const updateLog = debugLog.createLogger("update");
+
+/**
+ * The header and the command bar show a failed update's message, and the header
+ * cuts it to its room: the log keeps what the updater actually said.
+ */
+function logUpdateFailure(progress: UpdateProgress): void {
+  if (progress.phase === "error") updateLog.error("update failed", { error: progress.error });
+}
+
 /** An update is being downloaded, applied, or is downloaded and waiting for a restart. */
 function updateInFlight(progress: AppState["updateProgress"]): boolean {
   return progress?.phase === "downloading" || progress?.phase === "replacing" || progress?.phase === "ready";
@@ -53,6 +65,7 @@ export function useAppUpdateRuntime({
   const startUpdate = useCallback((release: ReleaseInfo) => {
     dispatch({ type: "SET_UPDATE_PROGRESS", progress: { phase: "downloading", percent: 0 } });
     void performUpdate(release, (progress) => {
+      logUpdateFailure(progress);
       dispatch({ type: "SET_UPDATE_PROGRESS", progress });
     });
   }, [dispatch]);
@@ -66,6 +79,7 @@ export function useAppUpdateRuntime({
     dispatch({ type: "SET_UPDATE_PROGRESS", progress: { phase: "replacing" } });
     void applyUpdate((progress) => {
       if (progress.phase === "error") restartingRef.current = false;
+      logUpdateFailure(progress);
       dispatch({ type: "SET_UPDATE_PROGRESS", progress });
     });
   }, [dispatch, enabled, isDetachedWindow, stateRef]);
@@ -91,6 +105,8 @@ export function useAppUpdateRuntime({
       return { kind: "error", error: message || "Update check failed" };
     });
 
+    if (result.kind === "error") updateLog.warn("update check failed", { error: result.error });
+
     if (!manual) {
       if (result.kind === "available") {
         dispatch({ type: "SET_UPDATE_AVAILABLE", release: result.release });

package/src/architecture/core-builtin-allowlist.json

@@ -40,7 +40,7 @@
   "src/layout-marketplace/gallery.tsx": ["cloud"],
   "src/layout-marketplace/linked-sync.ts": ["cloud"],
   "src/layout/desks.ts": ["chart-composer"],
-  "src/plugins/catalog-browser.ts": ["alerts","analytics","attention","awards","backtest","bond-calculator","catalysts","cds","central-bank-rates","changelog","chart-composer","clinical-trials","cloud","comment-letters","company-attention","company-kpis","connections","correlation","cot","cpi","credit-boards","credit-conditions","credit-documents","crypto-board","debt-maturities","dividend-yield","docs","doe","earnings-calls","earnings-ripple","econ","econ-statistics","equity-screener","estimate-revisions","executives","exposure","fear-greed","filing-events","futures","futures-curve","fx-matrix","gpu","help","insider","ipo-calendar","iv-history","jobs","kelly-sizer","layout-manager","macro-day","market-halts","market-heatmap","market-valuation","members","mna","money-markets","news","openfda","options","options-calculator","options-positioning","options-scenario","pe-band","perps","portfolio-list","power","rate-path","realized-vol","relative-rotation","research","research-search","revenue-breakdown","reverse-dcf","risk-factors","scanner","seasonality","sec","sectors","short-interest","short-volume","social-mentions","supply-chain","ticker-detail","time-sales","treasury-auctions","vol-surface","volatility","world-indices","world-venue-map","yield-curve"],
+  "src/plugins/catalog-browser.ts": ["alerts","analytics","attention","awards","backtest","bond-calculator","catalysts","cds","central-bank-rates","changelog","chart-composer","clinical-trials","cloud","comment-letters","commodities-energy","commodity-balances","company-attention","company-kpis","connections","correlation","cot","cpi","credit-boards","credit-conditions","credit-documents","crypto-board","debt-maturities","dividend-yield","docs","doe","earnings-calls","earnings-ripple","econ","econ-statistics","equity-screener","estimate-revisions","executives","exposure","fear-greed","filing-events","fixed-income","futures","futures-curve","fx-matrix","gpu","help","insider","ipo-calendar","iv-history","jobs","jodi","kelly-sizer","layout-manager","macro-day","market-halts","market-heatmap","market-valuation","members","mna","money-markets","news","openfda","options","options-calculator","options-positioning","options-scenario","pe-band","perps","portfolio-list","power","primary-dealers","rate-path","realized-vol","relative-rotation","research","research-search","revenue-breakdown","reverse-dcf","risk-factors","scanner","seasonality","sec","sectors","short-interest","short-volume","social-mentions","supply-chain","ticker-detail","time-sales","trace-bonds","treasury-auctions","treasury-daily","vol-surface","volatility","world-indices","world-venue-map","yield-curve"],
   "src/plugins/catalog-ui.ts": ["alerts","clinical-trials","cloud","comment-letters","custom-view","fear-greed","ipo-calendar","market-halts","market-heatmap","members","news","notes","openfda","research-search"],
   "src/plugins/catalog.ts": ["debug"],
   "src/remote/controller.ts": ["custom-view"],

package/src/architecture/dom-cell-metrics-allowlist.json

@@ -0,0 +1,102 @@
+{
+  "src/components/layout/pane/header.tsx": {
+    "uses": 2,
+    "why": "The title bar's inset for the window controls comes from the shell's header geometry, which the terminal shares, in cells."
+  },
+  "src/components/layout/pane/sizing.ts": {
+    "uses": 3,
+    "why": "Panes receive their size in cells (PaneProps); this gives the desktop's taller chrome row in those cells."
+  },
+  "src/components/layout/shell/drag/slide.ts": {
+    "uses": 4,
+    "why": "A dragged pane moves by offsets of the saved layout, which is kept in cells."
+  },
+  "src/components/layout/shell/pane/layers.tsx": {
+    "uses": 6,
+    "why": "Pane rectangles in the saved layout are in cells; this is where they become pixels."
+  },
+  "src/components/ui/select-button.tsx": {
+    "uses": 2,
+    "why": "A select's width is given in cells by the pane, as its terminal button's is."
+  },
+  "src/renderers/dom/data-table/dom.ts": {
+    "uses": 26,
+    "why": "The table's scroll and pointer API speaks rows and columns to callers shared with the terminal (j/k, paging, visible range); a row of text is one line tall."
+  },
+  "src/renderers/dom/data-table/index.tsx": {
+    "uses": 19,
+    "why": "Every pane gives its columns in cells (DataTableColumn.width) and rows are one line tall: the horizontal extent, the overflow decision, virtualization and paging follow from them."
+  },
+  "src/renderers/dom/data-table/row.tsx": {
+    "uses": 10,
+    "why": "Column widths and gaps are cells in the column model every pane uses; a row is one line tall."
+  },
+  "src/renderers/dom/desktop/controls.tsx": {
+    "uses": 6,
+    "why": "Callers give a button's size in cells; a framed field keeps its text one cell off its frame, as the terminal's does."
+  },
+  "src/renderers/dom/desktop/list-view.tsx": {
+    "uses": 2,
+    "why": "The caller gives a list's height in rows."
+  },
+  "src/renderers/dom/desktop/query-bar.tsx": {
+    "uses": 1,
+    "why": "The pane gives its search field's width in cells."
+  },
+  "src/renderers/dom/desktop/select-field.tsx": {
+    "uses": 2,
+    "why": "An inline select is one row tall, the row it sits in."
+  },
+  "src/renderers/dom/dom-ui-host.tsx": {
+    "uses": 6,
+    "why": "Exposes the cell size to components that still size in cells (chart bitmaps, the company logo)."
+  },
+  "src/renderers/dom/host/input.tsx": {
+    "uses": 3,
+    "why": "Callers give a field's width and height in cells; a one-line field is one row tall."
+  },
+  "src/renderers/dom/host/live-frame.ts": {
+    "uses": 8,
+    "why": "A resize's live frame is in cells, the pane's unit, until the pane renders at the new size."
+  },
+  "src/renderers/dom/host/mouse.ts": {
+    "uses": 10,
+    "why": "Pointer handlers receive cell coordinates, the event API every renderer shares."
+  },
+  "src/renderers/dom/host/scroll-box.tsx": {
+    "uses": 22,
+    "why": "The scroller's API (scrollTop, scrollBy, viewport) is in rows and columns for callers shared with the terminal; content insets are given in cells."
+  },
+  "src/renderers/dom/host/size-observer.ts": {
+    "uses": 6,
+    "why": "Observed sizes are reported in cells, as callers expect."
+  },
+  "src/renderers/dom/host/style.ts": {
+    "uses": 27,
+    "why": "Maps the shared Box and Text props that components give in cells (width, height, padding, margin, gap, position) to pixels."
+  },
+  "src/renderers/dom/host/surface-fit.ts": {
+    "uses": 4,
+    "why": "A chart takes its box when its cells come within a cell of it, because panes still count their space in cells."
+  },
+  "src/renderers/dom/host/tabs.tsx": {
+    "uses": 2,
+    "why": "A tab strip is one row tall, the row every caller reserves for it."
+  },
+  "src/renderers/dom/host/text.tsx": {
+    "uses": 2,
+    "why": "The ASCII wordmark draws one glyph per cell."
+  },
+  "src/renderers/dom/input-host.tsx": {
+    "uses": 4,
+    "why": "The viewport is reported in cells (useViewport), the unit every renderer shares."
+  },
+  "src/renderers/dom/native-renderer.ts": {
+    "uses": 4,
+    "why": "The renderer's width and height are reported in cells, the unit every renderer shares."
+  },
+  "src/renderers/dom/styles.css": {
+    "uses": 14,
+    "why": "Defines the cell size and the base line height; status, footer and hint lines are one row; a few insets are one cell, as the terminal's (the floating pane's two-cell grip, a query bar segment)."
+  }
+}

package/src/ask-gloom/pane-context.ts

@@ -1,8 +1,9 @@
+import type { ResolvedPane } from "../layout/pane-manager";
 import type { PluginRegistry } from "../plugins/registry";
-import { paneShowsPersonalData } from "../shares/personal-pane";
-import type { AppConfig, PaneInstanceConfig } from "../types/config";
+import { panePersonalData } from "../shares/personal-pane";
+import { resolveTickerForPane, type AppState } from "../state/app/context";
+import type { LayoutConfig } from "../types/config";
 import type { PaneSharePrivateFields } from "../types/plugin";
-import type { TickerRecord } from "../types/ticker";
 import type { AskGloomPaneAttachment } from "./pane-request";
 
 /** A handful of the pane's own settings is enough to say how it is set up. */
@@ -50,14 +51,13 @@ function functionCode(registry: Pick<PluginRegistry, "paneTemplates">, paneType:
 }
 
 export interface PaneAttachmentSource {
-  registry: Pick<PluginRegistry, "panes" | "paneTemplates" | "brokers" | "getPanePluginId" | "getBrokerPluginId">;
-  instance: PaneInstanceConfig;
+  registry: Pick<PluginRegistry, "paneTemplates" | "brokers" | "getPanePluginId" | "getBrokerPluginId">;
+  pane: Pick<ResolvedPane, "instance" | "def">;
+  state: AppState;
+  /** The layout the pane is in, as the share path reads it for `personalData`. */
+  layout: LayoutConfig;
   /** What the header calls it. */
   title: string;
-  symbol: string | null;
-  paneState?: Readonly<Record<string, unknown>>;
-  config: Pick<AppConfig, "portfolios" | "brokerInstances">;
-  tickers?: ReadonlyMap<string, TickerRecord>;
   /** The tab each of its tab strips has open, outermost first. */
   activeTabs?: readonly string[];
   visibleText: string | null;
@@ -70,16 +70,17 @@ export interface PaneAttachmentSource {
  */
 export function buildAskGloomPaneAttachment({
   registry,
-  instance,
+  pane,
+  state,
+  layout,
   title,
-  symbol,
-  paneState,
-  config,
-  tickers,
   activeTabs = [],
   visibleText,
 }: PaneAttachmentSource): AskGloomPaneAttachment {
-  const privateFields = registry.panes.get(instance.paneId)?.portableShare?.private;
+  const { instance } = pane;
+  const symbol = resolveTickerForPane(state, instance.instanceId);
+  const paneState = state.paneState[instance.instanceId];
+  const privateFields = pane.def.portableShare?.private;
   const args: Record<string, string> = {};
   const tabs = activeTabs.map((tab) => tab.trim()).filter(Boolean);
   if (tabs.length > 0) args.tab = tabs.join(" > ").slice(0, MAX_ARG_VALUE_LENGTH);
@@ -100,14 +101,17 @@ export function buildAskGloomPaneAttachment({
     symbol,
     args,
     visibleText,
-    personal: showsPersonalData({ registry, instance, paneState, symbol, config, tickers }),
+    personal: showsPersonalData({ registry, state, layout, pane }),
   };
 }
 
-/** A pane that cannot be read for it counts as personal: its contents then wait for a yes. */
-function showsPersonalData(source: Parameters<typeof paneShowsPersonalData>[0]): boolean {
+/**
+ * Whatever the pane shows as personal data, as sharing its picture reads it.
+ * A pane that cannot be read for it counts as personal: its contents then wait for a yes.
+ */
+function showsPersonalData(source: Parameters<typeof panePersonalData>[0]): boolean {
   try {
-    return paneShowsPersonalData(source);
+    return panePersonalData(source) !== null;
   } catch {
     return true;
   }

package/src/ask-gloom/pane-request.ts

@@ -23,8 +23,8 @@ export interface AskGloomPaneAttachment {
   /** Its text as drawn when asked, bounded; null when none could be read. */
   visibleText: string | null;
   /**
-   * It shows holdings, balances or account data, so Ask Gloom asks before
-   * anything it shows leaves the device.
+   * The pane shows personal data (`PaneDef.personalData`), so Ask Gloom
+   * asks before anything it shows leaves the device.
    */
   personal: boolean;
 }

package/src/cli/commands/fred-series.ts

@@ -19,18 +19,44 @@ export function isSpreadSeries(seriesId: string): boolean {
 }
 
 /**
- * The field a series' observations export under, named by their unit: a
- * spread in basis points (`value_bp`), a percent (`value_pct`), any other
- * unit slugged from FRED's own (`Index 1982-1984=100` is
- * `value_index_1982_1984_100`), and `value_unit_unknown` when FRED's
- * metadata did not come back. Never a bare `value`.
+ * The unit a series' observations export in, for the `currency_or_unit`
+ * column beside its bare `value`: `bp` for a spread (exported in basis
+ * points), `pct` for a percent, otherwise FRED's own units, with "annual
+ * rate" as the text header says it. Null when FRED's metadata did not come
+ * back.
  */
-export function fredValueKey(seriesId: string, units: string | null | undefined): string {
-  if (isSpreadSeries(seriesId)) return "value_bp";
-  const unit = units?.trim() ?? "";
-  if (/^percent$/i.test(unit)) return "value_pct";
-  const slug = unit.toLowerCase().replace(/[^a-z0-9]+/g, "_").replace(/^_+|_+$/g, "");
-  return `value_${slug || "unit_unknown"}`;
+export function fredUnit(seriesId: string, info: { units?: string | null; seasonalAdjustment?: string | null } | null | undefined): string | null {
+  if (isSpreadSeries(seriesId)) return "bp";
+  const units = info?.units?.trim();
+  if (!units) return null;
+  if (/^percent$/i.test(units)) return "pct";
+  const annualRate = /annual rate/i.test(info?.seasonalAdjustment ?? "") && !/annual rate/i.test(units);
+  return `${units}${annualRate ? ", annual rate" : ""}`;
+}
+
+/** How often a series observes, in FRED's word lower-cased: `Weekly, Ending Friday` is `weekly`. Null when FRED does not say. */
+export function fredInterval(frequency: string | null | undefined): string | null {
+  const word = frequency?.split(",")[0]?.trim().toLowerCase();
+  return word || null;
+}
+
+/**
+ * The observations from the series' first one on: Gloom Cloud answers a
+ * `--start` before a series begins with a blank row for every day in between
+ * (DEXSFUS from 1975 has five years of them before 1980-01-02). FRED's
+ * `observationStart` says where it begins; without it the blank rows before
+ * the first value go. Blank rows after it (a holiday's ".") stay.
+ */
+export function fredObservationsFromStart<T extends { date: string; value: number | null }>(
+  observations: readonly T[],
+  seriesStart: string | null | undefined,
+): T[] {
+  const first = seriesStart && /^\d{4}-\d{2}-\d{2}$/.test(seriesStart)
+    ? seriesStart
+    : observations.reduce<string | null>((earliest, observation) => (
+      observation.value != null && Number.isFinite(observation.value) && (!earliest || observation.date < earliest) ? observation.date : earliest
+    ), null);
+  return first ? observations.filter((observation) => observation.date >= first) : [...observations];
 }
 
 /**
@@ -144,3 +170,43 @@ export function fredEmptyMessage(startDate: string, latest: { date: string; valu
     ? `Latest observation: ${latest.date}${latest.value == null ? "" : ` (${latest.value})`}. Nothing on or after ${startDate}.`
     : "No results.";
 }
+
+/** What an export of nothing on or after `--start` says to try instead: a start that reaches the latest observation. */
+export function fredEmptyAdvice(seriesId: string, latest: { date: string } | null): string {
+  return latest
+    ? `Latest observation: ${latest.date}. Try: gloomberb fred ${seriesId} --start ${latest.date.slice(0, 4)}`
+    : `No observations came back for ${seriesId}. Try an earlier --start, or gloomberb fred --list for the series served.`;
+}
+
+/** A series as `fred --list` shows it. */
+export interface FredListRow {
+  id: string;
+  title: string;
+  group: string;
+}
+
+/** How well a word of the filter matches a series, best first: its id or group name, a word of its group or title, the start of its id, then any text. */
+function matchTier(term: string, row: FredListRow, words: readonly string[]): number {
+  if (row.id.toLowerCase() === term || row.group.toLowerCase() === term) return 0;
+  if (words.some((word) => word.startsWith(term))) return 1;
+  if (row.id.toLowerCase().startsWith(term)) return 2;
+  return 3;
+}
+
+/**
+ * The series that carry every word of the filter in their id, title or group,
+ * the ones it names first: a group or a word of the title ahead of the id that
+ * only has it inside (`fx` is the FX group, not FDEFX, whose id spells it).
+ * Catalog order breaks ties; an empty filter keeps the catalog as it is.
+ */
+export function filterFredSeries(rows: readonly FredListRow[], filter: string): FredListRow[] {
+  const terms = filter.toLowerCase().split(/\s+/).filter(Boolean);
+  const ranked = rows.flatMap((row, index) => {
+    const text = `${row.id} ${row.title} ${row.group}`.toLowerCase();
+    if (!terms.every((term) => text.includes(term))) return [];
+    const words = `${row.title} ${row.group}`.toLowerCase().split(/[^a-z0-9]+/).filter(Boolean);
+    const tiers = terms.map((term) => matchTier(term, row, words));
+    return [{ row, index, worst: Math.max(0, ...tiers), total: tiers.reduce((sum, tier) => sum + tier, 0) }];
+  });
+  return ranked.sort((a, b) => a.worst - b.worst || a.total - b.total || a.index - b.index).map((entry) => entry.row);
+}