gloomberb 0.16.1 → 0.16.2

package/src/plugins/builtin/chat/content/footer.tsx

@@ -6,7 +6,6 @@ import type { InlineTickerCatalogEntry } from "../../../../state/hooks/inline-ti
 import type { ContextMenuItem } from "../../../../types/context-menu";
 import { useRendererHost, useUiCapabilities } from "../../../../ui";
 import { useOptionalDialog, type PromptContext } from "../../../../ui/dialog";
-import { hasPublicChatProfileInfo } from "../message/profile-popover";
 import { chatMessageOpenTargets, type ChatOpenTarget } from "./open-targets";
 import { openChatImageViewer } from "../attachments/desktop";
 
@@ -28,7 +27,6 @@ export function useChatFooter({
   catalog,
   openTicker,
   openAttachPicker,
-  currentUserId,
   profilePopoverUser,
   showProfilePopover,
   closeProfilePopover,
@@ -45,6 +43,7 @@ export function useChatFooter({
   jumpToMessage,
   needsProfileSetup,
   openProfileSetup,
+  authorMessageAction,
 }: {
   /**
    * The composer or the New DM overlay owns the keyboard. Hints about the
@@ -64,7 +63,6 @@ export function useChatFooter({
   openTicker: (symbol: string) => void;
   /** Opens the composer's file picker; null where images cannot be attached. */
   openAttachPicker: (() => void) | null;
-  currentUserId: string | undefined;
   profilePopoverUser: ChatUserSummary | null;
   showProfilePopover: (user: ChatUserSummary) => void;
   closeProfilePopover: () => void;
@@ -83,6 +81,8 @@ export function useChatFooter({
   jumpToMessage: (messageId: string) => void;
   needsProfileSetup: boolean;
   openProfileSetup: () => void;
+  /** "Message @author" for the selected message, where its author can be written to. */
+  authorMessageAction: { label: string; run: () => void } | null;
 }) {
   const dialog = useOptionalDialog();
   const rendererHost = useRendererHost();
@@ -136,7 +136,6 @@ export function useChatFooter({
   }, [dialog, openTarget, openTargets]);
 
   const author = selectedMessage?.user ?? null;
-  const authorHasProfile = !!author && (author.id === currentUserId || hasPublicChatProfileInfo(author));
   // A card opened from the keyboard follows the selection: moving on closes it.
   const keyboardProfileRef = useRef(false);
   const toggleAuthorProfile = useCallback(() => {
@@ -186,6 +185,7 @@ export function useChatFooter({
     selectedIdx,
     setChannelNotificationsEnabled,
     toggleAuthorProfile,
+    authorMessageAction,
   });
   latest.current = {
     beginEditMessage,
@@ -203,7 +203,9 @@ export function useChatFooter({
     selectedIdx,
     setChannelNotificationsEnabled,
     toggleAuthorProfile,
+    authorMessageAction,
   };
+  const authorMessageLabel = composing ? null : authorMessageAction?.label ?? null;
 
   usePaneFooter("chat", () => {
     const hints: PaneHint[] = [];
@@ -213,7 +215,8 @@ export function useChatFooter({
       else if (canSend) hints.push({ id: "reply", key: "Enter", label: "reply", title: "Reply", onPress: () => latest.current.beginReplyTo(latest.current.selectedIdx, { deferFocus: true }) });
       if (canEdit) hints.push({ id: "edit", key: "e", label: "dit", title: "Edit Message", onPress: () => { latest.current.beginEditMessage(latest.current.selectedIdx, { deferFocus: true }); } });
       if (openTargets.length > 0) hints.push({ id: "open", key: "o", label: "pen", title: openTargetTitle, onPress: () => { void latest.current.openSelectedTargets(); } });
-      if (authorHasProfile) hints.push({ id: "profile", key: "p", label: "rofile", title: "Show Profile", onPress: () => latest.current.toggleAuthorProfile() });
+      // Every author has a card, if only their name and a way to write to them.
+      if (author) hints.push({ id: "profile", key: "p", label: "rofile", title: "Show Profile", onPress: () => latest.current.toggleAuthorProfile() });
     } else if (!composing && canSend) {
       hints.push({ id: "compose", key: "i", label: " compose", title: "Compose", onPress: () => queueMicrotask(() => latest.current.focusComposer()) });
     }
@@ -235,6 +238,11 @@ export function useChatFooter({
     }
 
     const menu: ContextMenuItem[] = [];
+    // No key of its own: a stray press would start a conversation. The pane
+    // menu (.) and a right-click on the name reach it.
+    if (authorMessageLabel) {
+      menu.push({ id: "message-author", label: authorMessageLabel, onSelect: () => latest.current.authorMessageAction?.run() });
+    }
     if (canCycleChannels) {
       menu.push(
         { id: "previous-channel", label: "Previous Channel", accelerator: "[", onSelect: () => { latest.current.cycleChannel(-1); } },
@@ -255,7 +263,8 @@ export function useChatFooter({
     }
     return { hints, menu };
   }, [
-    authorHasProfile,
+    author,
+    authorMessageLabel,
     canAttachImages,
     failedSend,
     canCycleChannels,

package/src/plugins/builtin/chat/content/index.tsx

@@ -1,4 +1,4 @@
-import { Box, Text, useUiCapabilities } from "../../../../ui";
+import { Box, Text, useContextMenu, useUiCapabilities } from "../../../../ui";
 import { useState, useEffect, useRef, useCallback, useMemo, useSyncExternalStore } from "react";
 import { PageStackView } from "../../../../components/ui";
 import { type ScrollBoxRenderable, type TextareaRenderable } from "../../../../ui";
@@ -34,11 +34,18 @@ import {
 import { buildChatUserByUsername } from "./user-map";
 import { useChatComposerRuntime } from "./composer-runtime";
 import { useChatMessageSelection } from "./selection-runtime";
-import type { ChatAttachment, ChatMessage } from "../../../../api-client";
+import type { ChatAttachment, ChatMessage, ChatUserSummary } from "../../../../api-client";
 import { DesktopChatDropOverlay, DesktopChatDropTarget } from "../attachments/desktop";
 import { uploadFromTransferFile, type TransferFile } from "../attachments/transfer";
 import { readChatImageFiles } from "../attachments/files";
 import { NewDmDialog } from "./new-dm-dialog";
+import {
+  describeConversationStartError,
+  directMessageAction,
+  findDirectChannelWith,
+} from "../direct-messages";
+import type { ChatUserAnchor, ChatUserContextMenuEvent } from "../message/types";
+import type { ContextMenuItem } from "../../../../types/context-menu";
 import { usePluginAppActions } from "../../../runtime";
 import { openTeamPane } from "../../cloud/team/pane-request";
 import { teamStore } from "../../cloud/team/store";
@@ -281,22 +288,29 @@ export function ChatContent({
     dismissProfilePopover,
     hoverProfilePopover,
     ownProfileConfigured,
+    profilePopoverAnchor,
     profilePopoverUser,
     scheduleProfilePopoverClose,
     showProfilePopover,
     toggleProfilePopover,
   } = useChatProfilePopover(focused ? user?.id : undefined);
 
-  const showUserProfilePopover = useCallback((targetUser: Parameters<typeof showProfilePopover>[0]) => {
-    showProfilePopover(targetUser, { ownProfile: targetUser.id === user?.id });
-  }, [showProfilePopover, user?.id]);
+  // `p` on the selected message: the card opens just below that message.
+  const selectedMessageId = messages[selectedIdx]?.id ?? null;
+  const showUserProfilePopover = useCallback((targetUser: ChatUserSummary) => {
+    const element = selectedMessageId ? messageElementsRef.current.get(selectedMessageId) : null;
+    showProfilePopover(targetUser, {
+      ownProfile: targetUser.id === user?.id,
+      anchor: (element as ChatUserAnchor | undefined) ?? null,
+    });
+  }, [selectedMessageId, showProfilePopover, user?.id]);
 
-  const hoverUserProfile = useCallback((targetUser: Parameters<typeof showProfilePopover>[0]) => {
-    hoverProfilePopover(targetUser, { ownProfile: targetUser.id === user?.id });
+  const hoverUserProfile = useCallback((targetUser: ChatUserSummary, anchor?: ChatUserAnchor) => {
+    hoverProfilePopover(targetUser, { ownProfile: targetUser.id === user?.id, anchor });
   }, [hoverProfilePopover, user?.id]);
 
-  const toggleUserProfile = useCallback((targetUser: Parameters<typeof showProfilePopover>[0]) => {
-    toggleProfilePopover(targetUser, { ownProfile: targetUser.id === user?.id });
+  const toggleUserProfile = useCallback((targetUser: ChatUserSummary, anchor?: ChatUserAnchor) => {
+    toggleProfilePopover(targetUser, { ownProfile: targetUser.id === user?.id, anchor });
   }, [toggleProfilePopover, user?.id]);
 
   const openProfileSetup = useCallback(() => {
@@ -433,17 +447,6 @@ export function ChatContent({
     return true;
   }, [channelListOpen, focusChannelSidebar, openChannelList, stackedNav]);
 
-  const openConversationFromDialog = useCallback(async (usernames: string[]) => {
-    const channel = usernames.length === 1
-      ? await controller.openDirectChannel({ username: usernames[0] })
-      : await controller.openGroupChannel({ usernames });
-    expandDirectSection();
-    selectSidebarChannel(channel.id);
-    setChannelListOpen(false);
-    setSidebarFocused(false);
-    closeNewDmDialog();
-  }, [closeNewDmDialog, controller, expandDirectSection, selectSidebarChannel, setSidebarFocused]);
-
   useEffect(() => {
     if (!focused && newDmOpen) {
       closeNewDmDialog();
@@ -471,6 +474,10 @@ export function ChatContent({
     }).catch(() => {});
   }, [controller]);
 
+  const reportConversationStartError = useCallback((error: unknown, usernames: string[]) => {
+    notify({ body: describeConversationStartError(error, usernames, userByUsername), type: "error" });
+  }, [notify, userByUsername]);
+
   const removeDraftAttachment = useCallback((localId: string) => {
     controller.removeChannelAttachment(channelIdRef.current, localId);
   }, [controller]);
@@ -535,9 +542,95 @@ export function ChatContent({
     useDefaultControllerChannel,
     draftAttachmentCount: draftAttachments.length,
     onPastedImagePaths: !nativePaneChrome && canAttach ? handlePastedImagePaths : undefined,
+    onConversationStartError: reportConversationStartError,
   });
   replaceComposerDraftRef.current = replaceComposerDraft;
 
+  // A conversation just opened or started: selected in the sidebar, with the
+  // composer ready to write in.
+  const showConversation = useCallback((nextChannelId: string) => {
+    expandDirectSection();
+    selectSidebarChannel(nextChannelId);
+    setChannelListOpen(false);
+    setSidebarFocused(false);
+    closeNewDmDialog();
+    closeProfilePopover();
+    if (canSend) focusComposer();
+  }, [canSend, closeNewDmDialog, closeProfilePopover, expandDirectSection, focusComposer, selectSidebarChannel, setSidebarFocused]);
+
+  const openConversationFromDialog = useCallback(async (usernames: string[]) => {
+    const channel = usernames.length === 1
+      ? await controller.openDirectChannel({ username: usernames[0] })
+      : await controller.openGroupChannel({ usernames });
+    showConversation(channel.id);
+  }, [controller, showConversation]);
+
+  const directMessageContext = useMemo(
+    () => ({ currentUserId: user?.id, channels, canSend }),
+    [canSend, channels, user?.id],
+  );
+
+  /** "Message @name": opens the DM you share, or starts one and opens it. */
+  const messageUser = useCallback(async (target: ChatUserSummary) => {
+    const action = directMessageAction(target, directMessageContext);
+    if (!action || action.kind === "refused") return;
+    const existing = action.kind === "open" ? findDirectChannelWith(channels, target) : null;
+    if (existing) {
+      showConversation(existing.id);
+      return;
+    }
+    try {
+      const channel = await controller.openDirectChannel({ username: action.username });
+      showConversation(channel.id);
+    } catch (error) {
+      notify({ body: describeConversationStartError(error, [action.username], userByUsername), type: "error" });
+    }
+  }, [channels, controller, directMessageContext, notify, showConversation, userByUsername]);
+
+  const pinUserProfile = useCallback((target: ChatUserSummary, anchor?: ChatUserAnchor) => {
+    showProfilePopover(target, { ownProfile: target.id === user?.id, pin: true, anchor });
+  }, [showProfilePopover, user?.id]);
+
+  const { showContextMenu } = useContextMenu();
+  const openUserContextMenu = useCallback((target: ChatUserSummary, event: ChatUserContextMenuEvent, anchor?: ChatUserAnchor) => {
+    const items: ContextMenuItem[] = [];
+    const action = directMessageAction(target, directMessageContext);
+    // Shown grayed out where their settings refuse it, so the menu does not just vanish.
+    if (action) {
+      items.push({
+        id: "chat-user:message",
+        label: action.menuLabel,
+        enabled: action.kind !== "refused",
+        onSelect: () => { void messageUser(target); },
+      });
+    }
+    items.push({ id: "chat-user:profile", label: "Show Profile", onSelect: () => pinUserProfile(target, anchor) });
+    void showContextMenu({ kind: "chat-user", userId: target.id, username: target.username }, items, event);
+  }, [directMessageContext, messageUser, pinUserProfile, showContextMenu]);
+  // Messages are memoized; they keep one handler that runs the latest menu.
+  const openUserContextMenuRef = useRef(openUserContextMenu);
+  openUserContextMenuRef.current = openUserContextMenu;
+  const onUserContextMenu = useCallback((target: ChatUserSummary, event: ChatUserContextMenuEvent, anchor?: ChatUserAnchor) => {
+    openUserContextMenuRef.current(target, event, anchor);
+  }, []);
+
+  const profileDirectMessage = useMemo(() => (
+    profilePopoverUser ? directMessageAction(profilePopoverUser, directMessageContext) : null
+  ), [directMessageContext, profilePopoverUser]);
+  const profileMessageAction = useMemo(() => {
+    if (!profileDirectMessage || profileDirectMessage.kind === "refused" || !profilePopoverUser) return null;
+    const target = profilePopoverUser;
+    return { label: profileDirectMessage.buttonLabel, onPress: () => { void messageUser(target); } };
+  }, [messageUser, profileDirectMessage, profilePopoverUser]);
+
+  const selectedMessageAuthor = selectionActive && !sidebarFocused ? messages[selectedIdx]?.user ?? null : null;
+  const authorMessageAction = useMemo(() => {
+    const action = selectedMessageAuthor ? directMessageAction(selectedMessageAuthor, directMessageContext) : null;
+    if (!action || action.kind === "refused" || !selectedMessageAuthor) return null;
+    const target = selectedMessageAuthor;
+    return { label: action.menuLabel, run: () => { void messageUser(target); } };
+  }, [directMessageContext, messageUser, selectedMessageAuthor]);
+
   const moveMentionSelection = useCallback((direction: "up" | "down") => {
     if (mentionSuggestions.length === 0) return false;
     setMentionSelectedIndex((current) => {
@@ -704,7 +797,6 @@ export function ChatContent({
     catalog,
     openTicker,
     openAttachPicker: canAttach && nativePaneChrome ? () => attachPickerRef.current?.() : null,
-    currentUserId: user?.id,
     profilePopoverUser,
     showProfilePopover: showUserProfilePopover,
     closeProfilePopover,
@@ -721,6 +813,7 @@ export function ChatContent({
     jumpToMessage,
     needsProfileSetup: !!user?.id && ownProfileConfigured === false,
     openProfileSetup,
+    authorMessageAction,
   });
 
   const chatContentBg = focused && showChannelSidebar && !sidebarFocused
@@ -762,7 +855,9 @@ export function ChatContent({
       height={height}
       userByUsername={userByUsername}
       currentUserId={user?.id}
+      channels={channels}
       onCancel={closeNewDmDialog}
+      onOpenChannel={showConversation}
       onSubmit={openConversationFromDialog}
     />
   ) : null;
@@ -809,6 +904,7 @@ export function ChatContent({
         latestEditableMessageId={latestEditableMessageId}
         openTicker={openTicker}
         profilePopoverUser={profilePopoverUser}
+        profilePopoverAnchor={profilePopoverAnchor}
         registerMessageElement={registerMessageElement}
         scheduleProfilePopoverClose={scheduleProfilePopoverClose}
         scrollRef={scrollRef}
@@ -821,6 +917,9 @@ export function ChatContent({
         user={user}
         userByUsername={userByUsername}
         onSetUpProfile={openProfileSetup}
+        onUserContextMenu={onUserContextMenu}
+        profileMessageAction={profileMessageAction}
+        profileMessageRefusal={profileDirectMessage?.refusal ?? null}
       />
 
       {stackedNav ? null : newDmDialog}