gloomberb 0.15.6 → 0.15.7

package/src/app/pane-runtime/ticker-open-runtime.ts

@@ -23,8 +23,9 @@ import {
   type TickerOpenTarget,
 } from "../../tickers/open-target";
 import { AmbiguousTickerError, findExactTickerSearchMatch } from "../../tickers/search";
+import { isDialogOpen } from "../../ui/dialog-stack";
 import { parsePublicTickerKey } from "../../utils/exchanges";
-import { tickerHasYahooSuffix } from "../../sources/yahoo-finance/symbols";
+import { tickerHasListingSuffix } from "../../sources/listing-symbols";
 import { instrumentFromTicker } from "../../market-data/request-types";
 import { tickerInstrumentLabel } from "../../tickers/instrument-label";
 
@@ -75,7 +76,8 @@ export function useAppTickerOpenRuntime({
       return target;
     } catch (err) {
       if (!canPresentFeedback()) return null;
-      if (err instanceof AmbiguousTickerError) {
+      // Ticker search offers the listings, unless a dialog would sit over the bar.
+      if (err instanceof AmbiguousTickerError && !isDialogOpen()) {
         dispatch({ type: "SET_COMMAND_BAR", open: true, query: rawSymbol,
           launch: { kind: "ticker-search", query: rawSymbol } });
       }
@@ -114,7 +116,7 @@ export function useAppTickerOpenRuntime({
     if (!options?.forceNewPane && !existing && instrument === null && !target.ticker.metadata.broker_contracts?.length) {
       existing = findFixedTickerPaneForSymbol(currentLayout, paneType, symbol);
     }
-    if (!options?.forceNewPane && !existing && !instrument && (parsePublicTickerKey(symbol).exchange || tickerHasYahooSuffix(symbol))) {
+    if (!options?.forceNewPane && !existing && !instrument && (parsePublicTickerKey(symbol).exchange || tickerHasListingSuffix(symbol))) {
       existing = currentLayout.instances.find((instance) => {
         if (instance.paneId !== paneType || instance.binding?.kind !== "fixed" || instance.binding.instrument || !isPaneInLayout(currentLayout, instance.instanceId)) return false;
         const ticker = currentState.tickers.get(instance.binding.symbol);

package/src/app/runtime/broker-import.ts

@@ -87,7 +87,7 @@ export function useBrokerImportRuntime({
 
     for (const position of result.positions) {
       throwIfBrokerImportCancelled(options?.signal);
-      // Skip Yahoo Finance for broker option symbols; position marks are already available.
+      // Skip market data for broker option symbols; position marks are already available.
       // Position data (markPrice, marketValue, unrealizedPnl) is used directly.
       if (options?.refreshImportedTickers !== false && position.assetCategory !== "OPT") {
         refreshQuote(position.ticker, position.exchange, undefined, 1);

package/src/app/runtime/desktop-menu.ts

@@ -4,9 +4,12 @@ import type { PluginRegistry } from "../../plugins/registry";
 import type { AppAction, AppState } from "../../state/app/context";
 import type { DesktopApplicationMenuBridge } from "../../types/desktop-menu";
 import type { DesktopWindowBridge } from "../../types/desktop-window";
+import { isDialogOpen } from "../../ui/dialog-stack";
 import type { RendererHost } from "../../ui/host";
 import { recordFunctionOpen } from "../../telemetry/usage-counts";
 
+const OPENS_OVER_DIALOGS = new Set<string>(["open-command-bar", "open-plugin-workflow", "open-builtin-workflow"]);
+
 export function useDesktopApplicationMenuRuntime({
   desktopApplicationMenuBridge,
   desktopWindowKind,
@@ -27,6 +30,11 @@ export function useDesktopApplicationMenuRuntime({
   useEffect(() => {
     if (desktopWindowKind !== "main" || !desktopApplicationMenuBridge) return;
     return desktopApplicationMenuBridge.subscribe((command) => {
+      // The native menu stays reachable over a dialog, accelerators included.
+      // A bar opened there would sit over the dialog without its keys, and Esc
+      // would close the dialog under it; a form would stack over one the user
+      // has not finished. Both wait for the dialog to close.
+      if (OPENS_OVER_DIALOGS.has(command.type) && isDialogOpen()) return;
       switch (command.type) {
         case "open-command-bar":
           dispatch({ type: "SET_COMMAND_BAR", open: true, query: command.query });
@@ -35,12 +43,7 @@ export function useDesktopApplicationMenuRuntime({
           pluginRegistry.openPluginCommandWorkflow(command.commandId);
           break;
         case "open-builtin-workflow":
-          dispatch({
-            type: "SET_COMMAND_BAR",
-            open: true,
-            query: "",
-            launch: { kind: "builtin-workflow", actionId: command.actionId },
-          });
+          pluginRegistry.openBuiltInWorkflow(command.actionId);
           break;
         case "open-url":
           void rendererHost.openExternal(command.url).catch((error) => {

package/src/app/runtime/plugin-bindings.ts

@@ -9,6 +9,7 @@ import type { MarketDataCoordinator } from "../../market-data/coordinator";
 import { instrumentFromTicker } from "../../market-data/request-types";
 import type { PluginRegistry } from "../../plugins/registry";
 import { saveConfigImmediately } from "../../state/config-save-scheduler";
+import { settleWithin } from "../../utils/async-deadline";
 import type { AppAction, AppState } from "../../state/app/context";
 import type { AppConfig, BrokerInstanceConfig } from "../../types/config";
 import type { DataProvider } from "../../types/data-provider";
@@ -18,6 +19,9 @@ import {
   getBrokerInstance,
 } from "../../utils/broker-instances";
 
+/** How long removing a profile waits for its adapter to disconnect before going on without it. */
+const ADAPTER_DISCONNECT_WAIT_MS = 5_000;
+
 export function bindPluginRegistryRuntimeAccess({
   dataProvider,
   dispatch,
@@ -186,8 +190,10 @@ export function bindPluginRegistryRuntimeAccess({
 
       clearPersistedBrokerAccounts(pluginRegistry.persistence.resources, instance);
 
+      // Best effort: an adapter that throws, rejects or never answers (a desktop
+      // call to a busy Bun process) must not keep the profile.
       const broker = pluginRegistry.brokers.get(instance.brokerType);
-      await broker?.disconnect?.(instance).catch(() => {});
+      await settleWithin(Promise.resolve().then(() => broker?.disconnect?.(instance)), ADAPTER_DISCONNECT_WAIT_MS);
 
       // A portfolio another profile of the account can keep (the account switched
       // to or from sign-in) goes to that profile; only this profile's positions go.

package/src/app/runtime/ticker-refresh.ts

@@ -96,7 +96,7 @@ export function useTickerRefreshRuntime({
       if (quote.currency) void marketData.loadFxRate(quote.currency).catch(() => {});
       void marketData.loadFxRate(baseCurrency).catch(() => {});
     } catch {
-      // Silently fail - the list can fall back to stale cache or Yahoo.
+      // Silently fail - the list can fall back to stale cache or the backend.
     } finally {
       quoteRefreshInFlight.delete(key);
     }

package/src/app.tsx

@@ -19,6 +19,7 @@ import { DetachedPaneShell } from "./components/layout/detached-pane-shell";
 import { TransientLayoutProvider } from "./components/layout/transient-layout";
 import { CommandBar } from "./components/command-bar/surface";
 import { OnboardingWizard } from "./components/onboarding/onboarding-wizard";
+import { CompanyPickerHost } from "./plugins/builtin/cloud/company-picker";
 import { SignInGate } from "./components/sign-in-gate";
 import { useDialog } from "./ui/dialog";
 import { PluginRegistry } from "./plugins/registry";
@@ -39,6 +40,7 @@ import { useBrokerImportRuntime } from "./app/runtime/broker-import";
 import { useDesktopDeepLinkRuntime } from "./app/runtime/desktop-deeplink";
 import { useDesktopApplicationMenuRuntime } from "./app/runtime/desktop-menu";
 import { useAppGlobalShortcuts } from "./app/global-shortcuts";
+import { AppDialogBridge } from "./app/dialog-bridge";
 import { KeybindingsProvider, useResolvedKeybindings } from "./app/keybindings";
 import { useAppPaneRuntime } from "./app/pane-runtime";
 import { bindPluginRegistryRuntimeAccess } from "./app/runtime/plugin-bindings";
@@ -181,6 +183,10 @@ function AppInner({
   const toast = useToastHost();
   const isDetachedWindow = desktopWindowBridge?.kind === "detached";
   const detachedPaneId = isDetachedWindow ? desktopWindowBridge.paneId ?? null : null;
+  const focusDetachedPane = useMemo(() => {
+    const focus = desktopWindowBridge?.kind === "main" ? desktopWindowBridge.focusDetachedPane : undefined;
+    return focus ? (paneId: string) => { void focus(paneId).catch(() => {}); } : undefined;
+  }, [desktopWindowBridge]);
   const [desktopDockPreview, setDesktopDockPreview] = useState<DesktopDockPreviewState | null>(null);
   const [commandBarNativeOccluder, setCommandBarNativeOccluder] = useState<LayoutBounds | null>(null);
   appActiveRef.current = appActive;
@@ -354,6 +360,7 @@ function AppInner({
     dialog,
     dispatch,
     externalPlugins,
+    focusDetachedPane,
     isDetachedWindow,
     notify,
     persistConfig,
@@ -409,6 +416,7 @@ function AppInner({
   if (desktopWindowBridge?.kind === "detached" && desktopWindowBridge.paneId) {
     return (
       <KeybindingsProvider value={keybindings}>
+        <AppDialogBridge />
         <ContextMenuProvider pluginRegistry={pluginRegistry}>
           <RemoteControlHost
             adapter={remoteControlAdapter}
@@ -432,6 +440,7 @@ function AppInner({
 
   return (
     <KeybindingsProvider value={keybindings}>
+    <AppDialogBridge />
     <ContextMenuProvider pluginRegistry={pluginRegistry}>
       <RemoteControlHost
         adapter={remoteControlAdapter}
@@ -448,6 +457,8 @@ function AppInner({
           <TransientLayoutProvider>
             <Shell
               pluginRegistry={pluginRegistry}
+              dataProvider={dataProvider}
+              tickerRepository={tickerRepository}
               desktopWindowBridge={desktopWindowBridge}
               desktopDockPreview={desktopDockPreview}
               commandBarNativeOccluder={commandBarNativeOccluder}
@@ -460,6 +471,7 @@ function AppInner({
               }}
             />
           </TransientLayoutProvider>
+          {!onboardingActive ? <CompanyPickerHost pluginRegistry={pluginRegistry} /> : null}
           {onboardingActive && onOnboardingComplete ? (
             <OnboardingWizard
               pluginRegistry={pluginRegistry}

package/src/brokers/directory.ts

@@ -4,6 +4,7 @@
  * adapter. One broker offered both ways is one entry with two methods, so Add
  * Broker and onboarding list "Interactive Brokers" once.
  */
+import { t, tf } from "../i18n";
 import type { BrokerAdapter } from "../types/broker";
 import type { SignedInBroker } from "./signed-in/client";
 import { SIGNED_IN_BROKER_TYPE } from "./signed-in/profile";
@@ -48,9 +49,17 @@ export function buildBrokerDirectory({
   return [...entries.values()].sort((left, right) => left.name.localeCompare(right.name));
 }
 
+/** How a broker connects, beside its name in a list of brokers. */
+export function brokerMethodSummary(entry: BrokerDirectoryEntry): string {
+  const signsIn = entry.methods.some((method) => method.kind === "signed-in");
+  const onDevice = entry.methods.some((method) => method.kind === "device");
+  if (signsIn && onDevice) return t("Sign in, or on this device");
+  return signsIn ? t("Sign in") : t("On this device");
+}
+
 export function brokerMethodLabel(entry: BrokerDirectoryEntry, method: BrokerMethod): string {
   if (method.kind === "signed-in") {
-    return entry.methods.some((candidate) => candidate.kind === "device") ? "Sign in (recommended)" : "Sign in";
+    return entry.methods.some((candidate) => candidate.kind === "device") ? t("Sign in (recommended)") : t("Sign in");
   }
-  return entry.methods.length > 1 ? `On this device (${method.adapter.name})` : method.adapter.name;
+  return entry.methods.length > 1 ? tf("On this device ({broker})", { broker: method.adapter.name }) : method.adapter.name;
 }

package/src/brokers/profile-form.ts

@@ -1,6 +1,7 @@
 import type { BrokerAdapter, BrokerConfigField } from "../types/broker";
 import type { BrokerInstanceConfig } from "../types/config";
 import { resolveBrokerConfigFields } from "../types/broker";
+import { t, tf } from "../i18n";
 
 export interface BrokerProfileDraft {
   label: string;
@@ -93,7 +94,7 @@ export function validateBrokerProfileValues(
   for (const field of getVisibleBrokerConfigFields(adapter, resolvedValues)) {
     if (!field.required) continue;
     if (!normalizeFormValue(resolvedValues[field.key]).trim()) {
-      return `${field.label} is required.`;
+      return tf("{label} is required.", { label: t(field.label) });
     }
   }
   return null;

package/src/brokers/remove-profile.ts

@@ -0,0 +1,61 @@
+/**
+ * Removing a broker profile, from the Brokers pane or the command bar. A
+ * signed-in profile's connection belongs to the Gloom account, so it is
+ * disconnected there too, as far as Gloom answers: the profile leaves this
+ * device either way, and the message says what the account kept.
+ */
+import type { ConfirmModalOptions } from "../components/form-modal";
+import { t, tf } from "../i18n";
+import type { BrokerInstanceConfig } from "../types/config";
+import { disconnectSignedInProfile, signedInBrokerForProfile } from "./signed-in/connect";
+import { isSignedInBrokerProfile } from "./signed-in/profile";
+
+/**
+ * The confirm before `onConfirm` removes `instance`. `brokerName` names the
+ * broker when the connector list does not.
+ */
+export function brokerProfileRemovalConfirm(
+  instance: BrokerInstanceConfig,
+  brokerName: string,
+  onConfirm: () => Promise<void>,
+): ConfirmModalOptions {
+  const signedIn = isSignedInBrokerProfile(instance) ? signedInBrokerForProfile(instance, brokerName) : null;
+  return {
+    confirmId: "remove-broker-profile",
+    title: "Disconnect broker?",
+    body: [
+      tf("Remove \"{label}\" and imported broker data?", { label: instance.label }),
+      t("Broker-managed portfolios, positions, and contracts will be removed."),
+      ...(signedIn
+        ? [tf("This also disconnects {broker} from your other devices and agents.", { broker: signedIn.name })]
+        : []),
+    ],
+    confirmLabel: "Disconnect",
+    tone: "danger",
+    onConfirm,
+  };
+}
+
+export interface BrokerProfileRemoval {
+  message: string;
+  /** The Gloom account still holds the broker, so its other devices and agents keep it. */
+  accountKept: boolean;
+}
+
+export async function removeBrokerProfile(
+  instance: BrokerInstanceConfig,
+  brokerName: string,
+  removeBrokerInstance: (instanceId: string) => Promise<void>,
+): Promise<BrokerProfileRemoval> {
+  const account = await disconnectSignedInProfile(instance);
+  await removeBrokerInstance(instance.id);
+  const label = instance.label;
+  if (!account.stillConnected) return { message: tf("Removed {label}.", { label }), accountKept: false };
+  const broker = signedInBrokerForProfile(instance, brokerName).name;
+  return {
+    accountKept: true,
+    message: account.signedOut
+      ? tf("Removed {label}. {broker} is still connected to your Gloom account. Sign in to Gloom to disconnect {broker} from your account.", { label, broker })
+      : tf("Removed {label}. {broker} is still connected to your Gloom account.", { label, broker }),
+  };
+}

package/src/brokers/signed-in/connect.ts

@@ -4,6 +4,7 @@
  * connecting again syncs the profile it already has.
  */
 import { ApiRequestError } from "../../api-client/errors";
+import { withDeadline } from "../../utils/async-deadline";
 import type { AppConfig, BrokerInstanceConfig } from "../../types/config";
 import { findSignedInBroker } from "./catalog";
 import { disconnectSignedInBroker, type SignedInBroker } from "./client";
@@ -31,7 +32,7 @@ export interface ConnectSignedInBrokerDeps<T> {
   getConfig(): AppConfig;
   createBrokerInstance(brokerType: string, label: string, values: Record<string, unknown>): Promise<BrokerInstanceConfig>;
   syncBrokerInstance(instanceId: string): Promise<T>;
-  /** Opens the connect dialog; replaced in tests. */
+  /** Asks the user to connect: a form's own connect step, or the connect dialog when missing. */
   requestSignIn?: (broker: SignedInBroker) => Promise<boolean>;
 }
 
@@ -50,20 +51,32 @@ export async function connectSignedInBrokerProfile<T>(
   return { instance, synced: await deps.syncBrokerInstance(instance.id) };
 }
 
+/** Long enough for a slow answer, short enough that removing a profile never hangs on one. */
+const DISCONNECT_TIMEOUT_MS = 10_000;
+
+/** What became of the Gloom account's connection behind a profile being removed. */
+export type SignedInProfileDisconnect =
+  | { stillConnected: false }
+  /** The account keeps the broker: signed out of Gloom, or Gloom did not do it. */
+  | { stillConnected: true; signedOut: boolean };
+
 /**
  * Disconnects the Gloom account's connection behind a signed-in profile before
- * the profile goes. Already gone is fine; signed out of Gloom, the account
- * keeps the broker, which the caller reports as `stillConnected`.
+ * the profile goes. Already gone is fine. It never throws: the profile leaves
+ * this device whatever Gloom answers, and the caller says what the account kept.
  */
-export async function disconnectSignedInProfile(instance: BrokerInstanceConfig): Promise<{ stillConnected: boolean }> {
+export async function disconnectSignedInProfile(instance: BrokerInstanceConfig): Promise<SignedInProfileDisconnect> {
   if (!isSignedInBrokerProfile(instance)) return { stillConnected: false };
   try {
-    await disconnectSignedInBroker(signedInBrokerId(instance));
+    await withDeadline(
+      disconnectSignedInBroker(signedInBrokerId(instance)),
+      DISCONNECT_TIMEOUT_MS,
+      "Gloom did not answer the disconnect.",
+    );
     return { stillConnected: false };
   } catch (error) {
     if (error instanceof ApiRequestError && error.status === 404) return { stillConnected: false };
-    if (error instanceof ApiRequestError && error.status === 401) return { stillConnected: true };
-    throw error;
+    return { stillConnected: true, signedOut: error instanceof ApiRequestError && error.status === 401 };
   }
 }
 

package/src/brokers/signed-in/sign-in-dialog.tsx

@@ -1,8 +1,10 @@
 /**
  * The dialog that connects a signed-in broker, plus the request bridge that
- * lets the command bar, the Brokers pane and onboarding open it. Those run
- * outside the React tree or in the desktop view, which is also where the
- * browser hand-off has to happen, so the broker adapter never opens it.
+ * lets the Brokers pane and onboarding open it. Those run outside the React
+ * tree or in the desktop view, which is also where the browser hand-off has to
+ * happen, so the broker adapter never opens it. The Brokers pane's add flow and
+ * New Portfolio's form show the same step in place, built from the pieces
+ * exported here.
  */
 import { useEffect, useRef, useState } from "react";
 import { apiClient, type AuthUser } from "../../api-client";
@@ -12,7 +14,7 @@ import { useAppLanguage } from "../../i18n/react";
 import { useViewport } from "../../react/input";
 import { colors } from "../../theme/colors";
 import { Box, Text, TextAttributes } from "../../ui";
-import { useDialog, useDialogKeyboard, type PromptContext } from "../../ui/dialog";
+import { useDialog, useDialogKeyboard, type DialogApi, type PromptContext } from "../../ui/dialog";
 import { isPlainKey } from "../../utils/keyboard";
 import { DeviceSignInDialog } from "../../plugins/builtin/cloud/device-signin-dialog";
 import type { SignedInBroker } from "./client";
@@ -23,7 +25,7 @@ import {
   type BrokerSignInSnapshot,
 } from "./sign-in";
 
-function signInStatus(snapshot: BrokerSignInSnapshot, broker: SignedInBroker): { text: string; color: string } {
+export function brokerSignInStatus(snapshot: BrokerSignInSnapshot, broker: SignedInBroker): { text: string; color: string } {
   switch (snapshot.phase) {
     case "connected":
       return { text: t("Connected"), color: colors.positive };
@@ -39,18 +41,31 @@ function signInStatus(snapshot: BrokerSignInSnapshot, broker: SignedInBroker): {
   }
 }
 
-function BrokerSignInDialog({
-  resolve,
-  dismiss,
-  broker,
-  write,
-}: PromptContext<BrokerSignInOutcome> & { broker: SignedInBroker; write: boolean }) {
-  useAppLanguage();
-  const { height: termHeight } = useViewport();
+/** Under the code: the broker's own note, or what connecting a single-connection broker does to other apps. */
+export function brokerSignInNote(broker: SignedInBroker): string | null {
+  return broker.capabilities.signupNote
+    ?? (broker.capabilities.singleConnection
+      ? tf("Other AI apps linked to {broker} get disconnected. Connect them to Gloom instead.", { broker: broker.name })
+      : null);
+}
+
+/**
+ * One attempt at connecting `broker`, with a controller of its own: started on
+ * mount, cancelled on unmount. A session Gloom refused ends it at once as
+ * "signed-out", for a new Gloom sign-in and a fresh attempt; "connected" waits
+ * a beat so it is seen, and `finish` skips the wait.
+ */
+export function useBrokerSignInAttempt(
+  broker: SignedInBroker,
+  write: boolean,
+  onOutcome: (outcome: "connected" | "signed-out") => void,
+): { snapshot: BrokerSignInSnapshot; restart(): void; finish(): void } {
   const controllerRef = useRef<BrokerSignInController | null>(null);
   if (!controllerRef.current) controllerRef.current = new BrokerSignInController(broker, write);
   const controller = controllerRef.current;
   const [snapshot, setSnapshot] = useState(controller.getSnapshot());
+  const onOutcomeRef = useRef(onOutcome);
+  onOutcomeRef.current = onOutcome;
 
   useEffect(() => {
     const unsubscribe = controller.subscribe(setSnapshot);
@@ -61,33 +76,59 @@ function BrokerSignInDialog({
     };
   }, [controller]);
 
-  // Close after a beat so "Connected" is visible; enter skips the wait. Signed
-  // out closes at once, for the host to sign in to Gloom.
   useEffect(() => {
     if (snapshot.phase === "signed-out") {
-      resolve("signed-out");
+      onOutcomeRef.current("signed-out");
       return;
     }
     if (snapshot.phase !== "connected") return;
-    const closeTimer = setTimeout(() => resolve("connected"), 900);
+    const closeTimer = setTimeout(() => onOutcomeRef.current("connected"), 900);
     return () => clearTimeout(closeTimer);
-  }, [resolve, snapshot.phase]);
+  }, [snapshot.phase]);
+
+  return {
+    snapshot,
+    restart: () => {
+      if (snapshot.phase !== "connected") controller.start();
+    },
+    finish: () => {
+      if (snapshot.phase === "connected") onOutcomeRef.current("connected");
+    },
+  };
+}
+
+/** Gloom's device sign-in, stacked over whatever asked for it. True once signed in. */
+export async function promptGloomSignIn(dialog: DialogApi): Promise<boolean> {
+  return !!await dialog.prompt<AuthUser | undefined>({
+    size: "full",
+    content: (context: unknown) => <DeviceSignInDialog {...(context as PromptContext<AuthUser | undefined>)} />,
+  });
+}
+
+function BrokerSignInDialog({
+  resolve,
+  dismiss,
+  broker,
+  write,
+}: PromptContext<BrokerSignInOutcome> & { broker: SignedInBroker; write: boolean }) {
+  useAppLanguage();
+  const { height: termHeight } = useViewport();
+  // Close after a beat so "Connected" is visible; enter skips the wait. Signed
+  // out closes at once, for the host to sign in to Gloom.
+  const { snapshot, restart, finish } = useBrokerSignInAttempt(broker, write, resolve);
 
   useDialogKeyboard((event) => {
     event.stopPropagation();
     if (event.name === "enter" || event.name === "return") {
-      if (snapshot.phase === "connected") resolve("connected");
-    } else if (isPlainKey(event, "r") && snapshot.phase !== "connected") {
-      controller.start();
+      finish();
+    } else if (isPlainKey(event, "r")) {
+      restart();
     } else if (event.name === "escape") {
       dismiss();
     }
   });
 
-  const note = broker.capabilities.signupNote
-    ?? (broker.capabilities.singleConnection
-      ? tf("Other AI apps linked to {broker} get disconnected. Connect them to Gloom instead.", { broker: broker.name })
-      : null);
+  const note = brokerSignInNote(broker);
   // Title, spacing, note, and footer take about eleven rows around the panel.
   const panelHeight = Math.max(4, termHeight - (note ? 12 : 10));
 
@@ -105,7 +146,7 @@ function BrokerSignInDialog({
       <SignInCodePanel
         url={snapshot.connectUrl}
         code={snapshot.code}
-        status={signInStatus(snapshot, broker)}
+        status={brokerSignInStatus(snapshot, broker)}
         height={panelHeight}
         shortcutScope="broker-signin:browser"
       />
@@ -161,10 +202,7 @@ export function BrokerSignInDialogHost() {
       // The broker connection belongs to the Gloom account, so there must be one.
       void runBrokerSignIn(request.broker, request.write, {
         isSignedIn: () => apiClient.isSignedIn(),
-        signInToGloom: async () => !!await dialog.prompt<AuthUser | undefined>({
-          size: "full",
-          content: (context: unknown) => <DeviceSignInDialog {...(context as PromptContext<AuthUser | undefined>)} />,
-        }),
+        signInToGloom: () => promptGloomSignIn(dialog),
         connectBroker: async (broker, write) => await dialog.prompt<BrokerSignInOutcome>({
           size: "full",
           content: (context: unknown) => (

package/src/cli/desktop-pane-shot.ts

@@ -65,7 +65,7 @@ export interface DesktopPaneShotPayload {
   paneState: Record<string, PaneRuntimeState>;
   /**
    * Installed plugins compiled for the browser, the same way the desktop view
-   * receives them. Without these a pane from `~/.gloomberb/plugins` resolves in
+   * receives them. Without these a pane from the plugins folder resolves in
    * the CLI but is unknown to the page that renders it.
    */
   externalPlugins?: DesktopExternalPluginBundle[];
@@ -80,7 +80,7 @@ export interface DesktopPaneShotApiProxy {
 /**
  * The page renders panes that fetch their own data. Left alone it can only
  * reach the cloud API, so a pane whose values come from a provider the router
- * merges in (analyst price targets, Yahoo dividends) rendered thinner than the
+ * merges in (analyst price targets, cash dividends) rendered thinner than the
  * same pane in the terminal. The bridge lets the page ask the Bun process to
  * run those requests through the real provider router instead.
  */

package/src/cli/history-rows.ts

@@ -22,7 +22,7 @@ function decimalPlaces(value: number): number {
 }
 
 /**
- * Providers serve prices as float32: Yahoo sends the exact float
+ * Providers serve prices as float32: The feed sends the exact float
  * (340.33 arrives as 340.3299865722656) and the cloud a float already rounded
  * to a few decimals (254.42999). Return the shortest decimal that is the same
  * float32. Values with fewer than five decimals are left alone, and a precise

package/src/cli/pane-functions/function-help.ts

@@ -372,21 +372,21 @@ export const FUNCTION_HELP: Readonly<Record<string, FunctionHelp>> = {
     summary: "The 10-K risk factor section grouped by theme, with what was added, dropped or rewritten since the prior year called out.",
     usage: ["RISK TSLA"],
     keys: [key("y", "ear"), key("o", "pen filing")],
-    data: AS_FILED,
+    data: pro(AS_FILED.pro),
     bloomberg: [],
   },
   EXEC: {
     summary: "Named executive officers and what they were paid, read from the proxy statement and checked against the filing.",
     usage: ["EXEC NVDA"],
     keys: [key("y", "ear"), key("o", "pen filing")],
-    data: AS_FILED,
+    data: pro(AS_FILED.pro),
     bloomberg: ["MGMT"],
   },
   EK: {
     summary: "The company's 8-Ks classified by item (agreements, executive changes, auditor changes, restructurings) with a summary of what each one said.",
     usage: ["EK NVDA"],
     keys: [key("o", "pen filing")],
-    data: AS_FILED,
+    data: pro(AS_FILED.pro),
     bloomberg: ["CF"],
   },
   CALLS: {

package/src/cli/ticker-resolution.ts

@@ -40,8 +40,8 @@ export async function resolveTickerForCli(
 }
 
 /**
- * Search catalogues can file a listing under another company's name: Twelve
- * Data names BAE Systems' London line (BA:LSE) after Boeing. The listing's own
+ * Search catalogues can file a listing under another company's name, such as
+ * BAE Systems' London line (BA:LSE) under Boeing. The listing's own
  * quote names the security it prices, which is the name the ticker command
  * shows, so a record created here takes it.
  */