gloomberb 0.15.1 → 0.15.2

package/bin/gloomberb

@@ -1,3 +1,11 @@
 #!/usr/bin/env bun
 
-import "../src/cli/entry.ts"
+// Bun applies patchedDependencies only to the root project, so a global
+// `bun install -g gloomberb` runs react-reconciler without
+// patches/react-reconciler@0.33.0.patch. Its dev build then records a
+// performance.measure for every component render, which Bun keeps forever.
+// The reconciler reads console.timeStamp once at load to decide, so hide it
+// before React is imported.
+delete console.timeStamp;
+
+await import("../src/cli/entry.ts");

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gloomberb",
-  "version": "0.15.1",
+  "version": "0.15.2",
   "packageManager": "bun@1.3.11",
   "description": "Market research and portfolio tracker for the terminal",
   "module": "src/index.tsx",

package/src/cli/native-smoke.ts

@@ -8,6 +8,8 @@ export async function smokeOpenTuiNative(): Promise<void> {
 
 export async function smokeOpenTuiRuntime(): Promise<void> {
   await import("../renderers/opentui/start");
+  const { assertRendersLeaveNoTimingEntries } = await import("../renderers/opentui/render-timing-smoke");
+  await assertRendersLeaveNoTimingEntries();
 }
 
 /**

package/src/components/ui/index.ts

@@ -22,7 +22,8 @@ export { Menu, MenuPopover } from "./menu";
 export type { MenuItem, MenuProps, MenuPopoverProps } from "./menu";
 
 export { MultiSelectDialogButton, MultiSelectDialogContent } from "./multi-select/dialog";
-export type { MultiSelectDialogButtonHandle, MultiSelectPopoverAnchorPoint } from "./multi-select/dialog";
+export type { MultiSelectDialogButtonHandle, MultiSelectPopoverAnchorPoint, MultiSelectRowAction } from "./multi-select/dialog";
+export { NumberPromptDialog } from "./number-prompt-dialog";
 
 export { SelectButton } from "./select-button";
 export type { SelectButtonOption, SelectButtonProps, SelectControl } from "./select-button";

package/src/components/ui/multi-select/dialog.tsx

@@ -37,6 +37,19 @@ import {
   type MultiSelectOption,
 } from "./index";
 
+/**
+ * One action on the highlighted row, shown beside Done: editing a value the
+ * option carries, such as an indicator's period.
+ */
+export interface MultiSelectRowAction {
+  label: string;
+  shortcut: string;
+  /** Whether the highlighted option offers it; `selected` is its checkbox. */
+  appliesTo(value: string, selected: boolean): boolean;
+  /** A returned label replaces the row's label while the dialog stays open. */
+  run(value: string): Promise<string | void> | string | void;
+}
+
 export interface MultiSelectDialogContentProps extends AlertContext {
   title: string;
   options: MultiSelectOption[];
@@ -45,6 +58,7 @@ export interface MultiSelectDialogContentProps extends AlertContext {
   ordered?: boolean;
   emptyLabel?: string;
   idPrefix?: string;
+  rowAction?: MultiSelectRowAction;
 }
 
 export interface MultiSelectDialogButtonProps {
@@ -61,6 +75,8 @@ export interface MultiSelectDialogButtonProps {
   shortcutKey?: string | string[];
   shortcutActive?: boolean;
   onOpenChange?: (open: boolean) => void;
+  /** Opens the dialog on desktop too, since the popover menu has no row actions. */
+  rowAction?: MultiSelectRowAction;
 }
 
 export interface MultiSelectPopoverAnchorPoint {
@@ -197,6 +213,7 @@ export function MultiSelectDialogContent({
   onChange,
   ordered = false,
   idPrefix,
+  rowAction,
 }: MultiSelectDialogContentProps) {
   const isDesktopWeb = useUiHost().kind === "desktop-web";
   const optionByValue = useMemo(() => new Map(options.map((option) => [option.value, option])), [options]);
@@ -216,6 +233,11 @@ export function MultiSelectDialogContent({
   const canMoveDown = ordered
     && selectedValueOrder >= 0
     && selectedValueOrder < knownSelectedValues.length - 1;
+  const [labelOverrides, setLabelOverrides] = useState<Record<string, string>>({});
+  const canRunRowAction = !!rowAction
+    && !!selectedOption
+    && !selectedOption.disabled
+    && rowAction.appliesTo(selectedOption.value, selectedValues.includes(selectedOption.value));
 
   useEffect(() => {
     setSelectedValues((values) => normalizeDialogSelectedValues(options, values, ordered));
@@ -235,7 +257,7 @@ export function MultiSelectDialogContent({
 
     return {
       id: option.value,
-      label: option.label,
+      label: labelOverrides[option.value] ?? option.label,
       disabled: option.disabled,
       enabled: selectedValues.includes(option.value),
       description: [option.description, orderDescription].filter((entry): entry is string => !!entry).join(" "),
@@ -278,6 +300,13 @@ export function MultiSelectDialogContent({
     );
   };
 
+  const runRowAction = async () => {
+    if (!rowAction || !canRunRowAction || !selectedOption) return;
+    const value = selectedOption.value;
+    const label = await rowAction.run(value);
+    if (typeof label === "string") setLabelOverrides((current) => ({ ...current, [value]: label }));
+  };
+
   useDialogKeyboard((event) => {
     event.stopPropagation();
     const move = listCursorMove(event, pageSize);
@@ -290,6 +319,8 @@ export function MultiSelectDialogContent({
       void moveOption("up").catch(() => {});
     } else if (event.name === "]" && ordered) {
       void moveOption("down").catch(() => {});
+    } else if (rowAction && event.name === rowAction.shortcut && !event.ctrl && !event.meta && !event.alt) {
+      void runRowAction().catch(() => {});
     } else if (event.name === "enter" || event.name === "return" || event.name === "escape" || isDetailBackNavigationKey(event)) {
       dismiss();
     }
@@ -331,6 +362,15 @@ export function MultiSelectDialogContent({
               <Button label="Move Down" shortcut="]" variant="ghost" disabled={!canMoveDown} onPress={() => { void moveOption("down").catch(() => {}); }} />
             </>
           )}
+          {rowAction && (
+            <Button
+              label={rowAction.label}
+              shortcut={rowAction.shortcut}
+              variant="ghost"
+              disabled={!canRunRowAction}
+              onPress={() => { void runRowAction().catch(() => {}); }}
+            />
+          )}
           <Button label="Done" shortcut="Enter" variant="primary" onPress={dismiss} />
         </Box>
       </Box>
@@ -352,6 +392,7 @@ function MultiSelectDialogButtonInner({
   shortcutKey,
   shortcutActive = false,
   onOpenChange,
+  rowAction,
 }: MultiSelectDialogButtonProps, ref: ForwardedRef<MultiSelectDialogButtonHandle>) {
   const isDesktopWeb = useUiHost().kind === "desktop-web";
   const dialog = useDialog();
@@ -364,7 +405,7 @@ function MultiSelectDialogButtonInner({
   const openDialog = useCallback((event?: DialogTriggerEvent, anchorPoint?: MultiSelectPopoverAnchorPoint) => {
     stopMouseEvent(event);
     if (disabled) return;
-    if (isDesktopWeb && !ordered) {
+    if (isDesktopWeb && !ordered && !rowAction) {
       setPopoverAnchorPoint(anchorPoint ?? null);
       setPopoverOpen(true);
       onOpenChange?.(true);
@@ -383,10 +424,11 @@ function MultiSelectDialogButtonInner({
           ordered={ordered}
           emptyLabel={emptyLabel}
           idPrefix={idPrefix}
+          rowAction={rowAction}
         />
       ),
     }).catch(() => {}).finally(() => onOpenChange?.(false));
-  }, [dialog, disabled, emptyLabel, idPrefix, isDesktopWeb, label, onChange, onOpenChange, options, ordered, selectedValues, title]);
+  }, [dialog, disabled, emptyLabel, idPrefix, isDesktopWeb, label, onChange, onOpenChange, options, ordered, rowAction, selectedValues, title]);
 
   const closePopover = useCallback(() => {
     setPopoverOpen(false);
@@ -469,7 +511,7 @@ function MultiSelectDialogButtonInner({
     );
   }
 
-  if (isDesktopWeb && !ordered) {
+  if (isDesktopWeb && !ordered && !rowAction) {
     return (
       <Popover
         open={popoverOpen}

package/src/components/ui/number-prompt-dialog.tsx

@@ -0,0 +1,71 @@
+import { useEffect, useRef, useState } from "react";
+import { Box, Text, type InputRenderable } from "../../ui";
+import type { PromptContext } from "../../ui/dialog";
+import { useThemeColors } from "../../theme/theme-context";
+import { DialogFrame } from "./frame";
+import { TextField } from "./fields";
+
+/** A whole number within [min, max], or null for anything else. */
+export function parseWholeNumber(text: string, min: number, max: number): number | null {
+  const trimmed = text.trim();
+  if (!/^\d+$/.test(trimmed)) return null;
+  const value = Number(trimmed);
+  return value >= min && value <= max ? value : null;
+}
+
+export interface NumberPromptDialogProps extends PromptContext<number> {
+  title: string;
+  initialValue: number;
+  min: number;
+  max: number;
+  /** Shown under the field when Enter is pressed on something out of range. */
+  invalidMessage: string;
+}
+
+/**
+ * One prefilled number field. Enter keeps a valid value, Esc closes without
+ * one (the dialog host resolves the prompt with undefined).
+ */
+export function NumberPromptDialog({
+  resolve,
+  title,
+  initialValue,
+  min,
+  max,
+  invalidMessage,
+}: NumberPromptDialogProps) {
+  const colors = useThemeColors();
+  const inputRef = useRef<InputRenderable>(null);
+  const [value, setValue] = useState(String(initialValue));
+  const [invalid, setInvalid] = useState(false);
+
+  useEffect(() => {
+    inputRef.current?.focus?.();
+  }, []);
+
+  return (
+    <DialogFrame title={title}>
+      <Box flexDirection="column" width={32}>
+        <TextField
+          inputRef={inputRef}
+          value={value}
+          focused
+          onChange={(next) => {
+            setValue(next);
+            setInvalid(false);
+          }}
+          onSubmit={(submitted) => {
+            const parsed = parseWholeNumber(submitted, min, max);
+            if (parsed === null) setInvalid(true);
+            else resolve(parsed);
+          }}
+        />
+        {invalid && (
+          <Box height={1}>
+            <Text fg={colors.negative}>{invalidMessage}</Text>
+          </Box>
+        )}
+      </Box>
+    </DialogFrame>
+  );
+}

package/src/plugins/builtin/chart-composer/pane.tsx

@@ -11,7 +11,9 @@ import {
 } from "../../../components";
 import {
   MultiSelectDialogButton,
+  NumberPromptDialog,
   type MultiSelectDialogButtonHandle,
+  type MultiSelectRowAction,
 } from "../../../components/ui";
 import { CompositeChart } from "../../../components/chart/composite";
 import type { PaneProps, TickerResearchTabProps } from "../../../types/plugin";
@@ -58,11 +60,16 @@ import {
   buildPriceChartPreset,
   chartSeriesLabel,
   defaultFinancialTimestampMode,
+  builtinStudyPeriod,
   getSelectedBuiltinStudies,
   getSelectedPairStudies,
+  isPeriodStudy,
   setBuiltinStudies,
+  setBuiltinStudyPeriod,
   setPairStudies,
   rebindResearchChartSpec,
+  STUDY_PERIOD_MAX,
+  STUDY_PERIOD_MIN,
   type BuiltinStudySelection,
   type PairStudySelection,
 } from "./presets";
@@ -71,7 +78,9 @@ import {
   CHART_FORMULA_OPTIONS,
   CHART_RANGES as RANGES,
   CHART_RESOLUTIONS as RESOLUTIONS,
-  CHART_STUDY_OPTIONS,
+  chartStudyLabel,
+  chartStudyOptionsFor,
+  chartStudyPeriodTitle,
 } from "./settings";
 import { resolveChartComposerShortcut } from "./shortcuts";
 import { describeChartResolution, formatChartDateWindow, formatChartResolution } from "./viewport-labels";
@@ -310,6 +319,37 @@ function ChartComposerSurface({
   const interactionCaptureRef = useRef(false);
   const interactionCaptureSourcesRef = useRef(new Set<string>());
   const indicatorsDialogRef = useRef<MultiSelectDialogButtonHandle | null>(null);
+  // The Indicators dialog keeps the callbacks it opened with; reading the spec
+  // through this ref keeps a toggle from undoing a period edit made meanwhile.
+  const specRef = useRef(spec);
+  specRef.current = spec;
+  const studyOptions = useMemo(() => chartStudyOptionsFor(spec), [spec]);
+  const studyPeriodAction = useMemo<MultiSelectRowAction>(() => ({
+    label: "Period",
+    shortcut: "p",
+    appliesTo: (value, selected) => selected && isPeriodStudy(value),
+    run: async (value) => {
+      if (!isPeriodStudy(value)) return;
+      const current = builtinStudyPeriod(specRef.current, value) ?? STUDY_PERIOD_MIN;
+      const next = await dialog.prompt<number>({
+        content: (ctx: PromptContext<number>) => (
+          <NumberPromptDialog
+            {...ctx}
+            title={chartStudyPeriodTitle(value)}
+            initialValue={current}
+            min={STUDY_PERIOD_MIN}
+            max={STUDY_PERIOD_MAX}
+            invalidMessage={`Whole number from ${STUDY_PERIOD_MIN} to ${STUDY_PERIOD_MAX}`}
+          />
+        ),
+      });
+      if (next === undefined || next === current) return;
+      const nextSpec = setBuiltinStudyPeriod(specRef.current, value, next);
+      specRef.current = nextSpec;
+      setSpec(nextSpec);
+      return chartStudyLabel(value, next);
+    },
+  }), [dialog, setSpec]);
   const formulasDialogRef = useRef<MultiSelectDialogButtonHandle | null>(null);
   const indicatorsDisabled = !isPriceStudyTarget(spec);
   const formulasDisabled = spec.series.filter((series) => series.visible !== false).length < 2;
@@ -642,9 +682,14 @@ function ChartComposerSurface({
         ref={indicatorsDialogRef}
         label="Indicators"
         title="Chart Indicators"
-        options={CHART_STUDY_OPTIONS}
+        options={studyOptions}
         selectedValues={selectedStudies}
-        onChange={(values) => setSpec(setBuiltinStudies(spec, values as BuiltinStudySelection[]))}
+        onChange={(values) => {
+          const nextSpec = setBuiltinStudies(specRef.current, values as BuiltinStudySelection[]);
+          specRef.current = nextSpec;
+          setSpec(nextSpec);
+        }}
+        rowAction={studyPeriodAction}
         disabled={indicatorsDisabled}
         idPrefix={`${footerId}:indicators`}
         shortcutKey="i"

package/src/plugins/builtin/chart-composer/presets.test.ts

@@ -653,3 +653,20 @@ describe("chart composer CLI options", () => {
     });
   });
 });
+
+describe("indicator periods", () => {
+  test("an edited period survives toggling other indicators and names itself in the picker", async () => {
+    const { builtinStudyPeriod, setBuiltinStudyPeriod } = await import("./presets");
+    const { chartStudyLabel } = await import("./settings");
+    const withSma = setBuiltinStudies(buildPriceChartPreset("AAPL"), ["sma50"]);
+    const edited = setBuiltinStudyPeriod(withSma, "sma50", 30);
+    expect(builtinStudyPeriod(edited, "sma50")).toBe(30);
+    // Turning another indicator on and off rebuilds the list from the selection.
+    const toggled = setBuiltinStudies(setBuiltinStudies(edited, ["sma50", "rsi14"]), ["sma50"]);
+    expect(builtinStudyPeriod(toggled, "sma50")).toBe(30);
+    expect(chartStudyLabel("sma50", builtinStudyPeriod(toggled, "sma50"))).toBe("Simple moving average (SMA 30)");
+    // An indicator that is not on keeps its default and is left alone.
+    expect(setBuiltinStudyPeriod(toggled, "ema20", 9)).toBe(toggled);
+    expect(builtinStudyPeriod(toggled, "ema20")).toBe(20);
+  });
+});

package/src/plugins/builtin/chart-composer/presets.ts

@@ -794,6 +794,54 @@ export function setBuiltinStudies(spec: ChartSpec, selected: readonly BuiltinStu
   return { ...spec, studies, panels: reconcilePanels(spec.panels, spec.series, studies) };
 }
 
+/** Builtin studies whose lookback the Indicators dialog lets you change. */
+const PERIOD_STUDIES = new Set<BuiltinStudySelection>(["sma20", "sma50", "sma200", "ema20", "bollinger20", "rsi14"]);
+
+export const STUDY_PERIOD_MIN = 2;
+export const STUDY_PERIOD_MAX = 500;
+
+export function isPeriodStudy(selection: string): selection is BuiltinStudySelection {
+  return PERIOD_STUDIES.has(selection as BuiltinStudySelection);
+}
+
+function builtinStudy(spec: ChartSpec, selection: BuiltinStudySelection): ChartStudySpec | undefined {
+  const prefix = `${BUILTIN_STUDY_ID_PREFIX}${selection}:`;
+  return spec.studies.find((study) => study.id.startsWith(prefix));
+}
+
+export function defaultStudyPeriod(selection: BuiltinStudySelection): number | null {
+  const defaults = STUDY_DEFAULTS[selection].parameters as Record<string, unknown>;
+  return typeof defaults.period === "number" ? defaults.period : null;
+}
+
+/** The period a builtin study runs with: its own when selected, the default otherwise. */
+export function builtinStudyPeriod(spec: ChartSpec, selection: BuiltinStudySelection): number | null {
+  const period = builtinStudy(spec, selection)?.parameters.period;
+  return typeof period === "number" && Number.isFinite(period) ? period : defaultStudyPeriod(selection);
+}
+
+/**
+ * Changes the period of a selected builtin study. The study keeps its id, so
+ * `setBuiltinStudies` carries the new period through later toggles; an
+ * unselected study is left alone.
+ */
+export function setBuiltinStudyPeriod(
+  spec: ChartSpec,
+  selection: BuiltinStudySelection,
+  period: number,
+): ChartSpec {
+  if (!isPeriodStudy(selection)) return spec;
+  const bounded = Math.round(Math.min(STUDY_PERIOD_MAX, Math.max(STUDY_PERIOD_MIN, period)));
+  const target = builtinStudy(spec, selection);
+  if (!target) return spec;
+  return {
+    ...spec,
+    studies: spec.studies.map((study) => (
+      study.id === target.id ? { ...study, parameters: { ...study.parameters, period: bounded } } : study
+    )),
+  };
+}
+
 export type PairStudySelection = "ratio" | "spread" | "correlation";
 
 const PAIR_STUDY_ID_PREFIX = "pair:";

package/src/plugins/builtin/chart-composer/settings.ts

@@ -24,7 +24,10 @@ import {
   chartSeriesLabel,
   formatSeriesExpression,
   getCompatibleSeriesStyles,
+  builtinStudyPeriod,
+  defaultStudyPeriod,
   getSelectedBuiltinStudies,
+  isPeriodStudy,
   getSelectedPairStudies,
   setBuiltinStudies,
   setPairStudies,
@@ -38,17 +41,45 @@ import {
 
 export { CHART_RANGES, CHART_RESOLUTIONS };
 
-export const CHART_STUDY_OPTIONS: Array<PaneSettingOption & { value: BuiltinStudySelection }> = [
-  { value: "volume", label: "Volume", description: "Volume columns in a lower panel." },
-  { value: "sma20", label: "SMA 20", description: "20-bar simple moving average on the primary price series." },
-  { value: "sma50", label: "SMA 50", description: "50-bar simple moving average on the primary price series." },
-  { value: "sma200", label: "SMA 200", description: "200-bar simple moving average on the primary price series." },
-  { value: "ema20", label: "EMA 20", description: "20-bar exponential moving average on the primary price series." },
-  { value: "bollinger20", label: "Bollinger 20", description: "20-bar Bollinger Bands at two standard deviations." },
-  { value: "rsi14", label: "RSI 14", description: "14-bar Relative Strength Index in a lower panel." },
-  { value: "macd", label: "MACD", description: "12/26/9 MACD in a lower panel." },
-  { value: "realized-vol", label: "Realized Volatility", description: "Annualized daily volatility in a lower panel." },
-];
+/** Full name and short form for each builtin indicator; the label adds its period. */
+const CHART_STUDY_NAMES: Record<BuiltinStudySelection, { name: string; short?: string; description: string }> = {
+  volume: { name: "Volume", description: "Volume columns in a lower panel." },
+  sma20: { name: "Simple moving average", short: "SMA", description: "Simple moving average on the primary price series." },
+  sma50: { name: "Simple moving average", short: "SMA", description: "Simple moving average on the primary price series." },
+  sma200: { name: "Simple moving average", short: "SMA", description: "Simple moving average on the primary price series." },
+  ema20: { name: "Exponential moving average", short: "EMA", description: "Exponential moving average on the primary price series." },
+  bollinger20: { name: "Bollinger Bands", short: "BB", description: "Bollinger Bands at two standard deviations." },
+  rsi14: { name: "Relative strength index", short: "RSI", description: "Relative Strength Index in a lower panel." },
+  macd: { name: "MACD", short: "12, 26, 9", description: "12/26/9 MACD in a lower panel." },
+  "realized-vol": { name: "Realized volatility", description: "Annualized daily volatility in a lower panel." },
+};
+
+/** Title of the prompt that edits a study's period: `SMA period`. */
+export function chartStudyPeriodTitle(selection: BuiltinStudySelection): string {
+  return `${CHART_STUDY_NAMES[selection].short ?? CHART_STUDY_NAMES[selection].name} period`;
+}
+
+/** `Simple moving average (SMA 50)`: the name, the acronym and the period it runs with. */
+export function chartStudyLabel(selection: BuiltinStudySelection, period: number | null): string {
+  const { name, short } = CHART_STUDY_NAMES[selection];
+  if (!short) return name;
+  return isPeriodStudy(selection) && period != null ? `${name} (${short} ${period})` : `${name} (${short})`;
+}
+
+function chartStudyOptions(periodOf: (selection: BuiltinStudySelection) => number | null) {
+  return (Object.keys(CHART_STUDY_NAMES) as BuiltinStudySelection[]).map((value) => ({
+    value,
+    label: chartStudyLabel(value, periodOf(value)),
+    description: CHART_STUDY_NAMES[value].description,
+  }));
+}
+
+export const CHART_STUDY_OPTIONS: Array<PaneSettingOption & { value: BuiltinStudySelection }> = chartStudyOptions(defaultStudyPeriod);
+
+/** The indicator options with the periods this chart actually uses. */
+export function chartStudyOptionsFor(spec: ChartSpec): Array<PaneSettingOption & { value: BuiltinStudySelection }> {
+  return chartStudyOptions((selection) => builtinStudyPeriod(spec, selection));
+}
 
 export const CHART_FORMULA_OPTIONS: Array<PaneSettingOption & { value: PairStudySelection }> = [
   { value: "ratio", label: "Ratio", description: "First series divided by the second series." },

package/src/renderers/opentui/render-timing-smoke.ts

@@ -0,0 +1,20 @@
+import { createElement } from "react";
+import { testRender } from "@opentui/react/test-utils";
+
+/**
+ * A global install runs react-reconciler without its patch (see
+ * bin/gloomberb). If the dev build's user timing turns back on, every render
+ * adds a performance.measure entry that Bun never frees (#452).
+ */
+export async function assertRendersLeaveNoTimingEntries(): Promise<void> {
+  // Only the dev reconciler records user timing, and testRender needs the dev
+  // build's act; a `--production` binary has neither.
+  if (process.env.NODE_ENV === "production") return;
+  const setup = await testRender(createElement("text", null, "smoke"), { width: 10, height: 1 });
+  await setup.renderOnce();
+  const entries = performance.getEntriesByType("measure").length;
+  setup.renderer.destroy();
+  if (entries > 0) {
+    throw new Error(`React recorded ${entries} render timing entries, which are never freed.`);
+  }
+}