gloomberb 0.11.3 → 0.12.0

package/src/market-data/coordinator/subscriptions.test.ts

@@ -5,6 +5,11 @@ import { QUOTE_STREAM_UPDATE_THROTTLE_MS } from "../quotes/cadence";
 import { createTestDataProvider } from "../../test-support/data-provider";
 import type { Quote } from "../../types/financials";
 import type { DataProvider, QuoteSubscriptionTarget } from "../../types/data-provider";
+import {
+  QUOTE_SUBSCRIPTION_PRIORITY_UPDATE_DELAY_MS,
+  QUOTE_SUBSCRIPTION_REMOVE_GRACE_MS,
+  type QuoteSubscriptionRequest,
+} from "./quotes";
 
 function createProvider(): {
   provider: DataProvider;
@@ -75,47 +80,220 @@ describe("MarketDataCoordinator key subscriptions", () => {
   });
 
   test("keeps the highest-priority target when duplicate surfaces subscribe", () => {
-    const subscriptions: QuoteSubscriptionTarget[][] = [];
-    let disposals = 0;
-    const provider = createTestDataProvider({
-      id: "test-provider",
-      subscribeQuotes: (targets) => {
-        subscriptions.push(targets);
-        return () => {
-          disposals += 1;
-        };
-      },
-    });
-    const coordinator = new MarketDataCoordinator(provider);
-    const instrument = { symbol: "AAPL", exchange: "NASDAQ" };
+    jest.useFakeTimers();
+    try {
+      const subscriptions: QuoteSubscriptionTarget[][] = [];
+      let disposals = 0;
+      const provider = createTestDataProvider({
+        id: "test-provider",
+        subscribeQuotes: (targets) => {
+          subscriptions.push(targets);
+          return () => {
+            disposals += 1;
+          };
+        },
+      });
+      const coordinator = new MarketDataCoordinator(provider);
+      const instrument = { symbol: "AAPL", exchange: "NASDAQ" };
+
+      const unsubscribeDetail = coordinator.subscribeQuotes([{
+        instrument,
+        priority: { surface: "detail", visible: true, selected: true, weight: 100 },
+      }]);
+      const unsubscribePortfolio = coordinator.subscribeQuotes([{
+        instrument,
+        priority: { surface: "portfolio", visible: false, selected: false, weight: 10 },
+      }]);
+
+      expect(subscriptions).toHaveLength(1);
+      expect(subscriptions[0]?.[0]).toMatchObject({
+        surface: "detail",
+        visible: true,
+        selected: true,
+        weight: 100,
+      });
 
-    const unsubscribeDetail = coordinator.subscribeQuotes([{
-      instrument,
-      priority: { surface: "detail", visible: true, selected: true, weight: 100 },
-    }]);
-    coordinator.subscribeQuotes([{
-      instrument,
-      priority: { surface: "portfolio", visible: false, selected: false, weight: 10 },
-    }]);
+      unsubscribeDetail();
+      expect(subscriptions).toHaveLength(1);
 
-    expect(subscriptions).toHaveLength(1);
-    expect(subscriptions[0]?.[0]).toMatchObject({
-      surface: "detail",
-      visible: true,
-      selected: true,
-      weight: 100,
-    });
+      jest.advanceTimersByTime(QUOTE_SUBSCRIPTION_PRIORITY_UPDATE_DELAY_MS);
+      expect(subscriptions).toHaveLength(2);
+      expect(disposals).toBe(1);
+      expect(subscriptions[1]?.[0]).toMatchObject({
+        surface: "portfolio",
+        visible: false,
+        selected: false,
+        weight: 10,
+      });
 
-    unsubscribeDetail();
+      unsubscribePortfolio();
+      jest.runAllTimers();
+    } finally {
+      jest.useRealTimers();
+    }
+  });
 
-    expect(subscriptions).toHaveLength(2);
-    expect(disposals).toBe(1);
-    expect(subscriptions[1]?.[0]).toMatchObject({
-      surface: "portfolio",
-      visible: false,
-      selected: false,
-      weight: 10,
-    });
+  test("coalesces priority updates and overlaps the upstream replacement", () => {
+    jest.useFakeTimers();
+    try {
+      const events: string[] = [];
+      const subscriptions: QuoteSubscriptionTarget[][] = [];
+      const provider = createTestDataProvider({
+        id: "test-provider",
+        subscribeQuotes: (targets) => {
+          const subscriptionId = subscriptions.length + 1;
+          subscriptions.push(targets);
+          events.push(`subscribe:${subscriptionId}`);
+          return () => events.push(`dispose:${subscriptionId}`);
+        },
+      });
+      const coordinator = new MarketDataCoordinator(provider);
+      const instruments = ["AAPL", "MSFT", "NVDA"].map((symbol) => ({
+        symbol,
+        exchange: "NASDAQ",
+      }));
+      const requests = (
+        selectedSymbol: string,
+        selectedSurface: "portfolio" | "detail" = "portfolio",
+      ): QuoteSubscriptionRequest[] => instruments.map((instrument) => ({
+        instrument,
+        priority: {
+          surface: instrument.symbol === selectedSymbol ? selectedSurface : "portfolio",
+          visible: instrument.symbol === selectedSymbol,
+          selected: instrument.symbol === selectedSymbol,
+          weight: instrument.symbol === selectedSymbol ? 100 : 10,
+        },
+      }));
+
+      const subscription = coordinator.subscribeQuotes(requests("AAPL"));
+      subscription.update(requests("MSFT"));
+      subscription.update(requests("NVDA", "detail"));
+
+      jest.advanceTimersByTime(QUOTE_SUBSCRIPTION_PRIORITY_UPDATE_DELAY_MS - 1);
+      expect(subscriptions).toHaveLength(1);
+      expect(events).toEqual(["subscribe:1"]);
+
+      jest.advanceTimersByTime(1);
+      expect(subscriptions).toHaveLength(2);
+      expect(subscriptions[1]?.find((target) => target.symbol === "NVDA")).toMatchObject({
+        surface: "detail",
+        visible: true,
+        selected: true,
+        weight: 100,
+      });
+      expect(events).toEqual(["subscribe:1", "subscribe:2", "dispose:1"]);
+
+      subscription();
+      jest.runAllTimers();
+    } finally {
+      jest.useRealTimers();
+    }
+  });
+
+  test("applies membership and routing changes immediately", () => {
+    jest.useFakeTimers();
+    try {
+      const subscriptions: QuoteSubscriptionTarget[][] = [];
+      let disposals = 0;
+      const provider = createTestDataProvider({
+        id: "test-provider",
+        subscribeQuotes: (targets) => {
+          subscriptions.push(targets);
+          return () => { disposals += 1; };
+        },
+      });
+      const coordinator = new MarketDataCoordinator(provider);
+      const aapl = {
+        symbol: "AAPL",
+        exchange: "NASDAQ",
+        brokerId: "ibkr",
+        brokerInstanceId: "ibkr-work",
+        instrument: {
+          brokerId: "ibkr",
+          brokerInstanceId: "ibkr-work",
+          conId: 1001,
+          symbol: "AAPL",
+        },
+      };
+      const msft = { symbol: "MSFT", exchange: "NASDAQ" };
+      const subscription = coordinator.subscribeQuotes([{
+        instrument: aapl,
+        priority: { route: "provider", surface: "portfolio" },
+      }]);
+
+      subscription.update([
+        { instrument: aapl, priority: { route: "provider", surface: "portfolio" } },
+        { instrument: msft, priority: { route: "provider", surface: "portfolio" } },
+      ]);
+      expect(subscriptions).toHaveLength(2);
+      expect(disposals).toBe(1);
+      expect(subscriptions[1]?.map((target) => target.symbol).sort()).toEqual(["AAPL", "MSFT"]);
+
+      subscription.update([
+        { instrument: aapl, priority: { route: "broker", surface: "detail" } },
+        { instrument: msft, priority: { route: "provider", surface: "portfolio" } },
+      ]);
+      expect(subscriptions).toHaveLength(3);
+      expect(disposals).toBe(2);
+      expect(subscriptions[2]?.find((target) => target.symbol === "AAPL")).toMatchObject({
+        route: "broker",
+        surface: "detail",
+        context: {
+          brokerId: "ibkr",
+          brokerInstanceId: "ibkr-work",
+          instrument: { brokerId: "ibkr", conId: 1001, symbol: "AAPL" },
+        },
+      });
+
+      subscription();
+      jest.runAllTimers();
+    } finally {
+      jest.useRealTimers();
+    }
+  });
+
+  test("keeps an updated handle callable and honors removal grace on dispose", () => {
+    jest.useFakeTimers();
+    try {
+      const subscriptions: QuoteSubscriptionTarget[][] = [];
+      let disposals = 0;
+      const provider = createTestDataProvider({
+        id: "test-provider",
+        subscribeQuotes: (targets) => {
+          subscriptions.push(targets);
+          return () => { disposals += 1; };
+        },
+      });
+      const coordinator = new MarketDataCoordinator(provider);
+      const instrument = { symbol: "AAPL", exchange: "NASDAQ" };
+      const subscription = coordinator.subscribeQuotes([{
+        instrument,
+        priority: { surface: "portfolio", selected: false, weight: 10 },
+      }]);
+
+      expect(typeof subscription).toBe("function");
+      expect(typeof subscription.update).toBe("function");
+      subscription.update([{
+        instrument,
+        priority: { surface: "detail", selected: true, weight: 100 },
+      }]);
+      jest.advanceTimersByTime(QUOTE_SUBSCRIPTION_PRIORITY_UPDATE_DELAY_MS);
+      expect(subscriptions).toHaveLength(2);
+      expect(disposals).toBe(1);
+
+      subscription();
+      subscription.update([{ instrument: { symbol: "MSFT", exchange: "NASDAQ" } }]);
+      subscription();
+      jest.advanceTimersByTime(QUOTE_SUBSCRIPTION_REMOVE_GRACE_MS - 1);
+      expect(subscriptions).toHaveLength(2);
+      expect(disposals).toBe(1);
+
+      jest.advanceTimersByTime(1);
+      expect(subscriptions).toHaveLength(2);
+      expect(disposals).toBe(2);
+    } finally {
+      jest.useRealTimers();
+    }
   });
 
   test("replaces a capped target window without retaining pending removals", () => {

package/src/pane-settings.ts

@@ -52,7 +52,7 @@ export function setPaneSetting(
   value: unknown,
 ): LayoutConfig {
   const current = findPaneInstance(layout, paneId);
-  if (!current) return layout;
+  if (!current || Object.is(current.settings?.[key], value)) return layout;
   return setPaneSettings(layout, paneId, {
     ...(current.settings ?? {}),
     [key]: value,

package/src/plugins/builtin/analytics/pane-model.ts

@@ -1,4 +1,4 @@
-import { resolveChartPalette } from "../../../components/chart/core/renderer";
+import { resolveChartPalette } from "../../../components/chart/core/palette";
 import { colors, priceColor } from "../../../theme/colors";
 import type { TickerFinancials, PricePoint } from "../../../types/financials";
 import type { BrokerPortfolioPerformance } from "../../../types/trading";

package/src/plugins/builtin/analytics/view.tsx

@@ -5,7 +5,7 @@ import {
   loadingText,
   unavailableText,
 } from "../../../components";
-import type { StaticChartSurfaceProps } from "../../../components/chart/static/chart/surface";
+import type { StaticChartSurfaceProps } from "../../../components/chart/static";
 import type { ProjectedChartPoint } from "../../../components/chart/core/data";
 import { colors, priceColor } from "../../../theme/colors";
 import { formatCompact, formatPercentRaw } from "../../../utils/format";

package/src/plugins/builtin/broker-manager/index.test.tsx

@@ -7,7 +7,7 @@ import { AppContext, PaneInstanceProvider, createInitialState } from "../../../s
 import { createTestPluginRuntime } from "../../../test-support/plugin-runtime";
 import { createDefaultConfig, type BrokerInstanceConfig } from "../../../types/config";
 import { PluginRenderProvider } from "../../runtime";
-import { ibkrBroker } from "../../ibkr/broker-adapter";
+import { testBroker } from "../../../brokers/test-broker";
 import { BrokersPane } from "./index";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
@@ -63,7 +63,7 @@ function Harness({
     };
   }
   const runtime = createTestPluginRuntime({
-    getBrokerAdapter: (brokerType) => brokerType === "ibkr" ? ibkrBroker : null,
+    getBrokerAdapter: (brokerType) => brokerType === "ibkr" ? testBroker : null,
     openCommandBar: (query) => calls.push(`command:${query ?? ""}`),
     showPane: (paneId) => calls.push(`pane:${paneId}`),
     connectBrokerInstance: async (instanceId) => { calls.push(`connect:${instanceId}`); },
@@ -113,6 +113,7 @@ async function pressKey(key: string) {
 
 describe("BrokersPane", () => {
   test("renders IBKR row and invokes broker actions", async () => {
+
     const calls: string[] = [];
     testSetup = await testRender(<FooterHarness calls={calls} instance={createGatewayInstance()} height={35} />, { width: 92, height: 35 });
     await act(async () => {

package/src/plugins/builtin/broker-manager/model.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, test } from "bun:test";
 import type { BrokerAdapter } from "../../../types/broker";
 import { createDefaultConfig, type BrokerInstanceConfig } from "../../../types/config";
-import { ibkrBroker } from "../../ibkr/broker-adapter";
+import { testBroker } from "../../../brokers/test-broker";
 import { buildBrokerProfileRows, formatBrokerUpdatedAt } from "./model";
 
 function createInstance(patch: Partial<BrokerInstanceConfig> = {}): BrokerInstanceConfig {
@@ -131,7 +131,7 @@ describe("broker manager rows", () => {
         enabled: true,
       }],
     };
-    const rows = buildBrokerProfileRows(config, new Map([["ibkr", ibkrBroker]]), {});
+    const rows = buildBrokerProfileRows(config, new Map([["ibkr", testBroker]]), {});
 
     expect(rows[0]?.mode).toBe("Flex");
     expect(rows[0]?.stateLabel).toBe("Sync only");

package/src/plugins/builtin/chart-composer/catalog-inventory.ts

@@ -10,6 +10,8 @@ import {
   FUTURES_CONTRACTS,
   FUTURES_SECTOR_LABELS,
 } from "../futures/contracts";
+import { INDICATORS as VALUATION_INDICATORS } from "../market-valuation/indicators";
+import { MARKET_VALUATION_CAPABILITY_ID } from "../market-valuation/chart-series";
 import { TREASURY_MATURITIES } from "../yield-curve/treasury-data";
 import { fieldCategory, type SeriesCatalogInstrument } from "./series-catalog";
 
@@ -23,7 +25,8 @@ export type CatalogSourceId =
   | "crypto"
   | "fred"
   | "futures"
-  | "treasury";
+  | "treasury"
+  | "valuation";
 
 export type CatalogFilterId =
   | "all"
@@ -31,7 +34,8 @@ export type CatalogFilterId =
   | "options"
   | "crypto"
   | "fred"
-  | "futures";
+  | "futures"
+  | "valuation";
 
 export interface CatalogSeriesRow {
   id: string;
@@ -53,6 +57,7 @@ export const CATALOG_FILTERS: ReadonlyArray<{ id: CatalogFilterId; label: string
   { id: "crypto", label: "Crypto" },
   { id: "fred", label: "FRED" },
   { id: "futures", label: "Futures" },
+  { id: "valuation", label: "Valuation" },
 ];
 
 const FILTER_SOURCES: Record<CatalogFilterId, ReadonlySet<CatalogSourceId> | null> = {
@@ -62,6 +67,7 @@ const FILTER_SOURCES: Record<CatalogFilterId, ReadonlySet<CatalogSourceId> | nul
   crypto: new Set(["crypto"]),
   fred: new Set(["fred", "treasury"]),
   futures: new Set(["futures"]),
+  valuation: new Set(["valuation"]),
 };
 
 const CRYPTO_CATALOG: ReadonlyArray<{ symbol: string; name: string }> = [
@@ -321,6 +327,14 @@ const STATIC_CATALOG_INVENTORY: readonly CatalogSeriesRow[] = [
     expression: `UST:${entry.maturity}`,
     url: `https://fred.stlouisfed.org/series/${entry.seriesId}`,
   })),
+  ...VALUATION_INDICATORS.map((entry) => row({
+    id: `valuation:${entry.id}`,
+    label: entry.label,
+    source: "Gloom Cloud",
+    sourceId: "valuation",
+    kind: "Valuation",
+    expression: `CAP:${MARKET_VALUATION_CAPABILITY_ID}:${entry.id}`,
+  })),
   ...FUTURES_CONTRACTS.map((entry) => row({
     id: `fut:${entry.code}`,
     label: `${entry.name} (${entry.code})`,

package/src/plugins/builtin/chart-composer/pane.tsx

@@ -14,7 +14,10 @@ import { CompositeChart } from "../../../components/chart/composite";
 import type { PaneProps, TickerResearchTabProps } from "../../../types/plugin";
 import type { ChartResolution, TimeRange } from "../../../components/chart/core/types";
 import type { ChartSpec, ResolvedSeries } from "../../../time-series/types";
-import { getSupportedChartResolutionsForViewport } from "../../../time-series/resolution";
+import {
+  getSupportedChartResolutionsForViewport,
+  type ManualChartResolution,
+} from "../../../time-series/resolution";
 import { useResolvedChartSpec } from "../../../time-series/hooks";
 import { chartSeriesSourceKey } from "../../../capabilities";
 import { useShortcut } from "../../../react/input";
@@ -68,6 +71,9 @@ import { isPlainKey } from "../../../utils/keyboard";
 
 const RANGE_TABS = RANGES.map((range, index) => ({ label: `${index + 1}:${range}`, value: range }));
 const AUTO_VIEWPORT_DEBOUNCE_MS = 350;
+/** Bar pitch AUTO aims for; the coarser neighbour wins ties so bars stay readable. */
+const AUTO_RESOLUTION_BAR_PIXELS = 7;
+const MINIMUM_AUTO_RESOLUTION_POINTS = 60;
 
 interface RuntimeChartViewport {
   start: Date;
@@ -137,7 +143,7 @@ function ChartComposerSurface({
   const dialog = useDialog();
   const dispatch = useAppDispatch();
   const isDesktopWeb = useUiHost().kind === "desktop-web";
-  const { publicSharing } = useUiCapabilities();
+  const { publicSharing, cellWidthPx = 8 } = useUiCapabilities();
   const paneId = usePaneInstanceId();
   const liveStreaming = useLiveStreamingSetting();
   const dialogOpen = useDialogState((state) => state.isOpen);
@@ -179,15 +185,24 @@ function ChartComposerSurface({
   const activeRuntimeViewport = runtimeViewportState?.key === authoredViewportKey
     ? runtimeViewportState
     : null;
-  const targetPointCount = Math.max(60, Math.floor(width * 1.25));
+  const targetPointCount = Math.max(
+    MINIMUM_AUTO_RESOLUTION_POINTS,
+    Math.round((width * cellWidthPx) / AUTO_RESOLUTION_BAR_PIXELS),
+  );
+  // The loaded resolution is the tie-breaker for the next AUTO pick, so a
+  // small zoom keeps the bars it already has. Read from the previous render:
+  // the resolver only consults it when the viewport moves.
+  const currentResolutionRef = useRef<ManualChartResolution | null>(null);
   const resolution = useResolvedChartSpec(spec, {
     autoViewport: spec.viewport.resolution === "auto"
       ? activeRuntimeViewport?.adaptiveViewport
       : null,
     requestViewport: activeRuntimeViewport?.requestViewport,
     targetPointCount,
+    currentResolution: currentResolutionRef.current,
     liveStreaming: liveStreaming && (liveWhenUnfocused || focused),
   });
+  currentResolutionRef.current = resolution.resolution ?? currentResolutionRef.current;
   const availableResolutions = useMemo<ChartResolution[]>(() => {
     if (!resolution.resolutionSupport) {
       if (!resolution.loading) return RESOLUTIONS;
@@ -320,9 +335,8 @@ function ChartComposerSurface({
   }, [authoredViewportKey, persistedInteractionViewport, setStoredInteractionViewport]);
   const handleChartViewportChange = useCallback((
     next: { start: Date; end: Date } | null,
-    interaction: "pan" | "reset" | "sync" | "zoom",
+    _interaction: "pan" | "reset" | "zoom",
   ) => {
-    if (interaction === "sync") return;
     if (runtimeViewportTimerRef.current !== null) {
       clearTimeout(runtimeViewportTimerRef.current);
       runtimeViewportTimerRef.current = null;
@@ -339,9 +353,9 @@ function ChartComposerSurface({
     if (!Number.isFinite(start) || !Number.isFinite(end) || start > end) return;
     const viewport = { start: new Date(start), end: new Date(end) };
     requestViewportRef.current = viewport;
-    if (interaction === "zoom" && spec.viewport.resolution === "auto") {
-      adaptiveViewportRef.current = viewport;
-    }
+    // A pan can leave the window a provider serves at the current resolution
+    // just as a zoom can, so both re-pick.
+    if (spec.viewport.resolution === "auto") adaptiveViewportRef.current = viewport;
     runtimeViewportTimerRef.current = globalThis.setTimeout(() => {
       runtimeViewportTimerRef.current = null;
       const requestViewport = requestViewportRef.current;

package/src/plugins/builtin/chat/content/composer.tsx

@@ -1,7 +1,7 @@
-import { Box, Text, TextAttributes, type TextareaRenderable } from "../../../../ui";
+import { Box, Text, TextAttributes, useCommandBarShortcut, type TextareaRenderable } from "../../../../ui";
 import { getMessageComposerBlockHeight, MessageComposer } from "../../../../components/ui";
 import { colors } from "../../../../theme/colors";
-import { t } from "../../../../i18n";
+import { t, tf } from "../../../../i18n";
 import { truncateToDisplayWidth } from "../../../../utils/format";
 import type { ChatMessage } from "../../../../api-client";
 import { InlineAuthActions } from "../../cloud/auth-actions";
@@ -130,8 +130,10 @@ export function ChatComposerArea({
   onMentionSelect,
   user,
 }: ChatComposerAreaProps) {
+  const commandBarShortcut = useCommandBarShortcut();
   if (!canSend) {
-    const fitLine = (value: string) => truncateToDisplayWidth(t(value), contentWidth);
+    const fitText = (value: string) => truncateToDisplayWidth(value, contentWidth);
+    const fitLine = (value: string) => fitText(t(value));
     return (
       <Box width={contentWidth} height={2} flexDirection="column">
         {!user && !hasSavedSession ? (
@@ -147,7 +149,9 @@ export function ChatComposerArea({
         ) : (
           <>
             <Text fg={colors.positive}>{fitLine("Verify your email to send messages.")}</Text>
-            <Text fg={colors.textDim}>{fitLine("Ctrl+P, then Resend Verification Email")}</Text>
+            <Text fg={colors.textDim}>
+              {fitText(tf("{shortcut}, then Resend Verification Email", { shortcut: commandBarShortcut }))}
+            </Text>
           </>
         )}
       </Box>