gloomberb 0.10.0 → 0.10.2

package/src/components/ui/page-stack-view.tsx

@@ -29,21 +29,33 @@ export function PageStackView({
   backHint,
 }: PageStackViewProps) {
   const HostPageStackView = useUiHost().PageStackView as ComponentType<PageStackViewProps> | undefined;
+  const props = {
+    focused,
+    detailOpen,
+    onBack,
+    rootContent,
+    detailContent,
+    detailTitle,
+    backLabel,
+    backHint,
+  };
   if (HostPageStackView) {
-    return (
-      <HostPageStackView
-        focused={focused}
-        detailOpen={detailOpen}
-        onBack={onBack}
-        rootContent={rootContent}
-        detailContent={detailContent}
-        detailTitle={detailTitle}
-        backLabel={backLabel}
-        backHint={backHint}
-      />
-    );
+    return <HostPageStackView {...props} />;
   }
 
+  return <OpenTuiPageStackView {...props} />;
+}
+
+function OpenTuiPageStackView({
+  focused,
+  detailOpen,
+  onBack,
+  rootContent,
+  detailContent,
+  detailTitle,
+  backLabel,
+  backHint,
+}: PageStackViewProps) {
   const goBack = useCallback((event?: {
     preventDefault?: () => void;
     stopPropagation?: () => void;

package/src/components/ui/tabs.tsx

@@ -2,8 +2,10 @@ import { useCallback, useEffect, useMemo, useRef, useState } from "react";
 import { useShortcut } from "../../react/input";
 import { Box, ScrollBox, Text, useUiHost } from "../../ui";
 import { TextAttributes, type ScrollBoxRenderable } from "../../ui";
-import { colors, hoverBg } from "../../theme/colors";
+import { hoverBg } from "../../theme/colors";
+import { useThemeColors } from "../../theme/theme-context";
 import { t } from "../../i18n";
+import { useAppLanguage } from "../../i18n/react";
 import { displayWidth } from "../../utils/format";
 import { useRemoteUiNode } from "../../remote/semantic-tree";
 
@@ -55,9 +57,11 @@ export function Tabs({
   scrollable = true,
   scrollId,
 }: TabsProps) {
+  const language = useAppLanguage();
+  const colors = useThemeColors();
   const tabs = useMemo(() => rawTabs.map((tab) => (
     { ...tab, label: t(tab.label) }
-  )), [rawTabs]);
+  )), [language, rawTabs]);
   const ui = useUiHost();
   const NativeTabs = ui.Tabs;
   const navigationValueRef = useRef<string | null>(activeValue);
@@ -74,7 +78,7 @@ export function Tabs({
     activeUnderline: focused ? colors.textBright : colors.borderFocused,
     inactiveUnderline: colors.bg,
     hoverUnderline: colors.border,
-    hoverBg: hoverBg(),
+    hoverBg: hoverBg(colors),
     activeBg: colors.selected,
     activePillFg: colors.selectedText,
     closeFg: colors.textMuted,

package/src/components/ui/ui.test.tsx

@@ -19,6 +19,7 @@ import { Tabs } from "./tabs";
 import { AppContext, PaneInstanceProvider, createInitialState } from "../../state/app/context";
 import { createDefaultConfig } from "../../types/config";
 import { DataTableView } from "../data-table/view";
+import { setLanguage } from "../../i18n";
 
 let testSetup: Awaited<ReturnType<typeof testRender>> | undefined;
 let setListSelection: ((index: number) => void) | null = null;
@@ -277,9 +278,9 @@ async function emitKeypress(event: { name?: string; sequence?: string; ctrl?: bo
   await testSetup!.renderOnce();
 }
 
-afterEach(() => {
+afterEach(async () => {
   if (testSetup) {
-    testSetup.renderer.destroy();
+    await act(async () => testSetup?.renderer.destroy());
     testSetup = undefined;
   }
   setListSelection = null;
@@ -290,9 +291,29 @@ afterEach(() => {
   addedTab = false;
   resolvedChoice = null;
   multiSelectOpenStates = [];
+  setLanguage("en");
 });
 
 describe("shared UI kit", () => {
+  test("retranslates stable tab items when the app language changes", async () => {
+    const tabs = [{ label: "Open", value: "open" }];
+    testSetup = await testRender(
+      <Tabs tabs={tabs} activeValue="open" onSelect={() => {}} />,
+      { width: 20, height: 2 },
+    );
+
+    await act(async () => testSetup?.renderOnce());
+    expect(testSetup.captureCharFrame()).toContain("Open");
+
+    await act(async () => {
+      setLanguage("zh-CN");
+      await testSetup?.renderOnce();
+      await testSetup?.renderOnce();
+    });
+
+    expect(testSetup.captureCharFrame()).toContain("打开");
+  });
+
   test("scrolls overflowing tabs horizontally with the mouse wheel", async () => {
     testSetup = await testRender(
       <Tabs

package/src/components/use-external-link-footer.ts

@@ -15,6 +15,7 @@ interface UseExternalLinkFooterOptions {
   info?: PaneFooterSegment[];
   hints?: PaneHint[];
   label?: string;
+  showHint?: boolean;
 }
 
 const EMPTY_INFO: PaneFooterSegment[] = [];
@@ -33,6 +34,7 @@ export function useExternalLinkFooter({
   info = EMPTY_INFO,
   hints = EMPTY_HINTS,
   label = "link",
+  showHint = true,
 }: UseExternalLinkFooterOptions) {
   const rendererHost = useRendererHost();
   const url = normalizeUrl(rawUrl);
@@ -68,10 +70,10 @@ export function useExternalLinkFooter({
       info: [...info, ...linkInfo],
       hints: [
         ...hints,
-        ...(url ? [{ id: "open", key: "o", label: "pen", onPress: openUrl }] : []),
+        ...(url && showHint ? [{ id: "open", key: "o", label: "pen", onPress: openUrl }] : []),
       ],
     };
-  }, [hints, info, label, openUrl, sourceLabel, url]);
+  }, [hints, info, label, openUrl, showHint, sourceLabel, url]);
 
   usePaneFooter(registrationId, () => footer, [footer]);
 

package/src/core/app-service-ports.ts

@@ -0,0 +1,46 @@
+import type { PluginStateStore } from "../data/plugin-state-store";
+import type { ResourceStore } from "../data/resource-store";
+import type { SessionStore } from "../data/session-store";
+import type { TickerRepository } from "../data/ticker-repository";
+import type { MarketDataCoordinator } from "../market-data/coordinator";
+import type { PluginRegistry } from "../plugins/registry";
+import type { AppConfig } from "../types/config";
+import type { DataProvider } from "../types/data-provider";
+import type { GloomPlugin } from "../types/plugin";
+
+export type AppPluginStateStorePort = Pick<
+  PluginStateStore,
+  "get" | "set" | "delete" | "keys" | "clear"
+>;
+
+export type AppResourceStorePort = Pick<ResourceStore, "get" | "list" | "set" | "delete">;
+export type AppSessionStorePort = Pick<SessionStore, "get" | "set" | "delete">;
+
+export interface AppPersistencePort {
+  pluginState: AppPluginStateStorePort;
+  resources: AppResourceStorePort;
+  sessions: AppSessionStorePort;
+  close(): void;
+}
+
+export type AppTickerRepositoryPort = Pick<
+  TickerRepository,
+  "loadAllTickers" | "loadTicker" | "saveTicker" | "createTicker" | "deleteTicker"
+>;
+
+export interface AppRuntimeServices {
+  persistence: AppPersistencePort;
+  tickerRepository: AppTickerRepositoryPort;
+  dataProvider: DataProvider;
+  marketData: MarketDataCoordinator;
+  pluginRegistry: PluginRegistry;
+  ready: Promise<void>;
+  destroy(): void;
+}
+
+export interface AppServicesFactoryOptions {
+  config: AppConfig;
+  plugins: readonly GloomPlugin[];
+}
+
+export type AppServicesFactory = (options: AppServicesFactoryOptions) => AppRuntimeServices;

package/src/core/app-services.test.ts

@@ -0,0 +1,66 @@
+import { afterEach, expect, test } from "bun:test";
+import { mkdtemp, rm } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { newsProvider } from "../capabilities";
+import type { NewsArticle } from "../news/types";
+import { createDefaultConfig } from "../types/config";
+import type { GloomPlugin } from "../types/plugin";
+import { createAppServices, type AppServices } from "./app-services";
+
+let services: AppServices | null = null;
+let dataDir: string | null = null;
+
+afterEach(async () => {
+  services?.destroy();
+  services = null;
+  if (dataDir) await rm(dataDir, { recursive: true, force: true });
+  dataDir = null;
+});
+
+test("the router does not re-enter the aggregate news facade", async () => {
+  dataDir = await mkdtemp(join(tmpdir(), "gloomberb-news-composition-"));
+  let fetchCount = 0;
+  const article: NewsArticle = {
+    id: "composition-story",
+    title: "Composition story",
+    url: "https://composition.example.com/story",
+    source: "Test",
+    publishedAt: new Date("2026-07-26T12:00:00.000Z"),
+    topic: "markets",
+    topics: ["markets"],
+    sectors: [],
+    categories: ["markets"],
+    tickers: [],
+    scores: { importance: 50, urgency: 0, marketImpact: 50, novelty: 0, confidence: 100 },
+    importance: 50,
+    isBreaking: false,
+    isDeveloping: false,
+  };
+  const plugin: GloomPlugin = {
+    id: "composition-news",
+    name: "Composition News",
+    version: "1.0.0",
+    capabilities: [newsProvider({
+      id: "composition-news",
+      name: "Composition News",
+      provider: {
+        fetchNews: async () => {
+          fetchCount++;
+          return [article];
+        },
+      },
+    })],
+  };
+
+  services = createAppServices({
+    config: createDefaultConfig(dataDir),
+    plugins: [plugin],
+  });
+  await services.ready;
+
+  const articles = await services.providerRouter.getNews({ feed: "latest", limit: 20 });
+
+  expect(fetchCount).toBe(1);
+  expect(articles.map((item) => item.id)).toEqual([article.id]);
+});

package/src/core/app-services.ts

@@ -7,16 +7,15 @@ import { setSharedNewsService } from "../news/hooks";
 import { PluginRegistry } from "../plugins/registry";
 import { AssetDataRouter } from "../sources/provider-router";
 import { assetDataProvider, newsProvider } from "../capabilities";
-import type { AppConfig } from "../types/config";
 import type { DataProvider } from "../types/data-provider";
-import type { GloomPlugin } from "../types/plugin";
 import { debugLog } from "../utils/debug-log";
 import { measurePerf, measurePerfAsync } from "../utils/perf-marks";
 import { setIbkrPortfolioPerformanceResourceStore } from "../plugins/ibkr/portfolio-performance";
+import type { AppRuntimeServices, AppServicesFactoryOptions } from "./app-service-ports";
 
 const servicesLog = debugLog.createLogger("services");
 
-export interface AppServices {
+export interface AppServices extends AppRuntimeServices {
   persistence: AppPersistence;
   tickerRepository: TickerRepository;
   providerRouter: AssetDataRouter;
@@ -31,10 +30,7 @@ export interface AppServices {
 export function createAppServices({
   config,
   plugins,
-}: {
-  config: AppConfig;
-  plugins: readonly GloomPlugin[];
-}): AppServices {
+}: AppServicesFactoryOptions): AppServices {
   servicesLog.info("create services start", {
     pluginCount: plugins.length,
     brokerInstanceCount: config.brokerInstances.length,
@@ -49,14 +45,20 @@ export function createAppServices({
   const pluginRegistry = new PluginRegistry(dataProvider, tickerRepository, persistence);
   const newsService = new NewsService();
   pluginRegistry.capabilities.register("core", assetDataProvider(providerRouter));
-  pluginRegistry.capabilities.register("core", newsProvider({
-    id: "core",
-    name: "News",
-    provider: {
-      fetchNews: async (query) => (await newsService.load(query)).articles,
-      getCachedNews: (query) => newsService.getQueryState(query).articles,
-    },
-  }));
+  pluginRegistry.capabilities.register("core", {
+    ...newsProvider({
+      id: "core",
+      name: "News",
+      provider: {
+        fetchNews: async (query) => (await newsService.load(query)).articles,
+        getCachedNews: (query) => newsService.getQueryState(query).articles,
+      },
+    }),
+    // This capability exposes the aggregate service to remote renderers. Giving
+    // it the router source id prevents the router from rediscovering its own
+    // aggregate facade alongside the underlying plugin news sources.
+    sourceId: providerRouter.id,
+  });
 
   providerRouter.attachRegistry(pluginRegistry);
   pluginRegistry.getConfigFn = () => config;

package/src/data/config/chart-settings.ts

@@ -1,4 +1,4 @@
-import type { ChartResolution, TimeRange } from "../../components/chart/core/types";
+import type { ChartResolution, TimeRange } from "../../time-series/range";
 import type { LayoutConfig, PaneBinding } from "../../types/config";
 import type {
   ChartPanelSpec,
@@ -55,6 +55,7 @@ export interface LegacyChartIndicatorSelection {
 }
 
 export interface LegacyChartMigrationContext {
+  migrateLegacy?: boolean;
   defaultRenderMode?: SeriesStyle;
   indicatorSelection?: LegacyChartIndicatorSelection;
 }
@@ -362,6 +363,7 @@ export function migrateChartPaneSettings(
   settings: Record<string, unknown> | undefined,
   context: LegacyChartMigrationContext = {},
 ): Record<string, unknown> | undefined {
+  if (context.migrateLegacy === false) return settings;
   if (paneId === "chart-composer") {
     const retained = stripKeys(settings, [
       "chartAxisMode",
@@ -495,15 +497,6 @@ export function extractLegacyChartIndicatorSelection(
     : { ids: normalizedLegacyIndicatorIds(["volume", ...ids]), explicit: true };
 }
 
-export function hasLegacyChartIndicatorConfig(
-  pluginConfig: Record<string, Record<string, unknown>>,
-): boolean {
-  return ["ticker-research", "ticker-detail", "company-research"].some((pluginId) => {
-    const state = pluginConfig[pluginId];
-    return hasOwn(state, "chartIndicators") || hasOwn(state, "chartIndicatorsVersion");
-  });
-}
-
 export function stripLegacyChartPluginConfig(
   pluginConfig: Record<string, Record<string, unknown>>,
 ): Record<string, Record<string, unknown>> {

package/src/data/config/store/index.test.ts

@@ -648,6 +648,28 @@ describe("loadConfig", () => {
     expect(config.disabledPlugins).toEqual(["news"]);
   });
 
+  test("runs the Cloud-to-Macro split only before its v15 boundary", async () => {
+    const beforeDir = await createTempConfigDir();
+    await writeConfigJson(beforeDir, createSavedConfig({
+      configVersion: 14,
+      disabledPlugins: ["gloomberb-cloud"],
+      disabledSources: [],
+    }));
+    const before = await loadConfig(beforeDir);
+    expect(before.disabledPlugins).toEqual(["gloomberb-cloud", "macro"]);
+    expect(before.disabledSources).toEqual(["gloomberb-cloud"]);
+
+    const atBoundaryDir = await createTempConfigDir();
+    await writeConfigJson(atBoundaryDir, createSavedConfig({
+      configVersion: 15,
+      disabledPlugins: ["gloomberb-cloud"],
+      disabledSources: [],
+    }));
+    const atBoundary = await loadConfig(atBoundaryDir);
+    expect(atBoundary.disabledPlugins).toEqual(["gloomberb-cloud"]);
+    expect(atBoundary.disabledSources).toEqual([]);
+  });
+
   test("preserves IBKR gateway configs without migration rewrites", async () => {
     const dataDir = await createTempConfigDir();
     await writeConfigJson(dataDir, createSavedConfig({
@@ -679,6 +701,7 @@ describe("loadConfig", () => {
   test("migrates legacy saved pane tab IDs and preserves focus metadata", async () => {
     const dataDir = await createTempConfigDir();
     await writeConfigJson(dataDir, createSavedConfig({
+      configVersion: CURRENT_CONFIG_VERSION - 1,
       layouts: [{
         name: "Chart",
         layout: DEFAULT_LAYOUT,
@@ -726,6 +749,80 @@ describe("loadConfig", () => {
     expect(persisted.layouts[0]?.activePanel).toBe("right");
   });
 
+  test("does not replay historical migrations for current configs or saves", async () => {
+    const dataDir = await createTempConfigDir();
+    const selectedPortfolioColumns = DEFAULT_COLUMNS.map((column) => column.id);
+    const currentLayout = {
+      ...DEFAULT_LAYOUT,
+      instances: DEFAULT_LAYOUT.instances.map((instance) => (
+        instance.instanceId === "ticker-detail:main"
+          ? {
+            ...instance,
+            settings: {
+              ...(instance.settings ?? {}),
+              chartRangePreset: "6M",
+              chartResolution: "1d",
+            },
+          }
+          : instance.instanceId === "portfolio-list:main"
+            ? {
+              ...instance,
+              settings: {
+                ...(instance.settings ?? {}),
+                columnIds: selectedPortfolioColumns,
+              },
+            }
+          : instance
+      )),
+    };
+    const legacyPaneState = {
+      "ticker-detail:main": {
+        activeTabId: "fundamental-graphs",
+        pluginState: {
+          "ticker-detail": { detailMetric: "revenue", shared: "legacy" },
+          "ticker-research": { shared: "canonical" },
+        },
+      },
+    };
+    const legacyPluginConfig = {
+      "ticker-detail": {
+        chartIndicators: ["sma50"],
+        chartIndicatorsVersion: 2,
+        retainedPreference: "keep",
+      },
+    };
+    await writeConfigJson(dataDir, createSavedConfig({
+      layout: currentLayout,
+      layouts: [{ name: "Current", layout: currentLayout, paneState: legacyPaneState }],
+      pluginConfig: legacyPluginConfig,
+      disabledPlugins: ["options", "gloomberb-cloud"],
+      disabledSources: [],
+    }));
+
+    const config = await loadConfig(dataDir);
+    expect(findPaneInstance(config.layout, "ticker-detail:main")?.settings).toEqual(expect.objectContaining({
+      chartRangePreset: "6M",
+      chartResolution: "1d",
+    }));
+    expect(config.layouts[0]?.paneState).toEqual(legacyPaneState);
+    expect(config.pluginConfig).toEqual(legacyPluginConfig);
+    expect(config.disabledPlugins).toEqual(["options", "gloomberb-cloud"]);
+    expect(findPaneInstance(config.layout, "portfolio-list:main")?.settings?.columnIds)
+      .toEqual(selectedPortfolioColumns);
+
+    await saveConfig(config);
+    const persisted = JSON.parse(await readFile(join(dataDir, "config.json"), "utf-8")) as typeof config;
+    expect(persisted.layouts[0]?.paneState).toEqual(legacyPaneState);
+    expect(persisted.pluginConfig).toEqual(legacyPluginConfig);
+    expect(persisted.disabledPlugins).toEqual(["options", "gloomberb-cloud"]);
+    expect(findPaneInstance(persisted.layout, "portfolio-list:main")?.settings?.columnIds)
+      .toEqual(selectedPortfolioColumns);
+    expect(findPaneInstance(persisted.layout, "ticker-detail:main")?.settings).toEqual(expect.objectContaining({
+      chartRangePreset: "6M",
+      chartResolution: "1d",
+    }));
+  });
+
   test("migrates legacy main portfolio panes to the portfolio default columns", async () => {
     const dataDir = await createTempConfigDir();
     const legacyColumnIds = DEFAULT_COLUMNS.map((column) => column.id);
@@ -757,7 +854,7 @@ describe("loadConfig", () => {
       .toEqual(DEFAULT_PORTFOLIO_COLUMN_IDS);
   });
 
-  test("does not replay the portfolio column migration for version 19 configs", async () => {
+  test("does not replay the portfolio column migration at its v17 boundary", async () => {
     const dataDir = await createTempConfigDir();
     const selectedColumnIds = DEFAULT_COLUMNS.map((column) => column.id);
     const layout = {
@@ -776,7 +873,7 @@ describe("loadConfig", () => {
     };
 
     await writeConfigJson(dataDir, createSavedConfig({
-      configVersion: 19,
+      configVersion: 17,
       layout,
       layouts: [{ name: "Default", layout }],
     }));