glib-web 4.44.2 → 4.44.3

package/components/fields/captcha.vue

@@ -27,7 +27,7 @@ export default {
     const error = ref(null);
 
     const loadRecaptchaEnterprise = () => {
-      return new Promise(function (resolve) {
+      return new Promise(function (resolve, reject) {
         if (window.grecaptcha && window.grecaptcha.enterprise) {
           resolve(window.grecaptcha.enterprise);
           return;
@@ -41,6 +41,9 @@ export default {
         script.src = 'https://www.google.com/recaptcha/enterprise.js?render=' + props.spec.siteKey + '&onload=onRecaptchaEnterpriseLoad';
         script.async = true;
         script.defer = true;
+        script.onerror = function () {
+          reject(new Error('Failed to load reCAPTCHA script'));
+        };
         document.head.appendChild(script);
       });
     };

package/cypress/e2e/glib-web/fieldsCaptcha.cy.ts

@@ -4,10 +4,10 @@ const url = testPageUrl('fields_captcha')
 
 const visitWithCaptcha = (executeResult: () => Promise<string>) => {
   cy.visit(url, {
-    onBeforeLoad(win) {
-      (win as any).grecaptcha = {
+    onBeforeLoad(win: Cypress.AUTWindow) {
+      (win as unknown as Record<string, unknown>).grecaptcha = {
         enterprise: {
-          ready: function(cb: Function) { cb(); },
+          ready: function(cb: () => void) { cb(); },
           execute: function() { return executeResult(); }
         }
       }
@@ -43,6 +43,13 @@ describe('fieldsCaptcha', () => {
     cy.get('.unformatted').should('contain.text', 'fake-captcha-token')
   })
 
+  it('shows error when reCAPTCHA returns empty token', () => {
+    visitWithCaptcha(() => Promise.resolve(''))
+
+    cy.contains('Verification failed. Please refresh and try again.').should('exist')
+    cy.get('.v-progress-circular').should('not.exist')
+  })
+
   it('shows error when reCAPTCHA fails', () => {
     visitWithCaptcha(() => Promise.reject(new Error('reCAPTCHA unavailable')))
 

package/doc/TESTING.md

@@ -52,7 +52,7 @@ You **cannot write frontend tests in isolation**.
 
 ---
 
-These 6 concepts explain **why the test structure exists** and **what you need to get started**. Everything else (selectors, assertions, etc.) is standard Cypress mechanics.
+These 7 concepts explain **why the test structure exists** and **what you need to get started**. Everything else (selectors, assertions, etc.) is standard Cypress mechanics.
 
 ### 7. **Do Not Run `bin/vite dev` Separately During Cypress Tests**
 Running the Vite dev server separately (`bin/vite dev`) while running Cypress tests causes blank pages (Vue app fails to mount). Just use the Rails server alone — it handles Vite compilation internally.

package/package.json

@@ -1,11 +1,12 @@
 {
   "type": "module",
   "name": "glib-web",
-  "version": "4.44.2",
+  "version": "4.44.3",
   "description": "",
   "main": "index.js",
   "scripts": {
     "clean:coverage": "rm -rf coverage .nyc_output",
+    "pretest": "eslint .",
     "lint": "eslint .",
     "lint:fix": "eslint . --fix",
     "test": "env -u ELECTRON_RUN_AS_NODE cypress run --browser chrome && env -u ELECTRON_RUN_AS_NODE cypress run --component",