glab-setup-git-identity 0.6.1 → 0.6.2

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.6.2
+
+### Patch Changes
+
+- 9f3ac16: Fix --version showing 'unknown' and fix auth flow for unauthenticated users
+  - Fix --version to explicitly read version from package.json (yargs auto-detection fails when installed globally with bun)
+  - Fix isGlabAuthenticated to detect invalid/missing tokens even when glab auth status exits with code 0
+  - Suppress noisy glab auth status output by using mirror: false with capture: true in command-stream
+  - Add mirror: false to all captured command executions to prevent output leaking to terminal
+
 ## 0.6.1
 
 ### Patch Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "glab-setup-git-identity",
-  "version": "0.6.1",
+  "version": "0.6.2",
   "description": "A tool to setup git identity based on current GitLab user",
   "type": "module",
   "main": "src/index.js",

package/src/cli.js

@@ -6,6 +6,7 @@
  * Command-line interface for setting up git identity based on GitLab user
  */
 
+import { createRequire } from 'node:module';
 import { makeConfig } from 'lino-arguments';
 import {
   setupGitIdentity,
@@ -17,6 +18,11 @@ import {
 } from './index.js';
 import { $ } from 'command-stream';
 
+// Read version from package.json explicitly (yargs auto-detection may fail when installed globally)
+const require = createRequire(import.meta.url);
+const packageJson = require('../package.json');
+const packageVersion = packageJson.version;
+
 // Parse command-line arguments with environment variable and .lenv support
 const config = makeConfig({
   yargs: ({ yargs, getenv }) =>
@@ -145,7 +151,7 @@ const config = makeConfig({
       )
       .help('h')
       .alias('h', 'help')
-      .version()
+      .version(packageVersion)
       .strict(),
 });
 

package/src/index.js

@@ -62,7 +62,10 @@ export async function getGlabPath(options = {}) {
   const command = process.platform === 'win32' ? 'where' : 'which';
 
   try {
-    const result = await $`${command} glab`.run({ capture: true });
+    const result = await $`${command} glab`.run({
+      capture: true,
+      mirror: false,
+    });
 
     if (result.code !== 0 || !result.stdout) {
       throw new Error(
@@ -238,7 +241,7 @@ export async function runGlabAuthSetupGit(options = {}) {
     try {
       const existingResult =
         await $`git config --global --get credential.${credentialUrl}.helper`.run(
-          { capture: true }
+          { capture: true, mirror: false }
         );
 
       if (existingResult.code === 0 && existingResult.stdout && !force) {
@@ -262,6 +265,7 @@ export async function runGlabAuthSetupGit(options = {}) {
     try {
       await $`git config --global credential.${credentialUrl}.helper ""`.run({
         capture: true,
+        mirror: false,
       });
     } catch {
       // Ignore errors if not set
@@ -272,7 +276,7 @@ export async function runGlabAuthSetupGit(options = {}) {
 
     const result =
       await $`git config --global --add credential.${credentialUrl}.helper ${credentialHelper}`.run(
-        { capture: true }
+        { capture: true, mirror: false }
       );
 
     if (result.code !== 0) {
@@ -312,13 +316,29 @@ export async function isGlabAuthenticated(options = {}) {
   }
 
   try {
-    const result = await $`glab ${args}`.run({ capture: true });
+    const result = await $`glab ${args}`.run({
+      capture: true,
+      mirror: false,
+    });
 
     if (result.code !== 0) {
       log.debug(`GitLab CLI is not authenticated: ${result.stderr}`);
       return false;
     }
 
+    // glab auth status may exit with code 0 even when not properly authenticated.
+    // Check stderr for indicators of auth failure (e.g., "No token provided", "401 Unauthorized").
+    const output = (result.stderr || '') + (result.stdout || '');
+    if (
+      /no token provided/i.test(output) ||
+      /401\s*unauthorized/i.test(output)
+    ) {
+      log.debug(
+        `GitLab CLI reports success but token is missing or invalid: ${output.trim()}`
+      );
+      return false;
+    }
+
     log.debug('GitLab CLI is authenticated');
     return true;
   } catch (error) {
@@ -350,7 +370,7 @@ export async function getGitLabUsername(options = {}) {
     args.push('--hostname', hostname);
   }
 
-  const result = await $`glab ${args}`.run({ capture: true });
+  const result = await $`glab ${args}`.run({ capture: true, mirror: false });
 
   if (result.code !== 0) {
     throw new Error(`Failed to get GitLab username: ${result.stderr}`);
@@ -401,7 +421,7 @@ export async function getGitLabEmail(options = {}) {
     args.push('--hostname', hostname);
   }
 
-  const result = await $`glab ${args}`.run({ capture: true });
+  const result = await $`glab ${args}`.run({ capture: true, mirror: false });
 
   if (result.code !== 0) {
     throw new Error(`Failed to get GitLab email: ${result.stderr}`);
@@ -454,7 +474,7 @@ export async function getGitLabUserInfo(options = {}) {
     args.push('--hostname', hostname);
   }
 
-  const result = await $`glab ${args}`.run({ capture: true });
+  const result = await $`glab ${args}`.run({ capture: true, mirror: false });
 
   if (result.code !== 0) {
     throw new Error(`Failed to get GitLab user info: ${result.stderr}`);
@@ -512,6 +532,7 @@ export async function setGitConfig(key, value, options = {}) {
 
   const result = await $`git config ${scopeFlag} ${key} ${value}`.run({
     capture: true,
+    mirror: false,
   });
 
   if (result.code !== 0) {
@@ -539,7 +560,10 @@ export async function getGitConfig(key, options = {}) {
 
   log.debug(`Getting git config ${key} (${scope})`);
 
-  const result = await $`git config ${scopeFlag} ${key}`.run({ capture: true });
+  const result = await $`git config ${scopeFlag} ${key}`.run({
+    capture: true,
+    mirror: false,
+  });
 
   if (result.code !== 0) {
     log.debug(`Git config ${key} not set`);

package/tests/index.test.js

@@ -4,15 +4,19 @@
  */
 
 import { describe, it, expect } from 'test-anywhere';
+import { createRequire } from 'node:module';
 import {
   defaultAuthOptions,
   getGitConfig,
   setGitConfig,
   verifyGitIdentity,
   getGlabPath,
+  isGlabAuthenticated,
   runGlabAuthSetupGit,
 } from '../src/index.js';
 
+const require = createRequire(import.meta.url);
+
 describe('defaultAuthOptions', () => {
   it('should have correct default hostname', () => {
     expect(defaultAuthOptions.hostname).toBe('gitlab.com');
@@ -131,7 +135,65 @@ describe('runGlabAuthSetupGit', () => {
   });
 });
 
-// Note: Tests for isGlabAuthenticated, getGitLabUsername, getGitLabEmail,
+describe('CLI --version', () => {
+  it('should output the version from package.json', async () => {
+    const pkg = require('../package.json');
+    const { execSync } = await import('node:child_process');
+    const output = execSync('node src/cli.js --version', {
+      encoding: 'utf8',
+    }).trim();
+    expect(output).toBe(pkg.version);
+  });
+});
+
+describe('isGlabAuthenticated', () => {
+  it('should be a function', () => {
+    expect(typeof isGlabAuthenticated).toBe('function');
+  });
+
+  it('should return false when glab has no valid token', async () => {
+    // In this test environment, glab is not properly authenticated
+    // so isGlabAuthenticated should return false
+    try {
+      const result = await isGlabAuthenticated();
+      expect(typeof result).toBe('boolean');
+    } catch {
+      // If glab is not installed, it should handle gracefully
+      expect(true).toBe(true);
+    }
+  });
+
+  it('should not produce visible output when checking auth status', async () => {
+    // Ensure isGlabAuthenticated does not leak glab output to the console
+    const originalStdoutWrite = process.stdout.write;
+    const originalStderrWrite = process.stderr.write;
+    let capturedOutput = '';
+
+    process.stdout.write = (chunk) => {
+      capturedOutput += chunk.toString();
+      return true;
+    };
+    process.stderr.write = (chunk) => {
+      capturedOutput += chunk.toString();
+      return true;
+    };
+
+    try {
+      await isGlabAuthenticated({ verbose: false });
+    } catch {
+      // ignore errors
+    } finally {
+      process.stdout.write = originalStdoutWrite;
+      process.stderr.write = originalStderrWrite;
+    }
+
+    // Should not contain glab auth status output
+    expect(capturedOutput.includes('No token provided')).toBe(false);
+    expect(capturedOutput.includes('401 Unauthorized')).toBe(false);
+  });
+});
+
+// Note: Tests for getGitLabUsername, getGitLabEmail,
 // getGitLabUserInfo, runGlabAuthLogin, and setupGitIdentity require
 // an authenticated glab CLI environment and are better suited for
 // integration tests or manual testing.