gitnexus 1.6.9-rc.13 → 1.6.9-rc.14

package/dist/core/group/extractors/http-patterns/java.js

@@ -576,13 +576,16 @@ export const JAVA_HTTP_PLUGIN = {
     language: Java,
     // routeCoverage intentionally LEFT at the default 'partial' (#2138 Part 2).
     // The graph provider set is a strict *subset* of this scan()'s provider set —
-    // ingestion does NOT emit a Route node for (1) array-form `@GetMapping({...})`,
-    // (2) interface-inherited Spring routes, or (3) the 2nd verb of a same-URL
-    // GET+POST pair (Route nodes are URL-keyed). Declaring 'complete' here would
-    // let the parse-skip drop those group-only providers. Java flips to 'complete'
-    // only once ingestion provider extraction matches this scan (a follow-up:
-    // array-form query branch + interface-inheritance emission + per-verb Route
-    // identity). `hasConsumerSignals` below is kept ready for that flip.
+    // ingestion does NOT emit a Route node for (1) a method-level array route
+    // nested under a class-level array-form `@RequestMapping` (ingestion suppresses
+    // it rather than drop the prefix; bare/scalar-prefixed array methods ARE now
+    // emitted — see #2280), (2) interface-inherited Spring routes, or (3) the 2nd
+    // verb of a same-URL GET+POST pair (Route nodes are URL-keyed). Declaring
+    // 'complete' here would let the parse-skip drop those group-only providers.
+    // Java flips to 'complete' only once ingestion provider extraction matches this
+    // scan (a follow-up: class-level array-form prefix support + interface-
+    // inheritance emission + per-verb Route identity — tracked in #2280).
+    // `hasConsumerSignals` below is kept ready for that flip.
     // Consumer signals this plugin's scan() can detect: RestTemplate / WebClient /
     // OkHttp / Java-HttpClient / Apache-HttpClient call sites, OpenFeign
     // (`@FeignClient` + `@RequestLine`) interfaces, and Spring 6 HTTP Interface

package/dist/core/ingestion/route-extractors/spring.js

@@ -31,6 +31,18 @@ import { METHOD_ANNOTATION_TO_HTTP, isRouteMemberKey, findEnclosingClass, unquot
  *   @node  → enclosing declaration (class_declaration | method_declaration)
  *   @value → the string-literal argument
  *   @key   → the named-argument member key (absent for positional form)
+ *
+ * Method-level routes accept both the bare string form `@GetMapping("/x")` and
+ * the array form `@GetMapping({"/a","/b"})` (positional or `path =`/`value =`):
+ * a multi-element array yields one match per element, so the Phase 2 loop emits
+ * one route per path with no special-casing. This mirrors the group-layer
+ * `java.ts` query so the two Spring extractors stay in parity (#2138 follow-up;
+ * the divergence here was the root of the #2265 array-form gap). The class-level
+ * `@RequestMapping` branches also match the array form, but only to *detect* it:
+ * an array-form class prefix can't be resolved to a single string, so Phase 2
+ * suppresses that class's method-level array routes rather than emit them with a
+ * dropped prefix (a wrong route). Full class-array cross-product support is left
+ * to a follow-up (#2280).
  */
 const ROUTE_ANNOTATION_QUERY = new Parser.Query(Java, `
   [
@@ -38,7 +50,9 @@ const ROUTE_ANNOTATION_QUERY = new Parser.Query(Java, `
       (modifiers
         (annotation
           name: (identifier) @ann
-          arguments: (annotation_argument_list (string_literal) @value)))) @node
+          arguments: (annotation_argument_list
+            [(string_literal) @value
+             (element_value_array_initializer (string_literal) @value)])))) @node
     (class_declaration
       (modifiers
         (annotation
@@ -46,12 +60,15 @@ const ROUTE_ANNOTATION_QUERY = new Parser.Query(Java, `
           arguments: (annotation_argument_list
             (element_value_pair
               key: (identifier) @key
-              value: (string_literal) @value))))) @node
+              value: [(string_literal) @value
+                      (element_value_array_initializer (string_literal) @value)]))))) @node
     (method_declaration
       (modifiers
         (annotation
           name: (identifier) @ann
-          arguments: (annotation_argument_list (string_literal) @value)))) @node
+          arguments: (annotation_argument_list
+            [(string_literal) @value
+             (element_value_array_initializer (string_literal) @value)])))) @node
     (method_declaration
       (modifiers
         (annotation
@@ -59,7 +76,8 @@ const ROUTE_ANNOTATION_QUERY = new Parser.Query(Java, `
           arguments: (annotation_argument_list
             (element_value_pair
               key: (identifier) @key
-              value: (string_literal) @value))))) @node
+              value: [(string_literal) @value
+                      (element_value_array_initializer (string_literal) @value)]))))) @node
   ]
 `);
 /**
@@ -76,8 +94,15 @@ const ROUTE_ANNOTATION_QUERY = new Parser.Query(Java, `
  */
 export function extractSpringRoutes(tree, filePath, lineOffset = 0) {
     const matches = ROUTE_ANNOTATION_QUERY.matches(tree.rootNode);
-    // Phase 1: collect class-level @RequestMapping prefixes keyed by node id
+    // Phase 1: collect class-level @RequestMapping prefixes keyed by node id.
+    // A scalar prefix (`@RequestMapping("/base")`) is stored in prefixByClassId.
+    // A class whose @RequestMapping uses the array form (`@RequestMapping({...})`)
+    // is instead recorded in classesWithArrayPrefix: there is no single prefix to
+    // store, and Phase 2 uses this to suppress that class's method-level array
+    // routes rather than emit them unprefixed (a wrong route — see #2280). Full
+    // class-array cross-product support is out of scope here.
     const prefixByClassId = new Map();
+    const classesWithArrayPrefix = new Set();
     for (const match of matches) {
         const caps = {};
         for (const { name, node } of match.captures) {
@@ -92,6 +117,10 @@ export function extractSpringRoutes(tree, filePath, lineOffset = 0) {
         if (node.type === 'class_declaration' && annNode.text === 'RequestMapping') {
             if (!isRouteMemberKey(keyNode))
                 continue;
+            if (valueNode.parent?.type === 'element_value_array_initializer') {
+                classesWithArrayPrefix.add(node.id);
+                continue;
+            }
             const prefix = unquoteSpringLiteral(valueNode.text);
             if (prefix !== null)
                 prefixByClassId.set(node.id, prefix);
@@ -122,6 +151,18 @@ export function extractSpringRoutes(tree, filePath, lineOffset = 0) {
         if (routePath === null)
             continue;
         const enclosingClass = findEnclosingClass(node);
+        // Suppress a method-level *array-form* route nested under a class-level
+        // array-form @RequestMapping. The class prefix is one of several values that
+        // cannot be resolved to a single string here, so emitting the route would
+        // drop the prefix and yield a wrong unprefixed Route (a false signal, worse
+        // than a missing one). Skipping keeps ingestion a strict subset of the group
+        // scan — safe under routeCoverage:'partial'. Full class-array cross-product
+        // support is tracked in #2280. (Scalar method paths under an array class
+        // prefix are left unchanged: that pre-existing divergence is out of scope.)
+        const isArrayElement = valueNode.parent?.type === 'element_value_array_initializer';
+        if (isArrayElement && enclosingClass && classesWithArrayPrefix.has(enclosingClass.id)) {
+            continue;
+        }
         const classPrefix = enclosingClass ? (prefixByClassId.get(enclosingClass.id) ?? '') : '';
         // `node` is the annotated `method_declaration`; its name field is the
         // handler method name (resolved to a symbol UID later by the routes phase).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gitnexus",
-  "version": "1.6.9-rc.13",
+  "version": "1.6.9-rc.14",
   "description": "Graph-powered code intelligence for AI agents. Index any codebase, query via MCP or CLI.",
   "author": "Abhigyan Patwari",
   "license": "PolyForm-Noncommercial-1.0.0",