gitnexus 1.6.5-rc.22 → 1.6.5-rc.23

package/dist/core/search/hybrid-search.d.ts

@@ -46,5 +46,8 @@ export declare const formatHybridResults: (results: HybridSearchResult[]) => str
  * Execute BM25 + semantic search and merge with RRF.
  * Uses LadybugDB FTS for always-fresh BM25 results (no cached data).
  * The semanticSearch function is injected to keep this module environment-agnostic.
+ *
+ * When FTS is unavailable (e.g. read-only MCP connection, missing indexes),
+ * falls back to semantic-only results instead of crashing (#1489).
  */
 export declare const hybridSearch: (query: string, limit: number, executeQuery: (cypher: string) => Promise<any[]>, semanticSearch: (executeQuery: (cypher: string) => Promise<any[]>, query: string, k?: number) => Promise<SemanticSearchResult[]>) => Promise<HybridSearchResult[]>;

package/dist/core/search/hybrid-search.js

@@ -23,9 +23,14 @@ const RRF_K = 60;
  */
 export const mergeWithRRF = (bm25Results, semanticResults, limit = 10) => {
     const merged = new Map();
+    // Guard against undefined/null inputs (#1489) — when FTS is unavailable
+    // in the MCP process, bm25Results can arrive as undefined and the
+    // for-loop would throw "bm25Results is not iterable".
+    const safeBm25 = bm25Results ?? [];
+    const safeSemantic = semanticResults ?? [];
     // Process BM25 results
-    for (let i = 0; i < bm25Results.length; i++) {
-        const r = bm25Results[i];
+    for (let i = 0; i < safeBm25.length; i++) {
+        const r = safeBm25[i];
         const rrfScore = 1 / (RRF_K + i + 1); // i+1 because rank starts at 1
         merged.set(r.filePath, {
             filePath: r.filePath,
@@ -36,8 +41,8 @@ export const mergeWithRRF = (bm25Results, semanticResults, limit = 10) => {
         });
     }
     // Process semantic results and merge
-    for (let i = 0; i < semanticResults.length; i++) {
-        const r = semanticResults[i];
+    for (let i = 0; i < safeSemantic.length; i++) {
+        const r = safeSemantic[i];
         const rrfScore = 1 / (RRF_K + i + 1);
         const existing = merged.get(r.filePath);
         if (existing) {
@@ -110,10 +115,22 @@ export const formatHybridResults = (results) => {
  * Execute BM25 + semantic search and merge with RRF.
  * Uses LadybugDB FTS for always-fresh BM25 results (no cached data).
  * The semanticSearch function is injected to keep this module environment-agnostic.
+ *
+ * When FTS is unavailable (e.g. read-only MCP connection, missing indexes),
+ * falls back to semantic-only results instead of crashing (#1489).
  */
 export const hybridSearch = async (query, limit, executeQuery, semanticSearch) => {
-    // Use LadybugDB FTS for always-fresh BM25 results
-    const { results: bm25Results } = await searchFTSFromLbug(query, limit);
+    // Use LadybugDB FTS for always-fresh BM25 results.
+    // If FTS fails (e.g. extension not loaded in MCP process), fall back to
+    // semantic-only search instead of crashing with "bm25Results is not iterable".
+    let bm25Results = [];
+    try {
+        const ftsResponse = await searchFTSFromLbug(query, limit);
+        bm25Results = ftsResponse?.results ?? [];
+    }
+    catch {
+        // FTS unavailable — continue with semantic-only search
+    }
     const semanticResults = await semanticSearch(executeQuery, query, limit);
     return mergeWithRRF(bm25Results, semanticResults, limit);
 };

package/dist/mcp/local/local-backend.js

@@ -634,8 +634,10 @@ export class LocalBackend {
             timer.time('bm25', this.bm25Search(repo, searchQuery, searchLimit)),
             timer.time('vector', this.semanticSearch(repo, searchQuery, searchLimit)),
         ]);
-        const bm25Results = bm25SearchResult.results;
-        const ftsUsed = bm25SearchResult.ftsUsed;
+        // Guard against undefined results (#1489) — when FTS is entirely
+        // unavailable the search helper may return an unexpected shape.
+        const bm25Results = bm25SearchResult?.results ?? [];
+        const ftsUsed = bm25SearchResult?.ftsUsed ?? false;
         // Merge via reciprocal rank fusion
         timer.start('merge');
         const scoreMap = new Map();
@@ -651,8 +653,9 @@ export class LocalBackend {
                 scoreMap.set(key, { score: rrfScore, data: result });
             }
         }
-        for (let i = 0; i < semanticResults.length; i++) {
-            const result = semanticResults[i];
+        const safeSemanticResults = semanticResults ?? [];
+        for (let i = 0; i < safeSemanticResults.length; i++) {
+            const result = safeSemanticResults[i];
             const key = result.nodeId || result.filePath;
             const rrfScore = 1 / (60 + i);
             const existing = scoreMap.get(key);
@@ -826,7 +829,15 @@ export class LocalBackend {
      * BM25 keyword search helper - uses LadybugDB FTS for always-fresh results
      */
     async bm25Search(repo, query, limit) {
-        const { searchFTSFromLbug } = await import('../../core/search/bm25-index.js');
+        let searchFTSFromLbug;
+        try {
+            ({ searchFTSFromLbug } = await import('../../core/search/bm25-index.js'));
+        }
+        catch (err) {
+            // Module import can fail in sandboxed MCP contexts (#1489)
+            logger.warn({ err: err?.message }, 'GitNexus: bm25-index.js import failed — falling back to semantic-only');
+            return { results: [], ftsUsed: false };
+        }
         let ftsResponse;
         try {
             ftsResponse = await searchFTSFromLbug(query, limit, repo.id);
@@ -835,8 +846,10 @@ export class LocalBackend {
             logger.error({ err: err.message }, 'GitNexus: BM25/FTS search failed (FTS indexes may not exist) -');
             return { results: [], ftsUsed: false };
         }
-        const bm25Results = ftsResponse.results;
-        const ftsUsed = ftsResponse.ftsAvailable;
+        // Guard against unexpected response shape (#1489) — ftsResponse.results
+        // could be undefined when the FTS extension is unavailable in the MCP process.
+        const bm25Results = ftsResponse?.results ?? [];
+        const ftsUsed = ftsResponse?.ftsAvailable ?? false;
         const results = [];
         for (const bm25Result of bm25Results) {
             const fullPath = bm25Result.filePath;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gitnexus",
-  "version": "1.6.5-rc.22",
+  "version": "1.6.5-rc.23",
   "description": "Graph-powered code intelligence for AI agents. Index any codebase, query via MCP or CLI.",
   "author": "Abhigyan Patwari",
   "license": "PolyForm-Noncommercial-1.0.0",