gitnexus 1.6.10-rc.99 → 1.6.10

package/dist/core/ingestion/languages/go/import-target.js

@@ -1,3 +1,5 @@
+import { buildPackageDirIndex, filesDirectlyInPkgDir, sortedRootFiles, } from '../../import-resolvers/package-dir-index.js';
+import { perFileSet } from '../../import-resolvers/per-file-set.js';
 /**
  * Resolve a Go import path to ALL .go files in the matching package directory.
  *
@@ -7,23 +9,28 @@
  * IMPORTS edge fanout AND binding materialization for every exported symbol in
  * the package.
  *
- * Strategy (first match wins):
- *   1. go.mod-based: strip module prefix, match package directory
- *   2. Non-go.mod / GOPATH: progressively shorter directory suffixes
+ * Strategy:
+ *   1. With go.mod: resolve only imports owned by that module
+ *   2. Without go.mod / GOPATH: progressively shorter directory suffixes
  */
 export function resolveGoImportTarget(targetRaw, _fromFile, allFilePaths, resolutionConfig) {
     if (!targetRaw)
         return null;
     const goModule = resolutionConfig;
-    // 1) go.mod-based: strip module prefix, match directory
-    if (goModule != null &&
-        (targetRaw === goModule.modulePath || targetRaw.startsWith(`${goModule.modulePath}/`))) {
+    // 1) go.mod is authoritative: only this module's exact path or subpackages
+    //    can name files in the workspace. Standard-library and third-party
+    //    imports must not fall through to the suffix matcher below.
+    if (goModule != null) {
+        const ownedByModule = targetRaw === goModule.modulePath || targetRaw.startsWith(`${goModule.modulePath}/`);
+        if (!ownedByModule)
+            return null;
         const relativePkg = targetRaw === goModule.modulePath ? '' : targetRaw.slice(goModule.modulePath.length + 1); // e.g. "internal/models"
         const files = relativePkg === ''
             ? findRootPackageFiles(allFilePaths)
             : findAllFilesInPkgDir(allFilePaths, relativePkg);
         if (files.length > 0)
             return files;
+        return null;
     }
     // 2) Non-go.mod / GOPATH: progressively shorter directory suffixes.
     //    "github.com/xxx/yyy/pkg" → try "github.com/xxx/yyy/pkg/" → "xxx/yyy/pkg/" → "yyy/pkg/"
@@ -37,31 +44,28 @@ export function resolveGoImportTarget(targetRaw, _fromFile, allFilePaths, resolu
     }
     return null;
 }
+/** Go packages exclude `_test.go` files: they are a separate package. */
+function isGoPackageFile(normalized) {
+    return normalized.endsWith('.go') && !normalized.endsWith('_test.go');
+}
+/**
+ * Package index over the file set, memoized on the Set's identity (#2877).
+ *
+ * Every leg above used to walk all of `allFilePaths`, and the GOPATH fallback
+ * walks once per path segment — so without go.mod a single unresolved stdlib or
+ * third-party import ran the whole cascade before returning null and cost
+ * several full workspace scans, making resolution O(imports × files).
+ *
+ * The orchestrator hands the same Set to every import in a pass, so the index
+ * is built once per run. `resolveGoImportTarget` must therefore never copy the
+ * Set before this point — see `import-resolvers/workspace-file-index.ts`.
+ */
+const getGoPackageIndex = perFileSet((allFilePaths) => buildPackageDirIndex(allFilePaths, isGoPackageFile));
 function findRootPackageFiles(allFilePaths) {
-    const result = [];
-    for (const raw of allFilePaths) {
-        const normalized = raw.replace(/\\/g, '/');
-        if (normalized.includes('/'))
-            continue;
-        if (!normalized.endsWith('.go') || normalized.endsWith('_test.go'))
-            continue;
-        result.push(raw);
-    }
-    return result.sort();
+    return sortedRootFiles(getGoPackageIndex(allFilePaths));
 }
 function findAllFilesInPkgDir(allFilePaths, pkgPath) {
-    const pkgDir = '/' + pkgPath + '/';
-    const result = [];
-    for (const raw of allFilePaths) {
-        const normalized = '/' + raw.replace(/\\/g, '/');
-        if (!normalized.includes(pkgDir))
-            continue;
-        if (!normalized.endsWith('.go') || normalized.endsWith('_test.go'))
-            continue;
-        // Ensure file is directly in the package directory (not a subdirectory)
-        const afterPkg = normalized.substring(normalized.indexOf(pkgDir) + pkgDir.length);
-        if (!afterPkg.includes('/'))
-            result.push(raw);
-    }
-    return result;
+    // Deliberately UNSORTED, unlike the root leg: the previous single-pass scan
+    // emitted in Set-iteration order and `filesDirectlyInPkgDir` reproduces it.
+    return filesDirectlyInPkgDir(getGoPackageIndex(allFilePaths), pkgPath);
 }

package/dist/core/ingestion/languages/go/index.d.ts

@@ -10,7 +10,7 @@ export { synthesizeGoTypeBindings } from './type-binding.js';
 export { goArityCompatibility } from './arity.js';
 export { goMergeBindings } from './merge-bindings.js';
 export { goBindingScopeFor, goImportOwningScope, goReceiverBinding } from './simple-hooks.js';
-export { resolveGoImportTarget, type GoResolveContext } from './import-target.js';
+export { resolveGoImportTarget } from './import-target.js';
 export { populateGoPackageSiblings } from './package-siblings.js';
 export { populateGoRangeBindings } from './range-binding.js';
 export { detectGoInterfaceImplementations } from './interface-impls.js';

package/dist/core/ingestion/languages/go/interface-impls.d.ts

@@ -1,4 +1,12 @@
 import type { ParsedFile } from '../../../../_shared/index.js';
+import type { StructuralImplementationResult } from '../../scope-resolution/contract/scope-resolver.js';
 import type { SemanticModel } from '../../model/semantic-model.js';
 import type { ScopeResolutionIndexes } from '../../model/scope-resolution-indexes.js';
-export declare function detectGoInterfaceImplementations(parsedFiles: readonly ParsedFile[], _indexes: ScopeResolutionIndexes, _model: SemanticModel): Map<string, string[]>;
+/** Which method set satisfied an interface. `value` implies pointer too. */
+export type GoReceiverForm = 'value' | 'pointer';
+/** One structural implementor plus the form in which it implements. */
+export type GoStructuralImplementor = {
+    readonly structDefId: string;
+    readonly receiverForm: GoReceiverForm;
+};
+export declare function detectGoInterfaceImplementations(parsedFiles: readonly ParsedFile[], _indexes: ScopeResolutionIndexes, _model: SemanticModel): StructuralImplementationResult;