gitnexus 1.6.10-rc.93 → 1.6.10-rc.95

package/dist/core/lbug/native-check.js

@@ -1,6 +1,10 @@
 import fs from 'fs';
 import path from 'path';
 import { createRequire } from 'node:module';
+import { spawnSync } from 'node:child_process';
+/** Cap the out-of-process native load probe so a hung filesystem cannot wedge a
+ *  CLI startup gate (same bounding rationale as the extension probe below). */
+const NATIVE_LOAD_PROBE_TIMEOUT_MS = 15_000;
 export function checkLbugNative(overridePkgDir) {
     let pkgDir;
     if (overridePkgDir) {
@@ -51,35 +55,68 @@ export function checkLbugNative(overridePkgDir) {
             ].join('\n'),
         };
     }
-    try {
-        const _require = createRequire(import.meta.url);
-        _require(binaryPath);
+    // Validate loadability in a THROWAWAY CHILD PROCESS, not in-process. A merely
+    // truncated or corrupted .node (valid header, missing pages) does not throw a
+    // catchable error — it SIGBUSes the dynamic loader mid-dlopen, which would take
+    // the whole CLI down with a raw exit 135 and no guidance (#2441). Loading it in
+    // a child lets us observe that crash (a non-zero exit or a kill signal) and turn
+    // it into the same actionable failure as a clean load error. The child requires
+    // the binary by absolute path, exactly as the former in-process load did.
+    const probe = spawnSync(process.execPath, ['-e', 'require(process.argv[1])', binaryPath], {
+        encoding: 'utf8',
+        timeout: NATIVE_LOAD_PROBE_TIMEOUT_MS,
+        stdio: ['ignore', 'ignore', 'pipe'],
+        // Run as Node even if process.execPath is an Electron/embedder binary.
+        env: { ...process.env, ELECTRON_RUN_AS_NODE: '1' },
+    });
+    // Only a child that actually RAN and failed proves the binary is bad. If the
+    // probe could not run at all — a spawn error or a timeout, e.g. a sandbox that
+    // forbids subprocesses or a non-Node execPath — we could not test the binary,
+    // so we stay out of the way and let the command's own load be the authority
+    // rather than condemn a healthy binary. (#2441 still holds: a genuinely broken
+    // binary loaded in-process later still exits non-zero.)
+    if (probe.error || probe.status === 0) {
+        return { ok: true, binaryPath };
     }
-    catch (err) {
-        const nativeError = err instanceof Error ? err.message : String(err);
-        return {
-            ok: false,
-            binaryPath,
-            message: [
-                'LadybugDB native binary (lbugjs.node) exists but failed to load:',
-                `  ${nativeError}`,
-                '',
-                'This can happen with a truncated file, ABI mismatch, or wrong-platform binary.',
-                '',
-                'To repair:',
-                `  node ${path.join(pkgDir, 'install.js')}`,
-                '',
-                'If install scripts were skipped (pnpm dlx / pnpx / ignore-scripts):',
-                '  pnpm --allow-build=@ladybugdb/core --allow-build=gitnexus --allow-build=tree-sitter \\',
-                '    dlx gitnexus@latest serve',
-                '  pnpm add -g --allow-build=@ladybugdb/core --allow-build=gitnexus --allow-build=tree-sitter gitnexus',
-                '',
-                'If using bun, add to package.json and reinstall:',
-                '  "trustedDependencies": ["@ladybugdb/core"]',
-            ].join('\n'),
-        };
+    return {
+        ok: false,
+        binaryPath,
+        message: [
+            'LadybugDB native binary (lbugjs.node) exists but failed to load:',
+            `  ${describeNativeLoadFailure(probe)}`,
+            '',
+            'This can happen with a truncated file, ABI mismatch, or wrong-platform binary.',
+            '',
+            'To repair:',
+            `  node ${path.join(pkgDir, 'install.js')}`,
+            '',
+            'If install scripts were skipped (pnpm dlx / pnpx / ignore-scripts):',
+            '  pnpm --allow-build=@ladybugdb/core --allow-build=gitnexus --allow-build=tree-sitter \\',
+            '    dlx gitnexus@latest serve',
+            '  pnpm add -g --allow-build=@ladybugdb/core --allow-build=gitnexus --allow-build=tree-sitter gitnexus',
+            '',
+            'If using bun, add to package.json and reinstall:',
+            '  "trustedDependencies": ["@ladybugdb/core"]',
+        ].join('\n'),
+    };
+}
+/**
+ * Describe a child-observed native load failure. Reached only after a probe that
+ * actually ran and failed: a fatal signal (SIGBUS/SIGSEGV ⇒ truncated/corrupt
+ * binary), otherwise the child's own load error lifted from its stderr.
+ */
+function describeNativeLoadFailure(probe) {
+    if (probe.signal) {
+        return `crashed while loading (signal ${probe.signal}) — the binary is likely truncated or corrupted`;
     }
-    return { ok: true, binaryPath };
+    const lines = (probe.stderr ?? '')
+        .split('\n')
+        .map((line) => line.trim())
+        .filter(Boolean);
+    const errorLine = lines.find((line) => /^\w*Error: /.test(line));
+    return (errorLine?.replace(/^\w*Error:\s*/, '') ??
+        lines.at(-1) ??
+        `exited with code ${probe.status ?? 'unknown'}`);
 }
 const DEFAULT_FTS_PROBE_TIMEOUT_MS = 10_000;
 /** Close each result, swallowing close-time errors so a successful LOAD is not

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "gitnexus",
-  "version": "1.6.10-rc.93",
+  "version": "1.6.10-rc.95",
   "description": "Graph-powered code intelligence for AI agents. Index any codebase, query via MCP or CLI.",
   "author": "Abhigyan Patwari",
   "license": "PolyForm-Noncommercial-1.0.0",