gitnexus 1.4.6 → 1.4.8

package/dist/core/ingestion/type-extractors/jvm.js

@@ -1,4 +1,5 @@
-import { extractSimpleTypeName, extractVarName, findChildByType, extractGenericTypeArgs, resolveIterableElementType, methodToTypeArgPosition, extractElementTypeFromString } from './shared.js';
+import { extractSimpleTypeName, extractVarName, extractGenericTypeArgs, resolveIterableElementType, methodToTypeArgPosition, extractElementTypeFromString } from './shared.js';
+import { findChild } from '../resolvers/utils.js';
 // ── Java ──────────────────────────────────────────────────────────────────
 const JAVA_DECLARATION_NODE_TYPES = new Set([
     'local_variable_declaration',
@@ -78,7 +79,7 @@ const scanJavaConstructorBinding = (node) => {
         return undefined;
     if (typeNode.text !== 'var')
         return undefined;
-    const declarator = findChildByType(node, 'variable_declarator');
+    const declarator = findChild(node, 'variable_declarator');
     if (!declarator)
         return undefined;
     const nameNode = declarator.childForFieldName('name');
@@ -219,6 +220,32 @@ const extractJavaPendingAssignment = (node, scopeEnv) => {
             continue;
         if (valueNode.type === 'identifier' || valueNode.type === 'simple_identifier')
             return { kind: 'copy', lhs, rhs: valueNode.text };
+        // field_access RHS → fieldAccess (a.field)
+        if (valueNode.type === 'field_access') {
+            const obj = valueNode.childForFieldName('object');
+            const field = valueNode.childForFieldName('field');
+            if (obj?.type === 'identifier' && field) {
+                return { kind: 'fieldAccess', lhs, receiver: obj.text, field: field.text };
+            }
+        }
+        // method_invocation RHS
+        if (valueNode.type === 'method_invocation') {
+            const objField = valueNode.childForFieldName('object');
+            if (!objField) {
+                // No receiver → callResult
+                const nameField = valueNode.childForFieldName('name');
+                if (nameField?.type === 'identifier') {
+                    return { kind: 'callResult', lhs, callee: nameField.text };
+                }
+            }
+            else if (objField.type === 'identifier') {
+                // With receiver → methodCallResult
+                const nameField = valueNode.childForFieldName('name');
+                if (nameField?.type === 'identifier') {
+                    return { kind: 'methodCallResult', lhs, receiver: objField.text, method: nameField.text };
+                }
+            }
+        }
     }
     return undefined;
 };
@@ -267,6 +294,39 @@ const extractJavaPatternBinding = (node) => {
         return undefined;
     return { varName, typeName };
 };
+/** Infer the type of a literal AST node for Java/Kotlin overload disambiguation. */
+const inferJvmLiteralType = (node) => {
+    switch (node.type) {
+        case 'decimal_integer_literal':
+        case 'integer_literal':
+        case 'hex_integer_literal':
+        case 'octal_integer_literal':
+        case 'binary_integer_literal':
+            // Check for long suffix
+            if (node.text.endsWith('L') || node.text.endsWith('l'))
+                return 'long';
+            return 'int';
+        case 'decimal_floating_point_literal':
+        case 'real_literal':
+            if (node.text.endsWith('f') || node.text.endsWith('F'))
+                return 'float';
+            return 'double';
+        case 'string_literal':
+        case 'line_string_literal':
+        case 'multi_line_string_literal':
+            return 'String';
+        case 'character_literal':
+            return 'char';
+        case 'true':
+        case 'false':
+        case 'boolean_literal':
+            return 'boolean';
+        case 'null_literal':
+            return 'null';
+        default:
+            return undefined;
+    }
+};
 export const javaTypeConfig = {
     declarationNodeTypes: JAVA_DECLARATION_NODE_TYPES,
     forLoopNodeTypes: JAVA_FOR_LOOP_NODE_TYPES,
@@ -278,6 +338,7 @@ export const javaTypeConfig = {
     extractForLoopBinding: extractJavaForLoopBinding,
     extractPendingAssignment: extractJavaPendingAssignment,
     extractPatternBinding: extractJavaPatternBinding,
+    inferLiteralType: inferJvmLiteralType,
 };
 // ── Kotlin ────────────────────────────────────────────────────────────────
 const KOTLIN_DECLARATION_NODE_TYPES = new Set([
@@ -288,10 +349,11 @@ const KOTLIN_DECLARATION_NODE_TYPES = new Set([
 const extractKotlinDeclaration = (node, env) => {
     if (node.type === 'property_declaration') {
         // Kotlin property_declaration: name/type are inside a variable_declaration child
-        const varDecl = findChildByType(node, 'variable_declaration');
+        const varDecl = findChild(node, 'variable_declaration');
         if (varDecl) {
-            const nameNode = findChildByType(varDecl, 'simple_identifier');
-            const typeNode = findChildByType(varDecl, 'user_type');
+            const nameNode = findChild(varDecl, 'simple_identifier');
+            const typeNode = findChild(varDecl, 'user_type')
+                ?? findChild(varDecl, 'nullable_type');
             if (!nameNode || !typeNode)
                 return;
             const varName = extractVarName(nameNode);
@@ -302,9 +364,9 @@ const extractKotlinDeclaration = (node, env) => {
         }
         // Fallback: try direct fields
         const nameNode = node.childForFieldName('name')
-            ?? findChildByType(node, 'simple_identifier');
+            ?? findChild(node, 'simple_identifier');
         const typeNode = node.childForFieldName('type')
-            ?? findChildByType(node, 'user_type');
+            ?? findChild(node, 'user_type');
         if (!nameNode || !typeNode)
             return;
         const varName = extractVarName(nameNode);
@@ -314,8 +376,8 @@ const extractKotlinDeclaration = (node, env) => {
     }
     else if (node.type === 'variable_declaration') {
         // variable_declaration directly inside functions
-        const nameNode = findChildByType(node, 'simple_identifier');
-        const typeNode = findChildByType(node, 'user_type');
+        const nameNode = findChild(node, 'simple_identifier');
+        const typeNode = findChild(node, 'user_type');
         if (nameNode && typeNode) {
             const varName = extractVarName(nameNode);
             const typeName = extractSimpleTypeName(typeNode);
@@ -327,7 +389,7 @@ const extractKotlinDeclaration = (node, env) => {
 /** Kotlin: parameter / formal_parameter → type name.
  *  Kotlin's tree-sitter grammar uses positional children (simple_identifier, user_type)
  *  rather than named fields (name, type) on `parameter` nodes, so we fall back to
- *  findChildByType when childForFieldName returns null. */
+ *  findChild when childForFieldName returns null. */
 const extractKotlinParameter = (node, env) => {
     let nameNode = null;
     let typeNode = null;
@@ -341,9 +403,10 @@ const extractKotlinParameter = (node, env) => {
     }
     // Fallback: Kotlin `parameter` nodes use positional children, not named fields
     if (!nameNode)
-        nameNode = findChildByType(node, 'simple_identifier');
+        nameNode = findChild(node, 'simple_identifier');
     if (!typeNode)
-        typeNode = findChildByType(node, 'user_type');
+        typeNode = findChild(node, 'user_type')
+            ?? findChild(node, 'nullable_type');
     if (!nameNode || !typeNode)
         return;
     const varName = extractVarName(nameNode);
@@ -351,48 +414,61 @@ const extractKotlinParameter = (node, env) => {
     if (varName && typeName)
         env.set(varName, typeName);
 };
-/** Kotlin: val user = User() — infer type from call_expression when callee is a known class.
- *  Kotlin constructors are syntactically identical to function calls, so we verify
- *  against classNames (which may include cross-file SymbolTable lookups). */
-const extractKotlinInitializer = (node, env, classNames) => {
+/** Find the constructor callee name in a Kotlin property_declaration's initializer.
+ *  Returns the class name if the callee is a verified class constructor, undefined otherwise. */
+const findKotlinConstructorCallee = (node, classNames) => {
     if (node.type !== 'property_declaration')
-        return;
-    // Skip if there's an explicit type annotation — Tier 0 already handled it
-    const varDecl = findChildByType(node, 'variable_declaration');
-    if (varDecl && findChildByType(varDecl, 'user_type'))
-        return;
-    // Get the initializer value — the call_expression after '='
+        return undefined;
     const value = node.childForFieldName('value')
-        ?? findChildByType(node, 'call_expression');
+        ?? findChild(node, 'call_expression');
     if (!value || value.type !== 'call_expression')
-        return;
-    // The callee is the first child of call_expression (simple_identifier for direct calls)
+        return undefined;
     const callee = value.firstNamedChild;
     if (!callee || callee.type !== 'simple_identifier')
-        return;
+        return undefined;
     const calleeName = callee.text;
     if (!calleeName || !classNames.has(calleeName))
+        return undefined;
+    return calleeName;
+};
+/** Kotlin: val user = User() — infer type from call_expression when callee is a known class.
+ *  Kotlin constructors are syntactically identical to function calls, so we verify
+ *  against classNames (which may include cross-file SymbolTable lookups). */
+const extractKotlinInitializer = (node, env, classNames) => {
+    // Skip if there's an explicit type annotation — Tier 0 already handled it
+    const varDecl = findChild(node, 'variable_declaration');
+    if (varDecl && findChild(varDecl, 'user_type'))
+        return;
+    const calleeName = findKotlinConstructorCallee(node, classNames);
+    if (!calleeName)
         return;
     // Extract the variable name from the variable_declaration inside property_declaration
     const nameNode = varDecl
-        ? findChildByType(varDecl, 'simple_identifier')
-        : findChildByType(node, 'simple_identifier');
+        ? findChild(varDecl, 'simple_identifier')
+        : findChild(node, 'simple_identifier');
     if (!nameNode)
         return;
     const varName = extractVarName(nameNode);
     if (varName)
         env.set(varName, calleeName);
 };
+/** Kotlin: detect constructor type from call_expression in typed declarations.
+ *  Unlike extractKotlinInitializer (which SKIPS typed declarations), this detects
+ *  the constructor type EVEN when a type annotation exists, enabling virtual dispatch
+ *  for patterns like `val a: Animal = Dog()`. */
+const detectKotlinConstructorType = (node, classNames) => {
+    return findKotlinConstructorCallee(node, classNames);
+};
 /** Kotlin: val x = User(...) — constructor binding for property_declaration with call_expression */
 const scanKotlinConstructorBinding = (node) => {
     if (node.type !== 'property_declaration')
         return undefined;
-    const varDecl = findChildByType(node, 'variable_declaration');
+    const varDecl = findChild(node, 'variable_declaration');
     if (!varDecl)
         return undefined;
-    if (findChildByType(varDecl, 'user_type'))
+    if (findChild(varDecl, 'user_type'))
         return undefined;
-    const callExpr = findChildByType(node, 'call_expression');
+    const callExpr = findChild(node, 'call_expression');
     if (!callExpr)
         return undefined;
     const callee = callExpr.firstNamedChild;
@@ -414,7 +490,7 @@ const scanKotlinConstructorBinding = (node) => {
     }
     if (!calleeName)
         return undefined;
-    const nameNode = findChildByType(varDecl, 'simple_identifier');
+    const nameNode = findChild(varDecl, 'simple_identifier');
     if (!nameNode)
         return undefined;
     return { varName: nameNode.text, calleeName };
@@ -427,7 +503,7 @@ const KOTLIN_FOR_LOOP_NODE_TYPES = new Set([
  *  Handles the type_projection wrapper that Kotlin uses for generic type arguments. */
 const extractKotlinElementTypeFromTypeNode = (typeNode, pos = 'last') => {
     if (typeNode.type === 'user_type') {
-        const argsNode = findChildByType(typeNode, 'type_arguments');
+        const argsNode = findChild(typeNode, 'type_arguments');
         if (argsNode && argsNode.namedChildCount >= 1) {
             const targetArg = pos === 'first'
                 ? argsNode.namedChild(0)
@@ -450,16 +526,16 @@ const findKotlinParamElementType = (iterableName, startNode, pos = 'last') => {
     let current = startNode.parent;
     while (current) {
         if (current.type === 'function_declaration') {
-            const paramsNode = findChildByType(current, 'function_value_parameters');
+            const paramsNode = findChild(current, 'function_value_parameters');
             if (paramsNode) {
                 for (let i = 0; i < paramsNode.namedChildCount; i++) {
                     const param = paramsNode.namedChild(i);
                     if (!param || param.type !== 'parameter')
                         continue;
-                    const nameNode = findChildByType(param, 'simple_identifier');
+                    const nameNode = findChild(param, 'simple_identifier');
                     if (nameNode?.text !== iterableName)
                         continue;
-                    const typeNode = findChildByType(param, 'user_type');
+                    const typeNode = findChild(param, 'user_type');
                     if (typeNode)
                         return extractKotlinElementTypeFromTypeNode(typeNode, pos);
                 }
@@ -474,17 +550,17 @@ const findKotlinParamElementType = (iterableName, startNode, pos = 'last') => {
  *  Tier 1c: for `for (user in users)` without annotation, resolves from iterable. */
 const extractKotlinForLoopBinding = (node, ctx) => {
     const { scopeEnv, declarationTypeNodes, scope, returnTypeLookup } = ctx;
-    const varDecl = findChildByType(node, 'variable_declaration');
+    const varDecl = findChild(node, 'variable_declaration');
     if (!varDecl)
         return;
-    const nameNode = findChildByType(varDecl, 'simple_identifier');
+    const nameNode = findChild(varDecl, 'simple_identifier');
     if (!nameNode)
         return;
     const varName = extractVarName(nameNode);
     if (!varName)
         return;
     // Explicit type annotation (existing behavior): for (user: User in users)
-    const typeNode = findChildByType(varDecl, 'user_type');
+    const typeNode = findChild(varDecl, 'user_type');
     if (typeNode) {
         const typeName = extractSimpleTypeName(typeNode);
         if (typeName)
@@ -514,9 +590,9 @@ const extractKotlinForLoopBinding = (node, ctx) => {
         if (child.type === 'navigation_expression') {
             // data.keys → navigation_expression > simple_identifier(data) + navigation_suffix > simple_identifier(keys)
             const obj = child.firstNamedChild;
-            const suffix = findChildByType(child, 'navigation_suffix');
-            const prop = suffix ? findChildByType(suffix, 'simple_identifier') : null;
-            const hasCallSuffix = suffix ? findChildByType(suffix, 'call_suffix') !== null : false;
+            const suffix = findChild(child, 'navigation_suffix');
+            const prop = suffix ? findChild(suffix, 'simple_identifier') : null;
+            const hasCallSuffix = suffix ? findChild(suffix, 'call_suffix') !== null : false;
             // Always try object as iterable + property as method first (handles data.values, data.keys).
             // For bare property access without call_suffix, also save property as fallback
             // (handles this.users, repo.items where the property IS the iterable).
@@ -536,9 +612,9 @@ const extractKotlinForLoopBinding = (node, ctx) => {
                 const obj = callee.firstNamedChild;
                 if (obj?.type === 'simple_identifier')
                     iterableName = obj.text;
-                const suffix = findChildByType(callee, 'navigation_suffix');
+                const suffix = findChild(callee, 'navigation_suffix');
                 if (suffix) {
-                    const prop = findChildByType(suffix, 'simple_identifier');
+                    const prop = findChild(suffix, 'simple_identifier');
                     if (prop)
                         methodName = prop.text;
                 }
@@ -580,7 +656,7 @@ const extractKotlinForLoopBinding = (node, ctx) => {
 const extractKotlinPendingAssignment = (node, scopeEnv) => {
     if (node.type === 'property_declaration') {
         // Find the variable name from variable_declaration child
-        const varDecl = findChildByType(node, 'variable_declaration');
+        const varDecl = findChild(node, 'variable_declaration');
         if (!varDecl)
             return undefined;
         const nameNode = varDecl.firstNamedChild;
@@ -589,7 +665,7 @@ const extractKotlinPendingAssignment = (node, scopeEnv) => {
         const lhs = nameNode.text;
         if (scopeEnv.has(lhs))
             return undefined;
-        // Find the RHS: a simple_identifier sibling after the "=" token
+        // Find the RHS after the "=" token
         let foundEq = false;
         for (let i = 0; i < node.childCount; i++) {
             const child = node.child(i);
@@ -602,19 +678,43 @@ const extractKotlinPendingAssignment = (node, scopeEnv) => {
             if (foundEq && child.type === 'simple_identifier') {
                 return { kind: 'copy', lhs, rhs: child.text };
             }
+            // navigation_expression RHS → fieldAccess (a.field)
+            if (foundEq && child.type === 'navigation_expression') {
+                const recv = child.firstNamedChild;
+                const suffix = child.lastNamedChild;
+                const fieldNode = suffix?.type === 'navigation_suffix' ? suffix.lastNamedChild : suffix;
+                if (recv?.type === 'simple_identifier' && fieldNode?.type === 'simple_identifier') {
+                    return { kind: 'fieldAccess', lhs, receiver: recv.text, field: fieldNode.text };
+                }
+            }
+            // call_expression RHS
+            if (foundEq && child.type === 'call_expression') {
+                const calleeNode = child.firstNamedChild;
+                if (calleeNode?.type === 'simple_identifier') {
+                    return { kind: 'callResult', lhs, callee: calleeNode.text };
+                }
+                // navigation_expression callee → methodCallResult (a.method())
+                if (calleeNode?.type === 'navigation_expression') {
+                    const recv = calleeNode.firstNamedChild;
+                    const suffix = calleeNode.lastNamedChild;
+                    const methodNode = suffix?.type === 'navigation_suffix' ? suffix.lastNamedChild : suffix;
+                    if (recv?.type === 'simple_identifier' && methodNode?.type === 'simple_identifier') {
+                        return { kind: 'methodCallResult', lhs, receiver: recv.text, method: methodNode.text };
+                    }
+                }
+            }
         }
         return undefined;
     }
     if (node.type === 'variable_declaration') {
         // variable_declaration directly inside functions: simple_identifier children
-        const nameNode = findChildByType(node, 'simple_identifier');
+        const nameNode = findChild(node, 'simple_identifier');
         if (!nameNode)
             return undefined;
         const lhs = nameNode.text;
         if (scopeEnv.has(lhs))
             return undefined;
-        // Look for RHS simple_identifier after "=" in the parent (property_declaration)
-        // variable_declaration itself doesn't contain "=" — it's in the parent
+        // Look for RHS after "=" in the parent (property_declaration)
         const parent = node.parent;
         if (!parent)
             return undefined;
@@ -630,6 +730,28 @@ const extractKotlinPendingAssignment = (node, scopeEnv) => {
             if (foundEq && child.type === 'simple_identifier') {
                 return { kind: 'copy', lhs, rhs: child.text };
             }
+            if (foundEq && child.type === 'navigation_expression') {
+                const recv = child.firstNamedChild;
+                const suffix = child.lastNamedChild;
+                const fieldNode = suffix?.type === 'navigation_suffix' ? suffix.lastNamedChild : suffix;
+                if (recv?.type === 'simple_identifier' && fieldNode?.type === 'simple_identifier') {
+                    return { kind: 'fieldAccess', lhs, receiver: recv.text, field: fieldNode.text };
+                }
+            }
+            if (foundEq && child.type === 'call_expression') {
+                const calleeNode = child.firstNamedChild;
+                if (calleeNode?.type === 'simple_identifier') {
+                    return { kind: 'callResult', lhs, callee: calleeNode.text };
+                }
+                if (calleeNode?.type === 'navigation_expression') {
+                    const recv = calleeNode.firstNamedChild;
+                    const suffix = calleeNode.lastNamedChild;
+                    const methodNode = suffix?.type === 'navigation_suffix' ? suffix.lastNamedChild : suffix;
+                    if (recv?.type === 'simple_identifier' && methodNode?.type === 'simple_identifier') {
+                        return { kind: 'methodCallResult', lhs, receiver: recv.text, method: methodNode.text };
+                    }
+                }
+            }
         }
         return undefined;
     }
@@ -645,32 +767,83 @@ const findAncestorByType = (node, type) => {
     }
     return undefined;
 };
-const extractKotlinPatternBinding = (node) => {
-    if (node.type !== 'type_test')
-        return undefined;
-    const typeNode = node.lastNamedChild;
-    if (!typeNode)
-        return undefined;
-    const typeName = extractSimpleTypeName(typeNode);
-    if (!typeName)
-        return undefined;
-    const whenExpr = findAncestorByType(node, 'when_expression');
-    if (!whenExpr)
-        return undefined;
-    const whenSubject = whenExpr.namedChild(0);
-    const subject = whenSubject?.firstNamedChild ?? whenSubject;
-    if (!subject)
-        return undefined;
-    const varName = extractVarName(subject);
-    if (!varName)
+const extractKotlinPatternBinding = (node, scopeEnv, declarationTypeNodes, scope) => {
+    // Kotlin when/is smart casts (existing behavior)
+    if (node.type === 'type_test') {
+        const typeNode = node.lastNamedChild;
+        if (!typeNode)
+            return undefined;
+        const typeName = extractSimpleTypeName(typeNode);
+        if (!typeName)
+            return undefined;
+        const whenExpr = findAncestorByType(node, 'when_expression');
+        if (!whenExpr)
+            return undefined;
+        const whenSubject = whenExpr.namedChild(0);
+        const subject = whenSubject?.firstNamedChild ?? whenSubject;
+        if (!subject)
+            return undefined;
+        const varName = extractVarName(subject);
+        if (!varName)
+            return undefined;
+        return { varName, typeName };
+    }
+    // Null-check narrowing: if (x != null) { ... }
+    // Kotlin AST: equality_expression > simple_identifier, "!=" [anon], "null" [anon]
+    // Note: `null` is an anonymous node in tree-sitter-kotlin, not `null_literal`.
+    if (node.type === 'equality_expression') {
+        const op = node.children.find(c => !c.isNamed && c.text === '!=');
+        if (!op)
+            return undefined;
+        // `null` is anonymous in Kotlin grammar — use positional child scan
+        let varNode;
+        let hasNull = false;
+        for (let i = 0; i < node.childCount; i++) {
+            const c = node.child(i);
+            if (!c)
+                continue;
+            if (c.type === 'simple_identifier')
+                varNode = c;
+            if (!c.isNamed && c.text === 'null')
+                hasNull = true;
+        }
+        if (!varNode || !hasNull)
+            return undefined;
+        const varName = varNode.text;
+        const resolvedType = scopeEnv.get(varName);
+        if (!resolvedType)
+            return undefined;
+        // Check if the original declaration type was nullable (ends with ?)
+        const declTypeNode = declarationTypeNodes.get(`${scope}\0${varName}`);
+        if (!declTypeNode)
+            return undefined;
+        const declText = declTypeNode.text;
+        if (!declText.includes('?') && !declText.includes('null'))
+            return undefined;
+        // Find the if-body: walk up to if_expression, then find control_structure_body
+        const ifExpr = findAncestorByType(node, 'if_expression');
+        if (!ifExpr)
+            return undefined;
+        // The consequence is the first control_structure_body child
+        for (let i = 0; i < ifExpr.childCount; i++) {
+            const child = ifExpr.child(i);
+            if (child?.type === 'control_structure_body') {
+                return {
+                    varName,
+                    typeName: resolvedType,
+                    narrowingRange: { startIndex: child.startIndex, endIndex: child.endIndex },
+                };
+            }
+        }
         return undefined;
-    return { varName, typeName };
+    }
+    return undefined;
 };
 export const kotlinTypeConfig = {
     allowPatternBindingOverwrite: true,
     declarationNodeTypes: KOTLIN_DECLARATION_NODE_TYPES,
     forLoopNodeTypes: KOTLIN_FOR_LOOP_NODE_TYPES,
-    patternBindingNodeTypes: new Set(['type_test']),
+    patternBindingNodeTypes: new Set(['type_test', 'equality_expression']),
     extractDeclaration: extractKotlinDeclaration,
     extractParameter: extractKotlinParameter,
     extractInitializer: extractKotlinInitializer,
@@ -678,4 +851,6 @@ export const kotlinTypeConfig = {
     extractForLoopBinding: extractKotlinForLoopBinding,
     extractPendingAssignment: extractKotlinPendingAssignment,
     extractPatternBinding: extractKotlinPatternBinding,
+    inferLiteralType: inferJvmLiteralType,
+    detectConstructorType: detectKotlinConstructorType,
 };

package/dist/core/ingestion/type-extractors/php.js

@@ -373,13 +373,40 @@ const extractPendingAssignment = (node, scopeEnv) => {
     const right = node.childForFieldName('right');
     if (!left || !right)
         return undefined;
-    if (left.type !== 'variable_name' || right.type !== 'variable_name')
+    if (left.type !== 'variable_name')
         return undefined;
     const lhs = left.text;
-    const rhs = right.text;
-    if (!lhs || !rhs || scopeEnv.has(lhs))
+    if (!lhs || scopeEnv.has(lhs))
         return undefined;
-    return { kind: 'copy', lhs, rhs };
+    if (right.type === 'variable_name') {
+        const rhs = right.text;
+        if (rhs)
+            return { kind: 'copy', lhs, rhs };
+    }
+    // member_access_expression RHS → fieldAccess ($a->field)
+    if (right.type === 'member_access_expression') {
+        const obj = right.childForFieldName('object');
+        const name = right.childForFieldName('name');
+        if (obj?.type === 'variable_name' && name) {
+            return { kind: 'fieldAccess', lhs, receiver: obj.text, field: name.text };
+        }
+    }
+    // function_call_expression RHS → callResult (bare function calls only)
+    if (right.type === 'function_call_expression') {
+        const funcNode = right.childForFieldName('function');
+        if (funcNode?.type === 'name') {
+            return { kind: 'callResult', lhs, callee: funcNode.text };
+        }
+    }
+    // member_call_expression RHS → methodCallResult ($a->method())
+    if (right.type === 'member_call_expression') {
+        const obj = right.childForFieldName('object');
+        const name = right.childForFieldName('name');
+        if (obj?.type === 'variable_name' && name) {
+            return { kind: 'methodCallResult', lhs, receiver: obj.text, method: name.text };
+        }
+    }
+    return undefined;
 };
 const FOR_LOOP_NODE_TYPES = new Set([
     'foreach_statement',