gitmem-mcp 1.0.2 → 1.0.4

package/dist/tools/session-close.js

@@ -4,7 +4,7 @@
  * Persist session with compliance validation.
  * Validates that required fields are present based on close type.
  *
- * Performance target: <3000ms (OD-429)
+ * Performance target: <3000ms
  */
 import { v4 as uuidv4 } from "uuid";
 import { detectAgent } from "../services/agent-detection.js";
@@ -12,10 +12,10 @@ import * as supabase from "../services/supabase-client.js";
 import { embed, isEmbeddingAvailable } from "../services/embedding.js";
 import { hasSupabase } from "../services/tier.js";
 import { getStorage } from "../services/storage.js";
-import { clearCurrentSession, getSurfacedScars, getConfirmations, getObservations, getChildren, getThreads, getSessionActivity } from "../services/session-state.js"; // OD-547, OD-552, v2 Phase 2
-import { normalizeThreads, mergeThreadStates, migrateStringThread, saveThreadsFile } from "../services/thread-manager.js"; // OD-thread-lifecycle
-import { deduplicateThreadList } from "../services/thread-dedup.js"; // OD-641
-import { syncThreadsToSupabase, loadOpenThreadEmbeddings } from "../services/thread-supabase.js"; // OD-624
+import { clearCurrentSession, getSurfacedScars, getConfirmations, getObservations, getChildren, getThreads, getSessionActivity } from "../services/session-state.js";
+import { normalizeThreads, mergeThreadStates, migrateStringThread, saveThreadsFile } from "../services/thread-manager.js"; // 
+import { deduplicateThreadList } from "../services/thread-dedup.js";
+import { syncThreadsToSupabase, loadOpenThreadEmbeddings } from "../services/thread-supabase.js";
 import { validateSessionClose, buildCloseCompliance, } from "../services/compliance-validator.js";
 import { normalizeReflectionKeys } from "../constants/closing-questions.js";
 import { Timer, recordMetrics, buildPerformanceData, updateRelevanceData, } from "../services/metrics.js";
@@ -27,9 +27,10 @@ import { processTranscript } from "../services/transcript-chunker.js";
 import * as fs from "fs";
 import * as path from "path";
 import * as os from "os";
-import { getGitmemPath, getGitmemDir, getSessionPath } from "../services/gitmem-dir.js";
+import { getGitmemPath, getSessionPath, getSessionDir } from "../services/gitmem-dir.js";
 import { unregisterSession, findSessionByHostPid } from "../services/active-sessions.js";
 import { loadSuggestions, saveSuggestions, detectSuggestedThreads, loadRecentSessionEmbeddings } from "../services/thread-suggestions.js";
+import { writeAgentBriefing } from "../services/agent-briefing.js";
 /**
  * Normalize scars_applied to string[].
  * Handles both string (prose answer from agents) and string[] (schema-correct array).
@@ -54,7 +55,7 @@ function countScarsApplied(scarsApplied) {
 }
 /**
  * Find the most recently modified transcript file in Claude Code projects directory
- * OD-538: Search by recency, not by filename matching (supports post-compaction)
+ * Search by recency, not by filename matching (supports post-compaction)
  */
 function findMostRecentTranscript(projectsDir, cwdBasename, cwdFull) {
     // Claude Code names project dirs by replacing / with - in the full CWD path
@@ -100,7 +101,7 @@ function findMostRecentTranscript(projectsDir, cwdBasename, cwdFull) {
 }
 /**
  * Extract Claude Code session ID from transcript JSONL content
- * OD-538: Provides traceability between GitMem sessions and IDE sessions
+ * Provides traceability between GitMem sessions and IDE sessions
  */
 function extractClaudeSessionId(transcriptContent, filePath) {
     try {
@@ -167,7 +168,7 @@ async function sessionCloseFree(params, timer) {
         if (params.decisions && params.decisions.length > 0) {
             sessionData.decisions = params.decisions.map((d) => d.title);
         }
-        // OD-thread-lifecycle: Normalize threads for free tier too
+        // : Normalize threads for free tier too
         const freeSessionThreads = getThreads();
         if (params.open_threads && params.open_threads.length > 0) {
             const normalized = normalizeThreads(params.open_threads, params.session_id);
@@ -205,6 +206,9 @@ async function sessionCloseFree(params, timer) {
                 });
             }
         }
+        // Generate agent-briefing.md for PMEM bridge
+        const decisionsCount = params.decisions?.length || 0;
+        await writeAgentBriefing(learningsCount, decisionsCount);
         // Clear session state
         clearCurrentSession();
         // GIT-21: Clean up session files (registry, per-session dir, legacy file)
@@ -353,9 +357,9 @@ function cleanupSessionFiles(sessionId) {
     catch (error) {
         console.warn("[session_close] Failed to unregister session:", error);
     }
-    // 2. Delete per-session directory
+    // 2. Delete per-session directory (sanitized via getSessionDir to prevent traversal)
     try {
-        const sessionDir = path.join(getGitmemDir(), "sessions", sessionId);
+        const sessionDir = getSessionDir(sessionId);
         if (fs.existsSync(sessionDir)) {
             fs.rmSync(sessionDir, { recursive: true, force: true });
             console.error(`[session_close] Cleaned up session directory: ${sessionDir}`);
@@ -366,7 +370,7 @@ function cleanupSessionFiles(sessionId) {
     }
     // Legacy active-session.json cleanup removed — file is no longer written
 }
-// UUID and short-ID format validation for session_id (OD-548)
+// UUID and short-ID format validation for session_id
 const UUID_REGEX = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i;
 const SHORT_ID_REGEX = /^[0-9a-f]{8}$/i;
 function isValidSessionId(id) {
@@ -406,7 +410,7 @@ function buildSessionRecord(params, existingSession, isRetroactive, agentIdentit
             reflection.human_additions = params.human_corrections;
         }
         sessionData.closing_reflection = reflection;
-        // OD-666: Distill Q8+Q9 into rapport_summary for cross-agent surfacing
+        // Distill Q8+Q9 into rapport_summary for cross-agent surfacing
         const q8 = params.closing_reflection.collaborative_dynamic;
         const q9 = params.closing_reflection.rapport_notes;
         if (q8 || q9) {
@@ -418,7 +422,7 @@ function buildSessionRecord(params, existingSession, isRetroactive, agentIdentit
     if (params.decisions && params.decisions.length > 0) {
         sessionData.decisions = params.decisions.map((d) => d.title);
     }
-    // OD-thread-lifecycle: Normalize and merge open threads
+    // : Normalize and merge open threads
     const sessionThreads = getThreads();
     if (params.open_threads && params.open_threads.length > 0) {
         const normalized = normalizeThreads(params.open_threads, params.session_id);
@@ -430,7 +434,7 @@ function buildSessionRecord(params, existingSession, isRetroactive, agentIdentit
     else if (sessionThreads.length > 0) {
         sessionData.open_threads = sessionThreads;
     }
-    // OD-534: If project_state provided, prepend it to open_threads as a ThreadObject
+    // If project_state provided, prepend it to open_threads as a ThreadObject
     if (params.project_state) {
         const projectStateText = `PROJECT STATE: ${params.project_state}`;
         const existing = (sessionData.open_threads || []);
@@ -528,7 +532,7 @@ async function captureSessionTranscript(sessionId, params, existingSession, isRe
                 patch_warning: saveResult.patch_warning,
             };
             console.error(`[session_close] Transcript saved: ${saveResult.transcript_path} (${saveResult.size_kb}KB)`);
-            // OD-540: Process transcript for semantic search (fire-and-forget — chunking is expensive)
+            // Process transcript for semantic search (fire-and-forget — chunking is expensive)
             processTranscript(sessionId, transcriptContent, transcriptProject)
                 .then(result => {
                 if (result.success) {
@@ -677,7 +681,7 @@ function bridgeScarsToUsageRecords(normalizedScarsApplied, sessionId, agentIdent
 export async function sessionClose(params) {
     const timer = new Timer();
     const metricsId = uuidv4();
-    // OD-548: Validate session_id format before any DB calls
+    // Validate session_id format before any DB calls
     if (params.session_id && !isValidSessionId(params.session_id)) {
         const latencyMs = timer.stop();
         const perfData = buildPerformanceData("session_close", latencyMs, 0);
@@ -750,43 +754,37 @@ export async function sessionClose(params) {
             human_response: "auto-normalized from string payload",
         };
     }
-    // Close type auto-detection: reject mismatched close types based on session activity.
-    // Standard close on a short/trivial session is wasteful; quick close on a long session loses data.
-    // t-f7c2fa01: If closing_reflection is already present (agent answered 7 questions),
-    // skip the mismatch gate — the ceremony is done, rejecting it wastes work.
+    // Adaptive ceremony level based on session activity.
+    // Three levels: micro (quick fix), standard (normal), full (long/heavy session).
+    // t-f7c2fa01: If closing_reflection is already present, skip the mismatch gate.
     const hasReflection = params.closing_reflection &&
         Object.keys(params.closing_reflection).length > 0;
     const activity = getSessionActivity();
+    // Compute recommended ceremony level
+    let recommendedLevel = "standard";
+    if (activity) {
+        const isMinimal = activity.recall_count === 0 &&
+            activity.observation_count === 0 &&
+            activity.children_count === 0;
+        if (activity.duration_min < 15 && isMinimal) {
+            recommendedLevel = "micro";
+        }
+        else if (activity.duration_min >= 60 || activity.recall_count >= 3 ||
+            activity.observation_count >= 3) {
+            recommendedLevel = "full";
+        }
+    }
     if (activity && params.close_type && !hasReflection) {
         const isMinimal = activity.recall_count === 0 &&
             activity.observation_count === 0 &&
             activity.children_count === 0;
-        if (params.close_type === "standard" && activity.duration_min < 30 && isMinimal) {
-            const latencyMs = timer.stop();
-            const perfData = buildPerformanceData("session_close", latencyMs, 0);
-            return {
-                success: false,
-                session_id: params.session_id || "",
-                close_compliance: {
-                    close_type: params.close_type,
-                    agent: detectAgent().agent,
-                    checklist_displayed: false,
-                    questions_answered_by_agent: false,
-                    human_asked_for_corrections: false,
-                    learnings_stored: 0,
-                    scars_applied: 0,
-                },
-                validation_errors: [
-                    `Close type mismatch: "standard" requested but session qualifies for "quick".`,
-                    `Session duration: ${Math.round(activity.duration_min)} min (< 30 min threshold).`,
-                    `Activity: ${activity.recall_count} recalls, ${activity.observation_count} observations, ${activity.children_count} children.`,
-                    `Re-call with close_type: "quick" for short exploratory sessions.`,
-                ],
-                performance: perfData,
-                display: `## CLOSE TYPE MISMATCH\n\nSession is ${Math.round(activity.duration_min)} min with no substantive activity.\nUse \`close_type: "quick"\` instead of \`"standard"\`.`,
-            };
+        // Suggest micro for short sessions requesting standard (soft nudge, not rejection)
+        if (params.close_type === "standard" && recommendedLevel === "micro") {
+            console.error(`[session_close] Hint: session qualifies for "quick" close ` +
+                `(${Math.round(activity.duration_min)} min, no substantive activity). ` +
+                `Proceeding with standard as requested.`);
         }
-        if (params.close_type === "quick" && (activity.duration_min >= 30 || !isMinimal)) {
+        if (params.close_type === "quick" && recommendedLevel === "full") {
             // Warn but don't reject — agent chose quick on a substantive session
             console.error(`[session_close] Warning: "quick" close on substantive session ` +
                 `(${Math.round(activity.duration_min)} min, ${activity.recall_count} recalls, ` +
@@ -967,7 +965,7 @@ export async function sessionClose(params) {
     }
     // 5. Build session data (merge with existing or create from scratch)
     const sessionData = buildSessionRecord(params, existingSession, isRetroactive, agentIdentity, closeCompliance, sessionId);
-    // OD-624: Sync threads to Supabase (fire-and-forget, non-blocking)
+    // Sync threads to Supabase (fire-and-forget, non-blocking)
     const closeThreads = (sessionData.open_threads || []);
     if (closeThreads.length > 0) {
         const closeProject = isRetroactive ? "default" : existingSession?.project || "default";
@@ -984,10 +982,10 @@ export async function sessionClose(params) {
     catch (err) {
         console.error("[session_close] Failed to prune threads.json (non-fatal):", err);
     }
-    // OD-538: Capture transcript if enabled (default true for CLI/DAC)
+    // Capture transcript if enabled (default true for CLI/DAC)
     let transcriptStatus;
     const shouldCaptureTranscript = params.capture_transcript !== false &&
-        (agentIdentity === "CLI" || agentIdentity === "DAC");
+        (agentIdentity === "cli" || agentIdentity === "desktop");
     if (shouldCaptureTranscript) {
         const transcriptResult = await captureSessionTranscript(sessionId, params, existingSession, isRetroactive);
         transcriptStatus = transcriptResult.status;
@@ -995,7 +993,7 @@ export async function sessionClose(params) {
             sessionData.claude_code_session_id = transcriptResult.claudeSessionId;
         }
     }
-    // OD-552: Auto-bridge Q6 answers to scar_usage records
+    // Auto-bridge Q6 answers to scar_usage records
     const normalizedScarsApplied = normalizeScarsApplied(params.closing_reflection?.scars_applied);
     if ((!params.scars_to_record || params.scars_to_record.length === 0) &&
         normalizedScarsApplied.length > 0) {
@@ -1006,10 +1004,10 @@ export async function sessionClose(params) {
     }
     // 6. Persist to Supabase (direct REST API, bypasses ww-mcp)
     try {
-        // OD-646: Upsert session WITHOUT embedding (fast path)
+        // Upsert session WITHOUT embedding (fast path)
         // Embedding + thread detection run fire-and-forget after
         await supabase.directUpsert("orchestra_sessions", sessionData);
-        // OD-646: Tracked fire-and-forget embedding generation + session update + thread detection
+        // Tracked fire-and-forget embedding generation + session update + thread detection
         if (isEmbeddingAvailable()) {
             getEffectTracker().track("embedding", "session_close", async () => {
                 const embeddingParts = [
@@ -1039,8 +1037,8 @@ export async function sessionClose(params) {
                 }
             });
         }
-        // OD-646: Tracked fire-and-forget scar usage recording (was blocking ~200-500ms)
-        // OD-552: scars_to_record may now come from auto-bridge above
+        // Tracked fire-and-forget scar usage recording (was blocking ~200-500ms)
+        // scars_to_record may now come from auto-bridge above
         if (params.scars_to_record && params.scars_to_record.length > 0) {
             const project = isRetroactive
                 ? "default"
@@ -1054,7 +1052,7 @@ export async function sessionClose(params) {
         const perfData = buildPerformanceData("session_close", latencyMs, 1);
         // Update relevance data for memories applied during session
         if (normalizedScarsApplied.length > 0) {
-            updateRelevanceData(sessionId, normalizedScarsApplied).catch(() => { });
+            updateRelevanceData(sessionId, normalizedScarsApplied).catch((err) => console.error("[session_close] updateRelevanceData failed:", err instanceof Error ? err.message : err));
         }
         // Record metrics
         recordMetrics({
@@ -1077,8 +1075,11 @@ export async function sessionClose(params) {
                 retroactive: isRetroactive,
             },
         }).catch(() => { });
-        // OD-547: Clear session state after successful close
+        // Clear session state after successful close
         clearCurrentSession();
+        // Generate agent-briefing.md for PMEM bridge
+        const decisionsCount = params.decisions?.length || 0;
+        await writeAgentBriefing(learningsCount, decisionsCount);
         // GIT-21: Clean up session files (registry, per-session dir, legacy file)
         cleanupSessionFiles(sessionId);
         // Clean up payload file AFTER successful close (not before — crash safety)
@@ -1102,7 +1103,7 @@ export async function sessionClose(params) {
         const errorMessage = error instanceof Error ? error.message : String(error);
         const latencyMs = timer.stop();
         const perfData = buildPerformanceData("session_close", latencyMs, 0);
-        // OD-547: Clear session state even on error (session is done either way)
+        // Clear session state even on error (session is done either way)
         clearCurrentSession();
         const errorDisplay = formatCloseDisplay(sessionId, closeCompliance, params, learningsCount, false, [`Failed to persist session: ${errorMessage}`], transcriptStatus);
         return {

package/dist/tools/session-start.d.ts

@@ -4,9 +4,9 @@
  * Initialize session, detect agent, load institutional context.
  * Returns threads and recent decisions. Scars surface via recall on demand.
  *
- * Performance target: <750ms (OD-645: Lean Start)
+ * Performance target: <750ms
  *
- * OD-645: Removed scar/wins queries from start pipeline.
+ * Removed scar/wins queries from start pipeline.
  * Scars load on-demand via recall(). Wins available via search/log.
  * loadLastSession and loadRecentDecisions run in parallel.
  * createSessionRecord is fire-and-forget.
@@ -15,10 +15,10 @@ import type { SessionStartParams, SessionStartResult, Project } from "../types/i
 /**
  * Execute session_start tool
  *
- * OD-489: Returns detailed performance breakdown for test harness validation.
+ * Returns detailed performance breakdown for test harness validation.
  * Key metrics: network_calls_made, fully_local, breakdown per component.
  *
- * OD-558: Guards against overwriting existing active sessions.
+ * Guards against overwriting existing active sessions.
  * Returns existing session if active-session.json exists (idempotent).
  * Pass force=true to override.
  */
@@ -30,7 +30,7 @@ export declare function sessionStart(params: SessionStartParams): Promise<Sessio
  * without creating a new session ID. Same lean pipeline as session_start
  * (last session, decisions, threads) but skips session creation.
  *
- * OD-645: Scars/wins removed — load on-demand via recall/search.
+ * Scars/wins removed — load on-demand via recall/search.
  *
  * Use when: mid-session context refresh after compaction, long gaps, or
  * when you need to remember where you left off.