github-search-cli 9.7.0 → 9.8.0

package/src/search.ts

@@ -181,7 +181,7 @@ export function suggestFor(input: string): string[] {
     return QUALIFIER_SUGGESTIONS[trimmed];
   }
   const matches = KNOWN_QUALIFIERS.filter((k) => k.startsWith(trimmed));
-  return matches.map((k) => k + ":");
+  return matches.map((k) => `${k}:`);
 }
 
 export function tokenize(input: string): string[] {
@@ -329,7 +329,6 @@ export function githubSortParam(sort: SortStrategy): {
       return { sort: "forks", order: "desc" };
     case "updated":
       return { sort: "updated", order: "desc" };
-    case "best-match":
     default:
       return {};
   }
@@ -359,7 +358,6 @@ export function rankRepos(repos: Repo[], strategy: SortStrategy): Repo[] {
     case "updated":
       copy.sort(byKey((r) => Date.parse(r.updatedAt)));
       break;
-    case "best-match":
     default:
       break;
   }
@@ -473,7 +471,7 @@ export class GitHubSearchAdapter implements SearchAdapter {
           if (
             !parsed ||
             typeof parsed !== "object" ||
-            !Array.isArray((parsed as any).items)
+            !Array.isArray((parsed as { items?: unknown }).items)
           ) {
             this.logger.error(
               `[github] unexpected response shape: ${JSON.stringify(parsed).slice(0, 200)}`,
@@ -630,6 +628,7 @@ function trendingRepoToRepo(r: RawTrendingRepo): Repo {
  */
 export class TrendingAdapter implements SearchAdapter {
   readonly name = "trending";
+  // biome-ignore lint/correctness/noUnusedPrivateClassMembers: part of the adapter constructor contract — callers pass a shared logger (search.ts:757) even though this adapter currently logs nothing itself.
   private readonly logger: Logger;
 
   constructor(logger: Logger = noopLogger) {

package/src/share.ts

@@ -19,7 +19,7 @@ export function formatShare(repo: Repo, format: ShareFormat): string {
 }
 
 /** Copy text to clipboard via platform command. */
-import { spawn } from "child_process";
+import { spawn } from "node:child_process";
 
 export async function copyToClipboard(text: string): Promise<boolean> {
   try {
@@ -46,7 +46,7 @@ export async function copyToClipboard(text: string): Promise<boolean> {
 }
 
 async function findLinuxClipboard(): Promise<string[] | null> {
-  const { execFileSync } = await import("child_process");
+  const { execFileSync } = await import("node:child_process");
   try {
     execFileSync("xclip", ["-version"], { stdio: "ignore" });
     return ["xclip", "-selection", "clipboard"];

package/src/storage.ts

@@ -12,8 +12,8 @@ import {
   writeFileSync,
   appendFileSync,
   unlinkSync,
-} from "fs";
-import { join } from "path";
+} from "node:fs";
+import { join } from "node:path";
 import { stateDir } from "./config";
 
 /** Ensure the state directory exists. */
@@ -43,7 +43,7 @@ export function appendJSONL(filename: string, obj: unknown): void {
   try {
     appendFileSync(
       join(stateDir(), filename),
-      JSON.stringify(obj) + "\n",
+      `${JSON.stringify(obj)}\n`,
       "utf-8",
     );
   } catch {
@@ -119,7 +119,7 @@ export const memoryStorage = {
   },
   appendJSONL(filename: string, obj: unknown): void {
     const existing = memStore.get(filename) ?? "";
-    memStore.set(filename, existing + JSON.stringify(obj) + "\n");
+    memStore.set(filename, `${existing + JSON.stringify(obj)}\n`);
   },
   readJSONL<T>(filename: string): T[] {
     const raw = memStore.get(filename);

package/src/themes.ts

@@ -242,6 +242,7 @@ export async function detectTerminalBackground(
     // Reply: ESC ] 11 ; <spec> (BEL | ESC \)
     const onData = (d: Buffer) => {
       buffer += d.toString("latin1");
+      // biome-ignore lint/suspicious/noControlCharactersInRegex: matches raw ANSI OSC-11 escape bytes, which are control characters by definition
       const m = buffer.match(/\x1b\]11;([^\x07\x1b]*)(?:\x07|\x1b\\)/);
       if (m) finish(parseOscColor(m[1]));
     };

package/src/trending-parser.ts

@@ -35,7 +35,7 @@ function parseRepoLink(block: string): RepoLink | undefined {
   // `/login?...&return_to=...` href fails the bare-path requirement and the
   // stargazers/forks links don't carry the heading's class="Link".
   const anchor = block.match(
-    /<a[^>]*?href="\/([A-Za-z0-9._-]+)\/([^\"?#]+)"[^>]*class="Link"/,
+    /<a[^>]*?href="\/([A-Za-z0-9._-]+)\/([^"?#]+)"[^>]*class="Link"/,
   );
   if (!anchor) return undefined;
   return { owner: anchor[1], name: anchor[2] };
@@ -43,7 +43,7 @@ function parseRepoLink(block: string): RepoLink | undefined {
 
 function parseStars(block: string): number {
   const starsMatch = block.match(
-    /href="\/[^\/\"]+\/[^\/\"]+\/stargazers"[^>]*>.*?<\/svg>\s*(\d[\d,]*)/,
+    /href="\/[^/"]+\/[^/"]+\/stargazers"[^>]*>.*?<\/svg>\s*(\d[\d,]*)/,
   );
   return starsMatch ? parseInt(starsMatch[1].replace(/,/g, ""), 10) : 0;
 }
@@ -69,10 +69,9 @@ export function parseTrendingHtml(html: string): RawTrendingRepo[] {
   const flat = flattenHtml(html);
   const repos: RawTrendingRepo[] = [];
   const articleRe = /<article class="Box-row">(.*?)<\/article>/gi;
-  let match: RegExpExecArray | null;
   let rank = 0;
 
-  while ((match = articleRe.exec(flat)) !== null) {
+  for (const match of flat.matchAll(articleRe)) {
     rank++;
     const block = match[1];
     const link = parseRepoLink(block);

package/src/trending.ts

@@ -118,13 +118,13 @@ export function formatRepoLine(repo: Repo, rank: number): StyledText {
   const rankStr = String(rank).padStart(2, "0");
   const full = `${repo.owner}/${repo.name}`;
   const lc = langColor(repo.language ?? "");
-  const rc = rankColor(rank);
+  const _rc = rankColor(rank);
   const star = "★";
   const arrow = repo.score > 0 ? "▲" : repo.score < 0 ? "▼" : "—";
   const growth = `${arrow} ${fmtSigned(repo.score)} today`;
   const desc =
     (repo.description ?? "").length > 60
-      ? (repo.description ?? "").slice(0, 57) + "..."
+      ? `${(repo.description ?? "").slice(0, 57)}...`
       : (repo.description ?? "");
   const line1 = t`${dim(fg(C.rankBg)(`[${rankStr}]`))} ${bold(fg("#c0caf5")(full))}  ${fg(lc)(`● ${repo.language}`)}  ${fg(C.gold)(`${star} ${fmtStars(repo.stars)}`)}  ${bold(fg(C.green)(growth))}`;
   const line2 = t`  ${dim(fg(C.muted)(desc))}`;
@@ -182,7 +182,7 @@ export async function launchTrending(): Promise<void> {
   let currentPeriod = "this week";
   let repos: Repo[] = [];
   let selectedRepoIdx = 0;
-  let isLoading = false;
+  let _isLoading = false;
   // ── Fetch from github.com/trending ──
   async function loadTab(index: number) {
     if (index < 0 || index >= TAB_NAMES.length) return;
@@ -194,7 +194,7 @@ export async function launchTrending(): Promise<void> {
         : since === "weekly"
           ? "this week"
           : "this month";
-    isLoading = true;
+    _isLoading = true;
     for (const rb of rowBoxes) scrollBox.remove(rb);
     rowBoxes.length = 0;
     rowTexts.length = 0;
@@ -233,7 +233,7 @@ export async function launchTrending(): Promise<void> {
       });
       scrollBox.add(errText);
     }
-    isLoading = false;
+    _isLoading = false;
     renderTabBar();
     renderer.requestRender();
   }
@@ -359,7 +359,7 @@ export async function launchTrending(): Promise<void> {
       const lc = langColor(r.language ?? "");
       const desc =
         (r.description ?? "").length > 55
-          ? (r.description ?? "").slice(0, 52) + "..."
+          ? `${(r.description ?? "").slice(0, 52)}...`
           : (r.description ?? "");
       const arrow = r.score > 0 ? "▲" : r.score < 0 ? "▼" : "—";
       const growthStr = `${arrow} ${fmtStars(Math.abs(r.score))} ${currentPeriod}`;
@@ -373,7 +373,7 @@ export async function launchTrending(): Promise<void> {
         fg: rc,
         height: 1,
       });
-      const descStr = desc.length > 60 ? desc.slice(0, 57) + "..." : desc;
+      const descStr = desc.length > 60 ? `${desc.slice(0, 57)}...` : desc;
       const pad = "     ";
       const line1 = t`${bold(fg("#c0caf5")(nameStr))}${fg(lc)(langStr)}${fg(C.muted)(starsStr)}${bold(fg(C.green)(growthStr))}`;
       const line2 = t`${fg(C.descText)(`${pad}${descStr}`)}`;

package/src/tui.ts

@@ -38,6 +38,8 @@ import type {
   SortStrategy,
   Package,
   SessionState,
+  HistoryEntry,
+  SavedSearch,
 } from "./types";
 import { fetchOrgProfile, type OrgProfile } from "./org";
 import {
@@ -54,13 +56,7 @@ import {
 import { tabSince, TAB_NAMES, fmtStars } from "./trending";
 import { loadConfig, saveConfig } from "./config";
 import { buildHelpSections, HELP_KEYS_COLUMN } from "./help";
-import {
-  SearchCliError,
-  NetworkError,
-  RateLimitError,
-  BadQueryError,
-  NoResultsError,
-} from "./errors";
+import { SearchCliError, NoResultsError } from "./errors";
 import {
   appendHistory,
   readHistory,
@@ -68,12 +64,7 @@ import {
   clearHistory,
   rotateHistory,
 } from "./history";
-import {
-  getBookmarks,
-  isBookmarked,
-  toggleBookmark,
-  removeBookmark,
-} from "./bookmarks";
+import { getBookmarks, toggleBookmark, removeBookmark } from "./bookmarks";
 import {
   getSavedSearches,
   saveSearch,
@@ -83,8 +74,9 @@ import {
 import { saveSession, restoreSession } from "./session";
 import { fetchDeepDive, buildDeepDiveText } from "./deepdive";
 import { buildComparisonTable } from "./compare";
-import { renderMarkdown } from "./markdown-render";
-import { fetchTopics, type TopicItem } from "./explore";
+import { createMarkdownView } from "./markdown-view";
+import { fetchImageBytes, readmeBaseUrl } from "./image-loader";
+import { fetchTopics } from "./explore";
 import { exportToFile, type ExportFormat } from "./output";
 import {
   listThemes,
@@ -269,8 +261,8 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
   let currentPage = 1;
   let totalCount = 0;
   let deepDiveActive = false;
-  let compareList: Repo[] = [];
-  let quitArmed = false;
+  const compareList: Repo[] = [];
+  const _quitArmed = false;
 
   const header = new TextRenderable(renderer, {
     content:
@@ -1088,12 +1080,22 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
     paddingLeft: 2,
     paddingRight: 2,
   });
-  const updateText = new TextRenderable(renderer, {
+  // Version header only — the release notes below it are rendered markdown.
+  const updateHeader = new TextRenderable(renderer, {
     content: "",
     fg: colors.accent,
     bg: colors.surfaceDim,
   });
-  // ponytail: notes render as plain text with \n; keep it a column so lines stack
+  const updateNotes = createMarkdownView({
+    renderer,
+    colors,
+    // Notes ship with the release and are mostly prose/lists; skip the
+    // image pipeline in this narrow panel.
+    images: false,
+    background: colors.surfaceDim,
+  });
+  // ponytail: the notes are markdown now; keep the content a column so
+  // blocks stack and the scroll box can measure them.
   const updateScroll = new ScrollBoxRenderable(renderer, {
     flexGrow: 1,
     backgroundColor: colors.surfaceDim,
@@ -1196,7 +1198,8 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
     paddingX: 1,
   });
   updateBox.add(updateScroll);
-  updateScroll.add(updateText);
+  updateScroll.add(updateHeader);
+  updateScroll.add(updateNotes.renderable);
   updateBox.add(updateOptionsRow);
   updateBox.add(updateFooter);
   root.add(updateDim);
@@ -1259,7 +1262,8 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
   function popMenuLevel(): boolean {
     if (menuStack.length <= 1) return false;
     const prev = menuStack[menuStack.length - 2];
-    const current = menuStack.pop()!;
+    const current = menuStack.pop();
+    if (!current) return false;
     leaderSelect.options = prev.entries.map((e) => ({
       name:
         e.type === "category" ? `  ${e.icon} ${e.name} \u2192` : `  ${e.name}`,
@@ -1283,7 +1287,10 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
   function buildMenuHierarchy(): MenuCategory[] {
     const hasRepo = (() => {
       const opt = resultsSelect.getSelectedOption();
-      return opt?.value && typeof (opt.value as any)?.fullName === "string";
+      return (
+        opt?.value &&
+        typeof (opt.value as { fullName?: unknown })?.fullName === "string"
+      );
     })();
 
     const groups: MenuCategory[] = [];
@@ -1602,17 +1609,11 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
     if (state.lastInstalledVersion === currentVersion) return;
     // We just upgraded — show notes for the new version
     const notes = fetchReleaseNotes(currentVersion);
-    // Box is 55% of the terminal; subtract border + padding so wrapped
-    // lines never clip horizontally.
-    const notesWidth = Math.max(
-      30,
-      Math.floor((process.stdout.columns || 80) * 0.55) - 8,
-    );
-    const notesBlock = notes
-      ? renderMarkdown(notes, { width: notesWidth })
-      : "  No release notes found for this version.";
     updateSelectedOption = 0;
-    updateText.content = `  Updated ghfind ${state.lastInstalledVersion} → ${currentVersion}\n\n${notesBlock}`;
+    updateHeader.content = `  Updated ghfind ${state.lastInstalledVersion} → ${currentVersion}\n`;
+    updateNotes.setContent(
+      notes ?? "_No release notes found for this version._",
+    );
     renderUpdateOptions();
     showOverlay("update");
   }
@@ -1630,14 +1631,8 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
     if (latest) {
       updateSelectedOption = 0;
       const notes = fetchReleaseNotes(latest);
-      const notesWidth = Math.max(
-        30,
-        Math.floor((process.stdout.columns || 80) * 0.55) - 8,
-      );
-      const notesBlock = notes
-        ? renderMarkdown(notes, { width: notesWidth })
-        : `  A new version is available\n\n  Current: ${currentVersion}\n  Latest:   ${latest}\n\n  Run "npm install -g ghfind"`;
-      updateText.content = `  A new version is available\n\n  Current: ${currentVersion}\n  Latest:   ${latest}\n\n${notesBlock}`;
+      updateHeader.content = `  A new version is available\n\n  Current: ${currentVersion}\n  Latest:   ${latest}\n`;
+      updateNotes.setContent(notes ?? "Run `npm install -g ghfind` to update.");
       renderUpdateOptions();
       showOverlay("update");
     } else {
@@ -1694,7 +1689,7 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
     if (currentQueryInput) {
       const name =
         currentQueryInput.length > 40
-          ? currentQueryInput.slice(0, 37) + "..."
+          ? `${currentQueryInput.slice(0, 37)}...`
           : currentQueryInput;
       saveSearch(
         name,
@@ -1857,15 +1852,22 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
       },
     },
   });
-  const readmeText = new TextRenderable(renderer, {
-    content: "",
-    fg: colors.text,
-    bg: colors.bg,
+  // Full markdown rendering (headings, tables, code, inline images).
+  const readmeView = createMarkdownView({
+    renderer,
+    colors,
+    loadImage: (url) => fetchImageBytes(url, { token: githubToken }),
+    getImageWidth: () => Math.max(24, (process.stdout.columns || 80) - 12),
   });
-  readmeScroll.add(readmeText);
+  readmeScroll.add(readmeView.renderable);
   readmeBox.add(readmeScroll);
+
+  const readmeFooterText = () =>
+    `  ↑↓/jk scroll  PgUp/PgDn page  i images: ${
+      readmeView.imagesEnabled ? "on" : "off"
+    }  Esc/q close`;
   const readmeFooter = new TextRenderable(renderer, {
-    content: "  ↑↓/jk scroll  Esc/q close",
+    content: readmeFooterText(),
     fg: colors.muted,
     bg: colors.bg,
     height: 1,
@@ -1881,33 +1883,36 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
       setStatus("No repo selected");
       return;
     }
-    readmeText.content = `  Loading README for ${repo.fullName}...`;
+    readmeView.setContent(`Loading README for ${repo.fullName}…`);
+    readmeFooter.content = readmeFooterText();
+    readmeScroll.scrollTop = 0;
     showOverlay("readme");
     try {
       const headers: Record<string, string> = { "User-Agent": "ghfind/1.0" };
       if (githubToken) headers.Authorization = `Bearer ${githubToken}`;
       let text = "";
-      for (const path of [
-        `${repo.owner}/${repo.name}/main/README.md`,
-        `${repo.owner}/${repo.name}/master/README.md`,
-        `${repo.owner}/${repo.name}/main/README.rst`,
-      ]) {
-        const r = await fetch(`https://raw.githubusercontent.com/${path}`, {
-          headers,
-        });
+      let sourceUrl = "";
+      for (const [branch, file] of [
+        ["main", "README.md"],
+        ["master", "README.md"],
+        ["main", "README.rst"],
+      ] as const) {
+        // The README's own URL doubles as the base for relative image paths.
+        const url = readmeBaseUrl(repo.owner, repo.name, branch, file);
+        const r = await fetch(url, { headers });
         if (r.ok) {
           text = await r.text();
+          sourceUrl = url;
           break;
         }
       }
       if (!text) {
-        readmeText.content = `  (no README found for ${repo.fullName})`;
+        readmeView.setContent(`_(no README found for ${repo.fullName})_`);
       } else {
-        const termW = Math.max(40, (process.stdout.columns || 80) - 4);
-        readmeText.content = renderMarkdown(text, { width: termW });
+        readmeView.setContent(text, sourceUrl);
       }
     } catch {
-      readmeText.content = "  Failed to load README";
+      readmeView.setContent("_Failed to load README._");
     }
     renderer.requestRender();
   }
@@ -1925,16 +1930,11 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
     statusBar.content = ` ${text}`;
     renderer.requestRender();
   });
-
-  // ── Startup tip ──
-  if (config.theme !== undefined || true) {
-    // Show a tip after 2s idle
-    setTimeout(() => {
-      if (currentOverlay === "none") {
-        setStatus(nextTip());
-      }
-    }, 2000);
-  }
+  setTimeout(() => {
+    if (currentOverlay === "none") {
+      setStatus(nextTip());
+    }
+  }, 2000);
 
   // ── Helper functions ────────────────────────────────────────────────
 
@@ -2097,7 +2097,7 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
           val >= 1000
             ? `${(val / 1000).toFixed(1).replace(/\.0$/, "")}k`
             : String(val);
-        label = label.padStart(5) + " ";
+        label = `${label.padStart(5)} `;
       }
       lines.push(`${label}┆${chars.join("")}`);
     }
@@ -2515,6 +2515,24 @@ export async function launchBrowser(theme_override?: string): Promise<void> {
     }
   });
 
+  // Pasted content flows through "input"; purge JSON-shaped blobs that
+  // slipped into the query (a search line is never raw JSON: objects/arrays
+  // always arrive as paste payloads from API responses / deep-dive output).
+  searchInput.on("input", () => {
+    const v = searchInput.value;
+    if (v.length > 0) {
+      const t = v.trim();
+      if (
+        (t.startsWith("{") && t.endsWith("}")) ||
+        (t.startsWith("[") && t.endsWith("]"))
+      ) {
+        searchInput.value = "";
+        setStatus("Ignored JSON paste — search queries accept plain text");
+        renderer.requestRender();
+      }
+    }
+  });
+
   // Navigate results → update detail pane
   resultsSelect.on("selectionChanged", () => {
     const opt = resultsSelect.getSelectedOption();
@@ -2616,6 +2634,14 @@ ${pack.description ?? ""}`;
 
       // README viewer: scrollable, Esc/q already handled above
       if (currentOverlay === "readme") {
+        if (key.name === "i") {
+          readmeView.setImagesEnabled(!readmeView.imagesEnabled);
+          readmeFooter.content = readmeFooterText();
+          setStatus(
+            readmeView.imagesEnabled ? "README images on" : "README images off",
+          );
+          renderer.requestRender();
+        }
         return;
       }
 
@@ -2624,7 +2650,8 @@ ${pack.description ?? ""}`;
         if (key.name === "d") {
           const sel = historySelect.getSelectedOption();
           if (sel?.value) {
-            deleteHistoryEntry((sel.value as any).index);
+            const idx = (sel.value as { index?: number }).index;
+            if (idx !== undefined) deleteHistoryEntry(idx);
             refreshHistory();
             setStatus("Deleted history entry");
           }
@@ -2641,8 +2668,9 @@ ${pack.description ?? ""}`;
         if (key.name === "enter" || key.name === "return") {
           const sel = historySelect.getSelectedOption();
           if (sel?.value) {
-            const entry = (sel.value as any).entry;
+            const entry = (sel.value as { entry?: HistoryEntry }).entry;
             showOverlay("none");
+            if (!entry) return;
             if (entry.mode === "trending") {
               if (entry.tab)
                 trendingTab = entry.tab as (typeof TAB_NAMES)[number];
@@ -2663,7 +2691,10 @@ ${pack.description ?? ""}`;
         if (key.name === "d") {
           const sel = bookmarksSelect.getSelectedOption();
           if (sel?.value) {
-            removeBookmark((sel.value as any).repo.fullName);
+            removeBookmark(
+              (sel.value as { repo?: { fullName: string } }).repo?.fullName ??
+                "",
+            );
             refreshBookmarks();
             setStatus("Bookmark removed");
           }
@@ -2672,7 +2703,8 @@ ${pack.description ?? ""}`;
         }
         if (key.name === "enter" || key.name === "return") {
           const sel = bookmarksSelect.getSelectedOption();
-          if (sel?.value) openUrl((sel.value as any).repo.url);
+          if (sel?.value)
+            openUrl((sel.value as { repo?: { url?: string } }).repo?.url ?? "");
           return;
         }
         return;
@@ -2683,7 +2715,7 @@ ${pack.description ?? ""}`;
         if (key.name === "d") {
           const sel = savedSelect.getSelectedOption();
           if (sel?.value) {
-            deleteSavedSearch((sel.value as any).name);
+            deleteSavedSearch((sel.value as { name?: string }).name ?? "");
             refreshSavedSearches();
             setStatus("Saved search deleted");
           }
@@ -2693,7 +2725,7 @@ ${pack.description ?? ""}`;
         if (key.name === "enter" || key.name === "return") {
           const sel = savedSelect.getSelectedOption();
           if (sel?.value) {
-            const s = sel.value as any;
+            const s = sel.value as SavedSearch;
             showOverlay("none");
             touchSavedSearch(s.name);
             if (s.mode === "trending") {
@@ -2718,9 +2750,9 @@ ${pack.description ?? ""}`;
         if (key.name === "enter" || key.name === "return") {
           const sel = topicsSelect.getSelectedOption();
           if (sel?.value) {
-            const topic = sel.value as any;
+            const topic = sel.value as { name?: string };
             showOverlay("none");
-            searchInput.value = `topic:${topic.name}`;
+            searchInput.value = `topic:${topic.name ?? ""}`;
             showSearchMode();
             doSearch(`topic:${topic.name}`);
           }
@@ -2973,7 +3005,7 @@ ${pack.description ?? ""}`;
     // Number keys 1-5 switch trending tabs (only in trending mode)
     if (/^[1-5]$/.test(key.name)) {
       if (currentMode === "trending") {
-        const idx = parseInt(key.name) - 1;
+        const idx = parseInt(key.name, 10) - 1;
         if (idx >= 0 && idx < TAB_NAMES.length) {
           trendingTab = TAB_NAMES[idx];
           loadTrending();
@@ -3025,16 +3057,16 @@ ${pack.description ?? ""}`;
   });
 
   // ── Update check (before start) ──────────────────────────────────────
-  const currentVersion = getVersion();
+  const _currentVersion = getVersion();
   // ── Start ──────────────────────────────────────────────────────────
   // Check for updates (non-blocking — doesn't delay TUI startup)
-  if (!session || !session.mode) {
+  if (!session?.mode) {
     showLanding(true);
   }
   checkForUpdateAndShow();
   checkPostUpgradePanel();
   renderer.start();
-  if (session && session.mode) {
+  if (session?.mode) {
     if (currentMode === "trending") {
       loadTrending();
     } else {