github-search-cli 9.6.0 → 9.7.1

package/src/mcp-server.ts

@@ -27,8 +27,7 @@ import {
   rankRepos,
   createGitHubSearch,
   createTrendingSearch,
-  TRENDING_LANGUAGES,
-  trendingLanguageSlug,
+  resolveTrendingLanguage,
 } from "./search";
 import {
   createPackageSearch,
@@ -37,7 +36,11 @@ import {
 } from "./package";
 import { fetchOrgProfile, formatOrgText } from "./org";
 import { fetchUserProfile, formatUserJson } from "./user";
-import { fetchDeepDive, buildDeepDiveText } from "./deepdive";
+import {
+  fetchDeepDive,
+  buildDeepDiveText,
+  resolveRepoFromRef,
+} from "./deepdive";
 import { buildComparisonTable } from "./compare";
 import { allCachedReleases } from "./releases";
 import { getBookmarks } from "./bookmarks";
@@ -199,45 +202,9 @@ function formatPackageLines(
     .join("\n");
 }
 
-const REPO_NAME_RE = /^[A-Za-z0-9._-]+\/[A-Za-z0-9._-]+$/;
-
-function parseRepoName(input: string): { owner: string; name: string } {
-  const fullName = input
-    .trim()
-    .replace(/\.git$/, "")
-    .replace(/^@/, "");
-  if (!REPO_NAME_RE.test(fullName)) {
-    throw new McpToolError(
-      `"${input}" is not a repo name — use owner/name, e.g. facebook/react.`,
-    );
-  }
-  const [owner, name] = fullName.split("/");
-  return { owner, name };
-}
-
-/** Minimal Repo for deep-dive (fetchDeepDive only reads owner/name). */
-function stubRepo(fullName: string): Repo {
-  const { owner, name } = parseRepoName(fullName);
-  return {
-    id: 0,
-    fullName: `${owner}/${name}`,
-    name,
-    owner,
-    description: null,
-    url: `https://github.com/${owner}/${name}`,
-    stars: 0,
-    forks: 0,
-    watchers: 0,
-    language: null,
-    topics: [],
-    archived: false,
-    isFork: false,
-    private: false,
-    createdAt: "",
-    updatedAt: "",
-    pushedAt: "",
-    score: 0,
-  };
+/** Wrap a domain error as McpToolError so its message surfaces verbatim. */
+function asMcpToolError(err: unknown): McpToolError {
+  return new McpToolError(err instanceof Error ? err.message : String(err));
 }
 
 const TRENDING_QUERY = { keywords: [], qualifiers: [], raw: "trending" };
@@ -366,16 +333,12 @@ const TOOLS: ToolDefinition[] = [
       const token = resolveToken(state, args.token);
 
       let language: string | undefined;
-      const langArg =
-        typeof args.language === "string" ? args.language.trim() : "";
-      if (langArg) {
-        const slug = trendingLanguageSlug(langArg);
-        if (!TRENDING_LANGUAGES.has(slug)) {
-          throw new McpToolError(
-            `"${langArg}" is not a trending language filter. Try one of: rust, python, typescript, javascript, go, zig.`,
-          );
-        }
-        language = slug;
+      try {
+        language = resolveTrendingLanguage(
+          typeof args.language === "string" ? args.language : undefined,
+        );
+      } catch (err) {
+        throw asMcpToolError(err);
       }
 
       const trending = createTrendingSearch();
@@ -582,7 +545,12 @@ const TOOLS: ToolDefinition[] = [
     async run(args, state) {
       const repo = String(args.repo ?? "").trim();
       if (!repo) throw new McpToolError("repo must be a non-empty string.");
-      const stub = stubRepo(repo);
+      let stub: Repo;
+      try {
+        stub = await resolveRepoFromRef(repo, resolveToken(state, args.token));
+      } catch (err) {
+        throw asMcpToolError(err);
+      }
       const data = await fetchDeepDive(stub, resolveToken(state, args.token));
       return { text: buildDeepDiveText(data), data: { ...data } };
     },
@@ -720,8 +688,11 @@ export async function processServerLine(
     return;
   }
 
-  const isNotification = msg.id === undefined || msg.id === null;
-  const id = isNotification ? null : msg.id;
+  // Extract the id into a const so TS narrows `undefined` out of it below
+  // (aliased conditional narrowing doesn't apply through the `let msg` bind).
+  const rawId = msg.id;
+  const isNotification = rawId === undefined || rawId === null;
+  const id: JsonRpcId = isNotification ? null : rawId;
 
   // Notifications never get responses.
   if (msg.method === "notifications/initialized") {
@@ -830,7 +801,7 @@ export async function processServerLine(
 // ─── stdio transport ───────────────────────────────────────────────────
 
 function writeStdout(line: string): void {
-  process.stdout.write(line + "\n");
+  process.stdout.write(`${line}\n`);
 }
 
 /**
@@ -860,8 +831,9 @@ export async function runMcpServer(
   let buffer = "";
   process.stdin.on("data", (chunk: string) => {
     buffer += chunk;
-    let idx: number;
-    while ((idx = buffer.indexOf("\n")) >= 0) {
+    for (;;) {
+      const idx = buffer.indexOf("\n");
+      if (idx < 0) break;
       const line = buffer.slice(0, idx).trim();
       buffer = buffer.slice(idx + 1);
       if (!line) continue;

package/src/open-url.ts

@@ -1,15 +1,26 @@
 /**
- * Open a URL in the user's default browser — platform-aware.
+ * Open a URL in the user's default browser — platform- and runtime-aware.
  *
- * only if the open/xdg-open pattern fails somewhere.
+ * Windows note: `explorer.exe` is used instead of the classic
+ * `cmd /c start "" <url>` idiom. cmd splits the URL at the first unquoted
+ * `&` (a query-string separator) and executes the rest as a command, which
+ * truncated every URL with query params. explorer.exe receives the URL as a
+ * single CreateProcess argument, so `&` is never interpreted.
  */
+import { spawn } from "node:child_process";
 
 export function openUrl(url: string): void {
   try {
     const p = process.platform;
-    if (p === "win32") Bun.spawn(["cmd", "/c", "start", "", url]);
-    else if (p === "darwin") Bun.spawn(["open", url]);
-    else Bun.spawn(["xdg-open", url]);
+    const cmd =
+      p === "win32" ? "explorer" : p === "darwin" ? "open" : "xdg-open";
+    if (typeof Bun !== "undefined") {
+      Bun.spawn([cmd, url]);
+      return;
+    }
+    // Node fallback — detached so the child survives our exit.
+    const child = spawn(cmd, [url], { detached: true, stdio: "ignore" });
+    child.unref();
   } catch {
     // non-critical — user can copy the URL manually
   }

package/src/output.ts

@@ -5,7 +5,7 @@
  * clone-commands, ids) register in a single registry. One `format()` function
  * dispatches. `exportToFile` and `pipeExec` are methods on the same module.
  */
-import { writeFileSync } from "fs";
+import { writeFileSync } from "node:fs";
 import type { Repo } from "./types";
 import { openUrl } from "./open-url";
 

package/src/package-browser.ts

@@ -49,7 +49,7 @@ function formatPackageLine(pack: Package): StyledText {
   const scoreStr = `score ${pack.score.toFixed(2)}`.padEnd(12).slice(0, 12);
   const desc =
     (pack.description ?? "").length > 60
-      ? (pack.description ?? "").slice(0, 57) + "..."
+      ? `${(pack.description ?? "").slice(0, 57)}...`
       : (pack.description ?? "");
   const line1 = t`${bold(fg(C.nameText)(nameStr))}${fg(C.cyan)(dlStr)}${fg(C.gold)(scoreStr)}`;
   const line2 = t`${dim(fg(C.descText)(`     ${desc}`))}`;

package/src/releases.ts

@@ -1,16 +1,3 @@
-/**
- * Release tracker — checks bookmarked repos for new GitHub releases.
- *
- * Decisions (map 003):
- *   - Signal: new GitHub releases only (`GET /repos/{o}/{r}/releases?per_page=5`).
- *   - Seen state: `lastSeenAt` per bookmark; "new" = published after it.
- *   - Rate budget: etag conditional requests + token when present.
- *   - Prereleases shown (tagged `[pre]`), drafts never.
- *
- * ponytail: sequential fetches — fine for ≤100 bookmarks at launch;
- * parallelize with p-limit if users report slow startup.
- */
-import type { Bookmark } from "./types";
 import { readJSON, writeJSON } from "./storage";
 import { getBookmarks, getLastSeen, markSeen } from "./bookmarks";
 import { addNotification } from "./notifications";
@@ -68,7 +55,7 @@ async function fetchReleases(
     Accept: "application/vnd.github+json",
   };
   if (etag) headers["If-None-Match"] = etag;
-  if (token) headers["Authorization"] = `Bearer ${token}`;
+  if (token) headers.Authorization = `Bearer ${token}`;
   const res = await fetch(
     `https://api.github.com/repos/${fullName}/releases?per_page=${PER_REPO}`,
     { headers },

package/src/search-state.ts

@@ -4,7 +4,7 @@
  * The TUI view layer reads from SearchState and dispatches actions.
  * This module is testable without the OpenTUI renderer.
  */
-import type { Repo, SearchOptions, SortStrategy, SessionState } from "./types";
+import type { Repo, SortStrategy, SessionState } from "./types";
 import type { TabName } from "./trending";
 import { tabSince } from "./trending";
 import {
@@ -24,7 +24,6 @@ import {
   touchSavedSearch,
 } from "./saved-searches";
 import { fetchDeepDive, buildDeepDiveText } from "./deepdive";
-import { fetchTopics } from "./explore";
 import { loadConfig } from "./config";
 
 export type Overlay =
@@ -131,8 +130,6 @@ export class SearchStateManager {
         timestamp: Date.now(),
         resultCount: response.repos.length,
       });
-    } catch (err) {
-      throw err;
     } finally {
       this.state.isLoading = false;
     }

package/src/search.ts

@@ -181,7 +181,7 @@ export function suggestFor(input: string): string[] {
     return QUALIFIER_SUGGESTIONS[trimmed];
   }
   const matches = KNOWN_QUALIFIERS.filter((k) => k.startsWith(trimmed));
-  return matches.map((k) => k + ":");
+  return matches.map((k) => `${k}:`);
 }
 
 export function tokenize(input: string): string[] {
@@ -329,7 +329,6 @@ export function githubSortParam(sort: SortStrategy): {
       return { sort: "forks", order: "desc" };
     case "updated":
       return { sort: "updated", order: "desc" };
-    case "best-match":
     default:
       return {};
   }
@@ -359,7 +358,6 @@ export function rankRepos(repos: Repo[], strategy: SortStrategy): Repo[] {
     case "updated":
       copy.sort(byKey((r) => Date.parse(r.updatedAt)));
       break;
-    case "best-match":
     default:
       break;
   }
@@ -473,7 +471,7 @@ export class GitHubSearchAdapter implements SearchAdapter {
           if (
             !parsed ||
             typeof parsed !== "object" ||
-            !Array.isArray((parsed as any).items)
+            !Array.isArray((parsed as { items?: unknown }).items)
           ) {
             this.logger.error(
               `[github] unexpected response shape: ${JSON.stringify(parsed).slice(0, 200)}`,
@@ -570,6 +568,25 @@ export function trendingLanguageSlug(language: string): string {
   return language.trim().toLowerCase().replace(/\s+/g, "-");
 }
 
+/**
+ * Validate a user-supplied trending language and return its slug, or null if
+ * empty. Throws with a user-facing suggestion list for unknown languages.
+ * Shared by the MCP trending tool and the CLI trending filter.
+ */
+export function resolveTrendingLanguage(
+  language: string | undefined | null,
+): string | undefined {
+  const trimmed = typeof language === "string" ? language.trim() : "";
+  if (!trimmed) return undefined;
+  const slug = trendingLanguageSlug(trimmed);
+  if (!TRENDING_LANGUAGES.has(slug)) {
+    throw new Error(
+      `"${trimmed}" is not a trending language filter. Try one of: rust, python, typescript, javascript, go, zig.`,
+    );
+  }
+  return slug;
+}
+
 /** Build the github.com/trending URL for a period + optional language filter. */
 export function buildTrendingUrl(
   since: "daily" | "weekly" | "monthly",
@@ -611,6 +628,7 @@ function trendingRepoToRepo(r: RawTrendingRepo): Repo {
  */
 export class TrendingAdapter implements SearchAdapter {
   readonly name = "trending";
+  // biome-ignore lint/correctness/noUnusedPrivateClassMembers: part of the adapter constructor contract — callers pass a shared logger (search.ts:757) even though this adapter currently logs nothing itself.
   private readonly logger: Logger;
 
   constructor(logger: Logger = noopLogger) {

package/src/share.ts

@@ -19,7 +19,7 @@ export function formatShare(repo: Repo, format: ShareFormat): string {
 }
 
 /** Copy text to clipboard via platform command. */
-import { spawn } from "child_process";
+import { spawn } from "node:child_process";
 
 export async function copyToClipboard(text: string): Promise<boolean> {
   try {
@@ -46,7 +46,7 @@ export async function copyToClipboard(text: string): Promise<boolean> {
 }
 
 async function findLinuxClipboard(): Promise<string[] | null> {
-  const { execFileSync } = await import("child_process");
+  const { execFileSync } = await import("node:child_process");
   try {
     execFileSync("xclip", ["-version"], { stdio: "ignore" });
     return ["xclip", "-selection", "clipboard"];

package/src/storage.ts

@@ -12,8 +12,8 @@ import {
   writeFileSync,
   appendFileSync,
   unlinkSync,
-} from "fs";
-import { join } from "path";
+} from "node:fs";
+import { join } from "node:path";
 import { stateDir } from "./config";
 
 /** Ensure the state directory exists. */
@@ -43,7 +43,7 @@ export function appendJSONL(filename: string, obj: unknown): void {
   try {
     appendFileSync(
       join(stateDir(), filename),
-      JSON.stringify(obj) + "\n",
+      `${JSON.stringify(obj)}\n`,
       "utf-8",
     );
   } catch {
@@ -119,7 +119,7 @@ export const memoryStorage = {
   },
   appendJSONL(filename: string, obj: unknown): void {
     const existing = memStore.get(filename) ?? "";
-    memStore.set(filename, existing + JSON.stringify(obj) + "\n");
+    memStore.set(filename, `${existing + JSON.stringify(obj)}\n`);
   },
   readJSONL<T>(filename: string): T[] {
     const raw = memStore.get(filename);

package/src/themes.ts

@@ -242,6 +242,7 @@ export async function detectTerminalBackground(
     // Reply: ESC ] 11 ; <spec> (BEL | ESC \)
     const onData = (d: Buffer) => {
       buffer += d.toString("latin1");
+      // biome-ignore lint/suspicious/noControlCharactersInRegex: matches raw ANSI OSC-11 escape bytes, which are control characters by definition
       const m = buffer.match(/\x1b\]11;([^\x07\x1b]*)(?:\x07|\x1b\\)/);
       if (m) finish(parseOscColor(m[1]));
     };

package/src/trending-parser.ts

@@ -35,7 +35,7 @@ function parseRepoLink(block: string): RepoLink | undefined {
   // `/login?...&return_to=...` href fails the bare-path requirement and the
   // stargazers/forks links don't carry the heading's class="Link".
   const anchor = block.match(
-    /<a[^>]*?href="\/([A-Za-z0-9._-]+)\/([^\"?#]+)"[^>]*class="Link"/,
+    /<a[^>]*?href="\/([A-Za-z0-9._-]+)\/([^"?#]+)"[^>]*class="Link"/,
   );
   if (!anchor) return undefined;
   return { owner: anchor[1], name: anchor[2] };
@@ -43,7 +43,7 @@ function parseRepoLink(block: string): RepoLink | undefined {
 
 function parseStars(block: string): number {
   const starsMatch = block.match(
-    /href="\/[^\/\"]+\/[^\/\"]+\/stargazers"[^>]*>.*?<\/svg>\s*(\d[\d,]*)/,
+    /href="\/[^/"]+\/[^/"]+\/stargazers"[^>]*>.*?<\/svg>\s*(\d[\d,]*)/,
   );
   return starsMatch ? parseInt(starsMatch[1].replace(/,/g, ""), 10) : 0;
 }
@@ -69,10 +69,9 @@ export function parseTrendingHtml(html: string): RawTrendingRepo[] {
   const flat = flattenHtml(html);
   const repos: RawTrendingRepo[] = [];
   const articleRe = /<article class="Box-row">(.*?)<\/article>/gi;
-  let match: RegExpExecArray | null;
   let rank = 0;
 
-  while ((match = articleRe.exec(flat)) !== null) {
+  for (const match of flat.matchAll(articleRe)) {
     rank++;
     const block = match[1];
     const link = parseRepoLink(block);

package/src/trending.ts

@@ -118,13 +118,13 @@ export function formatRepoLine(repo: Repo, rank: number): StyledText {
   const rankStr = String(rank).padStart(2, "0");
   const full = `${repo.owner}/${repo.name}`;
   const lc = langColor(repo.language ?? "");
-  const rc = rankColor(rank);
+  const _rc = rankColor(rank);
   const star = "★";
   const arrow = repo.score > 0 ? "▲" : repo.score < 0 ? "▼" : "—";
   const growth = `${arrow} ${fmtSigned(repo.score)} today`;
   const desc =
     (repo.description ?? "").length > 60
-      ? (repo.description ?? "").slice(0, 57) + "..."
+      ? `${(repo.description ?? "").slice(0, 57)}...`
       : (repo.description ?? "");
   const line1 = t`${dim(fg(C.rankBg)(`[${rankStr}]`))} ${bold(fg("#c0caf5")(full))}  ${fg(lc)(`● ${repo.language}`)}  ${fg(C.gold)(`${star} ${fmtStars(repo.stars)}`)}  ${bold(fg(C.green)(growth))}`;
   const line2 = t`  ${dim(fg(C.muted)(desc))}`;
@@ -182,7 +182,7 @@ export async function launchTrending(): Promise<void> {
   let currentPeriod = "this week";
   let repos: Repo[] = [];
   let selectedRepoIdx = 0;
-  let isLoading = false;
+  let _isLoading = false;
   // ── Fetch from github.com/trending ──
   async function loadTab(index: number) {
     if (index < 0 || index >= TAB_NAMES.length) return;
@@ -194,7 +194,7 @@ export async function launchTrending(): Promise<void> {
         : since === "weekly"
           ? "this week"
           : "this month";
-    isLoading = true;
+    _isLoading = true;
     for (const rb of rowBoxes) scrollBox.remove(rb);
     rowBoxes.length = 0;
     rowTexts.length = 0;
@@ -233,7 +233,7 @@ export async function launchTrending(): Promise<void> {
       });
       scrollBox.add(errText);
     }
-    isLoading = false;
+    _isLoading = false;
     renderTabBar();
     renderer.requestRender();
   }
@@ -359,7 +359,7 @@ export async function launchTrending(): Promise<void> {
       const lc = langColor(r.language ?? "");
       const desc =
         (r.description ?? "").length > 55
-          ? (r.description ?? "").slice(0, 52) + "..."
+          ? `${(r.description ?? "").slice(0, 52)}...`
           : (r.description ?? "");
       const arrow = r.score > 0 ? "▲" : r.score < 0 ? "▼" : "—";
       const growthStr = `${arrow} ${fmtStars(Math.abs(r.score))} ${currentPeriod}`;
@@ -373,7 +373,7 @@ export async function launchTrending(): Promise<void> {
         fg: rc,
         height: 1,
       });
-      const descStr = desc.length > 60 ? desc.slice(0, 57) + "..." : desc;
+      const descStr = desc.length > 60 ? `${desc.slice(0, 57)}...` : desc;
       const pad = "     ";
       const line1 = t`${bold(fg("#c0caf5")(nameStr))}${fg(lc)(langStr)}${fg(C.muted)(starsStr)}${bold(fg(C.green)(growthStr))}`;
       const line2 = t`${fg(C.descText)(`${pad}${descStr}`)}`;