github-search-cli 9.4.2 → 9.4.4

package/CHANGELOG.md

@@ -5,8 +5,20 @@ All notable changes to `github-search-cli` (published as the `ghfind` binary).
 Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). Published versions and dates mirror [npm](https://www.npmjs.com/package/github-search-cli?activeTab=versions).
 
 ---
+## [9.4.3] — 2026-09-13 (released)
 
-## — 9.4.2
+### Added
+- nothing added
+
+### Changed
+
+- tui bug that local works but global doesn't
+
+### Fixed
+
+- tui bug that local works but global doesn't
+
+## [9.4.2] — 2026-09-12 (released)
 
 ### Added
 
@@ -25,6 +37,21 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). Publish
 - **README trust & comparison** — npm version / weekly downloads / CI /
   TypeScript / license badges; a "Why ghfind?" table vs `gh search` and
   `hub`; standalone-binary install section.
+- **`ghfind login`** — stores a GitHub token for 5,000 req/hr rate limits.
+  Detects a token managed by the GitHub CLI (`~/.config/gh/hosts.yml`) and
+  offers to import it, or accepts a pasted token; warns if it doesn't look
+  like a GitHub credential (`ghp_` / `gho_` / `github_pat_`). Writes the same
+  config file as `ghfind init`.
+- **Better failure hints** — the `bin/ghfind.js` entry now points broken
+  installs at `ghfind --doctor` instead of failing silently (previously a
+  missing `src/` + `dist/` exited 0 without a word).
+- **Hardened trending parser** — `parseTrendingHtml` moved to its own module
+  (`src/trending-parser.ts`, no TUI/@opentui dependency). Layout changes that
+  previously produced an **empty trending list with no explanation** now throw
+  a friendly `ParseError` ("GitHub may have changed the layout. [r]etry").
+  New golden-test harness: `tests/fixtures/trending.html` is a live capture
+  of the page, and 11 tests pin the parser to it (including the login
+  `/login?return_to=…` href and `/owner/name/stargazers`-link false positives).
 
 ### Changed
 
@@ -43,12 +70,19 @@ Format follows [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). Publish
   `package.json` via filesystem paths in `cli.ts`, `tui.ts`,
   `update-check.ts`, and `error-report.ts`, which do not exist inside a
   single-file executable. Version is now embedded at build time.
+- **TUI crashed on boot with upgrade state (`bun start` → exit 1)** — the
+  update modal's `showOverlay("update")` called `updateSelect.focus()`, but
+  `updateSelect` was never declared (vestigial reference from the 9.4.0
+  refactor). Every launch where `update-state.json` recorded a version
+  upgrade threw `ReferenceError: updateSelect is not defined` before the
+  render loop started. The vestigial call is removed; the modal is driven by
+  `updateSelectedOption` + the global key handler, which now renders
+  correctly ("Updated ghfind X → Y" panel). Guarded by a source-grep test in
+  `tests/overlay-registry.test.ts`.
 
 ---
 
-## [Unreleased] — 9.4.1
-
-## [Unreleased] — 9.4.1
+## [Unreleased]
 
 ### Changed
 

package/README.md

@@ -62,6 +62,7 @@ ghfind
 ghfind "language:Rust stars:>1000" --json | jq '.[].fullName'
 ghfind "language:Zig" --count
 ghfind --trending --json --since weekly
+ghfind login                    # import the gh CLI token or paste one
 ```
 
 ### Non-interactive
@@ -190,7 +191,7 @@ Prefix with `-` to exclude. Supported: `language`, `stars`, `fork`, `archived`,
 
 ## Config
 
-`~/.config/ghfind/config.json` (auto-created, or run `ghfind init`):
+`~/.config/ghfind/config.json` (auto-created, or run `ghfind init`; `ghfind login` will set your GitHub token):
 
 ```json
 {
@@ -214,14 +215,18 @@ cd ghfind
 # With Bun (recommended for TUI)
 bun install
 bun start        # TUI
-bun test         # 179 tests
+bun test         # 215 tests
+bun run check    # format check + tests — the green gate
 bun run build    # build dist/
 
 # Or with npm
 npm install
 npm start        # TUI (requires Node 20+)
-npm test         # 179 tests
+npm test         # 215 tests
 npm run build    # build dist/
+
+> Want to contribute? See [CONTRIBUTING.md](CONTRIBUTING.md) for commands,
+> conventions, and the two tracked quality gates (`typecheck`, `lint`).
 ```
 
 ---

package/bin/ghfind.js

@@ -1,89 +1,98 @@
-#!/usr/bin/env node
-/**
- * ghfind — npm bin entry point.
- * Requires Node.js >= 20 or Bun.
- *
- * Strategy 1: Use a Bun binary to run TypeScript source directly. Prefers the
- *   bundled vendor/bun (downloaded by postinstall), then falls back to a
- *   system-installed `bun` on PATH. Only runnable binaries are considered.
- * Strategy 2: Fall back to the bundled dist/cli.js with Node.js (works for
- *   non-interactive modes).
- */
-import { existsSync } from "fs";
-import { spawnSync } from "child_process";
-import { join, dirname } from "path";
-import { fileURLToPath, pathToFileURL } from "url";
-import { platform } from "os";
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const PKG_DIR = join(__dirname, "..");
-
-// Path to bundled Bun binary
-const BUN_BIN = join(
-  PKG_DIR,
-  "vendor",
-  platform() === "win32" ? "bun.exe" : "bun",
-);
-
-// Path to bundled dist
-const distCli = join(PKG_DIR, "dist", "cli.js");
-
-// Path to source
-const srcCli = join(PKG_DIR, "src", "cli.ts");
-
-/** Returns "bun" if a system Bun is available on PATH, else undefined. */
-function systemBun() {
-  try {
-    const res = spawnSync("bun", ["--version"], {
-      encoding: "utf8",
-      timeout: 15000,
-    });
-    return res.status === 0 ? "bun" : undefined;
-  } catch {
-    return undefined;
-  }
-}
-
-/** Returns true if the given Bun binary actually runs. */
-function bunRuns(bin) {
-  try {
-    const res = spawnSync(bin, ["--version"], {
-      encoding: "utf8",
-      timeout: 15000,
-    });
-    return res.status === 0;
-  } catch {
-    return false;
-  }
-}
-
-// Strategy 1: Use Bun to run source directly (bundled binary first, then system bun)
-if (existsSync(srcCli)) {
-  const candidates = [];
-  if (existsSync(BUN_BIN)) candidates.push(BUN_BIN);
-  const sysBun = systemBun();
-  if (sysBun) candidates.push(sysBun);
-
-  for (const bunBin of candidates) {
-    if (!bunRuns(bunBin)) continue;
-    const result = spawnSync(
-      bunBin,
-      ["run", srcCli, ...process.argv.slice(2)],
-      {
-        stdio: "inherit",
-        env: { ...process.env, GHFIND_BUNDLED: "1" },
-      },
-    );
-    process.exit(result.status ?? 0);
-  }
-}
-
-// Strategy 2: Use bundled dist/cli.js with Node (non-interactive only on Node 23+)
-if (existsSync(distCli)) {
-  try {
-    await import(pathToFileURL(distCli).href);
-  } catch (err) {
-    console.error("Failed to start ghfind. Node.js >= 20 or Bun required.");
-    console.error(err instanceof Error ? err.message : String(err));
-    process.exit(1);
-  }
-}
+#!/usr/bin/env node
+/**
+ * ghfind — npm bin entry point.
+ * Requires Node.js >= 20 or Bun.
+ *
+ * Strategy 1: Use a Bun binary to run TypeScript source directly. Prefers the
+ *   bundled vendor/bun (downloaded by postinstall), then falls back to a
+ *   system-installed `bun` on PATH. Only runnable binaries are considered.
+ * Strategy 2: Fall back to the bundled dist/cli.js with Node.js (works for
+ *   non-interactive modes).
+ */
+import { existsSync } from "fs";
+import { spawnSync } from "child_process";
+import { join, dirname } from "path";
+import { fileURLToPath, pathToFileURL } from "url";
+import { platform } from "os";
+const __dirname = dirname(fileURLToPath(import.meta.url));
+const PKG_DIR = join(__dirname, "..");
+
+// Path to bundled Bun binary
+const BUN_BIN = join(
+  PKG_DIR,
+  "vendor",
+  platform() === "win32" ? "bun.exe" : "bun",
+);
+
+// Path to bundled dist
+const distCli = join(PKG_DIR, "dist", "cli.js");
+
+// Path to source
+const srcCli = join(PKG_DIR, "src", "cli.ts");
+
+/** Returns "bun" if a system Bun is available on PATH, else undefined. */
+function systemBun() {
+  try {
+    const res = spawnSync("bun", ["--version"], {
+      encoding: "utf8",
+      timeout: 15000,
+    });
+    return res.status === 0 ? "bun" : undefined;
+  } catch {
+    return undefined;
+  }
+}
+
+/** Returns true if the given Bun binary actually runs. */
+function bunRuns(bin) {
+  try {
+    const res = spawnSync(bin, ["--version"], {
+      encoding: "utf8",
+      timeout: 15000,
+    });
+    return res.status === 0;
+  } catch {
+    return false;
+  }
+}
+
+// Strategy 1: Use Bun to run source directly (bundled binary first, then system bun)
+if (existsSync(srcCli)) {
+  const candidates = [];
+  if (existsSync(BUN_BIN)) candidates.push(BUN_BIN);
+  const sysBun = systemBun();
+  if (sysBun) candidates.push(sysBun);
+
+  for (const bunBin of candidates) {
+    if (!bunRuns(bunBin)) continue;
+    const result = spawnSync(
+      bunBin,
+      ["run", srcCli, ...process.argv.slice(2)],
+      {
+        stdio: "inherit",
+        env: { ...process.env, GHFIND_BUNDLED: "1" },
+      },
+    );
+    process.exit(result.status ?? 0);
+  }
+}
+
+// Strategy 2: Use bundled dist/cli.js with Node (non-interactive only on Node 23+)
+if (existsSync(distCli)) {
+  try {
+    await import(pathToFileURL(distCli).href);
+  } catch (err) {
+    console.error("Failed to start ghfind. Node.js >= 20 or Bun required.");
+    console.error(
+      "  Tip: run 'ghfind --doctor' for a full environment report.",
+    );
+    console.error(err instanceof Error ? err.message : String(err));
+    process.exit(1);
+  }
+}
+
+// Neither strategy produced a runnable CLI: report clearly instead of exiting 0.
+console.error("ghfind: could not start — neither src/ nor dist/ is available.");
+console.error("  Try reinstalling: npm install -g github-search-cli");
+console.error("  Tip: run 'ghfind --doctor' for a full environment report.");
+process.exit(1);

package/completions/ghfind.bash

@@ -7,7 +7,7 @@ _ghfind() {
   cur="${COMP_WORDS[COMP_CWORD]}"
   prev="${COMP_WORDS[COMP_CWORD-1]}"
 
-  opts="--json --csv --markdown --count --limit --sort --token --trending --since --pipe --format --registry --watch --interval --version --help --completion pkg"
+  opts="--json --csv --markdown --count --limit --sort --token --trending --since --pipe --format --registry --watch --interval --version --help --completion pkg login init doctor org"
 
   case "${prev}" in
     --sort)

package/completions/ghfind.fish

@@ -18,4 +18,6 @@ complete -c ghfind -l watch -d "Watch mode"
 complete -c ghfind -l interval -d "Watch interval seconds" -r
 complete -c ghfind -l version -d "Print version"
 complete -c ghfind -l help -d "Print help"
-complete -c ghfind -l completion -d "Shell" -r -f -a "bash zsh fish"
+complete -c ghfind -l completion -d "Shell" -r -f -a "bash zsh fish"
+
+complete -c ghfind -f -a "login init doctor org pkg"

package/completions/ghfind.zsh

@@ -22,6 +22,12 @@ _ghfind() {
     '--version[Print version]'
     '--help[Print help]'
     '--completion[Shell]:(bash zsh fish)'
+
+    'login[Import a GitHub token from the gh CLI or paste one]'
+    'init[Run the setup wizard]'
+    'doctor[Environment diagnostics]'
+    'org[Org profile]:org name:'
+    'pkg[Search packages]:query:'
   )
   _arguments "${opts[@]}" '*:query:'
 }

package/dist/{chunk-IVUU2KGR.js → chunk-GYIL4S5X.js}

@@ -38,7 +38,10 @@ function loadConfig() {
 }
 function saveConfig(config) {
   const path = configPath();
-  const dir = path.slice(0, Math.max(path.lastIndexOf("/"), path.lastIndexOf("\\")));
+  const dir = path.slice(
+    0,
+    Math.max(path.lastIndexOf("/"), path.lastIndexOf("\\"))
+  );
   mkdirSync(dir, { recursive: true });
   writeFileSync(path, JSON.stringify(config, null, 2));
 }