github-router 0.3.292 → 0.3.295

package/dist/{attribution-settings-CpLUCi8R.js → attribution-settings-pkIop1NU.js}

@@ -1,10 +1,9 @@
-import { $t as CONDENSED_OPERATING_SEQUENCE, Sn as withOneMSuffix, a as buildAgentPrompt, en as DEFINITION_OF_GREATNESS, l as personasFor, n as MCP_GROUPS, t as GROUP_META, xn as oneMContextDisabled } from "./peer-mcp-personas-CHbl6MwM.js";
-import { a as isUnderClaudeConfigMirror, d as writeRuntimeFileSecure, t as PATHS } from "./paths-BH4J7slC.js";
-import { f as LUNA_IMPLEMENTER_ALIAS_ID, p as LUNA_SCOUT_ALIAS_ID } from "./server-setup-CqlaZukJ.js";
-import "./self-invocation-DhO1Z8iD.js";
-import { a as STRIPPED_AUTH_ROUTING_ENV_KEYS, n as buildCodexProviderConfigFlags } from "./provision-BYFd9nPK.js";
-import { n as buildWorkspaceHeaderHelperCommand } from "./mcp-workspace-header-q34H_4wL.js";
-import { a as dispatcherAgentName, c as dispatcherTools, n as activeDispatchModes, o as dispatcherDescription, s as dispatcherPrompt } from "./worker-dispatch-D5fGroNr.js";
+import { It as LUNA_SCOUT_ALIAS_ID, Ln as oneMContextDisabled, Pt as LUNA_IMPLEMENTER_ALIAS_ID, Rn as withOneMSuffix, _n as DEFINITION_OF_GREATNESS, a as buildAgentPrompt, gn as CONDENSED_OPERATING_SEQUENCE, jt as FAST_CRITIC_ALIAS_ID, l as personasFor, n as MCP_GROUPS, t as GROUP_META } from "./peer-mcp-personas-BwNtC8jt.js";
+import { a as isUnderClaudeConfigMirror, d as writeRuntimeFileSecure, t as PATHS } from "./paths-Ci485qSJ.js";
+import "./self-invocation-DAB_od0C.js";
+import { a as STRIPPED_AUTH_ROUTING_ENV_KEYS, n as buildCodexProviderConfigFlags } from "./provision-DeNqzvSM.js";
+import { n as buildWorkspaceHeaderHelperCommand } from "./mcp-workspace-header-dERl2YTT.js";
+import { a as dispatcherAgentName, c as dispatcherTools, n as activeDispatchModes, o as dispatcherDescription, s as dispatcherPrompt } from "./worker-dispatch-BEHkTbnH.js";
 import consola from "consola";
 import path from "node:path";
 import { randomBytes } from "node:crypto";
@@ -280,27 +279,43 @@ function buildFastProfileAgentDefinitions(opts) {
 	const implementerModel = nonEmptyModel(opts.nativeSubagentModel);
 	const reviewerModel = nonEmptyModel(opts.reviewerModel);
 	const plannerModel = nonEmptyModel(opts.plannerModel);
-	if (!scoutModel || !implementerModel || !reviewerModel || !plannerModel) throw new Error("fast profile requires resolved scout, implementer, reviewer, and planner models");
+	const criticModel = nonEmptyModel(opts.criticModel);
+	if (!scoutModel || !implementerModel || !reviewerModel || !plannerModel || !criticModel) throw new Error("fast profile requires resolved scout, implementer, reviewer, planner, and critic models");
 	const searchKey = opts.groupKeys.search ?? GROUP_META.search.preferredKey;
 	const peersKey = peersKeyOf(opts.groupKeys);
 	const searchMcp = opts.serverUrl ? { mcpServers: { [searchKey]: httpEntryFor(opts.serverUrl, "search", opts.nonce, opts.workspaceHeaderCmd) } } : {};
 	const peersMcp = opts.serverUrl && opts.groupKeys.peers ? { mcpServers: { [peersKey]: httpEntryFor(opts.serverUrl, "peers", opts.nonce, opts.workspaceHeaderCmd) } } : {};
 	const oracleTool = opts.groupKeys.peers ? `mcp__${peersKey}__oracle` : void 0;
-	const readOnlyTools = readOnlyToolAllowlist(searchKey);
-	const consultTools = oracleTool ? [...readOnlyTools, oracleTool] : readOnlyTools;
-	const reviewerPrompt = "You are the fast profile's repository-aware reviewer. Verify what is actually true by reading the code and running the relevant build, tests, or end-to-end reproduction. Find root causes rather than symptoms. Do not modify production code. Report severity-ranked findings with `file:line` evidence and a clear go/no-go. Use Oracle only as a last resort after your own investigation and Advisor have not resolved one precise question. " + fileToolSteer("builds and reproductions") + " Do not spawn further agents.";
+	const readSearchTools = [
+		"Read",
+		"Grep",
+		"Glob",
+		"Bash"
+	];
+	const scoutTools = [...readSearchTools, `mcp__${searchKey}__*`];
+	const reviewerTools = [...scoutTools, ...oracleTool ? [oracleTool] : []];
+	const plannerTools = [
+		...readSearchTools,
+		"WebFetch",
+		"WebSearch",
+		`mcp__${searchKey}__*`,
+		...oracleTool ? [oracleTool] : [],
+		"Agent"
+	];
+	const reviewerPrompt = "You are the fast profile's repository-aware reviewer. Verify what is actually true by reading the code and running the relevant build, tests, or end-to-end reproduction. Find root causes rather than symptoms. Do not modify production code. Report severity-ranked findings with `file:line` evidence and a clear go/no-go. You do not have Advisor; independently reach your verdict from repository evidence. Use Oracle only as a last resort for one precise unresolved question after your own investigation. " + fileToolSteer("builds and reproductions") + " Do not spawn further agents.";
+	const criticPrompt = "You are the fast profile's fresh-context cross-lab critic. Assess the supplied plan, design, diff, or decision against its stated constraints. Look for overlooked failure modes, unsupported assumptions, and simpler safer alternatives. Do not modify files, run mutating commands, or spawn agents. Return concise severity-ranked findings with `file:line` evidence where applicable. " + readOnlyToolSteer();
 	const out = {
 		scout: {
 			description: `Read-only exploration subagent running ${scoutModel}. Use for broad repository discovery before the lead drafts a plan; return conclusions with file:line evidence, not file dumps.`,
 			prompt: "Investigate the repository read-only. Cast a wide net, then return a concise evidence packet for the lead: conclusions, load-bearing `file:line` citations, commands checked, and explicit gaps. Do not plan, edit, or spawn agents. " + readOnlyToolSteer(),
-			tools: readOnlyTools,
+			tools: scoutTools,
 			model: decorateGuaranteedOneM(LUNA_SCOUT_ALIAS_ID),
 			effort: opts.scoutEffort ?? "high",
 			...searchMcp
 		},
 		implementer: {
 			description: `Implementation subagent running ${implementerModel}. Use for well-specified mechanical changes after the plan is approved; implement and verify end to end in its own context.`,
-			prompt: "Implement the approved, well-specified change surgically. Match surrounding style, minimize unrelated churn, use dedicated file tools, and run the relevant build/tests. Do not redesign the plan or spawn more agents. Report changes, verification, and unresolved risk. " + fileToolSteer("builds"),
+			prompt: "Implement the approved, well-specified change surgically. Match surrounding style, minimize unrelated churn, use dedicated file tools, and run the relevant build/tests. For verification, you may invoke only the fast-profile `reviewer` or `critic` native subagent; do not invoke any other role or redesign the plan. Report changes, verification, and unresolved risk. " + fileToolSteer("builds"),
 			model: decorateGuaranteedOneM(LUNA_IMPLEMENTER_ALIAS_ID),
 			effort: opts.implementerEffort ?? "max"
 		},
@@ -309,12 +324,24 @@ function buildFastProfileAgentDefinitions(opts) {
 			prompt: reviewerPrompt,
 			model: reviewerModel,
 			effort: opts.reviewerEffort ?? "medium",
-			...peersMcp
+			tools: reviewerTools,
+			mcpServers: {
+				...searchMcp.mcpServers ?? {},
+				...peersMcp.mcpServers ?? {}
+			}
+		},
+		critic: {
+			description: `Fresh-context cross-lab critic running ${criticModel} at medium effort. Use to challenge a plan, design, diff, or decision against its stated constraints and expose overlooked failure modes.`,
+			prompt: criticPrompt,
+			model: decorateGuaranteedOneM(FAST_CRITIC_ALIAS_ID),
+			effort: opts.criticEffort ?? "medium",
+			tools: scoutTools,
+			...searchMcp
 		},
 		planner: {
 			description: `Plan consultant and approver running ${plannerModel}. Invoke only after Luna has done the repository legwork and drafted a plan; pass a handcrafted evidence packet and the complete draft. The lead must not implement until this agent returns APPROVE.`,
-			prompt: "You are the fast profile's final plan consultant and approver, not a first-pass planner. The caller must provide the user goal, acceptance criteria, repository/domain constraints, Luna's `file:line` and command/test evidence, the complete draft plan, settled decisions, and one focused review question. Selectively verify disputed citations or narrow evidence gaps with read/search tools, but do not repeat broad discovery, edit files, or execute the plan. Return exactly one leading verdict: `APPROVE`, `REVISE`, or `NEED_MORE_CONTEXT`. APPROVE only when the plan is safe, ordered, complete, and verifiable. REVISE must give concrete corrections. NEED_MORE_CONTEXT must name the exact evidence Luna should collect. Use Oracle only as a last resort for one precise unresolved question after your own review and Advisor are insufficient. Do not spawn further agents. " + readOnlyToolSteer(),
-			tools: consultTools,
+			prompt: "You are the fast profile's final plan consultant and approver, not a first-pass planner. The caller must provide the user goal, acceptance criteria, repository/domain constraints, Luna's `file:line` and command/test evidence, the complete draft plan, settled decisions, and one focused review question. Selectively verify disputed citations or narrow evidence gaps with read/search tools, but do not repeat broad discovery, edit files, or execute the plan. Return exactly one leading verdict: `APPROVE`, `REVISE`, or `NEED_MORE_CONTEXT`. APPROVE only when the plan is safe, ordered, complete, and verifiable. REVISE must give concrete corrections. NEED_MORE_CONTEXT must name the exact evidence Luna should collect. You do not have Advisor; independently reach your verdict from the evidence packet and selective verification. Use Oracle only as a last resort for one precise unresolved question after your own review. The Task/Agent capability is restricted by the fast in-session ACL: you may invoke only `reviewer`, `scout`, or `critic`; do not invoke any other role. Bash is for evidence commands only; this is not a shell sandbox. " + readOnlyToolSteer(),
+			tools: plannerTools,
 			model: decorateGuaranteedOneM(plannerModel),
 			effort: opts.plannerEffort ?? "high",
 			mcpServers: {
@@ -789,6 +816,8 @@ async function writePeerMcpRuntimeFiles(serverUrl, opts) {
 		implementerEffort: opts.implementerEffort,
 		reviewerEffort: opts.reviewerEffort,
 		plannerEffort: opts.plannerEffort,
+		criticModel: opts.criticModel,
+		criticEffort: opts.criticEffort,
 		nonce,
 		codexHome,
 		serverUrl,
@@ -796,15 +825,24 @@ async function writePeerMcpRuntimeFiles(serverUrl, opts) {
 	});
 	await fs.unlink(mcpConfigPath).catch(() => {});
 	await fs.unlink(agentsPath).catch(() => {});
-	await writeRuntimeFileSecure(mcpConfigPath, JSON.stringify(mcpConfig, null, 2));
-	await writeRuntimeFileSecure(agentsPath, JSON.stringify(agents, null, 2));
-	const mdResult = await writePeerAgentMdFiles(opts.builtinSubagents ? {
-		...agents,
-		...opts.builtinSubagents
-	} : agents, {
-		agentsDir: opts.agentsDir,
-		fileSuffix
-	});
+	let mdResult;
+	try {
+		await writeRuntimeFileSecure(mcpConfigPath, JSON.stringify(mcpConfig, null, 2));
+		await writeRuntimeFileSecure(agentsPath, JSON.stringify(agents, null, 2));
+		mdResult = await writePeerAgentMdFiles(opts.builtinSubagents ? {
+			...agents,
+			...opts.builtinSubagents
+		} : agents, {
+			agentsDir: opts.agentsDir,
+			fileSuffix
+		});
+	} catch (err) {
+		if (mdResult) await mdResult.cleanup().catch(() => {});
+		await Promise.allSettled([fs.unlink(mcpConfigPath), fs.unlink(agentsPath)]);
+		throw err;
+	}
+	const completeMdResult = mdResult;
+	if (!completeMdResult) throw new Error("peer MCP agent files were not generated");
 	const personas = opts.fastProfile ? [] : personasFor({
 		codexCli: opts.codexCli,
 		geminiAvailable: opts.geminiAvailable,
@@ -815,13 +853,13 @@ async function writePeerMcpRuntimeFiles(serverUrl, opts) {
 		await Promise.allSettled([
 			fs.unlink(mcpConfigPath),
 			fs.unlink(agentsPath),
-			mdResult.cleanup()
+			completeMdResult.cleanup()
 		]);
 	};
 	return {
 		mcpConfigPath,
 		agentsPath,
-		agentMdPaths: mdResult.paths,
+		agentMdPaths: completeMdResult.paths,
 		nonce,
 		personas,
 		cleanup
@@ -1883,7 +1921,8 @@ function buildNativeReachClauses(opts) {
 		"`scout` to find or understand something in the repo",
 		"`implementer` for approved mechanical coding changes",
 		"`reviewer` for repository-aware verification, reproduction, and root-causing",
-		"`planner` as the Sol plan consultant and approver after Luna has drafted with evidence"
+		"`planner` as the Sol plan consultant and approver after Luna has drafted with evidence",
+		"`critic` for a fresh-context cross-lab challenge to a plan, design, diff, or decision"
 	]);
 	const clauses = [];
 	const implementerFast = opts.implementerFastAvailable !== false;
@@ -1907,7 +1946,7 @@ function buildNativeReachClauses(opts) {
 function buildOperatingDefaultsDirective(opts = {}) {
 	if (opts.profile === "fast") {
 		if (opts.fastRuntimeAvailable === false) return "## Operating defaults (apply when the user has not specified otherwise; the user's explicit direction and the domain's own standards always override)\n\nFast profile runtime wiring is unavailable, so no injected Task roster, search, or Oracle is available. Work directly, use only tools actually listed in this session, verify with the repository's relevant build/tests before declaring done, report uncertainty, and do not invent unavailable capabilities.";
-		return "## Operating defaults (apply when the user has not specified otherwise; the user's explicit direction and the domain's own standards always override)\n\nOrchestrate. Delegate research, implementation, and review to the right subagent. Reach for " + buildNativeReachClauses(opts) + "; Task subagents run in parallel. That keeps your own context free to reason and collaborate with the user. Delegate only when work is wide or slow; do trivial and surgical work directly. Luna investigates and drafts. The lead must give `planner` a handcrafted evidence packet and must not implement until `planner` returns `APPROVE`. Advisor is the transcript-aware brainstorming, sounding-board, fresh-look, uncertainty, and stuck path. `oracle` is exact Opus 5 (1M/high), stateless and last resort after the normal paths remain stuck. Before declaring work done, run the relevant build/tests and ask `reviewer` for repository-aware verification. Verify claims, report uncertainty, and stop named teammates when finished.";
+		return "## Operating defaults (apply when the user has not specified otherwise; the user's explicit direction and the domain's own standards always override)\n\nOrchestrate. Delegate research, implementation, and review to the right subagent. Reach for " + buildNativeReachClauses(opts) + "; Task subagents run in parallel. That keeps your own context free to reason and collaborate with the user. Delegate only when work is wide or slow; do trivial and surgical work directly. Luna investigates and drafts. The lead must give `planner` a handcrafted evidence packet and must not implement until `planner` returns `APPROVE`. Advisor is an optional, non-binding, lead-only transcript-aware sounding board for consequential unresolved uncertainty, conflicting evidence, or a genuinely stuck path; never use it for routine progress, waiting, directly verifiable facts, planner approval, reviewer verification, or completion ritual. `oracle` is exact Opus 5 (1M/high), stateless and last resort after the normal paths remain stuck. Before declaring work done, run the relevant build/tests and ask `reviewer` for repository-aware verification. Verify claims, report uncertainty, and stop named teammates when finished.";
 	}
 	return "## Operating defaults (apply when the user has not specified otherwise; the user's explicit direction and the domain's own standards always override)\n\nOrchestrate. Delegate research, implementation, review, and large reads to the right subagent, worker, or model. Reach for " + buildNativeReachClauses(opts) + "; worker-* agents for background non-blocking runs; Task subagents for parallel work; peer critics for review. That keeps your own context free to reason and collaborate with the user. Launch independent agents concurrently in a single message rather than serially. Delegation pays when the work is WIDE (many files or sources to sweep) or SLOW, and you need only the conclusion: the main thread is where you think with and respond to the user, and its context window is a finite shared resource. It does NOT pay merely because a sub-question is separable. A narrow, deep question whose whole value is file:line fidelity loses exactly that through a summarization layer, and a sub-question you could answer in one command is cheaper done directly than paying a subagent's startup. Do trivial, surgical, and last-mile work yourself. A named teammate persists after it reports so you can send it follow-ups, and nothing reaps it for you: its idle notice means available, not finished. Stop it once you are done with it.\n\nAdversarial review. The peer critics (`codex_critic` and `codex_reviewer`, `gemini_critic` and `gemini_reviewer`, `opus_critic`, and the `peer-review-coordinator` that fans out to several of them) are fresh-context models, so what they add is a blind spot that whoever produced the work cannot reach by thinking harder about it; prefer a critic from a different lab than the producer, since blind spots correlate within a lab. The `advisor` is a complement and not a substitute: it sees your transcript, so it catches your own drift and momentum, but it inherits your framing, which is exactly what a fresh-context critic does not. They earn their keep on consequential design choices, recommendations, and hard-to-reverse decisions: the cases where plausible alternatives remain and the conclusion rests on judgment rather than on something you can verify directly. That is where confabulation hides, so budget the wait even under delivery pressure. Always consult one when the change touches auth, user input, database queries, crypto, or serialization. They do NOT pay for read-only tracing, ordinary repository lookup, or a conclusion that a focused test, a direct reproduction, or unambiguous code evidence already settles. Asking a critic to re-derive a proven fact returns a confident answer either way, which is ritual skepticism rather than review, and skipping them there is the right call and not a shortcut. Match the lens to the artifact: a strategic critic for plans and trade-offs, a code reviewer for a concrete diff, the coordinator only when the risk warrants several independent lenses. Give whichever you pick the artifact and the constraints and not your rationale, since justification anchors the review and dulls it.\n\nAim high. Default to radical simplicity and a relentless focus on the user's real experience: design for the person and the job to be done, not the demo. Reason about the whole system from first principles, anticipating scale and the long arc rather than patching the surface. Work backwards from the outcome the user actually needs. Question every assumption and prefer what you can derive, reproduce, or test.\n\nEngineering excellence. When making technical decisions, give little weight to development cost; prefer quality, simplicity, robustness, scalability, and long-term maintainability. Fix a bug by first reproducing it end to end, as close to how a real user hits it as you can, so you solve the real problem and not a symptom. When testing a product end to end, be picky about the UI and obsessed with pixel perfection: if something clearly looks off, even when it is unrelated to your task, get it fixed along the way. Hold that same bar for the codebase itself: a lint error, a failing test, or a flaky test is worth fixing the moment you see it, whoever introduced it. Fold it into your current work rather than letting it derail the task the user actually asked for.";
 }
@@ -2476,4 +2515,4 @@ async function injectAttributionSuppressionIntoSettingsFile(settingsPath) {
 //#endregion
 export { injectPeerMcpIntoMirror as _, appendPeerAwarenessToMirroredClaudeMd as a, workersKeyOf as b, prependArtifactPanelDirectiveToMirroredClaudeMd as c, SEAMLESS_BUILTIN_TOOLS as d, configureServeDefaultPermissionMode as f, BUILTIN_SUBAGENT_DEFINITIONS as g, sanitizeServeSettingsEnv as h, OPERATING_DEFAULTS_DIGEST as i, prependOperatingDefaultsToMirroredClaudeMd as l, planModeAllowRules as m, INJECTED_SKILLS as n, appendToolbeltAwarenessToMirroredClaudeMd as o, injectAllowRules as p, writeInjectedSkill as r, buildOperatingDefaultsDirective as s, injectAttributionSuppressionIntoSettingsFile as t, prependStyleDirectiveToMirroredClaudeMd as u, resolveCodexCliBackend as v, writePeerMcpRuntimeFiles as x, resolveGroupKeysFromMirror as y };
 
-//# sourceMappingURL=attribution-settings-CpLUCi8R.js.map
+//# sourceMappingURL=attribution-settings-pkIop1NU.js.map