github-issue-tower-defence-management 2.6.1 → 2.7.0

package/src/domain/usecases/TriagerApprovalDispatchUseCase.ts

@@ -1,274 +0,0 @@
-import { IssueCommentRepository } from './adapter-interfaces/IssueCommentRepository';
-import { IssueRepository } from './adapter-interfaces/IssueRepository';
-import { ProjectRepository } from './adapter-interfaces/ProjectRepository';
-import { Comment } from '../entities/Comment';
-import {
-  isAgentReportBody,
-  isAgentReportBodyFromAgent,
-} from './isAgentReportBody';
-import { ensureAgentOptionAndGetId } from './ensureAgentOptionAndGetId';
-import { isAuthorAuthorizedForAutoStatusCheck } from './isAuthorAuthorizedForAutoStatusCheck';
-import { isRecord } from './isRecord';
-import {
-  AWAITING_QUALITY_CHECK_STATUS_NAME,
-  AWAITING_WORKSPACE_STATUS_NAME,
-} from '../entities/WorkflowStatus';
-import { normalizeReportBody } from './normalizeReportBody';
-
-const TRIAGER_AGENT_NAME = 'triager';
-const MAX_COMMENT_FETCHES_PER_CYCLE = 20;
-
-type TriagerProposal = {
-  recommendedAgent: string;
-  recommendedStory: string;
-  storyAlreadySet: boolean;
-};
-
-const parseTriagerProposalBlock = (
-  commentContent: string,
-): TriagerProposal | null => {
-  if (!isAgentReportBodyFromAgent(commentContent, TRIAGER_AGENT_NAME)) {
-    return null;
-  }
-  const jsonBlockMatches = [
-    ...normalizeReportBody(commentContent).matchAll(
-      /```json\n([\s\S]*?)\n```/g,
-    ),
-  ];
-  for (let i = 0; i < jsonBlockMatches.length; i++) {
-    const blockContent = jsonBlockMatches[i][1];
-    if (!blockContent) {
-      continue;
-    }
-    let parsed: unknown;
-    try {
-      parsed = JSON.parse(blockContent);
-    } catch {
-      continue;
-    }
-    if (!isRecord(parsed)) {
-      continue;
-    }
-    const proposalValue = parsed['triagerProposal'];
-    if (!isRecord(proposalValue)) {
-      continue;
-    }
-    if (
-      typeof proposalValue['recommendedAgent'] !== 'string' ||
-      typeof proposalValue['recommendedStory'] !== 'string' ||
-      typeof proposalValue['storyAlreadySet'] !== 'boolean'
-    ) {
-      continue;
-    }
-    return {
-      recommendedAgent: proposalValue['recommendedAgent'],
-      recommendedStory: proposalValue['recommendedStory'],
-      storyAlreadySet: proposalValue['storyAlreadySet'],
-    };
-  }
-  return null;
-};
-
-const isNotFoundError = (error: unknown): boolean =>
-  (error instanceof Error ? error.message : String(error)).includes('404');
-
-const isApprovalComment = (
-  content: string,
-  author: string,
-  allowedIssueAuthors: string[],
-): boolean => {
-  if (!isAuthorAuthorizedForAutoStatusCheck(author, allowedIssueAuthors)) {
-    return false;
-  }
-  if (isAgentReportBody(content)) {
-    return false;
-  }
-  return /^(ok|オーケー|はい[\s\S]*)$/i.test(content.trim());
-};
-
-export class TriagerApprovalDispatchUseCase {
-  constructor(
-    private readonly projectRepository: Pick<
-      ProjectRepository,
-      | 'findProjectIdByUrl'
-      | 'getProject'
-      | 'createField'
-      | 'getByUrl'
-      | 'updateAgentList'
-    >,
-    private readonly issueRepository: Pick<
-      IssueRepository,
-      'getAllIssues' | 'updateStatus' | 'updateStory' | 'setIssueAgentField'
-    >,
-    private readonly issueCommentRepository: Pick<
-      IssueCommentRepository,
-      'getCommentsFromIssue' | 'createComment'
-    >,
-  ) {}
-
-  run = async (params: {
-    projectUrl: string;
-    allowedIssueAuthors?: string[] | null;
-    cycleIndex?: number;
-  }): Promise<void> => {
-    const allowedIssueAuthors = params.allowedIssueAuthors ?? null;
-    const cycleIndex = params.cycleIndex ?? Math.floor(Date.now() / 60_000);
-
-    const projectId = await this.projectRepository.findProjectIdByUrl(
-      params.projectUrl,
-    );
-    if (!projectId) {
-      throw new Error(`Project not found. projectUrl: ${params.projectUrl}`);
-    }
-    const project = await this.projectRepository.getProject(projectId);
-    if (!project) {
-      throw new Error(
-        `Project not found. projectId: ${projectId} projectUrl: ${params.projectUrl}`,
-      );
-    }
-
-    const awaitingWorkspaceStatus = project.status.statuses.find(
-      (s) => s.name === AWAITING_WORKSPACE_STATUS_NAME,
-    );
-    if (!awaitingWorkspaceStatus) {
-      return;
-    }
-
-    const { issues } = await this.issueRepository.getAllIssues(projectId);
-
-    const candidateIssues = issues
-      .filter(
-        (issue) =>
-          (issue.status === AWAITING_WORKSPACE_STATUS_NAME ||
-            issue.status === AWAITING_QUALITY_CHECK_STATUS_NAME) &&
-          (issue.agent === null || issue.agent === TRIAGER_AGENT_NAME) &&
-          isAuthorAuthorizedForAutoStatusCheck(
-            issue.author,
-            allowedIssueAuthors,
-          ),
-      )
-      .sort((a, b) => a.createdAt.getTime() - b.createdAt.getTime());
-
-    if (candidateIssues.length === 0) {
-      return;
-    }
-
-    const windowSize = Math.min(
-      MAX_COMMENT_FETCHES_PER_CYCLE,
-      candidateIssues.length,
-    );
-    const windowStart =
-      (cycleIndex * MAX_COMMENT_FETCHES_PER_CYCLE) % candidateIssues.length;
-
-    for (let slot = 0; slot < windowSize; slot++) {
-      const issue =
-        candidateIssues[(windowStart + slot) % candidateIssues.length];
-
-      let comments: Comment[];
-      try {
-        comments =
-          await this.issueCommentRepository.getCommentsFromIssue(issue);
-      } catch (error) {
-        if (!isNotFoundError(error)) {
-          throw error;
-        }
-        console.warn(
-          `[TriagerApprovalDispatch] Failed to fetch comments, skipping issue for this cycle. issueUrl: ${issue.url} error: ${error instanceof Error ? error.message : String(error)}`,
-        );
-        continue;
-      }
-
-      let firstProposalIndex = -1;
-      let proposal: TriagerProposal | null = null;
-      for (let i = 0; i < comments.length; i++) {
-        const parsed = parseTriagerProposalBlock(comments[i].content);
-        if (parsed !== null) {
-          if (firstProposalIndex === -1) {
-            firstProposalIndex = i;
-          }
-          proposal = parsed;
-        }
-      }
-
-      if (firstProposalIndex === -1 || proposal === null) {
-        console.log(
-          `[TriagerApprovalDispatch] No machine-readable triager proposal block found, skipping. issueUrl: ${issue.url}`,
-        );
-        continue;
-      }
-
-      let approvalIndex = -1;
-      for (let i = firstProposalIndex + 1; i < comments.length; i++) {
-        const comment = comments[i];
-        if (
-          isApprovalComment(
-            comment.content,
-            comment.author,
-            allowedIssueAuthors ?? [],
-          )
-        ) {
-          approvalIndex = i;
-        }
-      }
-
-      if (approvalIndex === -1) {
-        continue;
-      }
-
-      const alreadyDispatched = comments
-        .slice(approvalIndex + 1)
-        .some((c) =>
-          c.content.startsWith('Auto Status Check: TRIAGER_PROPOSAL_APPROVED'),
-        );
-      if (alreadyDispatched) {
-        continue;
-      }
-
-      const agentOptionId = await ensureAgentOptionAndGetId(
-        this.projectRepository,
-        project,
-        proposal.recommendedAgent,
-      );
-      if (agentOptionId === null) {
-        console.warn(
-          `[TriagerApprovalDispatch] Agent '${proposal.recommendedAgent}' could not be resolved, skipping. issueUrl: ${issue.url}`,
-        );
-        continue;
-      }
-
-      if (!proposal.storyAlreadySet && project.story) {
-        const storyOption = project.story.stories.find(
-          (s) => s.name === proposal.recommendedStory,
-        );
-        if (storyOption) {
-          await this.issueRepository.updateStory(
-            { ...project, story: project.story },
-            issue,
-            storyOption.id,
-          );
-        } else {
-          console.warn(
-            `[TriagerApprovalDispatch] Story '${proposal.recommendedStory}' not found in project, skipping story update. issueUrl: ${issue.url}`,
-          );
-        }
-      }
-
-      await this.issueRepository.setIssueAgentField(
-        issue.url,
-        project,
-        agentOptionId,
-      );
-
-      await this.issueRepository.updateStatus(
-        project,
-        issue,
-        awaitingWorkspaceStatus.id,
-      );
-
-      await this.issueCommentRepository.createComment(
-        issue,
-        `Auto Status Check: TRIAGER_PROPOSAL_APPROVED\nAgent: ${proposal.recommendedAgent}\nStory: ${proposal.storyAlreadySet ? '(already set)' : proposal.recommendedStory}`,
-      );
-    }
-  };
-}

package/src/domain/usecases/awaitingOwnerApprovalMessage.ts

@@ -1,5 +0,0 @@
-export const AWAITING_OWNER_APPROVAL_MESSAGE_HEAD =
-  'Auto Status Check: AWAITING_OWNER_APPROVAL';
-
-export const AWAITING_OWNER_APPROVAL_MESSAGE = `${AWAITING_OWNER_APPROVAL_MESSAGE_HEAD}
-The last report declared that this task is waiting for owner approval. Moving it to Awaiting Quality Check so that it waits for the owner's judgement instead of being dispatched again.`;

package/src/domain/usecases/isPullRequestDeclaredUnnecessary.test.ts

@@ -1,162 +0,0 @@
-import { isPullRequestDeclaredUnnecessary } from './isPullRequestDeclaredUnnecessary';
-
-const trustEveryAuthor = (): boolean => true;
-
-const reportComment = (
-  reportJson: string,
-  author = 'agent-bot',
-): { author: string; content: string } => ({
-  author,
-  content: `From: :robot: agent report\n\`\`\`json\n${reportJson}\n\`\`\``,
-});
-
-describe('isPullRequestDeclaredUnnecessary', () => {
-  it('returns true when the last report declares pullRequestRequired as false', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [reportComment('{"pullRequestRequired": false}')],
-        trustEveryAuthor,
-      ),
-    ).toBe(true);
-  });
-
-  it('returns true when the code fence backticks of that report are backslash escaped', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [
-          {
-            author: 'agent-bot',
-            content:
-              'From: :robot: agent report\n\\`\\`\\`json\n{"pullRequestRequired": false}\n\\`\\`\\`',
-          },
-        ],
-        trustEveryAuthor,
-      ),
-    ).toBe(true);
-  });
-
-  it('returns false when the last report declares pullRequestRequired as true', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [reportComment('{"pullRequestRequired": true}')],
-        trustEveryAuthor,
-      ),
-    ).toBe(false);
-  });
-
-  it('returns false when the report carries no pullRequestRequired field', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [reportComment('{"nextStep": null}')],
-        trustEveryAuthor,
-      ),
-    ).toBe(false);
-  });
-
-  it('returns false when pullRequestRequired is the string false rather than the boolean', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [reportComment('{"pullRequestRequired": "false"}')],
-        trustEveryAuthor,
-      ),
-    ).toBe(false);
-  });
-
-  it('returns false when the author of the last comment is not trusted', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [reportComment('{"pullRequestRequired": false}', 'stranger')],
-        (author) => author === 'agent-bot',
-      ),
-    ).toBe(false);
-  });
-
-  it('returns false when the last comment is not an agent report', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [
-          reportComment('{"pullRequestRequired": false}'),
-          {
-            author: 'agent-bot',
-            content:
-              'A later human comment\n```json\n{"pullRequestRequired": false}\n```',
-          },
-        ],
-        trustEveryAuthor,
-      ),
-    ).toBe(false);
-  });
-
-  it('reads only the last comment and ignores an earlier declaration', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [
-          reportComment('{"pullRequestRequired": false}'),
-          reportComment('{"pullRequestRequired": true}'),
-        ],
-        trustEveryAuthor,
-      ),
-    ).toBe(false);
-  });
-
-  it('returns false when there is no comment at all', () => {
-    expect(isPullRequestDeclaredUnnecessary([], trustEveryAuthor)).toBe(false);
-  });
-
-  it('returns false when the JSON block cannot be parsed', () => {
-    const consoleWarn = jest
-      .spyOn(console, 'warn')
-      .mockImplementation(() => {});
-
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [reportComment('{"pullRequestRequired": false')],
-        trustEveryAuthor,
-      ),
-    ).toBe(false);
-
-    consoleWarn.mockRestore();
-  });
-
-  it('returns false when the report carries no JSON block', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [{ author: 'agent-bot', content: 'From: :robot: agent report' }],
-        trustEveryAuthor,
-      ),
-    ).toBe(false);
-  });
-
-  it('returns true when pullRequestRequired is declared in a later fenced json block', () => {
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [
-          {
-            author: 'agent-bot',
-            content:
-              'From: :robot: agent report\n\n```json\n{ "nextStepAgent": "pr-reviewer" }\n```\n\n## summary\n\n```json\n{ "pullRequestRequired": false }\n```',
-          },
-        ],
-        trustEveryAuthor,
-      ),
-    ).toBe(true);
-  });
-
-  it('reads a later block and reports the earlier unparseable block', () => {
-    const consoleWarn = jest.spyOn(console, 'warn').mockImplementation();
-    expect(
-      isPullRequestDeclaredUnnecessary(
-        [
-          {
-            author: 'agent-bot',
-            content:
-              'From: :robot: agent report\n\n```json\n{ "pullRequestRequired": false,\n```\n\n```json\n{ "pullRequestRequired": false }\n```',
-          },
-        ],
-        trustEveryAuthor,
-      ),
-    ).toBe(true);
-    expect(consoleWarn).toHaveBeenCalled();
-    consoleWarn.mockRestore();
-  });
-});

package/src/domain/usecases/isPullRequestDeclaredUnnecessary.ts

@@ -1,29 +0,0 @@
-import { extractFencedJsonBlocks } from './extractFencedJsonBlocks';
-import { isAgentReportBody } from './isAgentReportBody';
-
-export const isPullRequestDeclaredUnnecessary = (
-  comments: { author: string; content: string }[],
-  isTrustedAuthor: (author: string) => boolean,
-): boolean => {
-  const lastComment = comments[comments.length - 1];
-  if (
-    !lastComment ||
-    !isTrustedAuthor(lastComment.author) ||
-    !isAgentReportBody(lastComment.content)
-  ) {
-    return false;
-  }
-  for (const block of extractFencedJsonBlocks(
-    lastComment.content,
-    'pullRequestRequired',
-  )) {
-    if (typeof block !== 'object' || block === null) {
-      continue;
-    }
-    const report: Record<string, unknown> = { ...block };
-    if (report.pullRequestRequired === false) {
-      return true;
-    }
-  }
-  return false;
-};

package/src/domain/usecases/isWaitingForOwnerApproval.test.ts

@@ -1,91 +0,0 @@
-import { isWaitingForOwnerApproval } from './isWaitingForOwnerApproval';
-
-const agentReport = (reportJson: string): string =>
-  `From: :robot: agent-name (model-id)\n\`\`\`json\n${reportJson}\n\`\`\``;
-
-describe('isWaitingForOwnerApproval', () => {
-  it('returns true when the first block has pullRequestRequired false and waitingForOwnerApproval true', () => {
-    expect(
-      isWaitingForOwnerApproval(
-        agentReport(
-          '{"pullRequestRequired": false, "waitingForOwnerApproval": true}',
-        ),
-      ),
-    ).toBe(true);
-  });
-
-  it('returns false when waitingForOwnerApproval is missing', () => {
-    expect(
-      isWaitingForOwnerApproval(agentReport('{"pullRequestRequired": false}')),
-    ).toBe(false);
-  });
-
-  it('returns false when pullRequestRequired is missing', () => {
-    expect(
-      isWaitingForOwnerApproval(
-        agentReport('{"waitingForOwnerApproval": true}'),
-      ),
-    ).toBe(false);
-  });
-
-  it('returns false when pullRequestRequired is true', () => {
-    expect(
-      isWaitingForOwnerApproval(
-        agentReport(
-          '{"pullRequestRequired": true, "waitingForOwnerApproval": true}',
-        ),
-      ),
-    ).toBe(false);
-  });
-
-  it('returns false when waitingForOwnerApproval is false', () => {
-    expect(
-      isWaitingForOwnerApproval(
-        agentReport(
-          '{"pullRequestRequired": false, "waitingForOwnerApproval": false}',
-        ),
-      ),
-    ).toBe(false);
-  });
-
-  it('returns false when waitingForOwnerApproval is a string rather than the boolean true', () => {
-    expect(
-      isWaitingForOwnerApproval(
-        agentReport(
-          '{"pullRequestRequired": false, "waitingForOwnerApproval": "true"}',
-        ),
-      ),
-    ).toBe(false);
-  });
-
-  it('returns false when there is no JSON block', () => {
-    expect(
-      isWaitingForOwnerApproval('From: :robot: agent-name (model-id)'),
-    ).toBe(false);
-  });
-
-  it('returns false when the JSON block cannot be parsed', () => {
-    const consoleWarn = jest
-      .spyOn(console, 'warn')
-      .mockImplementation(() => {});
-    expect(
-      isWaitingForOwnerApproval(
-        agentReport(
-          '{"pullRequestRequired": false, "waitingForOwnerApproval": true',
-        ),
-      ),
-    ).toBe(false);
-    consoleWarn.mockRestore();
-  });
-
-  it('reads only the first block and ignores subsequent blocks', () => {
-    const content = `From: :robot: agent-name (model-id)\n\`\`\`json\n{"pullRequestRequired": false, "nextStep": null}\n\`\`\`\n\n\`\`\`json\n{"pullRequestRequired": false, "waitingForOwnerApproval": true}\n\`\`\``;
-    expect(isWaitingForOwnerApproval(content)).toBe(false);
-  });
-
-  it('returns true when backticks in the block are backslash-escaped', () => {
-    const content =
-      'From: :robot: agent-name (model-id)\n\\`\\`\\`json\n{"pullRequestRequired": false, "waitingForOwnerApproval": true}\n\\`\\`\\`';
-    expect(isWaitingForOwnerApproval(content)).toBe(true);
-  });
-});

package/src/domain/usecases/isWaitingForOwnerApproval.ts

@@ -1,17 +0,0 @@
-import { extractFencedJsonBlocks } from './extractFencedJsonBlocks';
-
-export const isWaitingForOwnerApproval = (reportContent: string): boolean => {
-  const blocks = extractFencedJsonBlocks(
-    reportContent,
-    'waitingForOwnerApproval',
-  );
-  const firstBlock = blocks[0];
-  if (typeof firstBlock !== 'object' || firstBlock === null) {
-    return false;
-  }
-  const report: Record<string, unknown> = { ...firstBlock };
-  return (
-    report.pullRequestRequired === false &&
-    report.waitingForOwnerApproval === true
-  );
-};

package/src/domain/usecases/returnedToAwaitingWorkspaceMessage.ts

@@ -1,5 +0,0 @@
-export const RETURNED_TO_AWAITING_WORKSPACE_MESSAGE_HEAD =
-  'Auto Status Check: RETURNED_TO_AWAITING_WORKSPACE';
-
-export const RETURNED_TO_AWAITING_WORKSPACE_MESSAGE = `${RETURNED_TO_AWAITING_WORKSPACE_MESSAGE_HEAD}
-The last report declared that this task needs no pull request, so the task returns to the workspace queue to run under the agent its label selects. A later report carrying the same declaration takes the awaiting quality check path instead of returning here again.`;