github-issue-tower-defence-management 2.6.0 → 2.7.0

package/src/domain/usecases/IssueRejectionEvaluator.test.ts

@@ -739,125 +739,6 @@ describe('IssueRejectionEvaluator', () => {
       });
     });
 
-    describe('pullRequestRequired: false in issue body', () => {
-      it('should not reject and not call findRelatedOpenPRs when body ends with JSON block containing pullRequestRequired: false', async () => {
-        const body = '```json\n{"pullRequestRequired": false}\n```';
-
-        const result = await evaluator.evaluate({
-          url: 'https://github.com/user/repo/issues/1',
-          labels: [],
-          isPr: false,
-          body,
-        });
-
-        expect(mockIssueRepository.findRelatedOpenPRs).not.toHaveBeenCalled();
-        expect(result.rejections).toHaveLength(0);
-        expect(result.approvedPrUrl).toBeNull();
-      });
-
-      it('should not reject even with trailing whitespace after the closing JSON block', async () => {
-        const body = '```json\n{"pullRequestRequired": false}\n```\n  ';
-
-        const result = await evaluator.evaluate({
-          url: 'https://github.com/user/repo/issues/1',
-          labels: [],
-          isPr: false,
-          body,
-        });
-
-        expect(mockIssueRepository.findRelatedOpenPRs).not.toHaveBeenCalled();
-        expect(result.rejections).toHaveLength(0);
-      });
-
-      it('should still require PR when body has pullRequestRequired: true', async () => {
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
-        const body = '```json\n{"pullRequestRequired": true}\n```';
-
-        const result = await evaluator.evaluate({
-          url: 'https://github.com/user/repo/issues/1',
-          labels: [],
-          isPr: false,
-          body,
-        });
-
-        expect(result.rejections).toHaveLength(1);
-        expect(result.rejections[0].type).toBe('PULL_REQUEST_NOT_FOUND');
-      });
-
-      it('should still require PR when body is null', async () => {
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
-
-        const result = await evaluator.evaluate({
-          url: 'https://github.com/user/repo/issues/1',
-          labels: [],
-          isPr: false,
-          body: null,
-        });
-
-        expect(result.rejections).toHaveLength(1);
-        expect(result.rejections[0].type).toBe('PULL_REQUEST_NOT_FOUND');
-      });
-
-      it('should still require PR when body is undefined', async () => {
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
-
-        const result = await evaluator.evaluate({
-          url: 'https://github.com/user/repo/issues/1',
-          labels: [],
-          isPr: false,
-        });
-
-        expect(result.rejections).toHaveLength(1);
-        expect(result.rejections[0].type).toBe('PULL_REQUEST_NOT_FOUND');
-      });
-
-      it('should still require PR when JSON block with pullRequestRequired: false is not at end of body', async () => {
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
-        const body =
-          '```json\n{"pullRequestRequired": false}\n```\n\nsome text after';
-
-        const result = await evaluator.evaluate({
-          url: 'https://github.com/user/repo/issues/1',
-          labels: [],
-          isPr: false,
-          body,
-        });
-
-        expect(result.rejections).toHaveLength(1);
-        expect(result.rejections[0].type).toBe('PULL_REQUEST_NOT_FOUND');
-      });
-
-      it('should still require PR when body has invalid JSON in code block', async () => {
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
-        const body = '```json\n{invalid json}\n```';
-
-        const result = await evaluator.evaluate({
-          url: 'https://github.com/user/repo/issues/1',
-          labels: [],
-          isPr: false,
-          body,
-        });
-
-        expect(result.rejections).toHaveLength(1);
-        expect(result.rejections[0].type).toBe('PULL_REQUEST_NOT_FOUND');
-      });
-
-      it('should still require PR when body has pullRequestRequired not set to false', async () => {
-        mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([]);
-        const body = '```json\n{"someOtherField": true}\n```';
-
-        const result = await evaluator.evaluate({
-          url: 'https://github.com/user/repo/issues/1',
-          labels: [],
-          isPr: false,
-          body,
-        });
-
-        expect(result.rejections).toHaveLength(1);
-        expect(result.rejections[0].type).toBe('PULL_REQUEST_NOT_FOUND');
-      });
-    });
-
     describe('detectConflictEvenIfEvaluationSkipped option', () => {
       it('should call findRelatedOpenPRs and return PULL_REQUEST_CONFLICTED when relatedOpenPrUrls is null and PR is conflicted', async () => {
         mockIssueRepository.findRelatedOpenPRs.mockResolvedValue([

package/src/domain/usecases/IssueRejectionEvaluator.ts

@@ -2,7 +2,6 @@ import {
   IssueRepository,
   RelatedPullRequest,
 } from './adapter-interfaces/IssueRepository';
-import { normalizeReportBody } from './normalizeReportBody';
 
 export type PrRejectedReasonType =
   | 'PULL_REQUEST_NOT_FOUND'
@@ -243,7 +242,6 @@ export class IssueRejectionEvaluator {
     return (
       !isNonDeveloperAgent &&
       !hasLabelNotRequiringPullRequest &&
-      this.isPullRequestRequiredByBody(issue.body) &&
       (categoryLabels.length <= 0 || categoryLabels.includes('category:e2e'))
     );
   };
@@ -337,23 +335,4 @@ export class IssueRejectionEvaluator {
     targetPath: string,
   ): boolean =>
     filePath === targetPath || filePath.startsWith(`${targetPath}/`);
-
-  private isPullRequestRequiredByBody = (
-    body: string | null | undefined,
-  ): boolean => {
-    if (!body) return true;
-    const match = normalizeReportBody(body)
-      .trimEnd()
-      .match(/```json\n([\s\S]*?)\n```\s*$/);
-    if (!match || !match[1]) return true;
-    let config: unknown;
-    try {
-      config = JSON.parse(match[1]);
-    } catch {
-      return true;
-    }
-    if (typeof config !== 'object' || config === null) return true;
-    if (!('pullRequestRequired' in config)) return true;
-    return Reflect.get(config, 'pullRequestRequired') !== false;
-  };
 }