github-issue-tower-defence-management 2.5.0 → 2.5.1

package/bin/adapter/entry-points/console/ui-dist/index.html

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-C5cOzhyn.js"></script>
+    <script type="module" crossorigin src="/assets/index-CaxYBHiT.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-CLHvrafO.css">
   </head>
   <body>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "github-issue-tower-defence-management",
-  "version": "2.5.0",
+  "version": "2.5.1",
   "description": "",
   "main": "bin/index.js",
   "scripts": {

package/src/adapter/entry-points/console/ui/src/features/console/hooks/useConsoleOperations.test.ts

@@ -486,4 +486,144 @@ describe('useConsoleOperations', () => {
     ).rejects.toThrow();
     expect(callCount).toBe(1);
   });
+
+  it('marks setStatus overlay done before the API call resolves', async () => {
+    let resolveApi!: () => void;
+    global.fetch = jest.fn(
+      () =>
+        new Promise<Response>((resolve) => {
+          resolveApi = () =>
+            resolve({
+              ok: true,
+              status: 200,
+              json: async () => ({ ok: true }),
+            } as unknown as Response);
+        }),
+    ) as unknown as typeof fetch;
+    const { result } = setup();
+    const option = consoleStatusOptionsFixture[1];
+
+    act(() => {
+      void result.current.operations.setStatus(issueItem, option);
+    });
+
+    const stored = JSON.parse(
+      localStorage.getItem(overlayStorageKey('acme')) ?? '{}',
+    );
+    expect(stored[issueItem.projectItemId]?.done).toBe(true);
+
+    await act(async () => {
+      resolveApi();
+      await Promise.resolve();
+    });
+  });
+
+  it('marks reviewPullRequest overlay done before the API call resolves', async () => {
+    let resolveApi!: () => void;
+    global.fetch = jest.fn(
+      () =>
+        new Promise<Response>((resolve) => {
+          resolveApi = () =>
+            resolve({
+              ok: true,
+              status: 200,
+              json: async () => ({ ok: true }),
+            } as unknown as Response);
+        }),
+    ) as unknown as typeof fetch;
+    const { result } = setup();
+
+    act(() => {
+      void result.current.operations.reviewPullRequest(
+        prItem,
+        prItem.url,
+        'approve_and_merge',
+      );
+    });
+
+    const stored = JSON.parse(
+      localStorage.getItem(overlayStorageKey('acme')) ?? '{}',
+    );
+    expect(stored[prItem.projectItemId]?.done).toBe(true);
+
+    await act(async () => {
+      resolveApi();
+      await Promise.resolve();
+    });
+  });
+
+  it('marks closeIssue overlay done before the API call resolves', async () => {
+    let resolveApi!: () => void;
+    global.fetch = jest.fn(
+      () =>
+        new Promise<Response>((resolve) => {
+          resolveApi = () =>
+            resolve({
+              ok: true,
+              status: 200,
+              json: async () => ({ ok: true }),
+            } as unknown as Response);
+        }),
+    ) as unknown as typeof fetch;
+    const { result } = setup();
+
+    act(() => {
+      void result.current.operations.closeIssue(issueItem, 'close_not_planned');
+    });
+
+    const stored = JSON.parse(
+      localStorage.getItem(overlayStorageKey('acme')) ?? '{}',
+    );
+    expect(stored[issueItem.projectItemId]?.done).toBe(true);
+
+    await act(async () => {
+      resolveApi();
+      await Promise.resolve();
+    });
+  });
+
+  it('marks okAndMoveToAwaitingWorkspace overlay done before API calls resolve', async () => {
+    let resolveApi!: () => void;
+    global.fetch = jest.fn(
+      () =>
+        new Promise<Response>((resolve) => {
+          resolveApi = () =>
+            resolve({
+              ok: true,
+              status: 200,
+              json: async () => ({
+                ok: true,
+                comment: {
+                  author: 'bot',
+                  body: 'ok',
+                  createdAt: '2026-01-01T00:00:00Z',
+                },
+              }),
+            } as unknown as Response);
+        }),
+    ) as unknown as typeof fetch;
+    const { result } = setup();
+    const [option] = consoleStatusOptionsFixture.filter(
+      (o) => o.name.toLowerCase() === 'awaiting workspace',
+    );
+
+    act(() => {
+      void result.current.operations.okAndMoveToAwaitingWorkspace(
+        issueItem,
+        option,
+      );
+    });
+
+    const stored = JSON.parse(
+      localStorage.getItem(overlayStorageKey('acme')) ?? '{}',
+    );
+    expect(stored[issueItem.projectItemId]?.done).toBe(true);
+
+    await act(async () => {
+      resolveApi();
+      await Promise.resolve();
+      resolveApi();
+      await Promise.resolve();
+    });
+  });
 });

package/src/adapter/entry-points/console/ui/src/features/console/hooks/useConsoleOperations.ts

@@ -154,10 +154,9 @@ export const useConsoleOperations = (
 
   const markDone = useCallback(
     (item: ConsoleListItem) => {
-      invalidateItemContent(item);
       patchOverlay(overlayKeyForItem(item), { done: true }, mode);
     },
-    [invalidateItemContent, patchOverlay, mode],
+    [patchOverlay, mode],
   );
 
   const reviewPullRequest = useCallback(
@@ -170,13 +169,14 @@ export const useConsoleOperations = (
       if (pjcode === null) {
         throw missingPjcodeError();
       }
+      markDone(item);
       await postConsoleOperation(
         REVIEW_OPERATION_PATH,
         reviewRequest(pjcode, item, prUrl, action, pendingReviewComments),
       );
-      markDone(item);
+      invalidateItemContent(item);
     },
-    [pjcode, markDone],
+    [pjcode, markDone, invalidateItemContent],
   );
 
   const setNextActionDate = useCallback(
@@ -190,10 +190,11 @@ export const useConsoleOperations = (
         issueUrl: item.url,
         projectItemId: item.projectItemId,
       };
-      await postConsoleOperation(TRIAGE_OPERATION_PATH, request);
       markDone(item);
+      await postConsoleOperation(TRIAGE_OPERATION_PATH, request);
+      invalidateItemContent(item);
     },
-    [pjcode, markDone],
+    [pjcode, markDone, invalidateItemContent],
   );
 
   const setStory = useCallback(
@@ -208,13 +209,13 @@ export const useConsoleOperations = (
         projectItemId: item.projectItemId,
         storyOptionId: option.id,
       };
-      await postConsoleOperation(TRIAGE_OPERATION_PATH, request);
-      invalidateItemContent(item);
       patchOverlay(
         overlayKeyForItem(item),
         { done: true, story: { name: option.name, color: option.color } },
         mode,
       );
+      await postConsoleOperation(TRIAGE_OPERATION_PATH, request);
+      invalidateItemContent(item);
     },
     [pjcode, invalidateItemContent, patchOverlay, mode],
   );
@@ -231,13 +232,13 @@ export const useConsoleOperations = (
         projectItemId: item.projectItemId,
         statusName: option.name,
       };
-      await postConsoleOperation(TRIAGE_OPERATION_PATH, request);
-      invalidateItemContent(item);
       patchOverlay(
         overlayKeyForItem(item),
         { done: true, status: { name: option.name, color: option.color } },
         mode,
       );
+      await postConsoleOperation(TRIAGE_OPERATION_PATH, request);
+      invalidateItemContent(item);
     },
     [pjcode, invalidateItemContent, patchOverlay, mode],
   );
@@ -253,13 +254,13 @@ export const useConsoleOperations = (
         issueUrl: item.url,
         projectItemId: item.projectItemId,
       };
-      await postConsoleOperation(INTMUX_OPERATION_PATH, request);
-      invalidateItemContent(item);
       patchOverlay(
         overlayKeyForItem(item),
         { done: true, status: { name: option.name, color: option.color } },
         mode,
       );
+      await postConsoleOperation(INTMUX_OPERATION_PATH, request);
+      invalidateItemContent(item);
     },
     [pjcode, invalidateItemContent, patchOverlay, mode],
   );
@@ -275,10 +276,11 @@ export const useConsoleOperations = (
         issueUrl: item.url,
         projectItemId: item.projectItemId,
       };
-      await postConsoleOperation(TRIAGE_OPERATION_PATH, request);
       markDone(item);
+      await postConsoleOperation(TRIAGE_OPERATION_PATH, request);
+      invalidateItemContent(item);
     },
-    [pjcode, markDone],
+    [pjcode, markDone, invalidateItemContent],
   );
 
   const okAndMoveToAwaitingWorkspace = useCallback(
@@ -286,6 +288,11 @@ export const useConsoleOperations = (
       if (pjcode === null) {
         throw missingPjcodeError();
       }
+      patchOverlay(
+        overlayKeyForItem(item),
+        { done: true, status: { name: option.name, color: option.color } },
+        mode,
+      );
       await postConsoleComment({ pjcode, url: item.url, body: 'ok' });
       const request: ConsoleTriageRequest = {
         pjcode,
@@ -296,11 +303,6 @@ export const useConsoleOperations = (
       };
       await postConsoleOperation(TRIAGE_OPERATION_PATH, request);
       invalidateItemContent(item);
-      patchOverlay(
-        overlayKeyForItem(item),
-        { done: true, status: { name: option.name, color: option.color } },
-        mode,
-      );
     },
     [pjcode, invalidateItemContent, patchOverlay, mode],
   );