github-issue-tower-defence-management 2.2.0 → 2.3.0

package/src/adapter/entry-points/console/ui/src/features/console/hooks/useConsoleNavigation.test.ts

@@ -11,7 +11,6 @@ const counts = (
 ): Record<ConsoleTabName, number> => ({
   'workflow-blocker': 0,
   prs: 0,
-  triage: 0,
   'failed-preparation': 0,
   'todo-by-human': 0,
   'todo-by-agent': 0,
@@ -21,13 +20,17 @@ const counts = (
 
 describe('parseTabFromPath', () => {
   it('reads a known tab from the project path', () => {
-    expect(parseTabFromPath('/projects/acme/triage')).toBe('triage');
+    expect(parseTabFromPath('/projects/acme/prs')).toBe('prs');
   });
 
   it('returns null for an unknown tab segment', () => {
     expect(parseTabFromPath('/projects/acme/unknown')).toBeNull();
   });
 
+  it('returns null for the removed triage segment', () => {
+    expect(parseTabFromPath('/projects/acme/triage')).toBeNull();
+  });
+
   it('returns null when there is no tab segment', () => {
     expect(parseTabFromPath('/projects/acme')).toBeNull();
   });
@@ -56,16 +59,18 @@ describe('useConsoleNavigation', () => {
 
   it('builds a project tab href', () => {
     const { result } = renderHook(() => useConsoleNavigation('acme', counts()));
-    expect(result.current.tabHref('triage')).toBe('/projects/acme/triage');
+    expect(result.current.tabHref('todo-by-human')).toBe(
+      '/projects/acme/todo-by-human',
+    );
   });
 
   it('selects a tab and updates the path', () => {
     const { result } = renderHook(() => useConsoleNavigation('acme', counts()));
     act(() => {
-      result.current.selectTab('triage');
+      result.current.selectTab('todo-by-human');
     });
-    expect(result.current.activeTab).toBe('triage');
-    expect(window.location.pathname).toBe('/projects/acme/triage');
+    expect(result.current.activeTab).toBe('todo-by-human');
+    expect(window.location.pathname).toBe('/projects/acme/todo-by-human');
   });
 
   it('opens an item and reflects it in the hash', () => {
@@ -101,7 +106,6 @@ describe('useConsoleNavigation default tab without a tab segment', () => {
         counts({
           'workflow-blocker': 3,
           prs: 5,
-          triage: 2,
           'failed-preparation': 1,
           'todo-by-human': 4,
         }),
@@ -114,10 +118,10 @@ describe('useConsoleNavigation default tab without a tab segment', () => {
     const { result } = renderHook(() =>
       useConsoleNavigation(
         'acme',
-        counts({ 'workflow-blocker': 0, prs: 0, triage: 8 }),
+        counts({ 'workflow-blocker': 0, prs: 0, 'failed-preparation': 8 }),
       ),
     );
-    expect(result.current.activeTab).toBe('triage');
+    expect(result.current.activeTab).toBe('failed-preparation');
   });
 
   it('falls back to the first tab when every tab is empty', () => {
@@ -132,15 +136,15 @@ describe('useConsoleNavigation default tab without a tab segment', () => {
       { initialProps: { tabCounts: counts() } },
     );
     expect(result.current.activeTab).toBe('workflow-blocker');
-    rerender({ tabCounts: counts({ triage: 6 }) });
-    expect(result.current.activeTab).toBe('triage');
+    rerender({ tabCounts: counts({ 'failed-preparation': 6 }) });
+    expect(result.current.activeTab).toBe('failed-preparation');
   });
 
   it('keeps the tab from the path even when counts are present', () => {
-    window.history.replaceState({}, '', '/projects/acme/triage?k=token');
+    window.history.replaceState({}, '', '/projects/acme/todo-by-human?k=token');
     const { result } = renderHook(() =>
-      useConsoleNavigation('acme', counts({ triage: 6 })),
+      useConsoleNavigation('acme', counts({ 'todo-by-human': 6 })),
     );
-    expect(result.current.activeTab).toBe('triage');
+    expect(result.current.activeTab).toBe('todo-by-human');
   });
 });

package/src/adapter/entry-points/console/ui/src/features/console/hooks/useConsoleOverlay.test.ts

@@ -19,10 +19,10 @@ describe('useConsoleOverlay', () => {
   it('patches and persists overlay entries with timestamp and mode', () => {
     const { result } = renderHook(() => useConsoleOverlay('acme'));
     act(() => {
-      result.current.patchOverlay('PVTI_2', { done: true }, 'triage');
+      result.current.patchOverlay('PVTI_2', { done: true }, 'todo-by-human');
     });
     expect(result.current.overlay.PVTI_2?.done).toBe(true);
-    expect(result.current.overlay.PVTI_2?.mode).toBe('triage');
+    expect(result.current.overlay.PVTI_2?.mode).toBe('todo-by-human');
     const stored = JSON.parse(
       localStorage.getItem(overlayStorageKey('acme')) ?? '{}',
     );

package/src/adapter/entry-points/console/ui/src/features/console/logic/actionToast.test.ts

@@ -100,7 +100,7 @@ describe('actionToastMessage', () => {
     expect(
       actionToastMessage(
         { type: 'set_story', optionName: 'Move to Okinawa' },
-        'triage',
+        'todo-by-human',
       ),
     ).toBe('Story → Move to Okinawa');
   });

package/src/adapter/entry-points/console/ui/src/features/console/logic/grouping.test.ts

@@ -47,7 +47,7 @@ describe('resolveItemStory', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: {
         ts: 1,
-        mode: 'triage',
+        mode: 'todo-by-human',
         story: { name: 'Overlay', color: 'BLUE' },
       },
     };
@@ -73,7 +73,7 @@ describe('resolveItemStory', () => {
     const overlay: ConsoleOverlay = {
       PVTI_4: {
         ts: snapshotTs,
-        mode: 'triage',
+        mode: 'todo-by-human',
         story: { name: 'FreshOverlay', color: 'GREEN' },
       },
     };
@@ -92,7 +92,7 @@ describe('resolveItemStory', () => {
     const overlay: ConsoleOverlay = {
       PVTI_5: {
         ts: overlayTs,
-        mode: 'triage',
+        mode: 'todo-by-human',
         story: { name: 'StaleOverlay', color: 'RED' },
       },
     };
@@ -109,7 +109,7 @@ describe('resolveItemStory', () => {
     const overlay: ConsoleOverlay = {
       PVTI_6: {
         ts: 1,
-        mode: 'triage',
+        mode: 'todo-by-human',
         story: { name: 'OverlayStory', color: 'BLUE' },
       },
     };
@@ -122,7 +122,7 @@ describe('resolveItemStory', () => {
     const overlay: ConsoleOverlay = {
       PVTI_7: {
         ts: 1,
-        mode: 'triage',
+        mode: 'todo-by-human',
         story: { name: 'OverlayStory', color: 'BLUE' },
       },
     };
@@ -166,7 +166,7 @@ describe('buildConsoleListRows', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: {
         ts: 1,
-        mode: 'triage',
+        mode: 'todo-by-human',
         story: { name: 'Alpha', color: 'BLUE' },
       },
     };
@@ -212,7 +212,7 @@ describe('buildConsoleListRows', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: {
         ts: overlayTs,
-        mode: 'triage',
+        mode: 'todo-by-human',
         story: { name: 'StaleStory', color: 'RED' },
       },
     };

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.test.ts

@@ -70,9 +70,9 @@ describe('isOverlayEntryActed', () => {
   });
 
   it('treats a done entry as acted regardless of the mode it was written in', () => {
-    expect(isOverlayEntryActed({ ts: 100, mode: 'triage', done: true })).toBe(
-      true,
-    );
+    expect(
+      isOverlayEntryActed({ ts: 100, mode: 'todo-by-human', done: true }),
+    ).toBe(true);
   });
 });
 
@@ -86,7 +86,7 @@ describe('counts driven to zero do not revive on tab switch', () => {
 
   it('does not subtract a done item from a tab other than the one it was processed in', () => {
     const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'triage', done: true },
+      PVTI_1: { ts: 100, mode: 'todo-by-human', done: true },
     };
     expect(countPendingItems([item(1)], overlay, 'prs')).toBe(1);
   });
@@ -102,8 +102,10 @@ describe('counts driven to zero do not revive on tab switch', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 100, mode: 'prs', done: true },
     };
-    expect(countPendingItems([item(1)], overlay, 'triage')).toBe(1);
-    expect(filterPendingItems([item(1)], overlay, 'triage')).toEqual([item(1)]);
+    expect(countPendingItems([item(1)], overlay, 'todo-by-human')).toBe(1);
+    expect(filterPendingItems([item(1)], overlay, 'todo-by-human')).toEqual([
+      item(1),
+    ]);
   });
 
   it('counts an item that has no done entry', () => {
@@ -237,14 +239,14 @@ describe('writeOverlayEntry', () => {
       overlay,
       'PVTI_1',
       { story: { name: 'New Story', color: 'GREEN' } },
-      'triage',
+      'todo-by-human',
       999,
     );
     expect(next.PVTI_1).toEqual({
       done: true,
       story: { name: 'New Story', color: 'GREEN' },
       ts: 999,
-      mode: 'triage',
+      mode: 'todo-by-human',
     });
   });
 });

package/src/adapter/entry-points/console/ui/src/features/console/logic/tabAdvance.test.ts

@@ -9,7 +9,6 @@ const counts = (
 ): Record<ConsoleTabName, number> => ({
   'workflow-blocker': 0,
   prs: 0,
-  triage: 0,
   'failed-preparation': 0,
   'todo-by-human': 0,
   'todo-by-agent': 0,
@@ -19,16 +18,16 @@ const counts = (
 
 describe('findNextNonEmptyTabToRight', () => {
   it('returns the first non-empty tab to the right of the active tab', () => {
-    expect(findNextNonEmptyTabToRight('prs', counts({ triage: 7 }))).toBe(
-      'triage',
-    );
+    expect(
+      findNextNonEmptyTabToRight('prs', counts({ 'failed-preparation': 7 })),
+    ).toBe('failed-preparation');
   });
 
   it('skips empty tabs and returns the next non-empty tab further right', () => {
     expect(
       findNextNonEmptyTabToRight(
         'prs',
-        counts({ triage: 0, 'todo-by-human': 4 }),
+        counts({ 'failed-preparation': 0, 'todo-by-human': 4 }),
       ),
     ).toBe('todo-by-human');
   });
@@ -43,9 +42,9 @@ describe('findNextNonEmptyTabToRight', () => {
   });
 
   it('returns the immediately adjacent tab when it is non-empty', () => {
-    expect(findNextNonEmptyTabToRight('prs', counts({ triage: 12 }))).toBe(
-      'triage',
-    );
+    expect(
+      findNextNonEmptyTabToRight('prs', counts({ 'failed-preparation': 12 })),
+    ).toBe('failed-preparation');
   });
 
   it('returns null when no tab to the right has any items', () => {
@@ -68,7 +67,6 @@ describe('resolveDefaultActiveTab', () => {
         counts({
           'workflow-blocker': 3,
           prs: 5,
-          triage: 2,
           'failed-preparation': 1,
           'todo-by-human': 4,
         }),
@@ -79,9 +77,9 @@ describe('resolveDefaultActiveTab', () => {
   it('skips empty left-most tabs and returns the first non-empty tab', () => {
     expect(
       resolveDefaultActiveTab(
-        counts({ 'workflow-blocker': 0, prs: 0, triage: 8 }),
+        counts({ 'workflow-blocker': 0, prs: 0, 'failed-preparation': 8 }),
       ),
-    ).toBe('triage');
+    ).toBe('failed-preparation');
   });
 
   it('falls back to the first tab when every tab is empty', () => {

package/src/adapter/entry-points/console/ui/src/features/console/logic/types.ts

@@ -43,16 +43,7 @@ export type ConsoleStatusTab = {
   items: ConsoleListItem[];
 };
 
-export type ConsoleTriageTab = {
-  pjcode: string;
-  generatedAt: string;
-  storyOptions: ConsoleFieldOption[];
-  storyOrder: string[];
-  storyColors: Record<string, ConsoleColor>;
-  items: ConsoleListItem[];
-};
-
-export type ConsoleTabData = ConsoleStatusTab | ConsoleTriageTab;
+export type ConsoleTabData = ConsoleStatusTab;
 
 export type ConsoleStoryColorSource = Record<
   string,
@@ -144,7 +135,6 @@ export type ConsoleOverlay = Record<string, ConsoleOverlayEntry>;
 export type ConsoleTabName =
   | 'workflow-blocker'
   | 'prs'
-  | 'triage'
   | 'failed-preparation'
   | 'todo-by-human'
   | 'todo-by-agent'
@@ -166,7 +156,6 @@ export type ConsoleTab = {
 export const CONSOLE_TABS: ConsoleTab[] = [
   { name: 'workflow-blocker', label: 'Workflow Blocker' },
   { name: 'prs', label: 'Awaiting Quality Check' },
-  { name: 'triage', label: 'Triage' },
   { name: 'failed-preparation', label: 'Failed Preparation' },
   { name: 'todo-by-human', label: 'Todo by human' },
   { name: 'todo-by-agent', label: 'Todo by agent' },

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsoleItemDetailContainer.test.tsx

@@ -13,7 +13,6 @@ import {
   consoleRelatedPullRequestsFixture,
   consoleStatusOptionsFixture,
   consoleStoryColorsFixture,
-  consoleStoryOptionsFixture,
 } from '../testing/fixtures';
 import { ConsoleItemDetailContainer } from './ConsoleItemDetailContainer';
 
@@ -110,7 +109,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches()}
         operations={operations}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -144,7 +142,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches()}
         operations={buildOperations()}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -170,7 +167,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches()}
         operations={operations}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -212,7 +208,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches()}
         operations={operations}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -260,7 +255,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches()}
         operations={operations}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -311,7 +305,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches({ relatedPrsNeverResolve: true })}
         operations={operations}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -348,7 +341,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches({ prFiles: consoleChangedFilesFixture })}
         operations={operations}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -414,7 +406,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches()}
         operations={buildOperations()}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -437,7 +428,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches()}
         operations={buildOperations()}
         statusOptions={statusOptionsWithoutAwaitingWorkspace}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -458,7 +448,6 @@ describe('ConsoleItemDetailContainer', () => {
         caches={buildCaches()}
         operations={operations}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}
@@ -508,7 +497,6 @@ describe('ConsoleItemDetailContainer', () => {
         })}
         operations={operations}
         statusOptions={consoleStatusOptionsFixture}
-        storyOptions={consoleStoryOptionsFixture}
         storyColors={consoleStoryColorsFixture}
         storyName="TDPM Console port"
         overlayStatus={null}

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsoleItemDetailContainer.tsx

@@ -38,7 +38,6 @@ export type ConsoleItemDetailContainerProps = {
   caches: ConsoleCaches;
   operations: ConsoleOperationsApi;
   statusOptions: ConsoleFieldOption[];
-  storyOptions: ConsoleFieldOption[];
   storyColors: ConsoleStoryColorSource;
   storyName: string | null;
   overlayStatus: ConsoleOverlayStatus | null;
@@ -54,7 +53,6 @@ export const ConsoleItemDetailContainer = ({
   caches,
   operations,
   statusOptions,
-  storyOptions,
   storyColors,
   storyName,
   overlayStatus,
@@ -231,7 +229,6 @@ export const ConsoleItemDetailContainer = ({
           hasPullRequest={hasPullRequest}
           rejectEnabled={pendingReviewComments.length > 0}
           statusOptions={statusOptions}
-          storyOptions={storyOptions}
           handlers={handlers}
         />
       }

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.tsx

@@ -3,7 +3,6 @@ import { ConsoleTabList } from '../components/layout/ConsoleTabList';
 import { ConsoleTimerSettingsModalDialog } from '../components/layout/ConsoleTimerSettingsModalDialog';
 import { ConsoleItemList } from '../components/list/ConsoleItemList';
 import { ConsoleStoryList } from '../components/list/ConsoleStoryList';
-import { ConsoleStoryReorderPanel } from '../components/list/ConsoleStoryReorderPanel';
 import {
   ConsoleErrorToast,
   ConsoleUndoToast,
@@ -177,26 +176,14 @@ export const ConsolePage = () => {
 
   const storyColors = activeSnapshot?.storyColors ?? {};
   const statusOptions = activeSnapshot?.statusOptions ?? [];
-  const storyOptions = activeSnapshot?.storyOptions ?? [];
   const generatedAt = activeSnapshot?.generatedAt ?? null;
   const fromCache = activeSnapshot?.fromCache ?? false;
 
-  const [localStoryOptionsOverride, setLocalStoryOptionsOverride] = useState<{
-    generatedAt: string | undefined;
-    stories: typeof storyOptions;
-  } | null>(null);
-
   const [localStoryEntriesOverride, setLocalStoryEntriesOverride] = useState<{
     generatedAt: string | undefined;
     stories: ConsoleStoryEntry[];
   } | null>(null);
 
-  const triageStoryOptions =
-    localStoryOptionsOverride !== null &&
-    localStoryOptionsOverride.generatedAt === activeSnapshot?.generatedAt
-      ? localStoryOptionsOverride.stories
-      : storyOptions.filter((o) => o.color !== 'GRAY');
-
   const selectedItem = useMemo<ConsoleListItem | null>(() => {
     if (selectedItemKey === null || activeSnapshot === null) {
       return null;
@@ -385,25 +372,6 @@ export const ConsolePage = () => {
         throw new Error('No project specified in the URL path.');
       }
       await postConsoleReorderStory({ pjcode, storyOptionId, direction });
-      const triageIndex = triageStoryOptions.findIndex(
-        (o) => o.id === storyOptionId,
-      );
-      if (triageIndex !== -1) {
-        const triageSwapIndex = triageIndex + (direction === 'up' ? -1 : 1);
-        if (
-          triageSwapIndex >= 0 &&
-          triageSwapIndex < triageStoryOptions.length
-        ) {
-          const nextTriage = [...triageStoryOptions];
-          const triageTemp = nextTriage[triageIndex];
-          nextTriage[triageIndex] = nextTriage[triageSwapIndex];
-          nextTriage[triageSwapIndex] = triageTemp;
-          setLocalStoryOptionsOverride({
-            generatedAt: activeSnapshot?.generatedAt,
-            stories: nextTriage,
-          });
-        }
-      }
       const entryIndex = storyEntries.findIndex(
         (e) => e.storyOptionId === storyOptionId,
       );
@@ -421,13 +389,7 @@ export const ConsolePage = () => {
         }
       }
     },
-    [
-      pjcode,
-      triageStoryOptions,
-      storyEntries,
-      activeSnapshot?.generatedAt,
-      storiesSnapshot?.generatedAt,
-    ],
+    [pjcode, storyEntries, storiesSnapshot?.generatedAt],
   );
 
   const handleStoryAdd = useCallback(
@@ -565,23 +527,15 @@ export const ConsolePage = () => {
           colorErrors={storyColorErrors}
         />
       ) : selectedItem === null ? (
-        <>
-          {activeTab === 'triage' && triageStoryOptions.length > 0 && (
-            <ConsoleStoryReorderPanel
-              stories={triageStoryOptions}
-              onReorderStory={handleReorderStory}
-            />
-          )}
-          <ConsoleItemList
-            rows={rows}
-            storyColors={storyColors}
-            activeItemId={null}
-            now={now}
-            isLoading={isLoading}
-            error={error}
-            onSelectItem={(item) => navigation.openItem(item.projectItemId)}
-          />
-        </>
+        <ConsoleItemList
+          rows={rows}
+          storyColors={storyColors}
+          activeItemId={null}
+          now={now}
+          isLoading={isLoading}
+          error={error}
+          onSelectItem={(item) => navigation.openItem(item.projectItemId)}
+        />
       ) : (
         <div className="console-detail-screen" ref={detailScreenRef}>
           <ConsoleItemDetailContainer
@@ -591,7 +545,6 @@ export const ConsolePage = () => {
             caches={caches}
             operations={operations}
             statusOptions={statusOptions}
-            storyOptions={storyOptions}
             storyColors={storyColors}
             storyName={storyNameForSelected}
             overlayStatus={overlayStatusForSelected}