github-issue-tower-defence-management 2.19.1 → 2.19.3

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.test.ts

@@ -1,325 +0,0 @@
-import {
-  countPendingItems,
-  filterPendingItems,
-  isOverlayEntryActed,
-  overlayEntriesActedSinceSnapshot,
-  overlayKeyForItem,
-  overlayStatusSinceSnapshot,
-  overlayStorageKey,
-  writeOverlayEntry,
-} from './overlay';
-import type {
-  ConsoleListItem,
-  ConsoleOverlay,
-  ConsoleOverlayStatus,
-} from './types';
-
-const item = (number: number): ConsoleListItem => ({
-  number,
-  title: `Item ${number}`,
-  url: `https://github.com/o/r/issues/${number}`,
-  repo: 'o/r',
-  nameWithOwner: 'o/r',
-  projectItemId: `PVTI_${number}`,
-  itemId: `PVTI_${number}`,
-  isPr: false,
-  relatedOpenPullRequestUrls: [],
-  story: 'Story',
-  status: null,
-  agent: null,
-  nextActionDate: null,
-  nextActionHour: null,
-  dependedIssueUrls: [],
-  labels: [],
-  createdAt: '2026-06-10T00:00:00.000Z',
-});
-
-describe('overlay helpers', () => {
-  it('builds the per-project storage key', () => {
-    expect(overlayStorageKey('acme')).toBe('pv_overlay_acme');
-  });
-
-  it('uses the projectItemId as the overlay key when present', () => {
-    expect(overlayKeyForItem(item(5))).toBe('PVTI_5');
-  });
-
-  it('falls back to the itemId when the projectItemId is empty', () => {
-    expect(overlayKeyForItem({ ...item(5), projectItemId: '' })).toBe('PVTI_5');
-  });
-});
-
-describe('isOverlayEntryActed', () => {
-  it('treats a done entry as acted', () => {
-    expect(isOverlayEntryActed({ ts: 100, mode: 'prs', done: true })).toBe(
-      true,
-    );
-  });
-
-  it('treats a missing entry as not acted', () => {
-    expect(isOverlayEntryActed(undefined)).toBe(false);
-  });
-
-  it('treats an entry without done as not acted', () => {
-    expect(
-      isOverlayEntryActed({
-        ts: 100,
-        mode: 'prs',
-        story: { name: 'Story', color: 'BLUE' },
-      }),
-    ).toBe(false);
-  });
-
-  it('treats a done entry as acted regardless of the mode it was written in', () => {
-    expect(
-      isOverlayEntryActed({ ts: 100, mode: 'todo-by-human', done: true }),
-    ).toBe(true);
-  });
-});
-
-describe('counts driven to zero do not revive on tab switch', () => {
-  it('keeps a done item subtracted in the tab it was processed in', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 500, mode: 'prs', done: true },
-    };
-    expect(countPendingItems([item(1)], overlay, 'prs')).toBe(0);
-  });
-
-  it('does not subtract a done item from a tab other than the one it was processed in', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'todo-by-human', done: true },
-    };
-    expect(countPendingItems([item(1)], overlay, 'prs')).toBe(1);
-  });
-
-  it('does not revive a done item even when an entry was processed before the snapshot it still appears in', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'prs', done: true },
-    };
-    expect(countPendingItems([item(1)], overlay, 'prs')).toBe(0);
-  });
-
-  it('shows a done item in a tab other than the one it was processed in', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'prs', done: true },
-    };
-    expect(countPendingItems([item(1)], overlay, 'todo-by-human')).toBe(1);
-    expect(filterPendingItems([item(1)], overlay, 'todo-by-human')).toEqual([
-      item(1),
-    ]);
-  });
-
-  it('counts an item that has no done entry', () => {
-    expect(countPendingItems([item(1)], {}, 'prs')).toBe(1);
-  });
-});
-
-describe('filterPendingItems', () => {
-  it('drops acted items and keeps the rest', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 500, mode: 'prs', done: true },
-    };
-    const result = filterPendingItems([item(1), item(2)], overlay, 'prs');
-    expect(result.map((entry) => entry.number)).toEqual([2]);
-  });
-
-  it('keeps the badge count and the filtered list consistent', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 500, mode: 'prs', done: true },
-    };
-    const items = [item(1), item(2)];
-    expect(countPendingItems(items, overlay, 'prs')).toBe(
-      filterPendingItems(items, overlay, 'prs').length,
-    );
-  });
-});
-
-describe('workflow-blocker items are filtered by the done overlay like every other tab', () => {
-  it('subtracts a processed workflow-blocker item from the count', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
-    };
-    expect(
-      countPendingItems([item(1), item(2)], overlay, 'workflow-blocker'),
-    ).toBe(1);
-  });
-
-  it('removes a processed workflow-blocker item from the list', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
-    };
-    const result = filterPendingItems(
-      [item(1), item(2)],
-      overlay,
-      'workflow-blocker',
-    );
-    expect(result.map((entry) => entry.number)).toEqual([2]);
-  });
-
-  it('drives the count to zero when every workflow-blocker item is processed', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
-      PVTI_2: { ts: 100, mode: 'workflow-blocker', done: true },
-    };
-    expect(
-      countPendingItems([item(1), item(2)], overlay, 'workflow-blocker'),
-    ).toBe(0);
-    expect(
-      filterPendingItems([item(1), item(2)], overlay, 'workflow-blocker'),
-    ).toEqual([]);
-  });
-});
-
-describe('overlayEntriesActedSinceSnapshot', () => {
-  it('drops an entry written before the snapshot was generated so the item is pending again', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: {
-        ts: Date.parse('2026-08-04T00:20:00.000Z'),
-        mode: 'todo-by-human',
-        done: true,
-      },
-    };
-    const acted = overlayEntriesActedSinceSnapshot(
-      overlay,
-      '2026-08-04T00:26:06Z',
-    );
-    expect(acted).toEqual({});
-    expect(countPendingItems([item(1)], acted, 'todo-by-human')).toBe(1);
-    expect(filterPendingItems([item(1)], acted, 'todo-by-human')).toEqual([
-      item(1),
-    ]);
-  });
-
-  it('keeps an entry written after the snapshot was generated so the item stays hidden', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: {
-        ts: Date.parse('2026-08-04T00:30:00.000Z'),
-        mode: 'todo-by-human',
-        done: true,
-      },
-    };
-    const acted = overlayEntriesActedSinceSnapshot(
-      overlay,
-      '2026-08-04T00:26:06Z',
-    );
-    expect(countPendingItems([item(1)], acted, 'todo-by-human')).toBe(0);
-  });
-
-  it('keeps an entry written at the exact snapshot generation time', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: {
-        ts: Date.parse('2026-08-04T00:26:06Z'),
-        mode: 'todo-by-human',
-        done: true,
-      },
-    };
-    expect(
-      overlayEntriesActedSinceSnapshot(overlay, '2026-08-04T00:26:06Z'),
-    ).toEqual(overlay);
-  });
-
-  it('suppresses nothing when the snapshot carries no parsable generation time', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 500, mode: 'todo-by-human', done: true },
-    };
-    expect(overlayEntriesActedSinceSnapshot(overlay, '')).toEqual({});
-  });
-});
-
-describe('writeOverlayEntry', () => {
-  it('stamps the timestamp and mode on write', () => {
-    const next = writeOverlayEntry({}, 'PVTI_1', { done: true }, 'prs', 1234);
-    expect(next.PVTI_1).toEqual({ done: true, ts: 1234, mode: 'prs' });
-  });
-
-  it('merges a patch into an existing entry while refreshing ts and mode', () => {
-    const overlay: ConsoleOverlay = {
-      PVTI_1: { ts: 100, mode: 'prs', done: true },
-    };
-    const next = writeOverlayEntry(
-      overlay,
-      'PVTI_1',
-      { story: { name: 'New Story', color: 'GREEN' } },
-      'todo-by-human',
-      999,
-    );
-    expect(next.PVTI_1).toEqual({
-      done: true,
-      story: { name: 'New Story', color: 'GREEN' },
-      ts: 999,
-      mode: 'todo-by-human',
-    });
-  });
-});
-
-describe('overlayStatusSinceSnapshot', () => {
-  const snapshotGeneratedAt = '2026-08-13T21:52:01.000Z';
-  const snapshotEpochMs = Date.parse(snapshotGeneratedAt);
-  const inTmuxByHuman: ConsoleOverlayStatus = {
-    name: 'In Tmux by human',
-    color: 'RED',
-  };
-
-  const overlayWithStatusAt = (epochMs: number): ConsoleOverlay => ({
-    [overlayKeyForItem(item(1))]: {
-      status: inTmuxByHuman,
-      ts: epochMs,
-      mode: 'todo-by-human',
-    },
-  });
-
-  it('shows a status the owner set after the snapshot was generated', () => {
-    expect(
-      overlayStatusSinceSnapshot(
-        overlayWithStatusAt(snapshotEpochMs + 1000),
-        item(1),
-        snapshotGeneratedAt,
-      ),
-    ).toEqual(inTmuxByHuman);
-  });
-
-  it('drops a status the snapshot already superseded', () => {
-    expect(
-      overlayStatusSinceSnapshot(
-        overlayWithStatusAt(snapshotEpochMs - 1000),
-        item(1),
-        snapshotGeneratedAt,
-      ),
-    ).toBeNull();
-  });
-
-  it('drops every status when the snapshot time is unusable', () => {
-    expect(
-      overlayStatusSinceSnapshot(
-        overlayWithStatusAt(snapshotEpochMs + 1000),
-        item(1),
-        null,
-      ),
-    ).toBeNull();
-  });
-
-  it('shows a status set at the exact moment the snapshot was generated', () => {
-    expect(
-      overlayStatusSinceSnapshot(
-        overlayWithStatusAt(snapshotEpochMs),
-        item(1),
-        snapshotGeneratedAt,
-      ),
-    ).toEqual(inTmuxByHuman);
-  });
-
-  it('drops every status when the snapshot time cannot be parsed', () => {
-    expect(
-      overlayStatusSinceSnapshot(
-        overlayWithStatusAt(snapshotEpochMs + 1000),
-        item(1),
-        'not a timestamp',
-      ),
-    ).toBeNull();
-  });
-
-  it('returns null when the item has no overlay entry', () => {
-    expect(
-      overlayStatusSinceSnapshot({}, item(1), snapshotGeneratedAt),
-    ).toBeNull();
-  });
-});

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.ts

@@ -1,94 +0,0 @@
-import type {
-  ConsoleListItem,
-  ConsoleOverlay,
-  ConsoleOverlayEntry,
-  ConsoleOverlayStatus,
-  ConsoleTabName,
-} from './types';
-
-export const overlayStorageKey = (pjcode: string): string =>
-  `pv_overlay_${pjcode}`;
-
-export const overlayKeyForItem = (item: ConsoleListItem): string =>
-  item.projectItemId !== '' ? item.projectItemId : item.itemId;
-
-export const isOverlayEntryActed = (
-  entry: ConsoleOverlayEntry | undefined,
-): boolean => entry !== undefined && entry.done === true;
-
-const isActedInTab = (
-  entry: ConsoleOverlayEntry | undefined,
-  currentTab: ConsoleTabName,
-): boolean =>
-  entry !== undefined && entry.done === true && entry.mode === currentTab;
-
-export const countPendingItems = (
-  items: ConsoleListItem[],
-  overlay: ConsoleOverlay,
-  currentTab: ConsoleTabName,
-): number =>
-  items.filter(
-    (item) => !isActedInTab(overlay[overlayKeyForItem(item)], currentTab),
-  ).length;
-
-export const filterPendingItems = (
-  items: ConsoleListItem[],
-  overlay: ConsoleOverlay,
-  currentTab: ConsoleTabName,
-): ConsoleListItem[] =>
-  items.filter(
-    (item) => !isActedInTab(overlay[overlayKeyForItem(item)], currentTab),
-  );
-
-export const overlayEntriesActedSinceSnapshot = (
-  overlay: ConsoleOverlay,
-  snapshotGeneratedAt: string,
-): ConsoleOverlay => {
-  const snapshotGeneratedAtMs = Date.parse(snapshotGeneratedAt);
-  if (Number.isNaN(snapshotGeneratedAtMs)) {
-    return {};
-  }
-  const acted: ConsoleOverlay = {};
-  for (const [key, entry] of Object.entries(overlay)) {
-    if (entry.ts >= snapshotGeneratedAtMs) {
-      acted[key] = entry;
-    }
-  }
-  return acted;
-};
-
-export const overlayStatusSinceSnapshot = (
-  overlay: ConsoleOverlay,
-  item: ConsoleListItem,
-  snapshotGeneratedAt: string | null,
-): ConsoleOverlayStatus | null => {
-  if (snapshotGeneratedAt === null) {
-    return null;
-  }
-  const snapshotGeneratedAtMs = Date.parse(snapshotGeneratedAt);
-  if (Number.isNaN(snapshotGeneratedAtMs)) {
-    return null;
-  }
-  const entry = overlay[overlayKeyForItem(item)];
-  if (entry === undefined || entry.ts < snapshotGeneratedAtMs) {
-    return null;
-  }
-  return entry.status ?? null;
-};
-
-export const writeOverlayEntry = (
-  overlay: ConsoleOverlay,
-  key: string,
-  patch: Partial<Omit<ConsoleOverlayEntry, 'ts' | 'mode'>>,
-  mode: ConsoleTabName,
-  now: number,
-): ConsoleOverlay => {
-  const existing = overlay[key];
-  const next: ConsoleOverlayEntry = {
-    ...(existing ?? {}),
-    ...patch,
-    ts: now,
-    mode,
-  };
-  return { ...overlay, [key]: next };
-};

package/src/adapter/entry-points/console/ui/src/features/console/logic/postedComments.test.ts

@@ -1,44 +0,0 @@
-import { mergePostedComments } from './postedComments';
-import type { ConsoleComment } from './types';
-
-const loadedComment: ConsoleComment = {
-  author: 'HiromiShikata',
-  body: 'Loaded from GitHub.',
-  createdAt: '2026-06-19T10:00:00.000Z',
-};
-
-const postedComment: ConsoleComment = {
-  author: 'HiromiShikata',
-  body: 'Posted from the console.',
-  createdAt: '2026-06-19T11:58:00.000Z',
-};
-
-describe('mergePostedComments', () => {
-  it('appends a posted comment after the loaded comments', () => {
-    expect(mergePostedComments([loadedComment], [postedComment])).toEqual([
-      loadedComment,
-      postedComment,
-    ]);
-  });
-
-  it('drops a posted comment that the reloaded comments already carry', () => {
-    expect(
-      mergePostedComments([loadedComment, postedComment], [postedComment]),
-    ).toEqual([loadedComment, postedComment]);
-  });
-
-  it('keeps a posted comment whose body differs from an otherwise identical loaded comment', () => {
-    const editedComment: ConsoleComment = {
-      ...postedComment,
-      body: 'Posted from the console, then edited.',
-    };
-    expect(mergePostedComments([postedComment], [editedComment])).toEqual([
-      postedComment,
-      editedComment,
-    ]);
-  });
-
-  it('returns the loaded comments unchanged when nothing was posted', () => {
-    expect(mergePostedComments([loadedComment], [])).toEqual([loadedComment]);
-  });
-});

package/src/adapter/entry-points/console/ui/src/features/console/logic/postedComments.ts

@@ -1,17 +0,0 @@
-import type { ConsoleComment } from './types';
-
-const commentIdentity = (comment: ConsoleComment): string =>
-  JSON.stringify([comment.author, comment.createdAt, comment.body]);
-
-export const mergePostedComments = (
-  loadedComments: ConsoleComment[],
-  postedComments: ConsoleComment[],
-): ConsoleComment[] => {
-  const loadedIdentities = new Set(loadedComments.map(commentIdentity));
-  return [
-    ...loadedComments,
-    ...postedComments.filter(
-      (comment) => !loadedIdentities.has(commentIdentity(comment)),
-    ),
-  ];
-};

package/src/adapter/entry-points/console/ui/src/features/console/logic/references.test.ts

@@ -1,103 +0,0 @@
-import {
-  parseGitHubReferenceUrl,
-  parseNameWithOwner,
-  referenceStateToIconInput,
-} from './references';
-
-describe('parseNameWithOwner', () => {
-  it('splits owner and repo on the first slash', () => {
-    expect(parseNameWithOwner('HiromiShikata/repo-name')).toEqual({
-      owner: 'HiromiShikata',
-      repo: 'repo-name',
-    });
-  });
-
-  it('returns null when there is no slash', () => {
-    expect(parseNameWithOwner('repo-name')).toBeNull();
-  });
-
-  it('returns null when owner or repo is empty', () => {
-    expect(parseNameWithOwner('/repo')).toBeNull();
-    expect(parseNameWithOwner('owner/')).toBeNull();
-  });
-
-  it('returns null when the value contains extra path segments', () => {
-    expect(parseNameWithOwner('owner/repo/extra')).toBeNull();
-  });
-});
-
-describe('parseGitHubReferenceUrl', () => {
-  it('parses an issue url', () => {
-    expect(
-      parseGitHubReferenceUrl('https://github.com/octo/repo/issues/42'),
-    ).toEqual({ owner: 'octo', repo: 'repo', number: 42, kind: 'issue' });
-  });
-
-  it('parses a pull request url', () => {
-    expect(
-      parseGitHubReferenceUrl('https://github.com/octo/repo/pull/7'),
-    ).toEqual({ owner: 'octo', repo: 'repo', number: 7, kind: 'pull' });
-  });
-
-  it('parses a url with a trailing hash fragment', () => {
-    expect(
-      parseGitHubReferenceUrl(
-        'https://github.com/octo/repo/issues/42#issuecomment-1',
-      ),
-    ).toEqual({ owner: 'octo', repo: 'repo', number: 42, kind: 'issue' });
-  });
-
-  it('returns null for a non-issue github url', () => {
-    expect(
-      parseGitHubReferenceUrl('https://github.com/octo/repo/blob/main/file.ts'),
-    ).toBeNull();
-  });
-
-  it('returns null for a non-github url', () => {
-    expect(
-      parseGitHubReferenceUrl('https://example.com/octo/repo/issues/1'),
-    ).toBeNull();
-  });
-
-  it('returns null for a github user-attachments link', () => {
-    expect(
-      parseGitHubReferenceUrl('https://github.com/user-attachments/assets/abc'),
-    ).toBeNull();
-  });
-});
-
-describe('referenceStateToIconInput', () => {
-  it('maps a merged pull request to the pull request icon input', () => {
-    expect(
-      referenceStateToIconInput({
-        state: 'CLOSED',
-        merged: true,
-        isPullRequest: true,
-        title: 'merged pr',
-      }),
-    ).toEqual({
-      isPr: true,
-      state: 'closed',
-      merged: true,
-      isDraft: false,
-      stateReason: '',
-    });
-  });
-
-  it('maps an open issue to the issue icon input', () => {
-    expect(
-      referenceStateToIconInput({
-        state: 'OPEN',
-        merged: false,
-        isPullRequest: false,
-        title: 'open issue',
-      }),
-    ).toEqual({
-      isPr: false,
-      state: 'open',
-      merged: false,
-      isDraft: false,
-      stateReason: '',
-    });
-  });
-});

package/src/adapter/entry-points/console/ui/src/features/console/logic/references.ts

@@ -1,64 +0,0 @@
-import type { ConsoleItemIconInput } from './itemIcons';
-import type { ConsoleIssueState } from './types';
-
-export type ConsoleReferenceKind = 'issue' | 'pull';
-
-export type ConsoleGitHubReference = {
-  owner: string;
-  repo: string;
-  number: number;
-  kind: ConsoleReferenceKind;
-};
-
-const GITHUB_REFERENCE_URL =
-  /^https:\/\/github\.com\/([^/\s]+)\/([^/\s]+)\/(issues|pull)\/(\d+)(?:[#?].*)?$/;
-
-export const parseGitHubReferenceUrl = (
-  href: string,
-): ConsoleGitHubReference | null => {
-  const match = GITHUB_REFERENCE_URL.exec(href.trim());
-  if (match === null) {
-    return null;
-  }
-  const [, owner, repo, segment, numberText] = match;
-  const number = Number.parseInt(numberText, 10);
-  if (!Number.isFinite(number)) {
-    return null;
-  }
-  return {
-    owner,
-    repo,
-    number,
-    kind: segment === 'pull' ? 'pull' : 'issue',
-  };
-};
-
-export type ConsoleRepoContext = {
-  owner: string;
-  repo: string;
-};
-
-export const parseNameWithOwner = (
-  nameWithOwner: string,
-): ConsoleRepoContext | null => {
-  const separatorIndex = nameWithOwner.indexOf('/');
-  if (separatorIndex <= 0) {
-    return null;
-  }
-  const owner = nameWithOwner.slice(0, separatorIndex);
-  const repo = nameWithOwner.slice(separatorIndex + 1);
-  if (owner === '' || repo === '' || repo.includes('/')) {
-    return null;
-  }
-  return { owner, repo };
-};
-
-export const referenceStateToIconInput = (
-  state: ConsoleIssueState,
-): ConsoleItemIconInput => ({
-  isPr: state.isPullRequest,
-  state: state.state.toLowerCase(),
-  merged: state.merged,
-  isDraft: false,
-  stateReason: '',
-});