github-issue-tower-defence-management 2.19.1 → 2.19.2

package/src/adapter/entry-points/console/ui/src/features/console/components/detail/ConsoleFetchFailureAlert.stories.tsx

@@ -1,33 +0,0 @@
-import type { Meta, StoryObj } from '@storybook/react-vite';
-import { ConsoleFetchFailureAlert } from './ConsoleFetchFailureAlert';
-
-const meta: Meta<typeof ConsoleFetchFailureAlert> = {
-  title: 'Console/ConsoleFetchFailureAlert',
-  component: ConsoleFetchFailureAlert,
-};
-
-export default meta;
-
-type Story = StoryObj<typeof ConsoleFetchFailureAlert>;
-
-export const NoFailure: Story = {
-  args: { failures: [] },
-};
-
-export const SingleFailure: Story = {
-  args: {
-    failures: [
-      { section: 'comments', message: 'API rate limit already exceeded' },
-    ],
-  },
-};
-
-export const SharedCauseAcrossSections: Story = {
-  args: {
-    failures: [
-      { section: 'item state', message: 'API rate limit already exceeded' },
-      { section: 'description', message: 'API rate limit already exceeded' },
-      { section: 'comments', message: 'API rate limit already exceeded' },
-    ],
-  },
-};

package/src/adapter/entry-points/console/ui/src/features/console/components/detail/ConsoleFetchFailureAlert.test.tsx

@@ -1,62 +0,0 @@
-import { render } from '@testing-library/react';
-import { ConsoleFetchFailureAlert } from './ConsoleFetchFailureAlert';
-
-const rateLimit = 'API rate limit already exceeded';
-
-describe('ConsoleFetchFailureAlert', () => {
-  it('renders nothing when no read failed', () => {
-    const { container, queryByRole } = render(
-      <ConsoleFetchFailureAlert failures={[]} />,
-    );
-    expect(queryByRole('alert')).toBeNull();
-    expect(container).toBeEmptyDOMElement();
-  });
-
-  it('states one section on its own when only that read failed', () => {
-    const { getByRole } = render(
-      <ConsoleFetchFailureAlert
-        failures={[{ section: 'comments', message: rateLimit }]}
-      />,
-    );
-    expect(getByRole('alert')).toHaveTextContent(
-      `Failed to load comments: ${rateLimit}`,
-    );
-  });
-
-  it('names every section of one shared cause on a single line', () => {
-    const { getAllByRole, getByRole } = render(
-      <ConsoleFetchFailureAlert
-        failures={[
-          { section: 'item state', message: rateLimit },
-          { section: 'description', message: rateLimit },
-          { section: 'comments', message: rateLimit },
-        ]}
-      />,
-    );
-    expect(getAllByRole('alert')).toHaveLength(1);
-    expect(getByRole('alert').querySelectorAll('p')).toHaveLength(1);
-    expect(getByRole('alert')).toHaveTextContent(
-      `Failed to load item state, description and comments: ${rateLimit}`,
-    );
-  });
-
-  it('keeps distinct causes on their own lines inside the one alert', () => {
-    const { getAllByRole, getByRole } = render(
-      <ConsoleFetchFailureAlert
-        failures={[
-          { section: 'item state', message: rateLimit },
-          { section: 'description', message: 'HTTP 500' },
-          { section: 'comments', message: rateLimit },
-        ]}
-      />,
-    );
-    expect(getAllByRole('alert')).toHaveLength(1);
-    const lines = Array.from(getByRole('alert').querySelectorAll('p')).map(
-      (line) => line.textContent,
-    );
-    expect(lines).toEqual([
-      `Failed to load item state and comments: ${rateLimit}`,
-      'Failed to load description: HTTP 500',
-    ]);
-  });
-});

package/src/adapter/entry-points/console/ui/src/features/console/components/detail/ConsoleFetchFailureAlert.tsx

@@ -1,59 +0,0 @@
-export type ConsoleFetchFailure = {
-  section: string;
-  message: string;
-};
-
-type ConsoleFetchFailureGroup = {
-  message: string;
-  sections: string[];
-};
-
-export type ConsoleFetchFailureAlertProps = {
-  failures: ConsoleFetchFailure[];
-};
-
-export const groupConsoleFetchFailuresByMessage = (
-  failures: ConsoleFetchFailure[],
-): ConsoleFetchFailureGroup[] => {
-  const sectionsByMessage = new Map<string, string[]>();
-  for (const failure of failures) {
-    const sections = sectionsByMessage.get(failure.message);
-    if (sections === undefined) {
-      sectionsByMessage.set(failure.message, [failure.section]);
-      continue;
-    }
-    sections.push(failure.section);
-  }
-  return Array.from(sectionsByMessage, ([message, sections]) => ({
-    message,
-    sections,
-  }));
-};
-
-export const formatConsoleFetchFailureSections = (
-  sections: string[],
-): string => {
-  if (sections.length <= 1) {
-    return sections.join('');
-  }
-  return `${sections.slice(0, -1).join(', ')} and ${sections[sections.length - 1]}`;
-};
-
-export const ConsoleFetchFailureAlert = ({
-  failures,
-}: ConsoleFetchFailureAlertProps) => {
-  if (failures.length === 0) {
-    return null;
-  }
-
-  return (
-    <div role="alert" className="console-detail-fetch-error">
-      {groupConsoleFetchFailuresByMessage(failures).map((group) => (
-        <p key={group.message} className="console-detail-fetch-error-line">
-          Failed to load {formatConsoleFetchFailureSections(group.sections)}:{' '}
-          {group.message}
-        </p>
-      ))}
-    </div>
-  );
-};

package/src/adapter/entry-points/console/ui/src/features/console/components/detail/ConsoleFileDiff.stories.tsx

@@ -1,38 +0,0 @@
-import type { Meta, StoryObj } from '@storybook/react-vite';
-import { consoleChangedFilesFixture } from '../../testing/fixtures';
-import { ConsoleFileDiff } from './ConsoleFileDiff';
-
-const meta: Meta<typeof ConsoleFileDiff> = {
-  title: 'Console/ConsoleFileDiff',
-  component: ConsoleFileDiff,
-  args: { patch: consoleChangedFilesFixture[0].patch },
-};
-
-export default meta;
-
-type Story = StoryObj<typeof ConsoleFileDiff>;
-
-export const WithPatch: Story = {};
-
-export const NoPatch: Story = {
-  args: { patch: null },
-};
-
-export const ImageFile: Story = {
-  args: {
-    patch: null,
-    path: 'content/posts/img/20260707/before.jpg',
-    rawUrl:
-      'https://raw.githubusercontent.com/HiromiShikata/npm-cli-github-issue-tower-defence-management/main/docs/img/console.png',
-    buildImageProxyUrl: (src) => src,
-  },
-};
-
-export const WithInlineComments: Story = {
-  args: {
-    path: consoleChangedFilesFixture[0].path,
-    onAddInlineComment: async (path, line, side, body) => {
-      window.alert(`comment on ${path}:${line} (${side})\n${body}`);
-    },
-  },
-};

package/src/adapter/entry-points/console/ui/src/features/console/components/detail/ConsoleFileDiff.test.tsx

@@ -1,151 +0,0 @@
-import { fireEvent, render, waitFor } from '@testing-library/react';
-import { consoleChangedFilesFixture } from '../../testing/fixtures';
-import { ConsoleFileDiff } from './ConsoleFileDiff';
-
-describe('ConsoleFileDiff', () => {
-  it('renders added, removed and context lines from the patch', () => {
-    const { container } = render(
-      <ConsoleFileDiff patch={consoleChangedFilesFixture[0].patch} />,
-    );
-    const codeText = [...container.querySelectorAll('.console-diff-code')].map(
-      (cell) => cell.textContent,
-    );
-    expect(codeText).toContain('+          npm ci');
-    expect(codeText).toContain('-          npm install');
-    expect(container.querySelectorAll('.console-diff-add').length).toBe(2);
-    expect(container.querySelectorAll('.console-diff-del').length).toBe(1);
-    expect(container.querySelectorAll('.console-diff-hunk').length).toBe(1);
-  });
-
-  it('shows a placeholder when there is no patch', () => {
-    const { getByText } = render(<ConsoleFileDiff patch={null} />);
-    expect(getByText('(no diff / binary or too large)')).toBeInTheDocument();
-  });
-
-  it('renders an image file through the image proxy instead of the placeholder', () => {
-    const { getByAltText, queryByText } = render(
-      <ConsoleFileDiff
-        patch={null}
-        path="content/posts/img/20260707/before.jpg"
-        rawUrl="https://raw.githubusercontent.com/owner/repo/sha/content/posts/img/20260707/before.jpg"
-        buildImageProxyUrl={(src) => `/api/img?url=${encodeURIComponent(src)}`}
-      />,
-    );
-    expect(
-      getByAltText('content/posts/img/20260707/before.jpg'),
-    ).toHaveAttribute(
-      'src',
-      `/api/img?url=${encodeURIComponent('https://raw.githubusercontent.com/owner/repo/sha/content/posts/img/20260707/before.jpg')}`,
-    );
-    expect(queryByText('(no diff / binary or too large)')).toBeNull();
-  });
-
-  it('renders an image directly from a data URL without the proxy when rawUrl is a data URI', () => {
-    const dataUrl =
-      'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mNk+M9QDwADhgGAWjR9awAAAABJRU5ErkJggg==';
-    const { getByAltText, queryByText } = render(
-      <ConsoleFileDiff patch={null} path="assets/logo.png" rawUrl={dataUrl} />,
-    );
-    expect(getByAltText('assets/logo.png')).toHaveAttribute('src', dataUrl);
-    expect(queryByText('(no diff / binary or too large)')).toBeNull();
-  });
-
-  it('keeps the placeholder for a binary file that is not an image', () => {
-    const { getByText } = render(
-      <ConsoleFileDiff
-        patch={null}
-        path="assets/font.woff2"
-        rawUrl="https://raw.githubusercontent.com/owner/repo/sha/assets/font.woff2"
-        buildImageProxyUrl={(src) => `/api/img?url=${encodeURIComponent(src)}`}
-      />,
-    );
-    expect(getByText('(no diff / binary or too large)')).toBeInTheDocument();
-  });
-
-  it('does not render any comment affordance without an onAddInlineComment handler', () => {
-    const { container } = render(
-      <ConsoleFileDiff
-        patch={consoleChangedFilesFixture[0].patch}
-        path="src/adapter/entry-points/console/consoleServer.ts"
-      />,
-    );
-    expect(
-      container.querySelectorAll('.console-diff-comment-button').length,
-    ).toBe(0);
-  });
-
-  it('anchors an added line comment to its new line on the RIGHT side', async () => {
-    const onAddInlineComment = jest.fn().mockResolvedValue(undefined);
-    const { getByLabelText, getByPlaceholderText, getByText } = render(
-      <ConsoleFileDiff
-        patch={consoleChangedFilesFixture[0].patch}
-        path="src/adapter/entry-points/console/consoleServer.ts"
-        onAddInlineComment={onAddInlineComment}
-      />,
-    );
-    fireEvent.click(getByLabelText('Comment on line 57 (RIGHT)'));
-    fireEvent.change(
-      getByPlaceholderText('Leave a review comment on this line…'),
-      { target: { value: 'Why npm ci here?' } },
-    );
-    fireEvent.click(getByText('Comment'));
-    await waitFor(() =>
-      expect(onAddInlineComment).toHaveBeenCalledWith(
-        'src/adapter/entry-points/console/consoleServer.ts',
-        57,
-        'RIGHT',
-        'Why npm ci here?',
-      ),
-    );
-  });
-
-  it('anchors a removed line comment to its old line on the LEFT side', async () => {
-    const onAddInlineComment = jest.fn().mockResolvedValue(undefined);
-    const { getByLabelText, getByPlaceholderText, getByText } = render(
-      <ConsoleFileDiff
-        patch={consoleChangedFilesFixture[0].patch}
-        path="src/adapter/entry-points/console/consoleServer.ts"
-        onAddInlineComment={onAddInlineComment}
-      />,
-    );
-    fireEvent.click(getByLabelText('Comment on line 57 (LEFT)'));
-    fireEvent.change(
-      getByPlaceholderText('Leave a review comment on this line…'),
-      { target: { value: 'Keep npm install?' } },
-    );
-    fireEvent.click(getByText('Comment'));
-    await waitFor(() =>
-      expect(onAddInlineComment).toHaveBeenCalledWith(
-        'src/adapter/entry-points/console/consoleServer.ts',
-        57,
-        'LEFT',
-        'Keep npm install?',
-      ),
-    );
-  });
-
-  it('shows the surfaced error when posting an inline comment fails', async () => {
-    const onAddInlineComment = jest
-      .fn()
-      .mockRejectedValue(new Error('line must be part of the diff'));
-    const { getByLabelText, getByPlaceholderText, getByText, getByRole } =
-      render(
-        <ConsoleFileDiff
-          patch={consoleChangedFilesFixture[0].patch}
-          path="src/adapter/entry-points/console/consoleServer.ts"
-          onAddInlineComment={onAddInlineComment}
-        />,
-      );
-    fireEvent.click(getByLabelText('Comment on line 58 (RIGHT)'));
-    fireEvent.change(
-      getByPlaceholderText('Leave a review comment on this line…'),
-      { target: { value: 'A comment that will fail.' } },
-    );
-    fireEvent.click(getByText('Comment'));
-    await waitFor(() =>
-      expect(getByRole('alert')).toHaveTextContent(
-        'line must be part of the diff',
-      ),
-    );
-  });
-});

package/src/adapter/entry-points/console/ui/src/features/console/components/detail/ConsoleFileDiff.tsx

@@ -1,245 +0,0 @@
-import { Fragment, useState } from 'react';
-import type { ConsoleReviewCommentSide } from '../../lib/consoleApi';
-import type { ImageProxyUrlBuilder } from '../../lib/imageProxy';
-import { type ConsoleDiffLine, parseUnifiedDiff } from '../../logic/diff';
-import { isImageFilePath } from '../../logic/imageFile';
-
-export type ConsoleInlineCommentTarget = {
-  path: string;
-  line: number;
-  side: ConsoleReviewCommentSide;
-};
-
-export type ConsoleAddInlineComment = (
-  path: string,
-  line: number,
-  side: ConsoleReviewCommentSide,
-  body: string,
-) => Promise<void>;
-
-export type ConsoleFileDiffProps = {
-  patch: string | null;
-  path?: string;
-  rawUrl?: string | null;
-  buildImageProxyUrl?: ImageProxyUrlBuilder;
-  onAddInlineComment?: ConsoleAddInlineComment;
-};
-
-type ComposerStatus =
-  | { kind: 'idle' }
-  | { kind: 'posting' }
-  | { kind: 'error'; message: string }
-  | { kind: 'posted' };
-
-const commentTargetForRow = (
-  row: ConsoleDiffLine,
-): { line: number; side: ConsoleReviewCommentSide } | null => {
-  if (row.kind === 'add' || row.kind === 'ctx') {
-    if (row.newLineNumber === null) {
-      return null;
-    }
-    return { line: row.newLineNumber, side: 'RIGHT' };
-  }
-  if (row.kind === 'del') {
-    if (row.oldLineNumber === null) {
-      return null;
-    }
-    return { line: row.oldLineNumber, side: 'LEFT' };
-  }
-  return null;
-};
-
-const rowKey = (row: ConsoleDiffLine): string =>
-  `${row.kind}:${row.oldLineNumber ?? 'x'}:${row.newLineNumber ?? 'x'}:${row.content}`;
-
-type ConsoleInlineCommentComposerProps = {
-  target: ConsoleInlineCommentTarget;
-  onSubmit: ConsoleAddInlineComment;
-  onClose: () => void;
-};
-
-const ConsoleInlineCommentComposer = ({
-  target,
-  onSubmit,
-  onClose,
-}: ConsoleInlineCommentComposerProps) => {
-  const [draft, setDraft] = useState<string>('');
-  const [status, setStatus] = useState<ComposerStatus>({ kind: 'idle' });
-
-  const submit = async (): Promise<void> => {
-    const body = draft.trim();
-    if (body.length === 0 || status.kind === 'posting') {
-      return;
-    }
-    setStatus({ kind: 'posting' });
-    try {
-      await onSubmit(target.path, target.line, target.side, body);
-      setDraft('');
-      setStatus({ kind: 'posted' });
-    } catch (error) {
-      setStatus({
-        kind: 'error',
-        message: error instanceof Error ? error.message : 'failed to post',
-      });
-    }
-  };
-
-  return (
-    <div className="console-diff-composer">
-      <div className="console-diff-composer-anchor">
-        commenting on line {target.line} ({target.side})
-      </div>
-      {status.kind === 'posted' ? (
-        <p className="console-diff-composer-posted">Comment saved.</p>
-      ) : (
-        <>
-          <textarea
-            className="console-diff-composer-input"
-            rows={3}
-            placeholder="Leave a review comment on this line…"
-            value={draft}
-            onChange={(event) => setDraft(event.target.value)}
-          />
-          <div className="console-diff-composer-controls">
-            <button
-              type="button"
-              className="console-diff-composer-submit"
-              disabled={status.kind === 'posting'}
-              onClick={() => {
-                void submit();
-              }}
-            >
-              Comment
-            </button>
-            <button
-              type="button"
-              className="console-diff-composer-cancel"
-              onClick={onClose}
-            >
-              Cancel
-            </button>
-            {status.kind === 'posting' && (
-              <span className="console-diff-composer-status">Posting…</span>
-            )}
-            {status.kind === 'error' && (
-              <span
-                role="alert"
-                className="console-diff-composer-status console-diff-composer-error"
-              >
-                Failed: {status.message}
-              </span>
-            )}
-          </div>
-        </>
-      )}
-    </div>
-  );
-};
-
-export const ConsoleFileDiff = ({
-  patch,
-  path,
-  rawUrl,
-  buildImageProxyUrl,
-  onAddInlineComment,
-}: ConsoleFileDiffProps) => {
-  const [activeTarget, setActiveTarget] =
-    useState<ConsoleInlineCommentTarget | null>(null);
-
-  if (patch === null || patch === '') {
-    if (path !== undefined && rawUrl !== undefined && rawUrl !== null) {
-      if (rawUrl.startsWith('data:image/')) {
-        return (
-          <div className="console-file-diff-image">
-            <img
-              className="console-file-diff-image-content"
-              src={rawUrl}
-              alt={path}
-            />
-          </div>
-        );
-      }
-      if (isImageFilePath(path) && buildImageProxyUrl !== undefined) {
-        return (
-          <div className="console-file-diff-image">
-            <img
-              className="console-file-diff-image-content"
-              src={buildImageProxyUrl(rawUrl)}
-              alt={path}
-            />
-          </div>
-        );
-      }
-    }
-    return (
-      <p className="console-file-diff-empty">(no diff / binary or too large)</p>
-    );
-  }
-  const rows = parseUnifiedDiff(patch);
-  const canComment =
-    onAddInlineComment !== undefined && path !== undefined && path.length > 0;
-  const columnCount = canComment ? 4 : 3;
-
-  return (
-    <table className="console-file-diff">
-      <tbody>
-        {rows.map((row) => {
-          const key = rowKey(row);
-          const target = canComment ? commentTargetForRow(row) : null;
-          const isActive =
-            activeTarget !== null &&
-            target !== null &&
-            activeTarget.line === target.line &&
-            activeTarget.side === target.side;
-          return (
-            <Fragment key={key}>
-              <tr className={`console-diff-row console-diff-${row.kind}`}>
-                {canComment && (
-                  <td className="console-diff-comment-cell">
-                    {target !== null && path !== undefined && (
-                      <button
-                        type="button"
-                        className="console-diff-comment-button"
-                        aria-label={`Comment on line ${target.line} (${target.side})`}
-                        aria-expanded={isActive}
-                        onClick={() =>
-                          setActiveTarget(
-                            isActive
-                              ? null
-                              : {
-                                  path,
-                                  line: target.line,
-                                  side: target.side,
-                                },
-                          )
-                        }
-                      >
-                        +
-                      </button>
-                    )}
-                  </td>
-                )}
-                <td className="console-diff-ln">{row.oldLineNumber ?? ''}</td>
-                <td className="console-diff-ln">{row.newLineNumber ?? ''}</td>
-                <td className="console-diff-code">{row.content}</td>
-              </tr>
-              {isActive &&
-                onAddInlineComment !== undefined &&
-                activeTarget !== null && (
-                  <tr className="console-diff-composer-row">
-                    <td colSpan={columnCount}>
-                      <ConsoleInlineCommentComposer
-                        target={activeTarget}
-                        onSubmit={onAddInlineComment}
-                        onClose={() => setActiveTarget(null)}
-                      />
-                    </td>
-                  </tr>
-                )}
-            </Fragment>
-          );
-        })}
-      </tbody>
-    </table>
-  );
-};