github-issue-tower-defence-management 2.177.0 → 2.177.2

package/bin/adapter/entry-points/console/ui-dist/index.html

@@ -6,7 +6,7 @@
     <link rel="icon" type="image/svg+xml" href="/favicon.svg" />
     <link rel="manifest" href="/manifest.webmanifest" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-qne1gT7I.js"></script>
+    <script type="module" crossorigin src="/assets/index-CmBdbC7r.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-DrLmS10d.css">
   </head>
   <body>

package/bin/adapter/repositories/issue/ApiV3CheerioRestIssueRepository.js

@@ -6,6 +6,7 @@ const ClearDependedIssueURLUseCase_1 = require("../../../domain/usecases/ClearDe
 const storyValueClassify_1 = require("../../../domain/usecases/storyGate/storyValueClassify");
 const StoryObjectMap_1 = require("../../../domain/entities/StoryObjectMap");
 const gitHubRawUrl_1 = require("./gitHubRawUrl");
+const RestIssueRepository_1 = require("./RestIssueRepository");
 const ProjectIssuesCacheRepository_1 = require("../ProjectIssuesCacheRepository");
 const BaseGitHubRepository_1 = require("../BaseGitHubRepository");
 const githubGraphqlClient_1 = require("../githubGraphqlClient");
@@ -243,7 +244,8 @@ function isIssueOrPullRequestBodyResponse(value) {
 function isIssueOrPullRequestStateResponse(value) {
     return (isRecord(value) &&
         typeof value.state === 'string' &&
-        typeof value.title === 'string');
+        typeof value.title === 'string' &&
+        (value.state_reason === undefined || isNullableString(value.state_reason)));
 }
 function isIssueCommentsResponseItem(value) {
     if (!isRecord(value))
@@ -257,6 +259,23 @@ function isIssueCommentsResponseItem(value) {
 function isIssueCommentsResponse(value) {
     return Array.isArray(value) && value.every(isIssueCommentsResponseItem);
 }
+const isStoredIssueComment = (value) => isRecord(value) &&
+    typeof value.id === 'number' &&
+    typeof value.author === 'string' &&
+    typeof value.body === 'string' &&
+    typeof value.createdAt === 'string';
+const isStoredIssueCommentPage = (value) => isRecord(value) &&
+    isNullableString(value.etag) &&
+    Array.isArray(value.comments) &&
+    value.comments.every(isStoredIssueComment);
+const isStoredIssueCommentList = (value) => isRecord(value) &&
+    isNullableString(value.issueUpdatedAt) &&
+    Array.isArray(value.pages) &&
+    value.pages.every(isStoredIssueCommentPage);
+const buildStoredIssueCommentListKey = (owner, repo, issueNumber) => `issueOrPullRequestComments/${owner}/${repo}/${issueNumber}`;
+const readStoredIssueCommentListRevalidationRevision = (storedValue) => isRecord(storedValue) && typeof storedValue.revalidationRevision === 'number'
+    ? storedValue.revalidationRevision
+    : 0;
 function isIssueCommentIdResponseItem(value) {
     return isRecord(value) && typeof value.id === 'number';
 }
@@ -409,6 +428,7 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                 isInProgress: (0, utils_1.normalizeFieldName)(status || '').includes('progress'),
                 isClosed: item.state !== 'OPEN',
                 createdAt: new Date(item.createdAt || '2000-01-01'),
+                updatedAt: new Date(item.updatedAt),
                 author: item.author,
                 closingIssueReferenceUrls: item.closingIssueReferenceUrls,
                 plainCrossRepoIssueReferenceUrls: item.plainCrossRepoIssueReferenceUrls,
@@ -437,6 +457,9 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                 const createdAt = !('createdAt' in issue) || typeof issue.createdAt !== 'string'
                     ? new Date()
                     : new Date(issue.createdAt);
+                const updatedAt = 'updatedAt' in issue && typeof issue.updatedAt === 'string'
+                    ? new Date(issue.updatedAt)
+                    : undefined;
                 const closingIssueReferenceUrls = 'closingIssueReferenceUrls' in issue &&
                     Array.isArray(issue.closingIssueReferenceUrls) &&
                     issue.closingIssueReferenceUrls.every((url) => typeof url === 'string')
@@ -458,6 +481,7 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                     nextActionDate: nextActionDate,
                     completionDate50PercentConfidence: completionDate50PercentConfidence,
                     createdAt: createdAt,
+                    updatedAt: updatedAt,
                     closingIssueReferenceUrls: closingIssueReferenceUrls,
                     plainCrossRepoIssueReferenceUrls: plainCrossRepoIssueReferenceUrls,
                     stateReason: stateReason,
@@ -583,9 +607,12 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                     false);
             const cacheHasIssuesMissingStoryOptionIdSchema = cache !== null &&
                 cache.issues.some((issue) => issue.story !== null && issue.storyOptionId === undefined);
+            const cacheHasIssuesMissingUpdatedAt = cache !== null &&
+                cache.issues.some((issue) => issue.updatedAt === undefined);
             const effectiveIsFullFetch = isFullFetch ||
                 storyOptionsChanged ||
-                cacheHasIssuesMissingStoryOptionIdSchema;
+                cacheHasIssuesMissingStoryOptionIdSchema ||
+                cacheHasIssuesMissingUpdatedAt;
             if (effectiveIsFullFetch) {
                 const projectMetadataFellBackToCache = cache !== null && project === cache.project;
                 const itemIdsKnownBeforeFetch = new Set(cache?.issues.map((issue) => issue.itemId) ?? []);
@@ -693,6 +720,7 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                     isInProgress: false,
                     isClosed: false,
                     createdAt: now,
+                    updatedAt: now,
                     author: '',
                     closingIssueReferenceUrls: [],
                     plainCrossRepoIssueReferenceUrls: [],
@@ -713,7 +741,12 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
             await this.restIssueRepository.updateIssueBody(issue, body);
         };
         this.updateIssueCommentBody = async (comment, body) => {
-            await this.restIssueRepository.updateIssueCommentBody(comment, body);
+            const { commentedIssueNumber } = await this.restIssueRepository.updateIssueCommentBody(comment, body);
+            if (commentedIssueNumber === null) {
+                console.warn(`Stored comment list revalidation marking skipped: the commented issue of comment ${comment.commentId} in ${comment.org}/${comment.repo} is unknown`);
+                return;
+            }
+            await this.markStoredIssueCommentListForRevalidation(`https://github.com/${comment.org}/${comment.repo}/issues/${commentedIssueNumber}`);
         };
         this.findIssueInAllIssuesCache = async (url) => {
             const baseDir = (0, localStorageCacheDirectory_1.localStorageCacheBaseDirectory)();
@@ -988,6 +1021,26 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
         };
         this.createComment = async (issue, comment) => {
             await this.restIssueRepository.createComment(issue.url, comment);
+            await this.markStoredIssueCommentListForRevalidation(issue.url);
+        };
+        this.markStoredIssueCommentListForRevalidation = async (url) => {
+            try {
+                const { owner, repo, issueNumber } = this.parseIssueUrl(url);
+                const storedIssueCommentListKey = buildStoredIssueCommentListKey(owner, repo, issueNumber);
+                await this.localStorageCacheRepository.withLock(storedIssueCommentListKey, async () => {
+                    const storedValue = await this.localStorageCacheRepository.getSingle(storedIssueCommentListKey);
+                    await this.localStorageCacheRepository.setSingle(storedIssueCommentListKey, {
+                        issueUpdatedAt: null,
+                        pages: isStoredIssueCommentList(storedValue)
+                            ? storedValue.pages
+                            : [],
+                        revalidationRevision: readStoredIssueCommentListRevalidationRevision(storedValue) + 1,
+                    });
+                });
+            }
+            catch (error) {
+                console.warn(`Stored comment list revalidation marking failed: issueUrl=${url} error=${String(error)}`);
+            }
         };
         this.updateProjectTextField = async (project, fieldId, issue, text) => {
             await this.logDependedIssueUrlFieldWriteLiveItemIdCrossCheck(project, fieldId, issue.url, issue.itemId, 'update');
@@ -2413,7 +2466,21 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
             }
             return collectedPaths;
         };
+        this.authenticatedUserLoginRequest = null;
         this.getAuthenticatedUserLogin = async () => {
+            const authenticatedUserLoginRequest = this.authenticatedUserLoginRequest ?? this.fetchAuthenticatedUserLogin();
+            this.authenticatedUserLoginRequest = authenticatedUserLoginRequest;
+            try {
+                return await authenticatedUserLoginRequest;
+            }
+            catch (error) {
+                if (this.authenticatedUserLoginRequest === authenticatedUserLoginRequest) {
+                    this.authenticatedUserLoginRequest = null;
+                }
+                throw error;
+            }
+        };
+        this.fetchAuthenticatedUserLogin = async () => {
             const response = await this.fetchWithRateLimitRetry(() => fetch('https://api.github.com/user', {
                 method: 'GET',
                 headers: {
@@ -2677,7 +2744,9 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
             }
         };
         this.createCommentByUrl = async (issueOrPrUrl, commentBody) => {
-            return this.restIssueRepository.createComment(issueOrPrUrl, commentBody);
+            const createdComment = await this.restIssueRepository.createComment(issueOrPrUrl, commentBody);
+            await this.markStoredIssueCommentListForRevalidation(issueOrPrUrl);
+            return createdComment;
         };
         this.fetchIssueBodyResponse = (url) => {
             const { owner, repo, issueNumber } = this.parseIssueUrl(url);
@@ -2714,44 +2783,56 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
             }
             return this.parseIssueBodyResponse(url, response);
         };
-        this.getIssueOrPullRequestComments = async (url) => {
+        this.getIssueOrPullRequestComments = async (url, options) => {
             const { owner, repo, issueNumber } = this.parseIssueUrl(url);
-            const perPage = 100;
-            const collectedComments = [];
-            let page = 1;
-            let hasMore = true;
-            while (hasMore) {
-                const commentsUrl = `https://api.github.com/repos/${encodeURIComponent(owner)}/${encodeURIComponent(repo)}/issues/${issueNumber}/comments?per_page=${perPage}&page=${page}`;
+            const storedIssueCommentListKey = buildStoredIssueCommentListKey(owner, repo, issueNumber);
+            const issueUpdatedAt = options?.issueUpdatedAt?.toISOString() ?? null;
+            const storedValue = await this.localStorageCacheRepository.getSingle(storedIssueCommentListKey);
+            const storedIssueCommentList = isStoredIssueCommentList(storedValue)
+                ? storedValue
+                : null;
+            const revalidationRevisionAtReadStart = readStoredIssueCommentListRevalidationRevision(storedValue);
+            const reusableStoredComments = (0, RestIssueRepository_1.findStoredIssueCommentsReusableForIssueUpdatedAt)(storedIssueCommentList, issueUpdatedAt);
+            if (reusableStoredComments !== null) {
+                return reusableStoredComments;
+            }
+            const fetchedPages = await (0, RestIssueRepository_1.collectIssueCommentPagesReusingStoredPages)(storedIssueCommentList, async (pageNumber, storedPage) => {
+                const commentsUrl = `https://api.github.com/repos/${encodeURIComponent(owner)}/${encodeURIComponent(repo)}/issues/${issueNumber}/comments?per_page=${RestIssueRepository_1.ISSUE_COMMENTS_PER_PAGE}&page=${pageNumber}`;
                 const response = await this.fetchWithRateLimitRetry(() => fetch(commentsUrl, {
                     method: 'GET',
                     headers: {
                         Authorization: `Bearer ${this.ghToken}`,
                         Accept: 'application/vnd.github+json',
+                        ...(storedPage?.etag
+                            ? { 'If-None-Match': storedPage.etag }
+                            : {}),
                     },
                 }), { method: 'GET', path: (0, githubRestClient_1.sanitizeRestPath)(commentsUrl) });
-                if (!response.ok) {
-                    await this.throwGitHubError(`Failed to fetch comments for ${url}`, response);
-                }
-                const body = await response.json();
-                if (!isIssueCommentsResponse(body)) {
-                    throw new Error(`Unexpected response shape when fetching comments for ${url}`);
-                }
-                for (const comment of body) {
-                    collectedComments.push({
-                        id: comment.id,
-                        author: comment.user?.login ?? '',
-                        body: comment.body ?? '',
-                        createdAt: new Date(comment.created_at),
-                    });
-                }
-                if (body.length < perPage) {
-                    hasMore = false;
-                }
-                else {
-                    page += 1;
-                }
+                return response.status === 304 && storedPage !== null
+                    ? storedPage
+                    : this.parseIssueCommentsPageResponse(url, response);
+            });
+            await this.localStorageCacheRepository.withLock(storedIssueCommentListKey, async () => {
+                const currentRevalidationRevision = readStoredIssueCommentListRevalidationRevision(await this.localStorageCacheRepository.getSingle(storedIssueCommentListKey));
+                await this.localStorageCacheRepository.setSingle(storedIssueCommentListKey, {
+                    issueUpdatedAt: currentRevalidationRevision === revalidationRevisionAtReadStart
+                        ? issueUpdatedAt
+                        : null,
+                    pages: fetchedPages,
+                    revalidationRevision: currentRevalidationRevision,
+                });
+            });
+            return (0, RestIssueRepository_1.convertStoredIssueCommentPagesToIssueComments)(fetchedPages);
+        };
+        this.parseIssueCommentsPageResponse = async (url, response) => {
+            if (!response.ok) {
+                await this.throwGitHubError(`Failed to fetch comments for ${url}`, response);
             }
-            return collectedComments;
+            const body = await response.json();
+            if (!isIssueCommentsResponse(body)) {
+                throw new Error(`Unexpected response shape when fetching comments for ${url}`);
+            }
+            return (0, RestIssueRepository_1.convertIssueCommentResponseItemsToStoredIssueCommentPage)(response.headers.get('ETag'), body);
         };
         this.getPullRequestDetail = async (prUrl) => {
             const { owner, repo, issueNumber: prNumber, isPr, } = this.parseIssueUrl(prUrl);
@@ -2898,6 +2979,7 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                     merged: body.merged,
                     isPullRequest: true,
                     title: body.title,
+                    stateReason: '',
                 };
             }
             const issueStateUrl = `https://api.github.com/repos/${encodeURIComponent(owner)}/${encodeURIComponent(repo)}/issues/${issueNumber}`;
@@ -2923,6 +3005,7 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                 merged: false,
                 isPullRequest: false,
                 title: body.title,
+                stateReason: body.state_reason ?? '',
             };
         };
         this.getPullRequestSummary = async (prUrl) => {
@@ -2954,6 +3037,19 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
             };
         };
         this.deleteAllCommentsByUrl = async (issueOrPrUrl) => {
+            let deletedCommentCount = 0;
+            try {
+                await this.deleteAllCommentsByUrlCountingDeletions(issueOrPrUrl, () => {
+                    deletedCommentCount += 1;
+                });
+            }
+            finally {
+                if (deletedCommentCount > 0) {
+                    await this.markStoredIssueCommentListForRevalidation(issueOrPrUrl);
+                }
+            }
+        };
+        this.deleteAllCommentsByUrlCountingDeletions = async (issueOrPrUrl, onCommentDeleted) => {
             const { owner, repo, issueNumber } = this.parseIssueUrl(issueOrPrUrl);
             const perPage = 100;
             while (true) {
@@ -2984,6 +3080,7 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                     if (!deleteResponse.ok) {
                         await this.throwGitHubError(`Failed to delete comment ${comment.id} on ${issueOrPrUrl}`, deleteResponse);
                     }
+                    onCommentDeleted();
                 }
                 if (body.length < perPage) {
                     break;