github-issue-tower-defence-management 2.154.9 → 2.155.0

package/bin/adapter/repositories/issue/ApiV3CheerioRestIssueRepository.js

@@ -9,6 +9,7 @@ const BaseGitHubRepository_1 = require("../BaseGitHubRepository");
 const githubGraphqlClient_1 = require("../githubGraphqlClient");
 const utils_1 = require("../utils");
 const localStorageCacheDirectory_1 = require("../localStorageCacheDirectory");
+const isTransientApiError_1 = require("../../../domain/usecases/isTransientApiError");
 const githubRateLimitRetry_1 = require("./githubRateLimitRetry");
 const githubRestClient_1 = require("../githubRestClient");
 const githubSecondaryRateLimitBreaker_1 = require("./githubSecondaryRateLimitBreaker");
@@ -79,6 +80,7 @@ const RELATED_OPEN_PULL_REQUEST_URLS_BATCH_SIZE = 100;
 const RELATED_OPEN_PULL_REQUEST_URLS_TIMELINE_PAGE_SIZE = 100;
 const ISSUE_EVENTS_PAGE_SIZE = 100;
 const ISSUE_EVENT_COUNT_AT_WHICH_GITHUB_STOPS_LISTING_ISSUE_EVENTS = 310;
+const REOPENED_TIMELINE_ITEM_COUNT_AT_WHICH_GITHUB_STOPS_LISTING_REOPENED_TIMELINE_ITEMS = 310;
 function isIssueTimelineResponse(value) {
     if (typeof value !== 'object' || value === null)
         return false;
@@ -163,9 +165,22 @@ function isIssueLatestReopenedTimelineItemResponse(value) {
     if (!isRecord(timelineItems))
         return false;
     const nodes = timelineItems.nodes;
-    return (Array.isArray(nodes) &&
+    return (typeof timelineItems.totalCount === 'number' &&
+        Array.isArray(nodes) &&
         nodes.every((node) => isRecord(node) && typeof node.createdAt === 'string'));
 }
+function isRepositoryIssueEventFeedResponseItem(value) {
+    if (!isRecord(value))
+        return false;
+    const issue = value.issue;
+    return (typeof value.event === 'string' &&
+        typeof value.created_at === 'string' &&
+        isRecord(issue) &&
+        typeof issue.number === 'number');
+}
+function isRepositoryIssueEventFeedResponse(value) {
+    return (Array.isArray(value) && value.every(isRepositoryIssueEventFeedResponseItem));
+}
 function listGraphqlResponseErrors(value) {
     if (!isRecord(value))
         return [];
@@ -537,7 +552,7 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                 project = freshProject;
             }
             catch (error) {
-                if (!isFullFetch && cache !== null) {
+                if (cache !== null && (!isFullFetch || (0, isTransientApiError_1.isTransientApiError)(error))) {
                     console.warn(`Failed to refresh project metadata, using cached. projectId: ${projectId}, error: ${String(error)}`);
                     project = cache.project;
                 }
@@ -557,6 +572,7 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                 storyOptionsChanged ||
                 cacheHasIssuesMissingStoryOptionIdSchema;
             if (effectiveIsFullFetch) {
+                const projectMetadataFellBackToCache = cache !== null && project === cache.project;
                 const itemIdsKnownBeforeFetch = new Set(cache?.issues.map((issue) => issue.itemId) ?? []);
                 const items = await this.graphqlProjectItemRepository.fetchProjectItems(projectId);
                 const cachedIssuesKnownBeforeFetch = cache?.issues ?? [];
@@ -584,7 +600,11 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                     return { mergedIssues: reconciledIssues, mergedProject };
                 });
                 this.lastIssuesFetchedAtByProjectId.set(projectId, nowIso);
-                return { issues, project: mergedProject, cacheUsed: false };
+                return {
+                    issues,
+                    project: mergedProject,
+                    cacheUsed: projectMetadataFellBackToCache,
+                };
             }
             const itemIdsKnownBeforeFetch = new Set(cache.issues.map((issue) => issue.itemId));
             const lastFetchedAt = new Date(cache.lastFetchedAt);
@@ -1699,21 +1719,33 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
             const resolved = new Map();
             for (let start = 0; start < references.length; start += RELATED_OPEN_PULL_REQUEST_URLS_BATCH_SIZE) {
                 const batchReferences = references.slice(start, start + RELATED_OPEN_PULL_REQUEST_URLS_BATCH_SIZE);
-                let prUrlsByIssueUrl;
-                try {
-                    prUrlsByIssueUrl =
-                        await this.fetchRelatedOpenPrUrlsInOneQuery(batchReferences);
-                }
-                catch (error) {
-                    console.warn(`ApiV3CheerioRestIssueRepository: batched related open pull request query failed, leaving ${batchReferences.length} issue(s) to per-issue resolution. error: ${error instanceof Error ? error.message : String(error)}`);
-                    continue;
-                }
+                const prUrlsByIssueUrl = await this.resolveRelatedOpenPrUrlsByBisectingFailedBatches(batchReferences);
                 for (const [issueUrl, prUrls] of prUrlsByIssueUrl) {
                     resolved.set(issueUrl, prUrls);
                 }
             }
             return resolved;
         };
+        this.resolveRelatedOpenPrUrlsByBisectingFailedBatches = async (references) => {
+            try {
+                return await this.fetchRelatedOpenPrUrlsInOneQuery(references);
+            }
+            catch (error) {
+                const errorMessage = error instanceof Error ? error.message : String(error);
+                if (references.length === 1) {
+                    console.warn(`ApiV3CheerioRestIssueRepository: related open pull request query failed for issue ${references[0].issueUrl}, leaving it unresolved. error: ${errorMessage}`);
+                    return new Map();
+                }
+                const splitPoint = Math.ceil(references.length / 2);
+                const firstHalfResolved = await this.resolveRelatedOpenPrUrlsByBisectingFailedBatches(references.slice(0, splitPoint));
+                const secondHalfResolved = await this.resolveRelatedOpenPrUrlsByBisectingFailedBatches(references.slice(splitPoint));
+                const merged = new Map(firstHalfResolved);
+                for (const [issueUrl, prUrls] of secondHalfResolved) {
+                    merged.set(issueUrl, prUrls);
+                }
+                return merged;
+            }
+        };
         this.fetchRelatedOpenPrUrlsInOneQuery = async (references) => {
             const aliasOf = (index) => `issue${index}`;
             const variableDeclarations = references
@@ -2099,7 +2131,12 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
             if (issueEventListingScan.listingOutcome === 'listedEveryEvent') {
                 return issueEventListingScan.latestReopenedEventAt;
             }
-            return this.fetchLatestReopenedTimelineItemCreatedAt(issue);
+            const latestReopenedTimelineItemListing = await this.fetchLatestReopenedTimelineItemListing(issue);
+            if (latestReopenedTimelineItemListing.listingOutcome ===
+                'listedEveryReopenedTimelineItem') {
+                return latestReopenedTimelineItemListing.latestReopenedTimelineItemCreatedAt;
+            }
+            return this.scanRepositoryIssueEventFeedForLatestReopenedEventAt(issue, latestReopenedTimelineItemListing.lastListedReopenedTimelineItemCreatedAt);
         };
         this.scanIssueEventListingForLatestReopenedEventAt = async (issue) => {
             const { owner, repo, issueNumber } = this.parseIssueUrl(issue.url);
@@ -2146,13 +2183,14 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
             }
             return { listingOutcome: 'listedEveryEvent', latestReopenedEventAt };
         };
-        this.fetchLatestReopenedTimelineItemCreatedAt = async (issue) => {
+        this.fetchLatestReopenedTimelineItemListing = async (issue) => {
             const { owner, repo, issueNumber } = this.parseIssueUrl(issue.url);
             const query = `
       query IssueLatestReopenedTimelineItem($owner: String!, $repo: String!, $issueNumber: Int!) {
         repository(owner: $owner, name: $repo) {
           issue(number: $issueNumber) {
             timelineItems(last: 1, itemTypes: [REOPENED_EVENT]) {
+              totalCount
               nodes {
                 ... on ReopenedEvent {
                   createdAt
@@ -2179,12 +2217,65 @@ class ApiV3CheerioRestIssueRepository extends BaseGitHubRepository_1.BaseGitHubR
                 throw new Error(`GitHub GraphQL API returned errors for the latest reopened timeline item of issue ${issue.url}: ${JSON.stringify(graphqlErrors)}`);
             }
             if (!isIssueLatestReopenedTimelineItemResponse(responseBody)) {
-                throw new Error(`GitHub GraphQL API returned no timeline items for issue ${issue.url}`);
+                throw new Error(`GitHub GraphQL API returned no reopened timeline items with a totalCount for issue ${issue.url}`);
+            }
+            const { totalCount: reopenedTimelineItemTotalCount, nodes: reopenedTimelineItems, } = responseBody.data.repository.issue.timelineItems;
+            const lastListedReopenedTimelineItemCreatedAt = reopenedTimelineItems.length === 0
+                ? null
+                : new Date(reopenedTimelineItems[reopenedTimelineItems.length - 1].createdAt);
+            if (reopenedTimelineItemTotalCount <
+                REOPENED_TIMELINE_ITEM_COUNT_AT_WHICH_GITHUB_STOPS_LISTING_REOPENED_TIMELINE_ITEMS) {
+                return {
+                    listingOutcome: 'listedEveryReopenedTimelineItem',
+                    latestReopenedTimelineItemCreatedAt: lastListedReopenedTimelineItemCreatedAt,
+                };
             }
-            const reopenedTimelineItems = responseBody.data.repository.issue.timelineItems.nodes;
-            if (reopenedTimelineItems.length === 0)
-                return null;
-            return new Date(reopenedTimelineItems[reopenedTimelineItems.length - 1].createdAt);
+            if (lastListedReopenedTimelineItemCreatedAt === null) {
+                throw new Error(`GitHub GraphQL API reported ${reopenedTimelineItemTotalCount} reopened timeline items but listed none for issue ${issue.url}`);
+            }
+            return {
+                listingOutcome: 'stoppedAtGitHubReopenedTimelineItemListingLimit',
+                lastListedReopenedTimelineItemCreatedAt,
+            };
+        };
+        this.scanRepositoryIssueEventFeedForLatestReopenedEventAt = async (issue, lastListedReopenedTimelineItemCreatedAt) => {
+            const { owner, repo, issueNumber } = this.parseIssueUrl(issue.url);
+            const ownerSegment = encodeURIComponent(owner);
+            const repoSegment = encodeURIComponent(repo);
+            let page = 1;
+            let hasNextPage = true;
+            while (hasNextPage) {
+                const repositoryIssueEventFeedUrl = `https://api.github.com/repos/${ownerSegment}/${repoSegment}/issues/events?per_page=${ISSUE_EVENTS_PAGE_SIZE}&page=${page}`;
+                const response = await this.fetchWithRateLimitRetry(() => fetch(repositoryIssueEventFeedUrl, {
+                    method: 'GET',
+                    headers: {
+                        Authorization: `Bearer ${this.ghToken}`,
+                        Accept: 'application/vnd.github+json',
+                    },
+                }), { method: 'GET', path: (0, githubRestClient_1.sanitizeRestPath)(repositoryIssueEventFeedUrl) });
+                if (!response.ok) {
+                    const reason = await this.formatGitHubErrorWithStatus(response);
+                    throw new Error(`Failed to fetch page ${page} of the repository issue event feed of ${owner}/${repo} for issue ${issue.url}: ${reason}`);
+                }
+                const body = await response.json();
+                if (!isRepositoryIssueEventFeedResponse(body)) {
+                    throw new Error(`Unexpected response shape when fetching page ${page} of the repository issue event feed of ${owner}/${repo} for issue ${issue.url}`);
+                }
+                for (const feedEvent of body) {
+                    const feedEventCreatedAt = new Date(feedEvent.created_at);
+                    if (feedEventCreatedAt < lastListedReopenedTimelineItemCreatedAt) {
+                        return lastListedReopenedTimelineItemCreatedAt;
+                    }
+                    if (feedEvent.event === 'reopened' &&
+                        feedEvent.issue.number === issueNumber) {
+                        return feedEventCreatedAt;
+                    }
+                }
+                const linkHeader = response.headers.get('Link') ?? '';
+                hasNextPage = linkHeader.includes('rel="next"');
+                page++;
+            }
+            throw new Error(`The repository issue event feed of ${owner}/${repo} ended before listing a reopened event of issue ${issue.url} or an event earlier than its last listed reopened timeline item created at ${lastListedReopenedTimelineItemCreatedAt.toISOString()}`);
         };
         this.getPullRequestChangedFilePaths = async (prUrl) => {
             const { owner, repo, issueNumber: prNumber } = this.parseIssueUrl(prUrl);