github-issue-tower-defence-management 2.15.0 → 2.17.0

package/src/adapter/entry-points/console/ui/src/features/console/components/layout/ConsoleTabList.test.tsx

@@ -78,6 +78,22 @@ describe('ConsoleTabList', () => {
     expect(container.querySelector('.console-tab-count-heading')).toBeNull();
   });
 
+  it('renders the project switcher button before the first tab in the DOM', () => {
+    const { container } = render(
+      <ConsoleTabList {...baseProps} activeTab="prs" counts={counts} />,
+    );
+    const nav = container.querySelector('nav.console-tabbar');
+    const children = Array.from(nav?.children ?? []);
+    const pjnameIndex = children.findIndex((el) =>
+      el.classList.contains('console-tab-pjname'),
+    );
+    const firstTabIndex = children.findIndex((el) =>
+      el.classList.contains('console-tab'),
+    );
+    expect(pjnameIndex).toBeGreaterThanOrEqual(0);
+    expect(firstTabIndex).toBeGreaterThan(pjnameIndex);
+  });
+
   it('renders the Workflow Blocker tab immediately left of Awaiting Quality Check', () => {
     const { getByText } = render(
       <ConsoleTabList {...baseProps} activeTab="prs" counts={counts} />,
@@ -250,4 +266,67 @@ describe('ConsoleTabList', () => {
     );
     expect(baseElement.querySelector('.console-airplane-mode')).toBeNull();
   });
+
+  it('positions the dropdown left-anchored to the button when opened', () => {
+    const { getByRole, baseElement } = render(
+      <ConsoleTabList {...baseProps} activeTab="prs" counts={counts} />,
+    );
+    const btn = getByRole('button', { name: /acme/i });
+    jest.spyOn(btn, 'getBoundingClientRect').mockReturnValue({
+      left: 42,
+      right: 120,
+      bottom: 50,
+      top: 20,
+      width: 78,
+      height: 30,
+      x: 42,
+      y: 20,
+      toJSON: () => ({}),
+    } as DOMRect);
+    fireEvent.click(btn);
+    const dropdown = baseElement.querySelector(
+      '.console-tab-pjname-dropdown',
+    ) as HTMLElement;
+    expect(dropdown.style.left).toBe('42px');
+    expect(dropdown.style.right).toBe('');
+  });
+
+  it('renders a workflow improvement link that opens in a new tab when workflowImprovementIssueUrl is set', () => {
+    const url = 'https://github.com/owner/repo/issues/new?assignees=someone';
+    const { getByRole } = render(
+      <ConsoleTabList
+        {...baseProps}
+        activeTab="prs"
+        counts={counts}
+        workflowImprovementIssueUrl={url}
+      />,
+    );
+    const link = getByRole('link', { name: /workflow improvement/i });
+    expect(link).toHaveAttribute('href', url);
+    expect(link).toHaveAttribute('target', '_blank');
+    expect(link).toHaveAttribute('rel', 'noreferrer');
+  });
+
+  it('does not render the workflow improvement link when workflowImprovementIssueUrl is null', () => {
+    const { container } = render(
+      <ConsoleTabList
+        {...baseProps}
+        activeTab="prs"
+        counts={counts}
+        workflowImprovementIssueUrl={null}
+      />,
+    );
+    expect(
+      container.querySelector('.console-tab-workflow-improvement-link'),
+    ).toBeNull();
+  });
+
+  it('does not render the workflow improvement link when workflowImprovementIssueUrl is not provided', () => {
+    const { container } = render(
+      <ConsoleTabList {...baseProps} activeTab="prs" counts={counts} />,
+    );
+    expect(
+      container.querySelector('.console-tab-workflow-improvement-link'),
+    ).toBeNull();
+  });
 });

package/src/adapter/entry-points/console/ui/src/features/console/components/layout/ConsoleTabList.tsx

@@ -25,6 +25,7 @@ export type ConsoleTabBarProps = {
   airplaneModeFailures: string[];
   onAirplaneModeStartSync: () => void;
   onAirplaneModeTurnOff: () => void;
+  workflowImprovementIssueUrl?: string | null;
 };
 
 export const ConsoleTabList = ({
@@ -45,11 +46,12 @@ export const ConsoleTabList = ({
   airplaneModeFailures,
   onAirplaneModeStartSync,
   onAirplaneModeTurnOff,
+  workflowImprovementIssueUrl = null,
 }: ConsoleTabBarProps) => {
   const [isDropdownOpen, setIsDropdownOpen] = useState(false);
   const [dropdownPos, setDropdownPos] = useState<{
     top: number;
-    right: number;
+    left: number;
   } | null>(null);
   const buttonRef = useRef<HTMLButtonElement>(null);
   const dropdownRef = useRef<HTMLDivElement>(null);
@@ -77,7 +79,7 @@ export const ConsoleTabList = ({
       const rect = buttonRef.current.getBoundingClientRect();
       setDropdownPos({
         top: rect.bottom + 4,
-        right: window.innerWidth - rect.right,
+        left: rect.left,
       });
     }
     setIsDropdownOpen((prev) => !prev);
@@ -85,44 +87,6 @@ export const ConsoleTabList = ({
 
   return (
     <nav aria-label="Console tabs" className="console-tabbar">
-      {CONSOLE_TABS.filter((tab) => {
-        const count = counts[tab.name] ?? 0;
-        return count > 0 || tab.name === activeTab;
-      }).map((tab) => {
-        const count = counts[tab.name] ?? 0;
-        const isActive = tab.name === activeTab;
-        return (
-          <a
-            key={tab.name}
-            href={tabHref(tab.name)}
-            className="console-tab"
-            data-active={isActive ? 'true' : undefined}
-            aria-current={isActive ? 'page' : undefined}
-            onClick={(event) => {
-              if (
-                event.defaultPrevented ||
-                event.button !== 0 ||
-                event.metaKey ||
-                event.ctrlKey ||
-                event.shiftKey ||
-                event.altKey
-              ) {
-                return;
-              }
-              event.preventDefault();
-              onSelectTab(tab.name);
-            }}
-          >
-            <span className="console-tab-label">{tab.label}</span>
-            <span
-              className="console-tab-badge"
-              data-zero={count === 0 ? 'true' : undefined}
-            >
-              {count}
-            </span>
-          </a>
-        );
-      })}
       {pjcode !== null && (
         <div className="console-tab-pjname">
           <button
@@ -149,7 +113,7 @@ export const ConsoleTabList = ({
                 style={{
                   position: 'fixed',
                   top: dropdownPos.top,
-                  right: dropdownPos.right,
+                  left: dropdownPos.left,
                 }}
               >
                 {pjcodes.map((code) => (
@@ -172,6 +136,44 @@ export const ConsoleTabList = ({
             )}
         </div>
       )}
+      {CONSOLE_TABS.filter((tab) => {
+        const count = counts[tab.name] ?? 0;
+        return count > 0 || tab.name === activeTab;
+      }).map((tab) => {
+        const count = counts[tab.name] ?? 0;
+        const isActive = tab.name === activeTab;
+        return (
+          <a
+            key={tab.name}
+            href={tabHref(tab.name)}
+            className="console-tab"
+            data-active={isActive ? 'true' : undefined}
+            aria-current={isActive ? 'page' : undefined}
+            onClick={(event) => {
+              if (
+                event.defaultPrevented ||
+                event.button !== 0 ||
+                event.metaKey ||
+                event.ctrlKey ||
+                event.shiftKey ||
+                event.altKey
+              ) {
+                return;
+              }
+              event.preventDefault();
+              onSelectTab(tab.name);
+            }}
+          >
+            <span className="console-tab-label">{tab.label}</span>
+            <span
+              className="console-tab-badge"
+              data-zero={count === 0 ? 'true' : undefined}
+            >
+              {count}
+            </span>
+          </a>
+        );
+      })}
       {generatedAt !== null && airplaneModeStatus !== 'on' && (
         <span
           className="console-tab-geninfo"
@@ -183,6 +185,17 @@ export const ConsoleTabList = ({
       {settingsButton !== undefined && (
         <span className="console-tab-settings">{settingsButton}</span>
       )}
+      {workflowImprovementIssueUrl !== null && (
+        <a
+          href={workflowImprovementIssueUrl}
+          target="_blank"
+          rel="noreferrer"
+          className="console-tab-workflow-improvement-link"
+          aria-label="Open workflow improvement issue"
+        >
+          ⚡
+        </a>
+      )}
       {airplaneModeEnabled && (
         <ConsoleAirplaneModeButton
           status={airplaneModeStatus}

package/src/adapter/entry-points/console/ui/src/features/console/hooks/useConsoleProjectList.test.ts

@@ -6,7 +6,7 @@ describe('useConsoleProjectList', () => {
     jest.restoreAllMocks();
   });
 
-  it('starts in loading state with empty pjcodes and no error', () => {
+  it('starts in loading state with empty pjcodes, null workflowImprovementIssueUrl and no error', () => {
     global.fetch = jest.fn(
       () => new Promise(() => undefined),
     ) as unknown as typeof fetch;
@@ -14,6 +14,7 @@ describe('useConsoleProjectList', () => {
     const { result } = renderHook(() => useConsoleProjectList());
     expect(result.current.isLoading).toBe(true);
     expect(result.current.pjcodes).toEqual([]);
+    expect(result.current.workflowImprovementIssueUrl).toBeNull();
     expect(result.current.error).toBeNull();
   });
 
@@ -29,6 +30,28 @@ describe('useConsoleProjectList', () => {
       expect(result.current.isLoading).toBe(false);
     });
     expect(result.current.pjcodes).toEqual(['acme', 'beta']);
+    expect(result.current.workflowImprovementIssueUrl).toBeNull();
+    expect(result.current.error).toBeNull();
+  });
+
+  it('populates workflowImprovementIssueUrl when the server returns it', async () => {
+    global.fetch = jest.fn(async () => ({
+      ok: true,
+      status: 200,
+      json: async () => ({
+        pjcodes: ['acme'],
+        workflowImprovementIssueUrl: 'https://github.com/owner/repo/issues/new',
+      }),
+    })) as unknown as typeof fetch;
+
+    const { result } = renderHook(() => useConsoleProjectList());
+    await waitFor(() => {
+      expect(result.current.isLoading).toBe(false);
+    });
+    expect(result.current.pjcodes).toEqual(['acme']);
+    expect(result.current.workflowImprovementIssueUrl).toBe(
+      'https://github.com/owner/repo/issues/new',
+    );
     expect(result.current.error).toBeNull();
   });
 

package/src/adapter/entry-points/console/ui/src/features/console/hooks/useConsoleProjectList.ts

@@ -3,12 +3,15 @@ import { fetchProjectList } from '../lib/consoleApi';
 
 export type ConsoleProjectListState = {
   pjcodes: string[];
+  workflowImprovementIssueUrl: string | null;
   isLoading: boolean;
   error: Error | null;
 };
 
 export const useConsoleProjectList = (): ConsoleProjectListState => {
   const [pjcodes, setPjcodes] = useState<string[]>([]);
+  const [workflowImprovementIssueUrl, setWorkflowImprovementIssueUrl] =
+    useState<string | null>(null);
   const [isLoading, setIsLoading] = useState(true);
   const [error, setError] = useState<Error | null>(null);
 
@@ -18,9 +21,10 @@ export const useConsoleProjectList = (): ConsoleProjectListState => {
     setError(null);
 
     fetchProjectList()
-      .then((list) => {
+      .then((result) => {
         if (!cancelled) {
-          setPjcodes(list);
+          setPjcodes(result.pjcodes);
+          setWorkflowImprovementIssueUrl(result.workflowImprovementIssueUrl);
           setIsLoading(false);
         }
       })
@@ -36,5 +40,5 @@ export const useConsoleProjectList = (): ConsoleProjectListState => {
     };
   }, []);
 
-  return { pjcodes, isLoading, error };
+  return { pjcodes, workflowImprovementIssueUrl, isLoading, error };
 };

package/src/adapter/entry-points/console/ui/src/features/console/lib/consoleApi.ts

@@ -482,7 +482,12 @@ export const postConsoleReorderStory = async (
   }
 };
 
-export const fetchProjectList = async (): Promise<string[]> => {
+export type ProjectListResponse = {
+  pjcodes: string[];
+  workflowImprovementIssueUrl: string | null;
+};
+
+export const fetchProjectList = async (): Promise<ProjectListResponse> => {
   const response = await fetch('/api/projects');
   if (!response.ok) {
     throw new Error(`HTTP ${response.status}`);
@@ -493,13 +498,17 @@ export const fetchProjectList = async (): Promise<string[]> => {
     typeof payload !== 'object' ||
     Array.isArray(payload)
   ) {
-    return [];
+    return { pjcodes: [], workflowImprovementIssueUrl: null };
   }
   const record = payload as Record<string, unknown>;
-  if (!Array.isArray(record.pjcodes)) {
-    return [];
-  }
-  return record.pjcodes.filter(
-    (entry): entry is string => typeof entry === 'string',
-  );
+  const pjcodes = Array.isArray(record.pjcodes)
+    ? record.pjcodes.filter(
+        (entry): entry is string => typeof entry === 'string',
+      )
+    : [];
+  const workflowImprovementIssueUrl =
+    typeof record.workflowImprovementIssueUrl === 'string'
+      ? record.workflowImprovementIssueUrl
+      : null;
+  return { pjcodes, workflowImprovementIssueUrl };
 };

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.tsx

@@ -101,7 +101,11 @@ export const ConsolePage = () => {
     toggleDraftTimerMode,
     changeDraftMinutes,
   } = useConsoleTimerSettings();
-  const { pjcodes, isLoading: isLoadingPjcodes } = useConsoleProjectList();
+  const {
+    pjcodes,
+    workflowImprovementIssueUrl,
+    isLoading: isLoadingPjcodes,
+  } = useConsoleProjectList();
   const { isTimerExpired } = useConsoleProjectTimer(pjcode);
   const overlayState = useConsoleOverlay(pjcode ?? OVERLAY_NAMESPACE_FALLBACK);
 
@@ -664,6 +668,7 @@ export const ConsolePage = () => {
         airplaneModeFailures={airplaneMode.failures}
         onAirplaneModeStartSync={airplaneMode.startSync}
         onAirplaneModeTurnOff={airplaneMode.turnOff}
+        workflowImprovementIssueUrl={workflowImprovementIssueUrl}
       />
       {activeTab === 'stories' ? (
         <ConsoleStoryList

package/src/adapter/entry-points/console/ui/src/index.css

@@ -100,7 +100,6 @@ body {
 }
 
 .console-tab-pjname {
-  margin-left: auto;
   align-self: center;
   padding: 0 8px;
 }
@@ -158,6 +157,7 @@ body {
 }
 
 .console-tab-geninfo {
+  margin-left: auto;
   align-self: center;
   padding: 0 4px;
   color: #8b949e;