npm - github-issue-tower-defence-management - Versions diffs - 1.94.4 → 1.95.0 - Mend

github-issue-tower-defence-management 1.94.4 → 1.95.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (13) hide show

package/bin/adapter/entry-points/console/ui-dist/index.html CHANGED Viewed

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-fKvnL036.js"></script>
+    <script type="module" crossorigin src="/assets/index-BeJzGnfH.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-CO3Vvzqr.css">
   </head>
   <body>

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "github-issue-tower-defence-management",
-  "version": "1.94.4",
+  "version": "1.95.0",
   "description": "",
   "main": "bin/index.js",
   "scripts": {

package/src/adapter/entry-points/console/ui/src/features/console/components/layout/ConsoleTabList.stories.tsx CHANGED Viewed

@@ -59,6 +59,20 @@ export const ZeroCountActiveTabStaysVisible: Story = {
   },
 };
+export const AfterAutoAdvanceToNextTab: Story = {
+  args: {
+    activeTab: 'unread',
+    counts: {
+      prs: 0,
+      triage: 0,
+      unread: 7,
+      'failed-preparation': 2,
+      'todo-by-human': 4,
+    },
+    onSelectTab: () => {},
+  },
+};
 export const Interactive: Story = {
   render: (args) => {
     const [activeTab, setActiveTab] = useState<ConsoleTabName>('prs');

package/src/adapter/entry-points/console/ui/src/features/console/logic/tabAdvance.test.ts ADDED Viewed

@@ -0,0 +1,48 @@
+import { findNextNonEmptyTabToRight } from './tabAdvance';
+import type { ConsoleTabName } from './types';
+const counts = (
+  overrides: Partial<Record<ConsoleTabName, number>>,
+): Record<ConsoleTabName, number> => ({
+  prs: 0,
+  triage: 0,
+  unread: 0,
+  'failed-preparation': 0,
+  'todo-by-human': 0,
+  ...overrides,
+});
+describe('findNextNonEmptyTabToRight', () => {
+  it('returns the first non-empty tab to the right of the active tab', () => {
+    expect(findNextNonEmptyTabToRight('prs', counts({ unread: 7 }))).toBe(
+      'unread',
+    );
+  });
+  it('skips empty tabs and returns the next non-empty tab further right', () => {
+    expect(
+      findNextNonEmptyTabToRight(
+        'prs',
+        counts({ triage: 0, unread: 0, 'todo-by-human': 4 }),
+      ),
+    ).toBe('todo-by-human');
+  });
+  it('returns the immediately adjacent tab when it is non-empty', () => {
+    expect(
+      findNextNonEmptyTabToRight('prs', counts({ triage: 12, unread: 7 })),
+    ).toBe('triage');
+  });
+  it('returns null when no tab to the right has any items', () => {
+    expect(
+      findNextNonEmptyTabToRight('unread', counts({ prs: 35 })),
+    ).toBeNull();
+  });
+  it('returns null when the active tab is the last tab', () => {
+    expect(
+      findNextNonEmptyTabToRight('todo-by-human', counts({ prs: 35 })),
+    ).toBeNull();
+  });
+});

package/src/adapter/entry-points/console/ui/src/features/console/logic/tabAdvance.ts ADDED Viewed

@@ -0,0 +1,19 @@
+import type { ConsoleTabName } from './types';
+import { CONSOLE_TABS } from './types';
+export const findNextNonEmptyTabToRight = (
+  activeTab: ConsoleTabName,
+  counts: Record<ConsoleTabName, number>,
+): ConsoleTabName | null => {
+  const activeIndex = CONSOLE_TABS.findIndex((tab) => tab.name === activeTab);
+  if (activeIndex === -1) {
+    return null;
+  }
+  for (let index = activeIndex + 1; index < CONSOLE_TABS.length; index += 1) {
+    const candidate = CONSOLE_TABS[index].name;
+    if ((counts[candidate] ?? 0) > 0) {
+      return candidate;
+    }
+  }
+  return null;
+};

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.test.tsx CHANGED Viewed

@@ -128,10 +128,8 @@ describe('ConsolePage', () => {
       await waitFor(() => {
         expect(
-          getByText('Awaiting Quality Check')
-            .closest('a')
-            ?.querySelector('.console-tab-badge')?.textContent,
-        ).toBe('0');
+          getByText('Unread').closest('a')?.getAttribute('aria-current'),
+        ).toBe('page');
       });
     } finally {
       jest.useRealTimers();
@@ -397,3 +395,40 @@ describe('ConsolePage auto-advance', () => {
     }
   });
 });
+describe('ConsolePage auto-advance tab', () => {
+  beforeEach(() => {
+    localStorage.clear();
+    window.history.replaceState({}, '', '/projects/umino/prs?k=token');
+    installFetch();
+  });
+  it('auto-advances to the next non-empty tab on the right after the active tab is driven to zero', async () => {
+    jest.useFakeTimers();
+    try {
+      const { getByText, findByText } = render(<ConsolePage />);
+      await waitFor(() => {
+        expect(getByText('Add serveConsole subcommand')).toBeInTheDocument();
+      });
+      fireEvent.click(getByText('Add serveConsole subcommand'));
+      expect(await findByText('← Back to list')).toBeInTheDocument();
+      fireEvent.click(getByText('Approve'));
+      act(() => {
+        jest.advanceTimersByTime(5100);
+      });
+      await waitFor(() => {
+        expect(
+          getByText('Notify finished issue preparation'),
+        ).toBeInTheDocument();
+      });
+      expect(
+        getByText('Unread').closest('a')?.getAttribute('aria-current'),
+      ).toBe('page');
+    } finally {
+      jest.useRealTimers();
+    }
+  });
+});

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.tsx CHANGED Viewed

@@ -1,4 +1,4 @@
-import { useCallback, useMemo } from 'react';
+import { useCallback, useEffect, useMemo, useRef } from 'react';
 import { ConsoleTabList } from '../components/layout/ConsoleTabList';
 import { ConsoleItemList } from '../components/list/ConsoleItemList';
 import { ConsoleUndoToast } from '../components/operations/ConsoleUndoToast';
@@ -27,6 +27,7 @@ import {
   overlayKeyForItem,
 } from '../logic/overlay';
 import type { ConsoleSwipeDirection } from '../logic/swipe';
+import { findNextNonEmptyTabToRight } from '../logic/tabAdvance';
 import type {
   ConsoleListItem,
   ConsoleOverlayStatus,
@@ -109,6 +110,26 @@ export const ConsolePage = () => {
     );
   }, [selectedItemKey, activeSnapshot]);
+  const activeCount = counts[activeTab];
+  const previousActiveTabCountRef = useRef<{
+    tab: ConsoleTabName;
+    count: number;
+  }>({ tab: activeTab, count: activeCount });
+  useEffect(() => {
+    const previous = previousActiveTabCountRef.current;
+    previousActiveTabCountRef.current = { tab: activeTab, count: activeCount };
+    if (previous.tab !== activeTab) {
+      return;
+    }
+    if (previous.count > 0 && activeCount === 0) {
+      const nextTab = findNextNonEmptyTabToRight(activeTab, counts);
+      if (nextTab !== null) {
+        navigation.selectTab(nextTab);
+        navigation.closeItem();
+      }
+    }
+  }, [activeTab, activeCount, counts, navigation]);
   const overlayStatusForSelected = ((): ConsoleOverlayStatus | null => {
     if (selectedItem === null) {
       return null;
@@ -202,6 +223,13 @@ export const ConsolePage = () => {
         />
       ) : (
         <div className="console-detail-screen" ref={detailScreenRef}>
+          <button
+            type="button"
+            className="console-back-button"
+            onClick={closeItem}
+          >
+            ← Back to list
+          </button>
           <ConsoleItemDetailContainer
             tab={activeTab}
             item={selectedItem}