github-issue-tower-defence-management 1.80.1 → 1.82.0

package/src/domain/usecases/NotifyFinishedIssuePreparationUseCase.test.ts

@@ -3013,5 +3013,66 @@ describe('NotifyFinishedIssuePreparationUseCase', () => {
         'https://github.com/user/repo/pull/1',
       );
     });
+
+    it('should normalize leading slashes in change-target label paths', async () => {
+      setupApprovedPrScenario({ labels: ['change-target:/src/domain'] });
+      mockIssueRepository.getPullRequestChangedFilePaths.mockResolvedValue([
+        'src/domain/entities/Foo.ts',
+      ]);
+
+      await useCase.run({
+        projectUrl: 'https://github.com/users/user/projects/1',
+        issueUrl: 'https://github.com/user/repo/issues/1',
+        thresholdForAutoReject: 3,
+        workflowBlockerResolvedWebhookUrl: null,
+        allowedIssueAuthors: null,
+      });
+
+      expect(mockIssueRepository.approvePullRequest).toHaveBeenCalledWith(
+        'https://github.com/user/repo/pull/1',
+      );
+    });
+
+    it('should expand changeTargetPathAliases when alias matches a change-target label', async () => {
+      setupApprovedPrScenario({ labels: ['change-target:adapters'] });
+      mockIssueRepository.getPullRequestChangedFilePaths.mockResolvedValue([
+        'src/domain/usecases/adapter-interfaces/IssueRepository.ts',
+      ]);
+
+      await useCase.run({
+        projectUrl: 'https://github.com/users/user/projects/1',
+        issueUrl: 'https://github.com/user/repo/issues/1',
+        thresholdForAutoReject: 3,
+        workflowBlockerResolvedWebhookUrl: null,
+        allowedIssueAuthors: null,
+        changeTargetPathAliases: {
+          adapters: 'src/domain/usecases/adapter-interfaces',
+        },
+      });
+
+      expect(mockIssueRepository.approvePullRequest).toHaveBeenCalledWith(
+        'https://github.com/user/repo/pull/1',
+      );
+    });
+
+    it('should not approve when file is outside the alias-expanded path', async () => {
+      setupApprovedPrScenario({ labels: ['change-target:adapters'] });
+      mockIssueRepository.getPullRequestChangedFilePaths.mockResolvedValue([
+        'src/domain/usecases/SomeOtherUseCase.ts',
+      ]);
+
+      await useCase.run({
+        projectUrl: 'https://github.com/users/user/projects/1',
+        issueUrl: 'https://github.com/user/repo/issues/1',
+        thresholdForAutoReject: 3,
+        workflowBlockerResolvedWebhookUrl: null,
+        allowedIssueAuthors: null,
+        changeTargetPathAliases: {
+          adapters: 'src/domain/usecases/adapter-interfaces',
+        },
+      });
+
+      expect(mockIssueRepository.approvePullRequest).not.toHaveBeenCalled();
+    });
   });
 });

package/src/domain/usecases/NotifyFinishedIssuePreparationUseCase.ts

@@ -78,6 +78,7 @@ export class NotifyFinishedIssuePreparationUseCase {
     workflowBlockerResolvedWebhookUrl: string | null;
     allowedIssueAuthors?: string[] | null;
     labelsAsLlmAgentName?: string[] | null;
+    changeTargetPathAliases?: Record<string, string> | null;
   }): Promise<void> => {
     const project = await this.projectRepository.getByUrl(params.projectUrl);
 
@@ -238,6 +239,7 @@ export class NotifyFinishedIssuePreparationUseCase {
       await this.changeTargetPullRequestApprover.approveIfConfined(
         issue.labels,
         approvedPrUrl,
+        params.changeTargetPathAliases,
       );
       issue.status = AWAITING_QUALITY_CHECK_STATUS_NAME;
       await this.issueRepository.update(issue, project);

package/src/domain/usecases/RevertNotReadyReviewQueueIssueUseCase.test.ts

@@ -762,6 +762,42 @@ describe('RevertNotReadyReviewQueueIssueUseCase', () => {
           'https://github.com/user/repo/pull/1',
         );
       });
+
+      it('should expand changeTargetPathAliases when alias matches a change-target label', async () => {
+        setupReadyIssue(['change-target:adapters']);
+        mockIssueRepository.getPullRequestChangedFilePaths.mockResolvedValue([
+          'src/domain/usecases/adapter-interfaces/IssueRepository.ts',
+        ]);
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+          changeTargetPathAliases: {
+            adapters: 'src/domain/usecases/adapter-interfaces',
+          },
+        });
+
+        expect(mockIssueRepository.approvePullRequest).toHaveBeenCalledWith(
+          'https://github.com/user/repo/pull/1',
+        );
+      });
+
+      it('should not approve when file is outside the alias-expanded path', async () => {
+        setupReadyIssue(['change-target:adapters']);
+        mockIssueRepository.getPullRequestChangedFilePaths.mockResolvedValue([
+          'src/domain/usecases/SomeOtherUseCase.ts',
+        ]);
+
+        await useCase.run({
+          projectUrl: 'https://github.com/users/user/projects/1',
+          allowIssueCacheMinutes: 10,
+          changeTargetPathAliases: {
+            adapters: 'src/domain/usecases/adapter-interfaces',
+          },
+        });
+
+        expect(mockIssueRepository.approvePullRequest).not.toHaveBeenCalled();
+      });
     });
   });
 

package/src/domain/usecases/RevertNotReadyReviewQueueIssueUseCase.ts

@@ -44,6 +44,7 @@ export class RevertNotReadyReviewQueueIssueUseCase {
     projectUrl: string;
     allowIssueCacheMinutes: number;
     labelsAsLlmAgentName?: string[] | null;
+    changeTargetPathAliases?: Record<string, string> | null;
   }): Promise<void> => {
     const projectId = await this.projectRepository.findProjectIdByUrl(
       params.projectUrl,
@@ -103,6 +104,7 @@ export class RevertNotReadyReviewQueueIssueUseCase {
       await this.changeTargetPullRequestApprover.approveIfConfined(
         issue.labels,
         approvedPrUrl,
+        params.changeTargetPathAliases,
       );
     }