github-issue-tower-defence-management 1.71.0 → 1.72.0

package/src/adapter/repositories/issue/ApiV3CheerioRestIssueRepository.test.ts

@@ -267,6 +267,145 @@ describe('ApiV3CheerioRestIssueRepository', () => {
     });
   });
 
+  describe('getPullRequestChangedFilePaths', () => {
+    afterEach(() => {
+      jest.restoreAllMocks();
+    });
+
+    it('should fetch a single page of changed files and return their paths', async () => {
+      const fetchSpy = jest
+        .spyOn(global, 'fetch')
+        .mockResolvedValueOnce(
+          new Response(
+            JSON.stringify([
+              { filename: 'src/domain/Foo.ts' },
+              { filename: 'src/domain/Bar.ts' },
+            ]),
+            { status: 200, headers: { 'Content-Type': 'application/json' } },
+          ),
+        );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      const result = await repository.getPullRequestChangedFilePaths(
+        'https://github.com/HiromiShikata/test-repository/pull/42',
+      );
+
+      expect(result).toEqual(['src/domain/Foo.ts', 'src/domain/Bar.ts']);
+      expect(fetchSpy).toHaveBeenCalledTimes(1);
+      expect(fetchSpy).toHaveBeenCalledWith(
+        'https://api.github.com/repos/HiromiShikata/test-repository/pulls/42/files?per_page=100&page=1',
+        expect.objectContaining({ method: 'GET' }),
+      );
+    });
+
+    it('should paginate when a page returns exactly 100 entries and stop when fewer are returned', async () => {
+      const firstPage: { filename: string }[] = [];
+      for (let i = 0; i < 100; i += 1) {
+        firstPage.push({ filename: `src/domain/file${i}.ts` });
+      }
+      const secondPage = [
+        { filename: 'src/domain/extra-a.ts' },
+        { filename: 'src/domain/extra-b.ts' },
+      ];
+      const fetchSpy = jest
+        .spyOn(global, 'fetch')
+        .mockResolvedValueOnce(
+          new Response(JSON.stringify(firstPage), {
+            status: 200,
+            headers: { 'Content-Type': 'application/json' },
+          }),
+        )
+        .mockResolvedValueOnce(
+          new Response(JSON.stringify(secondPage), {
+            status: 200,
+            headers: { 'Content-Type': 'application/json' },
+          }),
+        );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      const result = await repository.getPullRequestChangedFilePaths(
+        'https://github.com/HiromiShikata/test-repository/pull/42',
+      );
+
+      expect(result).toHaveLength(102);
+      expect(result[0]).toBe('src/domain/file0.ts');
+      expect(result[99]).toBe('src/domain/file99.ts');
+      expect(result[100]).toBe('src/domain/extra-a.ts');
+      expect(result[101]).toBe('src/domain/extra-b.ts');
+      expect(fetchSpy).toHaveBeenCalledTimes(2);
+      expect(fetchSpy).toHaveBeenNthCalledWith(
+        1,
+        'https://api.github.com/repos/HiromiShikata/test-repository/pulls/42/files?per_page=100&page=1',
+        expect.objectContaining({ method: 'GET' }),
+      );
+      expect(fetchSpy).toHaveBeenNthCalledWith(
+        2,
+        'https://api.github.com/repos/HiromiShikata/test-repository/pulls/42/files?per_page=100&page=2',
+        expect.objectContaining({ method: 'GET' }),
+      );
+    });
+
+    it('should throw when the API responds with a non-2xx status', async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response('Not Found', {
+          status: 404,
+          statusText: 'Not Found',
+        }),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      await expect(
+        repository.getPullRequestChangedFilePaths(
+          'https://github.com/HiromiShikata/test-repository/pull/42',
+        ),
+      ).rejects.toThrow('404');
+    });
+  });
+
+  describe('approvePullRequest', () => {
+    afterEach(() => {
+      jest.restoreAllMocks();
+    });
+
+    it('should POST an APPROVE review to the GitHub API for the PR', async () => {
+      const fetchSpy = jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response(JSON.stringify({ id: 1, state: 'APPROVED' }), {
+          status: 200,
+          headers: { 'Content-Type': 'application/json' },
+        }),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      await repository.approvePullRequest(
+        'https://github.com/HiromiShikata/test-repository/pull/42',
+      );
+
+      expect(fetchSpy).toHaveBeenCalledWith(
+        'https://api.github.com/repos/HiromiShikata/test-repository/pulls/42/reviews',
+        expect.objectContaining({
+          method: 'POST',
+          body: JSON.stringify({ event: 'APPROVE' }),
+        }),
+      );
+    });
+
+    it('should throw when the API responds with a non-2xx status', async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response('Unprocessable Entity', {
+          status: 422,
+          statusText: 'Unprocessable Entity',
+        }),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      await expect(
+        repository.approvePullRequest(
+          'https://github.com/HiromiShikata/test-repository/pull/42',
+        ),
+      ).rejects.toThrow('422');
+    });
+  });
+
   const createApiV3CheerioRestIssueRepository = () => {
     const apiV3IssueRepository = mock<ApiV3IssueRepository>();
     const restIssueRepository = mock<RestIssueRepository>();

package/src/adapter/repositories/issue/ApiV3CheerioRestIssueRepository.ts

@@ -213,6 +213,16 @@ function isDirectPullRequestResponse(
   return true;
 }
 
+type PullRequestFilesResponseItem = {
+  filename: string;
+};
+
+function isPullRequestFilesResponse(
+  value: unknown,
+): value is PullRequestFilesResponseItem[] {
+  return typia.is<PullRequestFilesResponseItem[]>(value);
+}
+
 const fnmatch = (pattern: string, str: string): boolean => {
   let regexStr = '^';
   let i = 0;
@@ -1095,6 +1105,65 @@ export class ApiV3CheerioRestIssueRepository
     }
   };
 
+  getPullRequestChangedFilePaths = async (prUrl: string): Promise<string[]> => {
+    const { owner, repo, issueNumber: prNumber } = this.parseIssueUrl(prUrl);
+    const perPage = 100;
+    const collectedPaths: string[] = [];
+    let page = 1;
+    let hasMore = true;
+    while (hasMore) {
+      const response = await fetch(
+        `https://api.github.com/repos/${owner}/${repo}/pulls/${prNumber}/files?per_page=${perPage}&page=${page}`,
+        {
+          method: 'GET',
+          headers: {
+            Authorization: `Bearer ${this.ghToken}`,
+            Accept: 'application/vnd.github+json',
+          },
+        },
+      );
+      if (!response.ok) {
+        throw new Error(
+          `Failed to fetch changed files for PR ${prUrl}: HTTP ${response.status}`,
+        );
+      }
+      const body: unknown = await response.json();
+      if (!isPullRequestFilesResponse(body)) {
+        throw new Error(
+          `Unexpected response shape when fetching changed files for PR ${prUrl}`,
+        );
+      }
+      for (const file of body) {
+        collectedPaths.push(file.filename);
+      }
+      if (body.length < perPage) {
+        hasMore = false;
+      } else {
+        page += 1;
+      }
+    }
+    return collectedPaths;
+  };
+
+  approvePullRequest = async (prUrl: string): Promise<void> => {
+    const { owner, repo, issueNumber: prNumber } = this.parseIssueUrl(prUrl);
+    const response = await fetch(
+      `https://api.github.com/repos/${owner}/${repo}/pulls/${prNumber}/reviews`,
+      {
+        method: 'POST',
+        headers: {
+          Authorization: `Bearer ${this.ghToken}`,
+          'Content-Type': 'application/json',
+          Accept: 'application/vnd.github+json',
+        },
+        body: JSON.stringify({ event: 'APPROVE' }),
+      },
+    );
+    if (!response.ok) {
+      throw new Error(`Failed to approve PR ${prUrl}: HTTP ${response.status}`);
+    }
+  };
+
   deletePullRequestBranch = async (
     prUrl: string,
     branchName: string,

package/src/adapter/repositories/issue/GraphqlProjectItemRepository.test.ts

@@ -49,6 +49,24 @@ const extractRequestedFirstFromMockCall = (
   return typeof first === 'number' ? first : undefined;
 };
 
+const extractRequestedQueryFromMockCall = (
+  call: unknown,
+): string | undefined => {
+  if (!Array.isArray(call)) {
+    return undefined;
+  }
+  const second: unknown = call[1];
+  if (!isRecord(second)) {
+    return undefined;
+  }
+  const json: unknown = second.json;
+  if (!isRecord(json)) {
+    return undefined;
+  }
+  const query: unknown = json.query;
+  return typeof query === 'string' ? query : undefined;
+};
+
 const extractErrorMessage = (value: unknown): string => {
   if (value instanceof Error) {
     return value.message;
@@ -477,4 +495,170 @@ describe('GraphqlProjectItemRepository', () => {
       ]);
     });
   });
+
+  describe('fetchProjectItemByUrl', () => {
+    afterEach(() => {
+      mockPost.mockClear();
+    });
+
+    const makeContentNode = (url: string, number: number, title: string) => ({
+      number,
+      title,
+      state: 'OPEN',
+      url,
+      body: 'body text',
+      createdAt: '2024-01-01T00:00:00Z',
+      author: { login: 'octocat' },
+      labels: { nodes: [{ name: 'bug' }] },
+      assignees: { nodes: [{ login: 'octocat' }] },
+      repository: { nameWithOwner: 'owner/repo' },
+      projectItems: {
+        nodes: [
+          {
+            id: `item-${number}`,
+            fieldValues: {
+              nodes: [
+                {
+                  __typename: 'ProjectV2ItemFieldSingleSelectValue',
+                  name: 'Preparation',
+                  field: { name: 'Status' },
+                },
+              ],
+            },
+          },
+        ],
+      },
+    });
+
+    it('should return project item for an issue URL', async () => {
+      const localStorageRepository = new LocalStorageRepository();
+      const repository = new GraphqlProjectItemRepository(
+        localStorageRepository,
+        'dummy-token',
+      );
+
+      mockPost.mockReturnValueOnce(
+        mockJsonResponse({
+          data: {
+            repository: {
+              issue: makeContentNode(
+                'https://github.com/owner/repo/issues/7',
+                7,
+                'Issue Title',
+              ),
+              pullRequest: null,
+            },
+          },
+        }),
+      );
+
+      const result = await repository.fetchProjectItemByUrl(
+        'https://github.com/owner/repo/issues/7',
+      );
+
+      expect(mockPost).toHaveBeenCalledTimes(1);
+      expect(result).not.toBeNull();
+      expect(result?.url).toBe('https://github.com/owner/repo/issues/7');
+      expect(result?.title).toBe('Issue Title');
+      expect(result?.id).toBe('item-7');
+      expect(result?.customFields).toEqual([
+        { name: 'Status', value: 'Preparation' },
+      ]);
+    });
+
+    it('should return project item for a pull request URL when repository.issue is null', async () => {
+      const localStorageRepository = new LocalStorageRepository();
+      const repository = new GraphqlProjectItemRepository(
+        localStorageRepository,
+        'dummy-token',
+      );
+
+      mockPost.mockReturnValueOnce(
+        mockJsonResponse({
+          data: {
+            repository: {
+              issue: null,
+              pullRequest: makeContentNode(
+                'https://github.com/owner/repo/pull/9',
+                9,
+                'PR Title',
+              ),
+            },
+          },
+        }),
+      );
+
+      const result = await repository.fetchProjectItemByUrl(
+        'https://github.com/owner/repo/pull/9',
+      );
+
+      expect(mockPost).toHaveBeenCalledTimes(1);
+      expect(result).not.toBeNull();
+      expect(result?.url).toBe('https://github.com/owner/repo/pull/9');
+      expect(result?.title).toBe('PR Title');
+      expect(result?.id).toBe('item-9');
+      expect(result?.customFields).toEqual([
+        { name: 'Status', value: 'Preparation' },
+      ]);
+    });
+
+    it('should query both issue and pullRequest fields in a single request', async () => {
+      const localStorageRepository = new LocalStorageRepository();
+      const repository = new GraphqlProjectItemRepository(
+        localStorageRepository,
+        'dummy-token',
+      );
+
+      mockPost.mockReturnValueOnce(
+        mockJsonResponse({
+          data: {
+            repository: {
+              issue: null,
+              pullRequest: makeContentNode(
+                'https://github.com/owner/repo/pull/3',
+                3,
+                'PR Title',
+              ),
+            },
+          },
+        }),
+      );
+
+      await repository.fetchProjectItemByUrl(
+        'https://github.com/owner/repo/pull/3',
+      );
+
+      const sentQuery = extractRequestedQueryFromMockCall(
+        mockPost.mock.calls[0],
+      );
+      expect(typeof sentQuery).toBe('string');
+      expect(sentQuery).toContain('issue(number: $number)');
+      expect(sentQuery).toContain('pullRequest(number: $number)');
+    });
+
+    it('should return null when neither issue nor pullRequest exists', async () => {
+      const localStorageRepository = new LocalStorageRepository();
+      const repository = new GraphqlProjectItemRepository(
+        localStorageRepository,
+        'dummy-token',
+      );
+
+      mockPost.mockReturnValueOnce(
+        mockJsonResponse({
+          data: {
+            repository: {
+              issue: null,
+              pullRequest: null,
+            },
+          },
+        }),
+      );
+
+      const result = await repository.fetchProjectItemByUrl(
+        'https://github.com/owner/repo/issues/123',
+      );
+
+      expect(result).toBeNull();
+    });
+  });
 });

package/src/adapter/repositories/issue/GraphqlProjectItemRepository.ts

@@ -665,7 +665,7 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
     issueUrl: string,
   ): Promise<ProjectItem | null> => {
     const { owner, repo, issueNumber } = this.extractIssueFromUrl(issueUrl);
-    const graphql = `query GetIssue($owner: String!, $repo: String!, $number: Int!) {
+    const graphql = `query GetIssueOrPullRequest($owner: String!, $repo: String!, $number: Int!) {
   repository(owner: $owner, name: $repo) {
     issue(number: $number) {
       number
@@ -741,6 +741,80 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
         }
       }
     }
+    pullRequest(number: $number) {
+      number
+      title
+      state
+      url
+      body
+      createdAt
+      author {
+        login
+      }
+      labels(first: 100) {
+        nodes {
+          name
+        }
+      }
+      assignees(first: 20) {
+        nodes {
+          login
+        }
+      }
+      repository {
+        nameWithOwner
+      }
+      projectItems(first: 10) {
+        nodes {
+          id
+          fieldValues(first: 10) {
+            nodes {
+              ... on ProjectV2ItemFieldTextValue {
+                text
+                field {
+                  ... on ProjectV2Field {
+                    name
+                  }
+                }
+              }
+              ... on ProjectV2ItemFieldNumberValue {
+                number
+                id
+                field {
+                  ... on ProjectV2Field {
+                    name
+                  }
+                }
+              }
+              ... on ProjectV2ItemFieldDateValue {
+                date
+                field {
+                  ... on ProjectV2Field {
+                    name
+                  }
+                }
+              }
+              ... on ProjectV2ItemFieldSingleSelectValue {
+                name
+                field {
+                  ... on ProjectV2SingleSelectField {
+                    name
+                  }
+                }
+              }
+              ... on ProjectV2ItemFieldIterationValue {
+                title
+                field {
+                  ... on ProjectV2Field {
+                    name
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    }
   }
 }`;
     const graphqlQuery = {
@@ -751,6 +825,34 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
         number: issueNumber,
       },
     };
+    type ContentNode = {
+      number: number;
+      title: string;
+      state: string;
+      url: string;
+      body: string;
+      createdAt: string;
+      author: { login: string } | null;
+      labels: { nodes: { name: string }[] };
+      assignees: { nodes: { login: string }[] };
+      repository: { nameWithOwner: string };
+      projectItems: {
+        nodes: {
+          id: string;
+          fieldValues: {
+            nodes: {
+              text: string;
+              number: number;
+              date: string;
+              name: string;
+              field: {
+                name: string;
+              };
+            }[];
+          };
+        }[];
+      };
+    };
     const response = await ky
       .post('https://api.github.com/graphql', {
         json: graphqlQuery,
@@ -761,34 +863,8 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
       .json<{
         data?: {
           repository: {
-            issue: {
-              number: number;
-              title: string;
-              state: string;
-              url: string;
-              body: string;
-              createdAt: string;
-              author: { login: string } | null;
-              labels: { nodes: { name: string }[] };
-              assignees: { nodes: { login: string }[] };
-              repository: { nameWithOwner: string };
-              projectItems: {
-                nodes: {
-                  id: string;
-                  fieldValues: {
-                    nodes: {
-                      text: string;
-                      number: number;
-                      date: string;
-                      name: string;
-                      field: {
-                        name: string;
-                      };
-                    }[];
-                  };
-                }[];
-              };
-            };
+            issue: ContentNode | null;
+            pullRequest: ContentNode | null;
           };
         };
         errors?: { message: string }[];
@@ -802,40 +878,27 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
       );
     }
     const data = response.data;
-    if (!data.repository.issue) {
+    const content = data.repository.issue ?? data.repository.pullRequest;
+    if (!content) {
       return null;
     }
-    const projectItems: {
-      id: string;
-      fieldValues: {
-        nodes: {
-          text: string;
-          number: number;
-          date: string;
-          name: string;
-          field: {
-            name: string;
-          };
-        }[];
-      };
-    }[] = data.repository.issue.projectItems.nodes;
+    const projectItems = content.projectItems.nodes;
     const item = projectItems[0];
     if (!item) {
       throw new Error(`No project item found for issue ${issueUrl}`);
     }
     return {
       id: item.id,
-      nameWithOwner: data.repository.issue.repository.nameWithOwner,
-      number: data.repository.issue.number,
-      title: data.repository.issue.title,
-      state: this.convertStrToState(data.repository.issue.state),
-      url: data.repository.issue.url,
-      body: data.repository.issue.body,
-      labels: data.repository.issue.labels?.nodes?.map((l) => l.name) || [],
-      assignees:
-        data.repository.issue.assignees?.nodes?.map((a) => a.login) || [],
-      createdAt: data.repository.issue.createdAt || new Date().toISOString(),
-      author: data.repository.issue.author?.login || '',
+      nameWithOwner: content.repository.nameWithOwner,
+      number: content.number,
+      title: content.title,
+      state: this.convertStrToState(content.state),
+      url: content.url,
+      body: content.body,
+      labels: content.labels?.nodes?.map((l) => l.name) || [],
+      assignees: content.assignees?.nodes?.map((a) => a.login) || [],
+      createdAt: content.createdAt || new Date().toISOString(),
+      author: content.author?.login || '',
       customFields: item.fieldValues.nodes
         .filter((field) => !!field.field)
         .map((field) => {