github-issue-tower-defence-management 1.70.0 → 1.71.1

package/src/adapter/entry-points/cli/index.ts

@@ -19,6 +19,7 @@ import { StartPreparationUseCase } from '../../../domain/usecases/StartPreparati
 import { writeRotationOrderFile } from '../handlers/rotationOrderFileWriter';
 import { ProxyClaudeTokenUsageRepository } from '../../repositories/ProxyClaudeTokenUsageRepository';
 import { NotifyFinishedIssuePreparationUseCase } from '../../../domain/usecases/NotifyFinishedIssuePreparationUseCase';
+import { CheckIssueReviewReadinessUseCase } from '../../../domain/usecases/CheckIssueReviewReadinessUseCase';
 import { LocalStorageRepository } from '../../repositories/LocalStorageRepository';
 import { GraphqlProjectRepository } from '../../repositories/GraphqlProjectRepository';
 import { ApiV3IssueRepository } from '../../repositories/issue/ApiV3IssueRepository';
@@ -53,6 +54,12 @@ type NotifyFinishedOptions = {
   configFilePath: string;
 };
 
+type CheckIssueReviewReadinessOptions = {
+  issueUrl: string;
+  projectUrl?: string;
+  configFilePath: string;
+};
+
 const buildGithubRepositoryParams = (
   localStorageRepository: LocalStorageRepository,
   token: string,
@@ -444,6 +451,100 @@ program
     });
   });
 
+program
+  .command('checkIssueReviewReadiness')
+  .description(
+    'Check whether an issue is in a review-ready state without mutating any field or posting any comment',
+  )
+  .requiredOption(
+    '--configFilePath <path>',
+    'Path to config file for tower defence management',
+  )
+  .requiredOption('--issueUrl <url>', 'GitHub issue URL')
+  .option('--projectUrl <url>', 'GitHub project URL')
+  .action(async (options: CheckIssueReviewReadinessOptions) => {
+    const token = process.env.GH_TOKEN;
+    if (!token) {
+      console.error('GH_TOKEN environment variable is required');
+      process.exit(1);
+    }
+
+    const configFileValues = loadConfigFile(options.configFilePath);
+
+    const cliOverrides: ConfigFile = {
+      projectUrl: options.projectUrl,
+    };
+
+    const tempProjectUrl =
+      cliOverrides.projectUrl ?? configFileValues.projectUrl;
+
+    let readmeOverrides: ConfigFile = {};
+    if (tempProjectUrl) {
+      const readme = await fetchProjectReadme(tempProjectUrl, token);
+      if (readme) {
+        readmeOverrides = parseProjectReadmeConfig(readme, tempProjectUrl);
+      }
+    }
+
+    const config = mergeConfigs(
+      configFileValues,
+      cliOverrides,
+      readmeOverrides,
+    );
+
+    const projectUrl = config.projectUrl;
+
+    if (!projectUrl) {
+      console.error(
+        'projectUrl is required. Provide via --projectUrl, config file, or project README.',
+      );
+      process.exit(1);
+    }
+
+    const projectName = config.projectName ?? 'default';
+    const localStorageRepository = new LocalStorageRepository();
+    const cachePath = `./tmp/cache/${projectName}`;
+    const localStorageCacheRepository = new LocalStorageCacheRepository(
+      localStorageRepository,
+      cachePath,
+    );
+    const githubRepositoryParams = buildGithubRepositoryParams(
+      localStorageRepository,
+      token,
+    );
+    const projectRepository = new GraphqlProjectRepository(
+      ...githubRepositoryParams,
+    );
+    const apiV3IssueRepository = new ApiV3IssueRepository(
+      ...githubRepositoryParams,
+    );
+    const restIssueRepository = new RestIssueRepository(
+      ...githubRepositoryParams,
+    );
+    const graphqlProjectItemRepository = new GraphqlProjectItemRepository(
+      ...githubRepositoryParams,
+    );
+    const issueRepository = new ApiV3CheerioRestIssueRepository(
+      apiV3IssueRepository,
+      restIssueRepository,
+      graphqlProjectItemRepository,
+      localStorageCacheRepository,
+      ...githubRepositoryParams,
+    );
+
+    const useCase = new CheckIssueReviewReadinessUseCase(
+      projectRepository,
+      issueRepository,
+    );
+
+    const result = await useCase.run({
+      projectUrl,
+      issueUrl: options.issueUrl,
+    });
+
+    process.stdout.write(`${JSON.stringify(result)}\n`);
+  });
+
 /* istanbul ignore next */
 if (process.argv && require.main === module) {
   program.parse(process.argv);

package/src/adapter/repositories/issue/GraphqlProjectItemRepository.test.ts

@@ -49,6 +49,24 @@ const extractRequestedFirstFromMockCall = (
   return typeof first === 'number' ? first : undefined;
 };
 
+const extractRequestedQueryFromMockCall = (
+  call: unknown,
+): string | undefined => {
+  if (!Array.isArray(call)) {
+    return undefined;
+  }
+  const second: unknown = call[1];
+  if (!isRecord(second)) {
+    return undefined;
+  }
+  const json: unknown = second.json;
+  if (!isRecord(json)) {
+    return undefined;
+  }
+  const query: unknown = json.query;
+  return typeof query === 'string' ? query : undefined;
+};
+
 const extractErrorMessage = (value: unknown): string => {
   if (value instanceof Error) {
     return value.message;
@@ -477,4 +495,170 @@ describe('GraphqlProjectItemRepository', () => {
       ]);
     });
   });
+
+  describe('fetchProjectItemByUrl', () => {
+    afterEach(() => {
+      mockPost.mockClear();
+    });
+
+    const makeContentNode = (url: string, number: number, title: string) => ({
+      number,
+      title,
+      state: 'OPEN',
+      url,
+      body: 'body text',
+      createdAt: '2024-01-01T00:00:00Z',
+      author: { login: 'octocat' },
+      labels: { nodes: [{ name: 'bug' }] },
+      assignees: { nodes: [{ login: 'octocat' }] },
+      repository: { nameWithOwner: 'owner/repo' },
+      projectItems: {
+        nodes: [
+          {
+            id: `item-${number}`,
+            fieldValues: {
+              nodes: [
+                {
+                  __typename: 'ProjectV2ItemFieldSingleSelectValue',
+                  name: 'Preparation',
+                  field: { name: 'Status' },
+                },
+              ],
+            },
+          },
+        ],
+      },
+    });
+
+    it('should return project item for an issue URL', async () => {
+      const localStorageRepository = new LocalStorageRepository();
+      const repository = new GraphqlProjectItemRepository(
+        localStorageRepository,
+        'dummy-token',
+      );
+
+      mockPost.mockReturnValueOnce(
+        mockJsonResponse({
+          data: {
+            repository: {
+              issue: makeContentNode(
+                'https://github.com/owner/repo/issues/7',
+                7,
+                'Issue Title',
+              ),
+              pullRequest: null,
+            },
+          },
+        }),
+      );
+
+      const result = await repository.fetchProjectItemByUrl(
+        'https://github.com/owner/repo/issues/7',
+      );
+
+      expect(mockPost).toHaveBeenCalledTimes(1);
+      expect(result).not.toBeNull();
+      expect(result?.url).toBe('https://github.com/owner/repo/issues/7');
+      expect(result?.title).toBe('Issue Title');
+      expect(result?.id).toBe('item-7');
+      expect(result?.customFields).toEqual([
+        { name: 'Status', value: 'Preparation' },
+      ]);
+    });
+
+    it('should return project item for a pull request URL when repository.issue is null', async () => {
+      const localStorageRepository = new LocalStorageRepository();
+      const repository = new GraphqlProjectItemRepository(
+        localStorageRepository,
+        'dummy-token',
+      );
+
+      mockPost.mockReturnValueOnce(
+        mockJsonResponse({
+          data: {
+            repository: {
+              issue: null,
+              pullRequest: makeContentNode(
+                'https://github.com/owner/repo/pull/9',
+                9,
+                'PR Title',
+              ),
+            },
+          },
+        }),
+      );
+
+      const result = await repository.fetchProjectItemByUrl(
+        'https://github.com/owner/repo/pull/9',
+      );
+
+      expect(mockPost).toHaveBeenCalledTimes(1);
+      expect(result).not.toBeNull();
+      expect(result?.url).toBe('https://github.com/owner/repo/pull/9');
+      expect(result?.title).toBe('PR Title');
+      expect(result?.id).toBe('item-9');
+      expect(result?.customFields).toEqual([
+        { name: 'Status', value: 'Preparation' },
+      ]);
+    });
+
+    it('should query both issue and pullRequest fields in a single request', async () => {
+      const localStorageRepository = new LocalStorageRepository();
+      const repository = new GraphqlProjectItemRepository(
+        localStorageRepository,
+        'dummy-token',
+      );
+
+      mockPost.mockReturnValueOnce(
+        mockJsonResponse({
+          data: {
+            repository: {
+              issue: null,
+              pullRequest: makeContentNode(
+                'https://github.com/owner/repo/pull/3',
+                3,
+                'PR Title',
+              ),
+            },
+          },
+        }),
+      );
+
+      await repository.fetchProjectItemByUrl(
+        'https://github.com/owner/repo/pull/3',
+      );
+
+      const sentQuery = extractRequestedQueryFromMockCall(
+        mockPost.mock.calls[0],
+      );
+      expect(typeof sentQuery).toBe('string');
+      expect(sentQuery).toContain('issue(number: $number)');
+      expect(sentQuery).toContain('pullRequest(number: $number)');
+    });
+
+    it('should return null when neither issue nor pullRequest exists', async () => {
+      const localStorageRepository = new LocalStorageRepository();
+      const repository = new GraphqlProjectItemRepository(
+        localStorageRepository,
+        'dummy-token',
+      );
+
+      mockPost.mockReturnValueOnce(
+        mockJsonResponse({
+          data: {
+            repository: {
+              issue: null,
+              pullRequest: null,
+            },
+          },
+        }),
+      );
+
+      const result = await repository.fetchProjectItemByUrl(
+        'https://github.com/owner/repo/issues/123',
+      );
+
+      expect(result).toBeNull();
+    });
+  });
 });

package/src/adapter/repositories/issue/GraphqlProjectItemRepository.ts

@@ -665,7 +665,7 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
     issueUrl: string,
   ): Promise<ProjectItem | null> => {
     const { owner, repo, issueNumber } = this.extractIssueFromUrl(issueUrl);
-    const graphql = `query GetIssue($owner: String!, $repo: String!, $number: Int!) {
+    const graphql = `query GetIssueOrPullRequest($owner: String!, $repo: String!, $number: Int!) {
   repository(owner: $owner, name: $repo) {
     issue(number: $number) {
       number
@@ -741,6 +741,80 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
         }
       }
     }
+    pullRequest(number: $number) {
+      number
+      title
+      state
+      url
+      body
+      createdAt
+      author {
+        login
+      }
+      labels(first: 100) {
+        nodes {
+          name
+        }
+      }
+      assignees(first: 20) {
+        nodes {
+          login
+        }
+      }
+      repository {
+        nameWithOwner
+      }
+      projectItems(first: 10) {
+        nodes {
+          id
+          fieldValues(first: 10) {
+            nodes {
+              ... on ProjectV2ItemFieldTextValue {
+                text
+                field {
+                  ... on ProjectV2Field {
+                    name
+                  }
+                }
+              }
+              ... on ProjectV2ItemFieldNumberValue {
+                number
+                id
+                field {
+                  ... on ProjectV2Field {
+                    name
+                  }
+                }
+              }
+              ... on ProjectV2ItemFieldDateValue {
+                date
+                field {
+                  ... on ProjectV2Field {
+                    name
+                  }
+                }
+              }
+              ... on ProjectV2ItemFieldSingleSelectValue {
+                name
+                field {
+                  ... on ProjectV2SingleSelectField {
+                    name
+                  }
+                }
+              }
+              ... on ProjectV2ItemFieldIterationValue {
+                title
+                field {
+                  ... on ProjectV2Field {
+                    name
+                  }
+                }
+              }
+            }
+          }
+        }
+      }
+    }
   }
 }`;
     const graphqlQuery = {
@@ -751,6 +825,34 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
         number: issueNumber,
       },
     };
+    type ContentNode = {
+      number: number;
+      title: string;
+      state: string;
+      url: string;
+      body: string;
+      createdAt: string;
+      author: { login: string } | null;
+      labels: { nodes: { name: string }[] };
+      assignees: { nodes: { login: string }[] };
+      repository: { nameWithOwner: string };
+      projectItems: {
+        nodes: {
+          id: string;
+          fieldValues: {
+            nodes: {
+              text: string;
+              number: number;
+              date: string;
+              name: string;
+              field: {
+                name: string;
+              };
+            }[];
+          };
+        }[];
+      };
+    };
     const response = await ky
       .post('https://api.github.com/graphql', {
         json: graphqlQuery,
@@ -761,34 +863,8 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
       .json<{
         data?: {
           repository: {
-            issue: {
-              number: number;
-              title: string;
-              state: string;
-              url: string;
-              body: string;
-              createdAt: string;
-              author: { login: string } | null;
-              labels: { nodes: { name: string }[] };
-              assignees: { nodes: { login: string }[] };
-              repository: { nameWithOwner: string };
-              projectItems: {
-                nodes: {
-                  id: string;
-                  fieldValues: {
-                    nodes: {
-                      text: string;
-                      number: number;
-                      date: string;
-                      name: string;
-                      field: {
-                        name: string;
-                      };
-                    }[];
-                  };
-                }[];
-              };
-            };
+            issue: ContentNode | null;
+            pullRequest: ContentNode | null;
           };
         };
         errors?: { message: string }[];
@@ -802,40 +878,27 @@ query GetProjectFields($owner: String!, $repository: String!, $issueNumber: Int!
       );
     }
     const data = response.data;
-    if (!data.repository.issue) {
+    const content = data.repository.issue ?? data.repository.pullRequest;
+    if (!content) {
       return null;
     }
-    const projectItems: {
-      id: string;
-      fieldValues: {
-        nodes: {
-          text: string;
-          number: number;
-          date: string;
-          name: string;
-          field: {
-            name: string;
-          };
-        }[];
-      };
-    }[] = data.repository.issue.projectItems.nodes;
+    const projectItems = content.projectItems.nodes;
     const item = projectItems[0];
     if (!item) {
       throw new Error(`No project item found for issue ${issueUrl}`);
     }
     return {
       id: item.id,
-      nameWithOwner: data.repository.issue.repository.nameWithOwner,
-      number: data.repository.issue.number,
-      title: data.repository.issue.title,
-      state: this.convertStrToState(data.repository.issue.state),
-      url: data.repository.issue.url,
-      body: data.repository.issue.body,
-      labels: data.repository.issue.labels?.nodes?.map((l) => l.name) || [],
-      assignees:
-        data.repository.issue.assignees?.nodes?.map((a) => a.login) || [],
-      createdAt: data.repository.issue.createdAt || new Date().toISOString(),
-      author: data.repository.issue.author?.login || '',
+      nameWithOwner: content.repository.nameWithOwner,
+      number: content.number,
+      title: content.title,
+      state: this.convertStrToState(content.state),
+      url: content.url,
+      body: content.body,
+      labels: content.labels?.nodes?.map((l) => l.name) || [],
+      assignees: content.assignees?.nodes?.map((a) => a.login) || [],
+      createdAt: content.createdAt || new Date().toISOString(),
+      author: content.author?.login || '',
       customFields: item.fieldValues.nodes
         .filter((field) => !!field.field)
         .map((field) => {