github-issue-tower-defence-management 1.39.0 → 1.41.0

package/src/adapter/entry-points/cli/index.ts

@@ -26,9 +26,12 @@ type ConfigFile = {
   awaitingWorkspaceStatus?: string;
   preparationStatus?: string;
   defaultAgentName?: string;
-  logFilePath?: string;
+  defaultLlmModelName?: string;
+  defaultLlmAgentName?: string;
   maximumPreparingIssuesCount?: number;
   allowIssueCacheMinutes?: number;
+  utilizationPercentageThreshold?: number;
+  allowedIssueAuthors?: string;
   awaitingQualityCheckStatus?: string;
   thresholdForAutoReject?: number;
   workflowBlockerResolvedWebhookUrl?: string;
@@ -41,9 +44,12 @@ type StartDaemonOptions = {
   awaitingWorkspaceStatus?: string;
   preparationStatus?: string;
   defaultAgentName?: string;
-  logFilePath?: string;
+  defaultLlmModelName?: string;
+  defaultLlmAgentName?: string;
   maximumPreparingIssuesCount?: string;
   allowIssueCacheMinutes?: string;
+  utilizationPercentageThreshold?: string;
+  allowedIssueAuthors?: string;
   preparationProcessCheckCommand?: string;
   configFilePath: string;
 };
@@ -93,12 +99,18 @@ export const loadConfigFile = (configFilePath: string): ConfigFile => {
       ),
       preparationStatus: getStringValue(parsed, 'preparationStatus'),
       defaultAgentName: getStringValue(parsed, 'defaultAgentName'),
-      logFilePath: getStringValue(parsed, 'logFilePath'),
+      defaultLlmModelName: getStringValue(parsed, 'defaultLlmModelName'),
+      defaultLlmAgentName: getStringValue(parsed, 'defaultLlmAgentName'),
       maximumPreparingIssuesCount: getNumberValue(
         parsed,
         'maximumPreparingIssuesCount',
       ),
       allowIssueCacheMinutes: getNumberValue(parsed, 'allowIssueCacheMinutes'),
+      utilizationPercentageThreshold: getNumberValue(
+        parsed,
+        'utilizationPercentageThreshold',
+      ),
+      allowedIssueAuthors: getStringValue(parsed, 'allowedIssueAuthors'),
       awaitingQualityCheckStatus: getStringValue(
         parsed,
         'awaitingQualityCheckStatus',
@@ -146,12 +158,18 @@ export const parseProjectReadmeConfig = (readme: string): ConfigFile => {
       ),
       preparationStatus: getStringValue(parsed, 'preparationStatus'),
       defaultAgentName: getStringValue(parsed, 'defaultAgentName'),
-      logFilePath: getStringValue(parsed, 'logFilePath'),
+      defaultLlmModelName: getStringValue(parsed, 'defaultLlmModelName'),
+      defaultLlmAgentName: getStringValue(parsed, 'defaultLlmAgentName'),
       maximumPreparingIssuesCount: getNumberValue(
         parsed,
         'maximumPreparingIssuesCount',
       ),
       allowIssueCacheMinutes: getNumberValue(parsed, 'allowIssueCacheMinutes'),
+      utilizationPercentageThreshold: getNumberValue(
+        parsed,
+        'utilizationPercentageThreshold',
+      ),
+      allowedIssueAuthors: getStringValue(parsed, 'allowedIssueAuthors'),
       awaitingQualityCheckStatus: getStringValue(
         parsed,
         'awaitingQualityCheckStatus',
@@ -190,10 +208,14 @@ export const mergeConfigs = (
     readmeOverrides.defaultAgentName ??
     cliOverrides.defaultAgentName ??
     configFile.defaultAgentName,
-  logFilePath:
-    readmeOverrides.logFilePath ??
-    cliOverrides.logFilePath ??
-    configFile.logFilePath,
+  defaultLlmModelName:
+    readmeOverrides.defaultLlmModelName ??
+    cliOverrides.defaultLlmModelName ??
+    configFile.defaultLlmModelName,
+  defaultLlmAgentName:
+    readmeOverrides.defaultLlmAgentName ??
+    cliOverrides.defaultLlmAgentName ??
+    configFile.defaultLlmAgentName,
   maximumPreparingIssuesCount:
     readmeOverrides.maximumPreparingIssuesCount ??
     cliOverrides.maximumPreparingIssuesCount ??
@@ -202,6 +224,14 @@ export const mergeConfigs = (
     readmeOverrides.allowIssueCacheMinutes ??
     cliOverrides.allowIssueCacheMinutes ??
     configFile.allowIssueCacheMinutes,
+  utilizationPercentageThreshold:
+    readmeOverrides.utilizationPercentageThreshold ??
+    cliOverrides.utilizationPercentageThreshold ??
+    configFile.utilizationPercentageThreshold,
+  allowedIssueAuthors:
+    readmeOverrides.allowedIssueAuthors ??
+    cliOverrides.allowedIssueAuthors ??
+    configFile.allowedIssueAuthors,
   awaitingQualityCheckStatus:
     readmeOverrides.awaitingQualityCheckStatus ??
     cliOverrides.awaitingQualityCheckStatus ??
@@ -361,7 +391,8 @@ program
   )
   .option('--preparationStatus <status>', 'Status for issues in preparation')
   .option('--defaultAgentName <name>', 'Default agent name')
-  .option('--logFilePath <path>', 'Path to log file')
+  .option('--defaultLlmModelName <name>', 'Default LLM model name')
+  .option('--defaultLlmAgentName <name>', 'Default LLM agent name')
   .option(
     '--maximumPreparingIssuesCount <count>',
     'Maximum number of issues in preparation status (default: 6)',
@@ -370,6 +401,14 @@ program
     '--allowIssueCacheMinutes <minutes>',
     'Allow cache for issues in minutes (default: 0)',
   )
+  .option(
+    '--utilizationPercentageThreshold <percent>',
+    'Claude utilization percentage threshold (default: 90)',
+  )
+  .option(
+    '--allowedIssueAuthors <authors>',
+    'Comma-separated list of allowed issue authors',
+  )
   .option(
     '--preparationProcessCheckCommand <template>',
     'Shell command template with {URL} placeholder to check if a preparation process is alive',
@@ -388,13 +427,18 @@ program
       awaitingWorkspaceStatus: options.awaitingWorkspaceStatus,
       preparationStatus: options.preparationStatus,
       defaultAgentName: options.defaultAgentName,
-      logFilePath: options.logFilePath,
+      defaultLlmModelName: options.defaultLlmModelName,
+      defaultLlmAgentName: options.defaultLlmAgentName,
       maximumPreparingIssuesCount: options.maximumPreparingIssuesCount
         ? Number(options.maximumPreparingIssuesCount)
         : undefined,
       allowIssueCacheMinutes: options.allowIssueCacheMinutes
         ? Number(options.allowIssueCacheMinutes)
         : undefined,
+      utilizationPercentageThreshold: options.utilizationPercentageThreshold
+        ? Number(options.utilizationPercentageThreshold)
+        : undefined,
+      allowedIssueAuthors: options.allowedIssueAuthors,
       preparationProcessCheckCommand: options.preparationProcessCheckCommand,
     };
 
@@ -419,7 +463,6 @@ program
     const awaitingWorkspaceStatus = config.awaitingWorkspaceStatus;
     const preparationStatus = config.preparationStatus;
     const defaultAgentName = config.defaultAgentName;
-    const logFilePath = config.logFilePath;
 
     if (!projectUrl) {
       console.error(
@@ -484,6 +527,12 @@ program
     const projectRepository = {
       ...new GraphqlProjectRepository(...githubRepositoryParams),
       ...new CheerioProjectRepository(...githubRepositoryParams),
+      prepareStatus: async (
+        _name: string,
+        project: Project,
+      ): Promise<Project> => {
+        return project;
+      },
     };
     const apiV3IssueRepository = new ApiV3IssueRepository(
       ...githubRepositoryParams,
@@ -528,14 +577,26 @@ program
       localCommandRunner,
     );
 
+    const rawAllowedIssueAuthors = config.allowedIssueAuthors;
+    const allowedIssueAuthors = rawAllowedIssueAuthors
+      ? rawAllowedIssueAuthors
+          .split(',')
+          .map((s) => s.trim())
+          .filter(Boolean)
+      : null;
+
     await useCase.run({
       projectUrl,
       awaitingWorkspaceStatus,
       preparationStatus,
       defaultAgentName,
-      logFilePath: logFilePath ?? undefined,
+      defaultLlmModelName: config.defaultLlmModelName ?? null,
+      defaultLlmAgentName: config.defaultLlmAgentName ?? null,
+      configFilePath: options.configFilePath,
       maximumPreparingIssuesCount,
-      allowIssueCacheMinutes,
+      utilizationPercentageThreshold:
+        config.utilizationPercentageThreshold ?? 90,
+      allowedIssueAuthors,
     });
   });
 

package/src/adapter/repositories/NodeLocalCommandRunner.test.ts

@@ -1,11 +1,11 @@
-const mockExecAsync = jest.fn();
+const mockExecFileAsync = jest.fn();
 
 jest.mock('child_process', () => ({
-  exec: jest.fn(),
+  execFile: jest.fn(),
 }));
 
 jest.mock('util', () => ({
-  promisify: jest.fn(() => mockExecAsync),
+  promisify: jest.fn(() => mockExecFileAsync),
 }));
 
 import { NodeLocalCommandRunner } from './NodeLocalCommandRunner';
@@ -20,19 +20,19 @@ describe('NodeLocalCommandRunner', () => {
 
   describe('runCommand', () => {
     it('should execute command successfully', async () => {
-      mockExecAsync.mockResolvedValue({
+      mockExecFileAsync.mockResolvedValue({
         stdout: 'command output',
         stderr: '',
       });
 
-      const result = await runner.runCommand('echo "test"');
+      const result = await runner.runCommand('echo', ['"test"']);
 
       expect(result).toEqual({
         stdout: 'command output',
         stderr: '',
         exitCode: 0,
       });
-      expect(mockExecAsync).toHaveBeenCalledWith('echo "test"');
+      expect(mockExecFileAsync).toHaveBeenCalledWith('echo', ['"test"']);
     });
 
     it('should handle command errors with exit code', async () => {
@@ -41,9 +41,9 @@ describe('NodeLocalCommandRunner', () => {
         stdout: 'partial output',
         stderr: 'error message',
       });
-      mockExecAsync.mockRejectedValue(error);
+      mockExecFileAsync.mockRejectedValue(error);
 
-      const result = await runner.runCommand('invalid-command');
+      const result = await runner.runCommand('invalid-command', []);
 
       expect(result).toEqual({
         stdout: 'partial output',
@@ -58,9 +58,9 @@ describe('NodeLocalCommandRunner', () => {
         stdout: '',
         stderr: 'command not found',
       });
-      mockExecAsync.mockRejectedValue(error);
+      mockExecFileAsync.mockRejectedValue(error);
 
-      const result = await runner.runCommand('nonexistent');
+      const result = await runner.runCommand('nonexistent', []);
 
       expect(result).toEqual({
         stdout: '',
@@ -70,9 +70,9 @@ describe('NodeLocalCommandRunner', () => {
     });
 
     it('should throw error if error format is unexpected', async () => {
-      mockExecAsync.mockRejectedValue(new Error('Unexpected error'));
+      mockExecFileAsync.mockRejectedValue(new Error('Unexpected error'));
 
-      await expect(runner.runCommand('command')).rejects.toThrow(
+      await expect(runner.runCommand('command', [])).rejects.toThrow(
         'Unexpected error',
       );
     });

package/src/adapter/repositories/NodeLocalCommandRunner.ts

@@ -1,17 +1,20 @@
 import { LocalCommandRunner } from '../../domain/usecases/adapter-interfaces/LocalCommandRunner';
-import { exec } from 'child_process';
+import { execFile } from 'child_process';
 import { promisify } from 'util';
 
-const execAsync = promisify(exec);
+const execFileAsync = promisify(execFile);
 
 export class NodeLocalCommandRunner implements LocalCommandRunner {
-  async runCommand(command: string): Promise<{
+  async runCommand(
+    program: string,
+    args: string[],
+  ): Promise<{
     stdout: string;
     stderr: string;
     exitCode: number;
   }> {
     try {
-      const { stdout, stderr } = await execAsync(command);
+      const { stdout, stderr } = await execFileAsync(program, args);
       return {
         stdout,
         stderr,

package/src/adapter/repositories/issue/ApiV3CheerioRestIssueRepository.test.ts

@@ -63,6 +63,7 @@ describe('ApiV3CheerioRestIssueRepository', () => {
           isInProgress: false,
           isClosed: false,
           createdAt: new Date('2024-01-01T00:00:00Z'),
+          author: '',
         },
       },
       {
@@ -114,6 +115,7 @@ describe('ApiV3CheerioRestIssueRepository', () => {
           isInProgress: false,
           isClosed: false,
           createdAt: new Date('2024-01-01T00:00:00Z'),
+          author: '',
         },
       },
     ];
@@ -244,6 +246,7 @@ describe('ApiV3CheerioRestIssueRepository', () => {
         isInProgress: false,
         isClosed: false,
         createdAt: new Date('2024-01-01'),
+        author: '',
       };
       const statusId = 'new-status-id';