github-issue-tower-defence-management 1.197.0 → 1.197.1

package/bin/adapter/entry-points/console/ui-dist/index.html

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-CYwLv9pf.js"></script>
+    <script type="module" crossorigin src="/assets/index-lT5OKx7e.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-CLHvrafO.css">
   </head>
   <body>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "github-issue-tower-defence-management",
-  "version": "1.197.0",
+  "version": "1.197.1",
   "description": "",
   "main": "bin/index.js",
   "scripts": {

package/src/adapter/entry-points/console/consoleDataDelivery.test.ts

@@ -111,12 +111,12 @@ describe('buildConsoleDataResponse', () => {
     expect(response.statusCode).toBe(404);
   });
 
-  it('serves a list file and applies the done exclusion', () => {
+  it('serves a list file without filtering items that have done records', () => {
     writeJson('acme/prs/list.json', {
       pjcode: 'acme',
       items: [
         { projectItemId: 'PVTI_1', title: 'keep' },
-        { projectItemId: 'PVTI_2', title: 'drop' },
+        { projectItemId: 'PVTI_2', title: 'also keep despite done record' },
       ],
     });
     recordDoneProjectItemId(baseDir, 'acme', 'prs', 'PVTI_2');
@@ -129,16 +129,19 @@ describe('buildConsoleDataResponse', () => {
     const parsed: unknown = JSON.parse(response.body);
     expect(parsed).toEqual({
       pjcode: 'acme',
-      items: [{ projectItemId: 'PVTI_1', title: 'keep' }],
+      items: [
+        { projectItemId: 'PVTI_1', title: 'keep' },
+        { projectItemId: 'PVTI_2', title: 'also keep despite done record' },
+      ],
     });
   });
 
-  it('applies the done exclusion to the workflow-blocker list', () => {
+  it('serves the workflow-blocker list without filtering items that have done records', () => {
     writeJson('acme/workflow-blocker/list.json', {
       pjcode: 'acme',
       items: [
         { projectItemId: 'PVTI_1', title: 'keep' },
-        { projectItemId: 'PVTI_2', title: 'processed blocker' },
+        { projectItemId: 'PVTI_2', title: 'also keep despite done record' },
       ],
     });
     recordDoneProjectItemId(baseDir, 'acme', 'workflow-blocker', 'PVTI_2');
@@ -151,7 +154,10 @@ describe('buildConsoleDataResponse', () => {
     const parsed: unknown = JSON.parse(response.body);
     expect(parsed).toEqual({
       pjcode: 'acme',
-      items: [{ projectItemId: 'PVTI_1', title: 'keep' }],
+      items: [
+        { projectItemId: 'PVTI_1', title: 'keep' },
+        { projectItemId: 'PVTI_2', title: 'also keep despite done record' },
+      ],
     });
   });
 

package/src/adapter/entry-points/console/consoleDataDelivery.ts

@@ -1,6 +1,5 @@
 import * as fs from 'fs';
 import * as path from 'path';
-import { readDoneProjectItemIds } from './consoleDoneStore';
 import { CONSOLE_LIST_TAB_NAMES } from './consoleTabNames';
 
 export { CONSOLE_LIST_TAB_NAMES };
@@ -55,9 +54,6 @@ export const parseConsoleDataRoute = (
   return null;
 };
 
-const isRecord = (value: unknown): value is Record<string, unknown> =>
-  value !== null && typeof value === 'object' && !Array.isArray(value);
-
 type ReadJsonResult = { found: false } | { found: true; data: unknown };
 
 const readJsonFile = (filePath: string): ReadJsonResult => {
@@ -75,26 +71,6 @@ const readJsonFile = (filePath: string): ReadJsonResult => {
   return { found: true, data };
 };
 
-const isExcludedItem = (item: unknown, doneSet: Set<string>): boolean => {
-  if (!isRecord(item)) {
-    return false;
-  }
-  const projectItemId = item.projectItemId;
-  return typeof projectItemId === 'string' && doneSet.has(projectItemId);
-};
-
-const applyDoneExclusion = (
-  listData: unknown,
-  doneProjectItemIds: string[],
-): unknown => {
-  if (!isRecord(listData) || !Array.isArray(listData.items)) {
-    return listData;
-  }
-  const doneSet = new Set(doneProjectItemIds);
-  const items = listData.items.filter((item) => !isExcludedItem(item, doneSet));
-  return { ...listData, items };
-};
-
 export type ConsoleDataResponse = {
   statusCode: number;
   contentType: string;
@@ -116,13 +92,7 @@ export const buildConsoleDataResponse = (
     if (!listResult.found) {
       return notFoundJson();
     }
-    const doneProjectItemIds = readDoneProjectItemIds(
-      consoleDataOutputDir,
-      route.pjcode,
-      route.tab,
-    );
-    const filtered = applyDoneExclusion(listResult.data, doneProjectItemIds);
-    return okJson(filtered);
+    return okJson(listResult.data);
   }
   if (route.kind === 'detail') {
     const filePath = path.join(

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.test.ts

@@ -81,33 +81,33 @@ describe('counts driven to zero do not revive on tab switch', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 500, mode: 'prs', done: true },
     };
-    expect(countPendingItems([item(1)], overlay)).toBe(0);
+    expect(countPendingItems([item(1)], overlay, 'prs')).toBe(0);
   });
 
-  it('keeps a done item subtracted from every tab regardless of its mode', () => {
+  it('does not subtract a done item from a tab other than the one it was processed in', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 100, mode: 'triage', done: true },
     };
-    expect(countPendingItems([item(1)], overlay)).toBe(0);
+    expect(countPendingItems([item(1)], overlay, 'prs')).toBe(1);
   });
 
   it('does not revive a done item even when an entry was processed before the snapshot it still appears in', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 100, mode: 'prs', done: true },
     };
-    expect(countPendingItems([item(1)], overlay)).toBe(0);
+    expect(countPendingItems([item(1)], overlay, 'prs')).toBe(0);
   });
 
-  it('does not revive a done item when it appears in a tab other than the one it was processed in', () => {
+  it('shows a done item in a tab other than the one it was processed in', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 100, mode: 'prs', done: true },
     };
-    expect(countPendingItems([item(1)], overlay)).toBe(0);
-    expect(filterPendingItems([item(1)], overlay)).toEqual([]);
+    expect(countPendingItems([item(1)], overlay, 'triage')).toBe(1);
+    expect(filterPendingItems([item(1)], overlay, 'triage')).toEqual([item(1)]);
   });
 
   it('counts an item that has no done entry', () => {
-    expect(countPendingItems([item(1)], {})).toBe(1);
+    expect(countPendingItems([item(1)], {}, 'prs')).toBe(1);
   });
 });
 
@@ -116,7 +116,7 @@ describe('filterPendingItems', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 500, mode: 'prs', done: true },
     };
-    const result = filterPendingItems([item(1), item(2)], overlay);
+    const result = filterPendingItems([item(1), item(2)], overlay, 'prs');
     expect(result.map((entry) => entry.number)).toEqual([2]);
   });
 
@@ -125,8 +125,8 @@ describe('filterPendingItems', () => {
       PVTI_1: { ts: 500, mode: 'prs', done: true },
     };
     const items = [item(1), item(2)];
-    expect(countPendingItems(items, overlay)).toBe(
-      filterPendingItems(items, overlay).length,
+    expect(countPendingItems(items, overlay, 'prs')).toBe(
+      filterPendingItems(items, overlay, 'prs').length,
     );
   });
 });
@@ -136,14 +136,20 @@ describe('workflow-blocker items are filtered by the done overlay like every oth
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
     };
-    expect(countPendingItems([item(1), item(2)], overlay)).toBe(1);
+    expect(
+      countPendingItems([item(1), item(2)], overlay, 'workflow-blocker'),
+    ).toBe(1);
   });
 
   it('removes a processed workflow-blocker item from the list', () => {
     const overlay: ConsoleOverlay = {
       PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
     };
-    const result = filterPendingItems([item(1), item(2)], overlay);
+    const result = filterPendingItems(
+      [item(1), item(2)],
+      overlay,
+      'workflow-blocker',
+    );
     expect(result.map((entry) => entry.number)).toEqual([2]);
   });
 
@@ -152,8 +158,12 @@ describe('workflow-blocker items are filtered by the done overlay like every oth
       PVTI_1: { ts: 100, mode: 'workflow-blocker', done: true },
       PVTI_2: { ts: 100, mode: 'workflow-blocker', done: true },
     };
-    expect(countPendingItems([item(1), item(2)], overlay)).toBe(0);
-    expect(filterPendingItems([item(1), item(2)], overlay)).toEqual([]);
+    expect(
+      countPendingItems([item(1), item(2)], overlay, 'workflow-blocker'),
+    ).toBe(0);
+    expect(
+      filterPendingItems([item(1), item(2)], overlay, 'workflow-blocker'),
+    ).toEqual([]);
   });
 });
 
@@ -171,8 +181,10 @@ describe('overlayEntriesActedSinceSnapshot', () => {
       '2026-08-04T00:26:06Z',
     );
     expect(acted).toEqual({});
-    expect(countPendingItems([item(1)], acted)).toBe(1);
-    expect(filterPendingItems([item(1)], acted)).toEqual([item(1)]);
+    expect(countPendingItems([item(1)], acted, 'todo-by-human')).toBe(1);
+    expect(filterPendingItems([item(1)], acted, 'todo-by-human')).toEqual([
+      item(1),
+    ]);
   });
 
   it('keeps an entry written after the snapshot was generated so the item stays hidden', () => {
@@ -187,7 +199,7 @@ describe('overlayEntriesActedSinceSnapshot', () => {
       overlay,
       '2026-08-04T00:26:06Z',
     );
-    expect(countPendingItems([item(1)], acted)).toBe(0);
+    expect(countPendingItems([item(1)], acted, 'todo-by-human')).toBe(0);
   });
 
   it('keeps an entry written at the exact snapshot generation time', () => {

package/src/adapter/entry-points/console/ui/src/features/console/logic/overlay.ts

@@ -16,19 +16,28 @@ export const isOverlayEntryActed = (
   entry: ConsoleOverlayEntry | undefined,
 ): boolean => entry !== undefined && entry.done === true;
 
+const isActedInTab = (
+  entry: ConsoleOverlayEntry | undefined,
+  currentTab: ConsoleTabName,
+): boolean =>
+  entry !== undefined && entry.done === true && entry.mode === currentTab;
+
 export const countPendingItems = (
   items: ConsoleListItem[],
   overlay: ConsoleOverlay,
+  currentTab: ConsoleTabName,
 ): number =>
-  items.filter((item) => !isOverlayEntryActed(overlay[overlayKeyForItem(item)]))
-    .length;
+  items.filter(
+    (item) => !isActedInTab(overlay[overlayKeyForItem(item)], currentTab),
+  ).length;
 
 export const filterPendingItems = (
   items: ConsoleListItem[],
   overlay: ConsoleOverlay,
+  currentTab: ConsoleTabName,
 ): ConsoleListItem[] =>
   items.filter(
-    (item) => !isOverlayEntryActed(overlay[overlayKeyForItem(item)]),
+    (item) => !isActedInTab(overlay[overlayKeyForItem(item)], currentTab),
   );
 
 export const overlayEntriesActedSinceSnapshot = (

package/src/adapter/entry-points/console/ui/src/features/console/pages/ConsolePage.tsx

@@ -107,6 +107,7 @@ export const ConsolePage = () => {
             overlayState.overlay,
             snapshot.generatedAt,
           ),
+          tab.name,
         );
       }
     }
@@ -151,8 +152,9 @@ export const ConsolePage = () => {
         overlayState.overlay,
         activeSnapshot.generatedAt,
       ),
+      activeTab,
     );
-  }, [activeSnapshot, overlayState.overlay]);
+  }, [activeSnapshot, overlayState.overlay, activeTab]);
 
   const orderedPendingKeys = useMemo(
     () => pendingItems.map((item) => overlayKeyForItem(item)),