github-issue-tower-defence-management 1.187.1 → 1.187.3

package/src/adapter/entry-points/console/ui-dist/index.html

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-wj6o8qvo.js"></script>
+    <script type="module" crossorigin src="/assets/index-DfKDTGzS.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-yZy1TUOo.css">
   </head>
   <body>

package/src/domain/usecases/ProjectRequiredFieldCreateUseCase.test.ts

@@ -652,6 +652,37 @@ describe('ProjectRequiredFieldCreateUseCase', () => {
       expect(projectRepository.updateAgentList).not.toHaveBeenCalled();
     });
 
+    it('removes agents not in agentNames by calling updateAgentList without them', async () => {
+      const project = buildProjectWithAgent([
+        { id: 'opt-impl', name: 'impl' },
+        { id: 'opt-old', name: 'old-agent' },
+        { id: 'opt-chore', name: 'chore' },
+      ]);
+      const { projectRepository, useCase } = createUseCase([], project);
+
+      await useCase.reconcileAgentOptions(project, ['impl', 'chore']);
+
+      expect(projectRepository.updateAgentList).toHaveBeenCalledWith(project, [
+        expect.objectContaining({ id: 'opt-impl', name: 'impl' }),
+        expect.objectContaining({ id: 'opt-chore', name: 'chore' }),
+      ]);
+    });
+
+    it('reorders agents to match agentNames order when order differs', async () => {
+      const project = buildProjectWithAgent([
+        { id: 'opt-chore', name: 'chore' },
+        { id: 'opt-impl', name: 'impl' },
+      ]);
+      const { projectRepository, useCase } = createUseCase([], project);
+
+      await useCase.reconcileAgentOptions(project, ['impl', 'chore']);
+
+      expect(projectRepository.updateAgentList).toHaveBeenCalledWith(project, [
+        expect.objectContaining({ id: 'opt-impl', name: 'impl' }),
+        expect.objectContaining({ id: 'opt-chore', name: 'chore' }),
+      ]);
+    });
+
     it('calls createField with AGENT_FIELD_NAME and initial agents when project has no agent field', async () => {
       const { projectRepository, useCase } = createUseCase(
         [],

package/src/domain/usecases/ProjectRequiredFieldCreateUseCase.ts

@@ -106,26 +106,32 @@ export class ProjectRequiredFieldCreateUseCase {
       });
       return;
     }
-    const existingOptions = project.agent.options;
-    const existingNames = new Set(
-      existingOptions.map((o) => normalizeProjectFieldName(o.name)),
+    const existingByNormalizedName = new Map(
+      project.agent.options.map((o) => [normalizeProjectFieldName(o.name), o]),
     );
-    const toAdd = agentNames.filter(
-      (name) => !existingNames.has(normalizeProjectFieldName(name)),
+    const targetOptions: OptionToSubmit[] = agentNames.map((name) => {
+      const existing = existingByNormalizedName.get(
+        normalizeProjectFieldName(name),
+      );
+      return existing
+        ? { ...existing }
+        : { id: null, name, color: 'GRAY' as const, description: '' };
+    });
+    const existingNormalizedNames = project.agent.options.map((o) =>
+      normalizeProjectFieldName(o.name),
+    );
+    const targetNormalizedNames = targetOptions.map((o) =>
+      normalizeProjectFieldName(o.name),
     );
-    if (toAdd.length === 0) {
+    const needsUpdate =
+      existingNormalizedNames.length !== targetNormalizedNames.length ||
+      existingNormalizedNames.some(
+        (name, i) => name !== targetNormalizedNames[i],
+      );
+    if (!needsUpdate) {
       return;
     }
-    const mergedOptions: OptionToSubmit[] = [
-      ...existingOptions.map((o) => ({ ...o })),
-      ...toAdd.map((name) => ({
-        id: null,
-        name,
-        color: 'GRAY' as const,
-        description: '',
-      })),
-    ];
-    await this.projectRepository.updateAgentList(project, mergedOptions);
+    await this.projectRepository.updateAgentList(project, targetOptions);
   };
 
   private optionNameSatisfies = (

package/types/domain/usecases/ProjectRequiredFieldCreateUseCase.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ProjectRequiredFieldCreateUseCase.d.ts","sourceRoot":"","sources":["../../../src/domain/usecases/ProjectRequiredFieldCreateUseCase.ts"],"names":[],"mappings":"AAAA,OAAO,EAAe,OAAO,EAAE,MAAM,qBAAqB,CAAC;AAO3D,OAAO,EAAE,iBAAiB,EAAE,MAAM,wCAAwC,CAAC;AAM3E,qBAAa,iCAAiC;IAE1C,OAAO,CAAC,QAAQ,CAAC,iBAAiB;gBAAjB,iBAAiB,EAAE,IAAI,CACtC,iBAAiB,EACf,UAAU,GACV,gBAAgB,GAChB,aAAa,GACb,iBAAiB,GACjB,iBAAiB,CACpB;IAGH,GAAG,GAAU,QAAQ;QACnB,UAAU,EAAE,MAAM,CAAC;QACnB,MAAM,CAAC,EAAE,MAAM,EAAE,GAAG,IAAI,CAAC;KAC1B,KAAG,OAAO,CAAC,IAAI,CAAC,CAQf;IAEF,OAAO,CAAC,mBAAmB,CAYzB;IAEF,OAAO,CAAC,qBAAqB,CAmC3B;IAEF,qBAAqB,GACnB,SAAS,OAAO,EAChB,YAAY,MAAM,EAAE,GAAG,IAAI,KAC1B,OAAO,CAAC,IAAI,CAAC,CAoCd;IAEF,OAAO,CAAC,mBAAmB,CAMvB;IAEJ,MAAM,CAAC,QAAQ,CAAC,gBAAgB,WAAoB;CACrD"}
+{"version":3,"file":"ProjectRequiredFieldCreateUseCase.d.ts","sourceRoot":"","sources":["../../../src/domain/usecases/ProjectRequiredFieldCreateUseCase.ts"],"names":[],"mappings":"AAAA,OAAO,EAAe,OAAO,EAAE,MAAM,qBAAqB,CAAC;AAO3D,OAAO,EAAE,iBAAiB,EAAE,MAAM,wCAAwC,CAAC;AAM3E,qBAAa,iCAAiC;IAE1C,OAAO,CAAC,QAAQ,CAAC,iBAAiB;gBAAjB,iBAAiB,EAAE,IAAI,CACtC,iBAAiB,EACf,UAAU,GACV,gBAAgB,GAChB,aAAa,GACb,iBAAiB,GACjB,iBAAiB,CACpB;IAGH,GAAG,GAAU,QAAQ;QACnB,UAAU,EAAE,MAAM,CAAC;QACnB,MAAM,CAAC,EAAE,MAAM,EAAE,GAAG,IAAI,CAAC;KAC1B,KAAG,OAAO,CAAC,IAAI,CAAC,CAQf;IAEF,OAAO,CAAC,mBAAmB,CAYzB;IAEF,OAAO,CAAC,qBAAqB,CAmC3B;IAEF,qBAAqB,GACnB,SAAS,OAAO,EAChB,YAAY,MAAM,EAAE,GAAG,IAAI,KAC1B,OAAO,CAAC,IAAI,CAAC,CA0Cd;IAEF,OAAO,CAAC,mBAAmB,CAMvB;IAEJ,MAAM,CAAC,QAAQ,CAAC,gBAAgB,WAAoB;CACrD"}