npm - github-issue-tower-defence-management - Versions diffs - 1.170.1 → 1.172.0 - Mend

github-issue-tower-defence-management 1.170.1 → 1.172.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (51) hide show

package/src/adapter/entry-points/console/ui-dist/index.html CHANGED Viewed

@@ -4,8 +4,8 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-Db4JRB24.js"></script>
-    <link rel="stylesheet" crossorigin href="/assets/index-U8I8ESZj.css">
+    <script type="module" crossorigin src="/assets/index-ZYMkO0fm.js"></script>
+    <link rel="stylesheet" crossorigin href="/assets/index-Bh2slMtk.css">
   </head>
   <body>
     <div id="root"></div>

package/src/adapter/entry-points/handlers/FileSystemConsoleTabsRepository.test.ts CHANGED Viewed

@@ -18,6 +18,7 @@ const makeItem = (
   isPr: false,
   story: 'Story A',
   status: 'Awaiting Quality Check',
+  agent: null,
   nextActionDate: null,
   nextActionHour: null,
   dependedIssueUrls: [],

package/src/domain/usecases/ClearPastNextActionDateHourUseCase.ts CHANGED Viewed

@@ -1,6 +1,7 @@
 import { Issue } from '../entities/Issue';
 import { IssueRepository } from './adapter-interfaces/IssueRepository';
 import { Project } from '../entities/Project';
+import { issueReactivationTriggerStartOfTomorrow } from './issueReactivationTriggerIsPending';
 export class ClearPastNextActionDateHourUseCase {
   constructor(
@@ -57,11 +58,7 @@ export class ClearPastNextActionDateHourUseCase {
     if (!nextActionDate) {
       return;
     }
-    const startOfTomorrow = new Date(
-      now.getFullYear(),
-      now.getMonth(),
-      now.getDate() + 1,
-    );
+    const startOfTomorrow = issueReactivationTriggerStartOfTomorrow(now);
     for (const issue of input.issues) {
       if (
         issue.nextActionHour !== null ||

package/src/domain/usecases/NotifyFinishedIssuePreparationUseCase.test.ts CHANGED Viewed

@@ -518,7 +518,7 @@ describe('NotifyFinishedIssuePreparationUseCase', () => {
     );
     expect(mockIssueCommentRepository.createComment).toHaveBeenCalledWith(
       expect.objectContaining({ url: 'https://github.com/user/repo/issues/1' }),
-      expect.stringContaining('Issue has next action date or hour set:'),
+      expect.stringContaining('Reactivation trigger not yet reached:'),
     );
   });

package/src/domain/usecases/NotifyFinishedIssuePreparationUseCase.ts CHANGED Viewed

@@ -27,6 +27,7 @@ import {
 import { Issue } from '../entities/Issue';
 import { Project } from '../entities/Project';
 import { ensureAgentOptionAndGetId } from './ensureAgentOptionAndGetId';
+import { issueReactivationTriggerIsPending } from './issueReactivationTriggerIsPending';
 export class IssueNotFoundError extends Error {
   constructor(issueUrl: string) {
@@ -198,17 +199,7 @@ export class NotifyFinishedIssuePreparationUseCase {
     }
     const evaluatedAt = new Date();
-    const startOfTomorrow = new Date(
-      evaluatedAt.getFullYear(),
-      evaluatedAt.getMonth(),
-      evaluatedAt.getDate() + 1,
-    );
-    const hasFutureNextActionDate =
-      issue.nextActionDate !== null && issue.nextActionDate >= startOfTomorrow;
-    const hasUnreachedNextActionHour =
-      issue.nextActionHour !== null &&
-      evaluatedAt.getHours() < issue.nextActionHour;
-    if (hasFutureNextActionDate || hasUnreachedNextActionHour) {
+    if (issueReactivationTriggerIsPending(issue, evaluatedAt)) {
       issue.status = AWAITING_WORKSPACE_STATUS_NAME;
       await this.issueRepository.update(issue, project);
       await this.issueRepository.updateStatus(
@@ -219,7 +210,7 @@ export class NotifyFinishedIssuePreparationUseCase {
       await this.patchConsoleTab(issue);
       await this.issueCommentRepository.createComment(
         issue,
-        `Issue has next action date or hour set: nextActionDate=${issue.nextActionDate?.toISOString() ?? 'null'}, nextActionHour=${issue.nextActionHour ?? 'null'}`,
+        `Reactivation trigger not yet reached: nextActionDate=${issue.nextActionDate?.toISOString() ?? 'null'}, nextActionHour=${issue.nextActionHour ?? 'null'}`,
       );
       return;
     }
@@ -675,6 +666,7 @@ export class NotifyFinishedIssuePreparationUseCase {
       isPr: issue.isPr,
       story: issue.story ?? '',
       status: issue.status,
+      agent: issue.agent,
       nextActionDate:
         issue.nextActionDate === null
           ? null

package/src/domain/usecases/StartPreparationUseCase.ts CHANGED Viewed

@@ -10,6 +10,7 @@ import {
   PREPARATION_STATUS_NAME,
 } from '../entities/WorkflowStatus';
 import { adoptIssueAgentDesignationLabel } from './AgentDesignationLabelAdoptUseCase';
+import { issueReactivationTriggerIsPending } from './issueReactivationTriggerIsPending';
 const NORMAL_CONCURRENT_LIMIT = 6;
 const SEVEN_DAY_THROTTLE_START_THRESHOLD = 0.8;
@@ -433,17 +434,6 @@ export class StartPreparationUseCase {
     };
     const now = new Date();
-    const currentHour = now.getHours();
-    const todayStart = new Date(
-      now.getFullYear(),
-      now.getMonth(),
-      now.getDate(),
-    );
-    const tomorrowStart = new Date(
-      todayStart.getFullYear(),
-      todayStart.getMonth(),
-      todayStart.getDate() + 1,
-    );
     for (
       let i = 0;
@@ -460,15 +450,20 @@ export class StartPreparationUseCase {
         console.warn(`Skipping ${issue.url}: worker already running.`);
         continue;
       }
-      if (
-        issue.nextActionDate !== null &&
-        issue.nextActionDate >= tomorrowStart
-      ) {
-        exclusionCounts.futureNextActionDate++;
-        continue;
-      }
-      if (issue.nextActionHour !== null && currentHour < issue.nextActionHour) {
-        exclusionCounts.nextActionHourNotReached++;
+      if (issueReactivationTriggerIsPending(issue, now)) {
+        const startOfTomorrow = new Date(
+          now.getFullYear(),
+          now.getMonth(),
+          now.getDate() + 1,
+        );
+        if (
+          issue.nextActionDate !== null &&
+          issue.nextActionDate >= startOfTomorrow
+        ) {
+          exclusionCounts.futureNextActionDate++;
+        } else {
+          exclusionCounts.nextActionHourNotReached++;
+        }
         continue;
       }
       if (

package/src/domain/usecases/console/GenerateConsoleListsUseCase.test.ts CHANGED Viewed

@@ -508,6 +508,7 @@ describe('GenerateConsoleListsUseCase', () => {
       const item = result.unread.items[0];
       expect(Object.keys(item).sort()).toEqual(
         [
+          'agent',
           'createdAt',
           'dependedIssueUrls',
           'isPr',
@@ -898,4 +899,23 @@ describe('GenerateConsoleListsUseCase', () => {
       expect(result.stories.stories).toEqual([]);
     });
   });
+  describe('agent field propagation', () => {
+    it('copies the agent value from the issue into the list item', () => {
+      const result = run([makeIssue({ status: 'Unread', agent: 'developer' })]);
+      expect(result.unread.items[0].agent).toBe('developer');
+    });
+    it('preserves null when the issue has no agent set', () => {
+      const result = run([makeIssue({ status: 'Unread', agent: null })]);
+      expect(result.unread.items[0].agent).toBeNull();
+    });
+    it('copies the agent into every tab that shows the issue', () => {
+      const result = run([
+        makeIssue({ status: 'Awaiting Quality Check', agent: 'chore' }),
+      ]);
+      expect(result.prs.items[0].agent).toBe('chore');
+    });
+  });
 });

package/src/domain/usecases/console/GenerateConsoleListsUseCase.ts CHANGED Viewed

@@ -20,6 +20,7 @@ export type ConsoleListItem = {
   isPr: boolean;
   story: string;
   status: string | null;
+  agent: string | null;
   nextActionDate: string | null;
   nextActionHour: number | null;
   dependedIssueUrls: string[];
@@ -308,6 +309,7 @@ export class GenerateConsoleListsUseCase {
     isPr: issue.isPr,
     story: issue.story ?? '',
     status: issue.status,
+    agent: issue.agent,
     nextActionDate:
       issue.nextActionDate === null ? null : issue.nextActionDate.toISOString(),
     nextActionHour: issue.nextActionHour,