github-issue-tower-defence-management 1.148.25 → 1.149.0

package/src/adapter/repositories/FileSystemKevReportWatermarkRepository.ts

@@ -0,0 +1,130 @@
+import * as fs from 'fs';
+import * as os from 'os';
+import * as path from 'path';
+import { KevReportWatermark } from '../../domain/entities/KevReportWatermark';
+import {
+  KevReportWatermarkLoadResult,
+  KevReportWatermarkRepository,
+} from '../../domain/usecases/adapter-interfaces/KevReportWatermarkRepository';
+
+const isRecord = (value: unknown): value is Record<string, unknown> =>
+  typeof value === 'object' && value !== null && !Array.isArray(value);
+
+const errorCode = (error: unknown): string | null => {
+  if (!isRecord(error)) {
+    return null;
+  }
+  const code = error.code;
+  return typeof code === 'string' ? code : null;
+};
+
+const isCalendarYmd = (value: string): boolean => {
+  if (!/^\d{4}-\d{2}-\d{2}$/.test(value)) {
+    return false;
+  }
+  const parsed = new Date(`${value}T00:00:00.000Z`);
+  return (
+    !Number.isNaN(parsed.getTime()) &&
+    parsed.toISOString().slice(0, 10) === value
+  );
+};
+
+const defaultStateFilePath = (): string => {
+  const base = process.env.XDG_CACHE_HOME ?? path.join(os.homedir(), '.cache');
+  return path.join(base, 'tdpm', 'kev-report-watermark.json');
+};
+
+export class FileSystemKevReportWatermarkRepository implements KevReportWatermarkRepository {
+  constructor(
+    private readonly stateFilePath: string = defaultStateFilePath(),
+  ) {}
+
+  load = async (): Promise<KevReportWatermarkLoadResult> => {
+    let raw: string;
+    try {
+      raw = fs.readFileSync(this.stateFilePath, 'utf8');
+    } catch (error) {
+      if (errorCode(error) === 'ENOENT') {
+        return { type: 'absent' };
+      }
+      return this.unreadable(
+        `the stored watermark file could not be read (${String(error)})`,
+      );
+    }
+
+    let parsed: unknown;
+    try {
+      parsed = JSON.parse(raw);
+    } catch (error) {
+      return this.unreadable(
+        `the stored watermark file does not contain valid JSON (${String(error)})`,
+      );
+    }
+
+    if (!isRecord(parsed)) {
+      return this.unreadable(
+        'the stored watermark file does not contain a JSON object',
+      );
+    }
+
+    const lastReportedDateAdded = parsed.lastReportedDateAdded;
+    if (typeof lastReportedDateAdded !== 'string') {
+      return this.unreadable(
+        `the stored lastReportedDateAdded is not a string (${JSON.stringify(lastReportedDateAdded)})`,
+      );
+    }
+    if (!isCalendarYmd(lastReportedDateAdded)) {
+      return this.unreadable(
+        `the stored lastReportedDateAdded is not a calendar date in YYYY-MM-DD form (${JSON.stringify(lastReportedDateAdded)})`,
+      );
+    }
+
+    const reportedCveIdsOnLastReportedDateAdded =
+      parsed.reportedCveIdsOnLastReportedDateAdded;
+    if (!Array.isArray(reportedCveIdsOnLastReportedDateAdded)) {
+      return this.unreadable(
+        'the stored reportedCveIdsOnLastReportedDateAdded is not an array',
+      );
+    }
+    if (
+      !reportedCveIdsOnLastReportedDateAdded.every(
+        (cveId) => typeof cveId === 'string',
+      )
+    ) {
+      return this.unreadable(
+        'the stored reportedCveIdsOnLastReportedDateAdded contains a non-string entry',
+      );
+    }
+
+    return {
+      type: 'stored',
+      watermark: {
+        lastReportedDateAdded,
+        reportedCveIdsOnLastReportedDateAdded:
+          reportedCveIdsOnLastReportedDateAdded,
+      },
+    };
+  };
+
+  save = async (watermark: KevReportWatermark): Promise<void> => {
+    try {
+      const directory = path.dirname(this.stateFilePath);
+      fs.mkdirSync(directory, { recursive: true });
+      const temporaryPath = `${this.stateFilePath}.${process.pid}.tmp`;
+      fs.writeFileSync(temporaryPath, JSON.stringify(watermark));
+      fs.renameSync(temporaryPath, this.stateFilePath);
+    } catch (error) {
+      console.error(
+        `Unable to write the KEV report watermark to ${this.stateFilePath}: ${String(error)}`,
+      );
+      throw error;
+    }
+  };
+
+  private unreadable = (reason: string): KevReportWatermarkLoadResult => {
+    console.error(
+      `Unable to use the KEV report watermark stored at ${this.stateFilePath}: ${reason}. The file is left untouched for inspection.`,
+    );
+    return { type: 'unreadable', reason };
+  };
+}

package/src/adapter/repositories/ProcessListSessionSubAgentActivityRepository.test.ts

@@ -59,6 +59,7 @@ describe('ProcessListSessionSubAgentActivityRepository', () => {
         silentSeconds: 180,
         runningSeconds: 1200,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -88,6 +89,7 @@ describe('ProcessListSessionSubAgentActivityRepository', () => {
         silentSeconds: 0,
         runningSeconds: 30,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });

package/src/adapter/repositories/ProcessListSessionSubAgentActivityRepository.ts

@@ -44,6 +44,7 @@ export class ProcessListSessionSubAgentActivityRepository implements SessionSubA
         silentSeconds: this.silentSecondsResolver.resolveSilentSeconds(label),
         runningSeconds: process.elapsedSeconds,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       };
       const existing = result.get(sessionName);
       if (existing === undefined) {

package/src/adapter/repositories/TranscriptOwnerCallStatusProvider.test.ts

@@ -940,6 +940,9 @@ describe('TranscriptOwnerCallStatusProvider wired into NotifySilentLiveSessionsU
           .fn()
           .mockReturnValue('MAIN_STALLED_STALE'),
         composeSubAgentSection: jest.fn().mockReturnValue('SUBAGENT'),
+        composeSubAgentUnconsumedResultSection: jest
+          .fn()
+          .mockReturnValue('SUBAGENT_UNCONSUMED'),
       },
       { sleep: jest.fn().mockResolvedValue(undefined) },
     );

package/src/adapter/repositories/TranscriptSessionSubAgentActivityRepository.test.ts

@@ -279,6 +279,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 120,
         runningSeconds: 900,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -400,6 +401,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 60,
         runningSeconds: 600,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -474,6 +476,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 60,
         runningSeconds: 600,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -525,6 +528,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 600,
         runningSeconds: 900,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -555,6 +559,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: fourDaysSeconds,
         runningSeconds: fourDaysSeconds,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -592,6 +597,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 60,
         runningSeconds: 600,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
     fs.rmSync(targetDir, { force: true, recursive: true });
@@ -680,6 +686,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 0,
         runningSeconds: 0,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -731,6 +738,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 120,
         runningSeconds: 900,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -767,6 +775,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: twoDaysSeconds,
         runningSeconds: twoDaysSeconds,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -821,6 +830,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
             silentSeconds: 600,
             runningSeconds: 900,
             waitingOnExternalProcess: true,
+            finishedResultUnconsumed: false,
           },
         ]);
       },
@@ -956,6 +966,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
           silentSeconds: 600,
           runningSeconds: 900,
           waitingOnExternalProcess: true,
+          finishedResultUnconsumed: false,
         },
       ]);
     });
@@ -987,6 +998,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
           silentSeconds: 600,
           runningSeconds: 900,
           waitingOnExternalProcess: false,
+          finishedResultUnconsumed: false,
         },
       ]);
     });
@@ -1282,6 +1294,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 120,
         runningSeconds: 900,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -1337,6 +1350,7 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 600,
         runningSeconds: 900,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });
@@ -1367,6 +1381,151 @@ describe('TranscriptSessionSubAgentActivityRepository', () => {
         silentSeconds: 120,
         runningSeconds: 900,
         waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
+      },
+    ]);
+  });
+
+  it('reports a finished sub-agent still listed in the running-subagents record as an unconsumed result carrying its silence age', async () => {
+    const sessionName = 'https_//github_com/owner/repo/issues/9';
+    const unconsumedAgentId = 'aaabbbbcccc30001';
+    writeAgentTranscript(
+      sessionName,
+      unconsumedAgentId,
+      finishedEntries('2026-06-27T10:30:00.000Z'),
+      nowEpochSeconds - 5220,
+    );
+    const repository = new TranscriptSessionSubAgentActivityRepository(
+      createResolver(),
+      emptyProcessLister(),
+      now,
+      livenessResolverWith([unconsumedAgentId]),
+    );
+
+    const result = await repository.listSubAgentActivitiesBySessionName(
+      [sessionName],
+      transcriptMapFor([sessionName]),
+    );
+
+    expect(result.get(sessionName)).toEqual([
+      {
+        label: `agent-${unconsumedAgentId}`,
+        silentSeconds: 5220,
+        runningSeconds: 5400,
+        waitingOnExternalProcess: false,
+        finishedResultUnconsumed: true,
+      },
+    ]);
+  });
+
+  it('reports a finished sub-agent whose tail is a final text answer as an unconsumed result while it stays in the running-subagents record', async () => {
+    const sessionName = 'https_//github_com/owner/repo/issues/9';
+    const unconsumedAgentId = 'aaabbbbcccc30002';
+    writeAgentTranscript(
+      sessionName,
+      unconsumedAgentId,
+      finalTextAnswerEntries('2026-06-27T11:00:00.000Z'),
+      nowEpochSeconds - 360,
+    );
+    const repository = new TranscriptSessionSubAgentActivityRepository(
+      createResolver(),
+      emptyProcessLister(),
+      now,
+      livenessResolverWith([unconsumedAgentId]),
+    );
+
+    const result = await repository.listSubAgentActivitiesBySessionName(
+      [sessionName],
+      transcriptMapFor([sessionName]),
+    );
+
+    expect(result.get(sessionName)).toEqual([
+      {
+        label: `agent-${unconsumedAgentId}`,
+        silentSeconds: 360,
+        runningSeconds: 3600,
+        waitingOnExternalProcess: false,
+        finishedResultUnconsumed: true,
+      },
+    ]);
+  });
+
+  it('discards a finished sub-agent when the running-subagents record cannot be resolved', async () => {
+    const sessionName = 'https_//github_com/owner/repo/issues/9';
+    const finishedAgentId = 'aaabbbbcccc30003';
+    writeAgentTranscript(
+      sessionName,
+      finishedAgentId,
+      finishedEntries('2026-06-27T10:30:00.000Z'),
+      nowEpochSeconds - 5220,
+    );
+    const repository = new TranscriptSessionSubAgentActivityRepository(
+      createResolver(),
+      emptyProcessLister(),
+      now,
+      livenessResolverWith(null),
+    );
+
+    const result = await repository.listSubAgentActivitiesBySessionName(
+      [sessionName],
+      transcriptMapFor([sessionName]),
+    );
+
+    expect(result.size).toBe(0);
+  });
+
+  it('discards a finished sub-agent whose id has already been removed from the running-subagents record', async () => {
+    const sessionName = 'https_//github_com/owner/repo/issues/9';
+    const finishedAgentId = 'aaabbbbcccc30004';
+    writeAgentTranscript(
+      sessionName,
+      finishedAgentId,
+      finishedEntries('2026-06-27T10:30:00.000Z'),
+      nowEpochSeconds - 5220,
+    );
+    const repository = new TranscriptSessionSubAgentActivityRepository(
+      createResolver(),
+      emptyProcessLister(),
+      now,
+      livenessResolverWith(['aaabbbbcccc30005']),
+    );
+
+    const result = await repository.listSubAgentActivitiesBySessionName(
+      [sessionName],
+      transcriptMapFor([sessionName]),
+    );
+
+    expect(result.size).toBe(0);
+  });
+
+  it('reports a still-working sub-agent listed in the running-subagents record as having no unconsumed result', async () => {
+    const sessionName = 'https_//github_com/owner/repo/issues/9';
+    const workingAgentId = 'aaabbbbcccc30006';
+    writeAgentTranscript(
+      sessionName,
+      workingAgentId,
+      pendingToolUseEntries('2026-06-27T11:45:00.000Z'),
+      nowEpochSeconds - 600,
+    );
+    const repository = new TranscriptSessionSubAgentActivityRepository(
+      createResolver(),
+      emptyProcessLister(),
+      now,
+      livenessResolverWith([workingAgentId]),
+    );
+
+    const result = await repository.listSubAgentActivitiesBySessionName(
+      [sessionName],
+      transcriptMapFor([sessionName]),
+    );
+
+    expect(result.get(sessionName)).toEqual([
+      {
+        label: `agent-${workingAgentId}`,
+        silentSeconds: 600,
+        runningSeconds: 900,
+        waitingOnExternalProcess: false,
+        finishedResultUnconsumed: false,
       },
     ]);
   });

package/src/adapter/repositories/TranscriptSessionSubAgentActivityRepository.ts

@@ -344,6 +344,7 @@ export class TranscriptSessionSubAgentActivityRepository implements SessionSubAg
         filePath,
         fileName,
         nowEpochSeconds,
+        liveSubAgentIds !== null,
         loadNormalizedProcessCommandLines,
       );
       if (activity !== null) {
@@ -357,6 +358,7 @@ export class TranscriptSessionSubAgentActivityRepository implements SessionSubAg
     filePath: string,
     fileName: string,
     nowEpochSeconds: number,
+    listedInRunningSubAgentsRecord: boolean,
     loadNormalizedProcessCommandLines: () => Promise<string[]>,
   ): Promise<SubAgentActivity | null> => {
     let content: string;
@@ -368,7 +370,10 @@ export class TranscriptSessionSubAgentActivityRepository implements SessionSubAg
       return null;
     }
     const transcript = parseTranscript(content);
-    if (transcript.lastEntryIndicatesCompletion) {
+    if (
+      transcript.lastEntryIndicatesCompletion &&
+      !listedInRunningSubAgentsRecord
+    ) {
       return null;
     }
     const silentSeconds = clampToZero(
@@ -388,6 +393,7 @@ export class TranscriptSessionSubAgentActivityRepository implements SessionSubAg
           transcript.pendingToolCommands,
           loadNormalizedProcessCommandLines,
         )),
+      finishedResultUnconsumed: transcript.lastEntryIndicatesCompletion,
     };
   };
 

package/src/domain/entities/KevReportWatermark.ts

@@ -0,0 +1,4 @@
+export type KevReportWatermark = {
+  lastReportedDateAdded: string;
+  reportedCveIdsOnLastReportedDateAdded: string[];
+};

package/src/domain/entities/LiveSessionActivitySnapshot.ts

@@ -3,6 +3,7 @@ export type SubAgentActivity = {
   silentSeconds: number;
   runningSeconds: number;
   waitingOnExternalProcess: boolean;
+  finishedResultUnconsumed: boolean;
 };
 
 export type LiveSessionActivitySnapshot = {