github-issue-tower-defence-management 1.148.21 → 1.148.23

package/src/adapter/entry-points/console/consoleReadApi.test.ts

@@ -1,33 +1,5 @@
 import { mock } from 'jest-mock-extended';
-import { Issue } from '../../../domain/entities/Issue';
 import { IssueRepository } from '../../../domain/usecases/adapter-interfaces/IssueRepository';
-
-const buildIssueFixture = (title: string): Issue => ({
-  nameWithOwner: 'o/r',
-  number: 1,
-  title,
-  state: 'OPEN',
-  status: null,
-  story: null,
-  nextActionDate: null,
-  nextActionHour: null,
-  estimationMinutes: null,
-  dependedIssueUrls: [],
-  completionDate50PercentConfidence: null,
-  url: 'https://github.com/o/r/issues/1',
-  assignees: [],
-  labels: [],
-  org: 'o',
-  repo: 'r',
-  body: '',
-  itemId: 'itemId',
-  isPr: false,
-  isInProgress: false,
-  isClosed: false,
-  createdAt: new Date('2026-01-01T00:00:00Z'),
-  author: 'octocat',
-  closingIssueReferenceUrls: [],
-});
 import {
   ISSUE_TITLE_CACHE_TTL_MS,
   IssueTitleStateCache,
@@ -272,10 +244,8 @@ describe('consoleReadApi', () => {
         state: 'OPEN',
         merged: false,
         isPullRequest: false,
+        title: 'Issue title from repository',
       });
-      issueRepository.getIssueByUrl.mockResolvedValue(
-        buildIssueFixture('Issue title from repository'),
-      );
       const cache = new IssueTitleStateCache(() => 0);
       const url = 'https://github.com/o/r/issues/1';
       const first = await handleIssueTitle(issueRepository, cache, url);
@@ -290,22 +260,16 @@ describe('consoleReadApi', () => {
       expect(issueRepository.getIssueOrPullRequestState).toHaveBeenCalledTimes(
         1,
       );
-      expect(issueRepository.getIssueByUrl).toHaveBeenCalledTimes(1);
+      expect(issueRepository.getIssueByUrl).not.toHaveBeenCalled();
     });
 
-    it('returns the pull request title from the summary for pull request urls', async () => {
+    it('returns the pull request title for pull request urls', async () => {
       const issueRepository = mock<IssueRepository>();
       issueRepository.getIssueOrPullRequestState.mockResolvedValue({
         state: 'CLOSED',
         merged: true,
         isPullRequest: true,
-      });
-      issueRepository.getPullRequestSummary.mockResolvedValue({
-        title: 'Pull request title from summary',
-        body: 'body',
-        additions: 1,
-        deletions: 0,
-        changedFiles: 1,
+        title: 'Pull request title from state',
       });
       const cache = new IssueTitleStateCache(() => 0);
       const url = 'https://github.com/o/r/pull/2';
@@ -314,32 +278,34 @@ describe('consoleReadApi', () => {
         state: 'CLOSED',
         merged: true,
         isPullRequest: true,
-        title: 'Pull request title from summary',
+        title: 'Pull request title from state',
       });
-      expect(issueRepository.getPullRequestSummary).toHaveBeenCalledWith(url);
+      expect(issueRepository.getPullRequestSummary).not.toHaveBeenCalled();
       expect(issueRepository.getIssueByUrl).not.toHaveBeenCalled();
     });
 
-    it('falls back to an empty title when the title source returns nothing', async () => {
+    it('returns the title of an issue that is not an item on the project board', async () => {
       const issueRepository = mock<IssueRepository>();
       issueRepository.getIssueOrPullRequestState.mockResolvedValue({
-        state: 'OPEN',
+        state: 'CLOSED',
         merged: false,
         isPullRequest: false,
+        title: 'Title of an issue outside the board',
       });
       issueRepository.getIssueByUrl.mockResolvedValue(null);
       const cache = new IssueTitleStateCache(() => 0);
       const response = await handleIssueTitle(
         issueRepository,
         cache,
-        'https://github.com/o/r/issues/3',
+        'https://github.com/o/off-board-repository/issues/656',
       );
       expect(response.body).toEqual({
-        state: 'OPEN',
+        state: 'CLOSED',
         merged: false,
         isPullRequest: false,
-        title: '',
+        title: 'Title of an issue outside the board',
       });
+      expect(issueRepository.getIssueByUrl).not.toHaveBeenCalled();
     });
 
     it('re-fetches a non-merged result after the TTL elapses', async () => {
@@ -348,6 +314,7 @@ describe('consoleReadApi', () => {
         state: 'OPEN',
         merged: false,
         isPullRequest: true,
+        title: 'Open pull request title',
       });
       let now = 0;
       const cache = new IssueTitleStateCache(() => now);
@@ -371,6 +338,7 @@ describe('consoleReadApi', () => {
         state: 'CLOSED',
         merged: true,
         isPullRequest: true,
+        title: 'Merged pull request title',
       });
       let now = 0;
       const cache = new IssueTitleStateCache(() => now);

package/src/adapter/entry-points/console/consoleReadApi.ts

@@ -233,19 +233,6 @@ export const handleRelatedPrs = async (
   return ok({ relatedPullRequests: withSummaries });
 };
 
-const resolveIssueOrPullRequestTitle = async (
-  issueRepository: IssueRepository,
-  url: string,
-  isPullRequest: boolean,
-): Promise<string> => {
-  if (isPullRequest) {
-    const summary = await issueRepository.getPullRequestSummary(url);
-    return summary?.title ?? '';
-  }
-  const issue = await issueRepository.getIssueByUrl(url);
-  return issue?.title ?? '';
-};
-
 export const handleIssueTitle = async (
   issueRepository: IssueRepository,
   cache: IssueTitleStateCache,
@@ -258,13 +245,8 @@ export const handleIssueTitle = async (
   if (cached !== null) {
     return ok(cached);
   }
-  const baseState = await issueRepository.getIssueOrPullRequestState(url);
-  const title = await resolveIssueOrPullRequestTitle(
-    issueRepository,
-    url,
-    baseState.isPullRequest,
-  );
-  const state: IssueOrPullRequestState = { ...baseState, title };
+  const state: IssueOrPullRequestState =
+    await issueRepository.getIssueOrPullRequestState(url);
   cache.set(url, state);
   return ok(state);
 };

package/src/adapter/entry-points/console/ui/e2e/consoleTestHarness.ts

@@ -473,10 +473,19 @@ const createStubIssueRepository = (
   getPullRequestCommits: async (): Promise<PullRequestCommit[]> => [],
   getIssueOrPullRequestState: async (
     url: string,
-  ): Promise<{ state: string; merged: boolean; isPullRequest: boolean }> => ({
+  ): Promise<{
+    state: string;
+    merged: boolean;
+    isPullRequest: boolean;
+    title: string;
+  }> => ({
     state: 'open',
     merged: false,
     isPullRequest: url.includes('/pull/'),
+    title:
+      url === CONSOLE_E2E_INLINE_COMMENT_PR_URL
+        ? 'Add inline review comments on the related pull request diff'
+        : buildIssueForUrl(url).title,
   }),
   getPullRequestSummary: async (
     url: string,

package/src/adapter/entry-points/handlers/inTmuxByHumanSessionReconciler.test.ts

@@ -47,6 +47,7 @@ const createIssueStateRepository = (
     state,
     merged: false,
     isPullRequest: false,
+    title: 'In tmux by human session issue',
   }),
 });
 

package/src/adapter/repositories/issue/ApiV3CheerioRestIssueRepository.test.ts

@@ -1103,9 +1103,16 @@ describe('ApiV3CheerioRestIssueRepository', () => {
           ),
         )
         .mockResolvedValueOnce(
-          new Response(JSON.stringify({ state: 'open', merged: false }), {
-            status: 200,
-          }),
+          new Response(
+            JSON.stringify({
+              state: 'open',
+              merged: false,
+              title: 'Issue title',
+            }),
+            {
+              status: 200,
+            },
+          ),
         );
 
       const { repository, sleep } = createApiV3CheerioRestIssueRepository();
@@ -2010,6 +2017,7 @@ describe('ApiV3CheerioRestIssueRepository', () => {
         state: 'closed',
         merged: true,
         isPullRequest: true,
+        title: 'PR title',
       });
       expect(fetchSpy).toHaveBeenCalledWith(
         'https://api.github.com/repos/HiromiShikata/test-repository/pulls/42',
@@ -2019,7 +2027,7 @@ describe('ApiV3CheerioRestIssueRepository', () => {
 
     it('should fetch issue state with merged always false for an issue URL', async () => {
       const fetchSpy = jest.spyOn(global, 'fetch').mockResolvedValueOnce(
-        new Response(JSON.stringify({ state: 'open' }), {
+        new Response(JSON.stringify({ state: 'open', title: 'Issue title' }), {
           status: 200,
           headers: { 'Content-Type': 'application/json' },
         }),
@@ -2034,6 +2042,7 @@ describe('ApiV3CheerioRestIssueRepository', () => {
         state: 'open',
         merged: false,
         isPullRequest: false,
+        title: 'Issue title',
       });
       expect(fetchSpy).toHaveBeenCalledWith(
         'https://api.github.com/repos/HiromiShikata/test-repository/issues/42',
@@ -2041,6 +2050,80 @@ describe('ApiV3CheerioRestIssueRepository', () => {
       );
     });
 
+    it('should return the issue title carried by the same REST payload', async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response(
+          JSON.stringify({ state: 'closed', title: 'Issue title from REST' }),
+          {
+            status: 200,
+            headers: { 'Content-Type': 'application/json' },
+          },
+        ),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      const result = await repository.getIssueOrPullRequestState(
+        'https://github.com/HiromiShikata/other-repository/issues/656',
+      );
+
+      expect(result).toEqual({
+        state: 'closed',
+        merged: false,
+        isPullRequest: false,
+        title: 'Issue title from REST',
+      });
+    });
+
+    it('should return the pull request title carried by the same REST payload', async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response(
+          JSON.stringify({
+            title: 'PR title from REST',
+            state: 'open',
+            merged: false,
+            draft: false,
+            additions: 1,
+            deletions: 1,
+            changed_files: 1,
+            head: { ref: 'feature/foo' },
+            base: { ref: 'main' },
+            user: { login: 'alice' },
+            body: 'pr body',
+          }),
+          { status: 200, headers: { 'Content-Type': 'application/json' } },
+        ),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+      const result = await repository.getIssueOrPullRequestState(
+        'https://github.com/HiromiShikata/other-repository/pull/42',
+      );
+
+      expect(result).toEqual({
+        state: 'open',
+        merged: false,
+        isPullRequest: true,
+        title: 'PR title from REST',
+      });
+    });
+
+    it('should throw rather than report an empty title when the payload carries no title', async () => {
+      jest.spyOn(global, 'fetch').mockResolvedValueOnce(
+        new Response(JSON.stringify({ state: 'open' }), {
+          status: 200,
+          headers: { 'Content-Type': 'application/json' },
+        }),
+      );
+
+      const { repository } = createApiV3CheerioRestIssueRepository();
+
+      await expect(
+        repository.getIssueOrPullRequestState(
+          'https://github.com/HiromiShikata/other-repository/issues/656',
+        ),
+      ).rejects.toThrow('Unexpected response shape when fetching state for');
+    });
+
     it('should throw when the API responds with a non-2xx status', async () => {
       jest.spyOn(global, 'fetch').mockResolvedValueOnce(
         new Response('Not Found', {

package/src/adapter/repositories/issue/ApiV3CheerioRestIssueRepository.ts

@@ -277,12 +277,17 @@ function isIssueOrPullRequestBodyResponse(
 
 type IssueOrPullRequestStateResponse = {
   state: string;
+  title: string;
 };
 
 function isIssueOrPullRequestStateResponse(
   value: unknown,
 ): value is IssueOrPullRequestStateResponse {
-  return isRecord(value) && typeof value.state === 'string';
+  return (
+    isRecord(value) &&
+    typeof value.state === 'string' &&
+    typeof value.title === 'string'
+  );
 }
 
 type IssueCommentsResponseItem = {
@@ -2273,7 +2278,12 @@ export class ApiV3CheerioRestIssueRepository
 
   getIssueOrPullRequestState = async (
     url: string,
-  ): Promise<{ state: string; merged: boolean; isPullRequest: boolean }> => {
+  ): Promise<{
+    state: string;
+    merged: boolean;
+    isPullRequest: boolean;
+    title: string;
+  }> => {
     const { owner, repo, issueNumber, isPr } = this.parseIssueUrl(url);
     if (isPr) {
       const response = await this.fetchWithRateLimitRetry(() =>
@@ -2298,7 +2308,12 @@ export class ApiV3CheerioRestIssueRepository
           `Unexpected response shape when fetching state for ${url}`,
         );
       }
-      return { state: body.state, merged: body.merged, isPullRequest: true };
+      return {
+        state: body.state,
+        merged: body.merged,
+        isPullRequest: true,
+        title: body.title,
+      };
     }
     const response = await this.fetchWithRateLimitRetry(() =>
       fetch(
@@ -2322,7 +2337,12 @@ export class ApiV3CheerioRestIssueRepository
         `Unexpected response shape when fetching state for ${url}`,
       );
     }
-    return { state: body.state, merged: false, isPullRequest: false };
+    return {
+      state: body.state,
+      merged: false,
+      isPullRequest: false,
+      title: body.title,
+    };
   };
 
   getPullRequestSummary = async (