github-issue-tower-defence-management 1.146.17 → 1.146.18

package/bin/adapter/entry-points/console/ui-dist/index.html

@@ -4,7 +4,7 @@
     <meta charset="UTF-8" />
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <title>TDPM Console</title>
-    <script type="module" crossorigin src="/assets/index-Cuitqkoc.js"></script>
+    <script type="module" crossorigin src="/assets/index-Dj5NvMDZ.js"></script>
     <link rel="stylesheet" crossorigin href="/assets/index-CDLgAfIB.css">
   </head>
   <body>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "github-issue-tower-defence-management",
-  "version": "1.146.17",
+  "version": "1.146.18",
   "description": "",
   "main": "bin/index.js",
   "scripts": {

package/src/adapter/entry-points/console/consoleOperationApi.test.ts

@@ -266,6 +266,33 @@ describe('consoleOperationApi', () => {
       expectRecordedAcrossTabs('PVTI_unnecessary');
     });
 
+    it('tells the linked issue that the unnecessary pull request must not be created again', async () => {
+      issueRepository.getIssueByUrl.mockResolvedValue({
+        ...issue,
+        url: 'https://github.com/o/r/issues/9',
+        org: 'o',
+        repo: 'r',
+        number: 9,
+        labels: ['bug'],
+      });
+      const issueCommentBody =
+        'The pull request for this issue was unnecessary and has been closed: https://github.com/o/r/pull/3\n\nDo not create it again.';
+      const response = await handleReview(context, {
+        pjcode: 'acme',
+        action: 'unnecessary',
+        prUrl: 'https://github.com/o/r/pull/3',
+        issueUrl: 'https://github.com/o/r/issues/9',
+        projectItemId: 'PVTI_unnecessary_issue_comment',
+        commentBody: 'This pull request is unnecessary.',
+        issueCommentBody,
+      });
+      expect(response.statusCode).toBe(200);
+      expect(issueRepository.createCommentByUrl).toHaveBeenCalledWith(
+        'https://github.com/o/r/issues/9',
+        issueCommentBody,
+      );
+    });
+
     it('keeps the chore label once when the unnecessary item already carries it', async () => {
       issueRepository.getIssueByUrl.mockResolvedValue({
         ...issue,

package/src/adapter/entry-points/console/consoleOperationApi.ts

@@ -260,6 +260,11 @@ export const handleReview = async (
         .resolveIssueRepository(prUrl)
         .createCommentByUrl(prUrl, body.commentBody);
     }
+    if (isNonEmptyString(body.issueCommentBody)) {
+      await context
+        .resolveIssueRepository(issueUrl)
+        .createCommentByUrl(issueUrl, body.issueCommentBody);
+    }
     const labelFailure = await addChoreLabel(
       context.resolveIssueRepository(issueUrl),
       issueUrl,

package/src/adapter/entry-points/console/ui/src/features/console/hooks/useConsoleOperations.test.ts

@@ -89,6 +89,21 @@ describe('useConsoleOperations', () => {
     });
   });
 
+  it('posts an unnecessary review carrying the comment the linked issue receives', async () => {
+    const fetchMock = captureFetch();
+    const { result } = setup();
+    await act(async () => {
+      await result.current.operations.reviewPullRequest(
+        prItem,
+        prItem.url,
+        'unnecessary',
+      );
+    });
+    expect(lastBody(fetchMock)).toMatchObject({
+      issueCommentBody: `The pull request for this issue was unnecessary and has been closed: ${prItem.url}\n\nDo not create it again.`,
+    });
+  });
+
   it('posts an approve review and marks the item done in the overlay', async () => {
     captureFetch();
     const { result } = setup();

package/src/adapter/entry-points/console/ui/src/features/console/hooks/useConsoleOperations.ts

@@ -12,6 +12,7 @@ import {
 } from '../lib/consoleApi';
 import {
   buildRequestChangesBody,
+  buildUnnecessaryIssueCommentBody,
   type ConsoleCloseAction,
   type ConsoleNextActionDateAction,
   type ConsolePendingReviewComment,
@@ -119,6 +120,7 @@ const reviewRequest = (
     projectItemId: item.projectItemId,
     issueUrl: item.url,
     commentBody: UNNECESSARY_COMMENT_BODY,
+    issueCommentBody: buildUnnecessaryIssueCommentBody(prUrl),
   };
 };
 

package/src/adapter/entry-points/console/ui/src/features/console/lib/consoleApi.ts

@@ -25,6 +25,7 @@ export type ConsoleReviewRequest = {
   projectItemId: string;
   issueUrl?: string;
   commentBody?: string;
+  issueCommentBody?: string;
   changedFilePath?: string;
   line?: number;
   side?: ConsoleReviewCommentSide;

package/src/adapter/entry-points/console/ui/src/features/console/logic/operations.test.ts

@@ -1,5 +1,6 @@
 import {
   buildRequestChangesBody,
+  buildUnnecessaryIssueCommentBody,
   IN_TMUX_BY_HUMAN_NAME,
   isManualTriageTab,
   STATUS_BUTTON_NAMES,
@@ -16,6 +17,14 @@ describe('operation constants', () => {
     expect(UNNECESSARY_COMMENT_BODY).toBe('This pull request is unnecessary.');
   });
 
+  it('builds an issue comment body that names the closed pull request and forbids creating it again', () => {
+    expect(
+      buildUnnecessaryIssueCommentBody('https://github.com/o/r/pull/1'),
+    ).toBe(
+      'The pull request for this issue was unnecessary and has been closed: https://github.com/o/r/pull/1\n\nDo not create it again.',
+    );
+  });
+
   it('lists the status buttons left to right', () => {
     expect(STATUS_BUTTON_NAMES).toEqual([
       'In Tmux by agent',

package/src/adapter/entry-points/console/ui/src/features/console/logic/operations.ts

@@ -4,6 +4,9 @@ import type { ConsoleFieldOption, ConsoleTabName } from './types';
 export const TOTALLY_WRONG_COMMENT_BODY = 'totally wrong';
 export const UNNECESSARY_COMMENT_BODY = 'This pull request is unnecessary.';
 
+export const buildUnnecessaryIssueCommentBody = (prUrl: string): string =>
+  `The pull request for this issue was unnecessary and has been closed: ${prUrl}\n\nDo not create it again.`;
+
 export type ConsolePendingReviewComment = {
   path: string;
   line: number;